[patch 17/18] Use page_cache_xxx in fs/reiserfs

V2->V3: - reiserfs_commit_write(): Use common method to extract mapping from page->mapping->host chain Use page_cache_xxx in fs/reiserfs Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/reiserfs/file.c

[patch 18/18] Use page_cache_xxx for fs/xfs

V2->V3: - xfs_page_trace: Determine mapping from inode - xfs_probe_page: Make mapping check easier to read Use page_cache_xxx for fs/xfs Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xf

[patch 15/18] Use page_cache_xxx in fs/ext3

Use page_cache_xxx in fs/ext3 Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext3/dir.c |3 ++- fs/ext3/inode.c | 39 --- 2 files changed, 22 insertions(+), 20 deletions(-) Index:

[patch 16/18] Use page_cache_xxx in fs/ext4

Use page_cache_xxx in fs/ext4 Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext4/dir.c |3 ++- fs/ext4/inode.c | 34 +- 2 files changed, 19 insertions(+), 18 deletions(-) Index: linux

[patch 14/18] Use page_cache_xxx in ext2

Use page_cache_xxx functions in fs/ext2/* Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext2/dir.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) Index: linux-2.6/f

[patch 12/18] Use page_cache_xxx in mm/fadvise.c

Use page_cache_xxx in mm/fadvise.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/fadvise.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6/

[patch 11/18] Use page_cache_xxx in mm/mpage.c

Use page_cache_xxx in mm/mpage.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/mpage.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) Index: linux-2.

[patch 13/18] Use page_cache_xxx in fs/splice.c

Use page_cache_xxx in fs/splice.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/splice.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) Index: linux-2.6

[patch 09/18] Use page_cache_xxx in fs/sync

Use page_cache_xxx in fs/sync. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/sync.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2

[patch 10/18] Use page_cache_xxx in fs/buffer.c

V2->V3: - alloc_page_buffers(): Add comment to explain use of page->mapping - Consistently determine mapping if there is a reference chain page->mapping->host to determine the inode. Use page_cache_xxx in fs/buffer.c. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed

[patch 08/18] Use page_cache_xxx in fs/libfs.c

Use page_cache_xxx in fs/libfs.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/libfs.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Index: linux-2.

[patch 07/18] Use page_cache_xxx in mm/migrate.c

V2->V3: - Only use mapping in remove_file_migration_ptes after it was checked for NULL. Use page_cache_xxx in mm/migrate.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/migrate.c |3 ++- 1 file changed, 2 i

[patch 06/18] Use page_cache_xxx in mm/filemap_xip.c

Use page_cache_xxx in mm/filemap_xip.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/filemap_xip.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) Index: linux-2.6/mm/f

[patch 04/18] Use page_cache_xxx in mm/truncate.c

Use page_cache_xxx in mm/truncate.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/truncate.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) Index: linux-2.6.24-rc6-mm1/m

[patch 05/18] Use page_cache_xxx in mm/rmap.c

ave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/rmap.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) Index: linux-2.6/mm/rmap.c === --- linux-2.6

[patch 02/18] Use page_cache_xxx functions in mm/filemap.c

Convert the uses of PAGE_CACHE_xxx. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/filemap.c | 91 +-- 1 file changed, 46 insertions(+), 45 deletions(-) Index:

[patch 03/18] Use page_cache_xxx in mm/page-writeback.c

Use page_cache_xxx in mm/page-writeback.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/page-writeback.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: mm/mm/page

[patch 01/18] Define functions for page cache handling

position based on page number and an offset. This provides a basis that would allow the conversion of all page cache handling in the kernel and ultimately allow the removal of the PAGE_CACHE_* constants. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-

[patch 00/18] Page cache: Replace PAGE_CACHE_xx with inline functions V4

This patchset cleans up page cache handling by replacing open coded shifts and adds with inline function calls. The ultimate goal is to replace all uses of PAGE_CACHE_xxx in the kernel through the use of these functions. All the functions take a mapping parameter. The mapping parameter is required

[patch 18/18] Use page_cache_xxx for fs/xfs

V2->V3: - xfs_page_trace: Determine mapping from inode - xfs_probe_page: Make mapping check easier to read Use page_cache_xxx for fs/xfs Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xf

[patch 17/18] Use page_cache_xxx in fs/reiserfs

V2->V3: - reiserfs_commit_write(): Use common method to extract mapping from page->mapping->host chain Use page_cache_xxx in fs/reiserfs Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/reiserfs/file.c

[patch 16/18] Use page_cache_xxx in fs/ext4

Use page_cache_xxx in fs/ext4 Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext4/dir.c |3 ++- fs/ext4/inode.c | 34 +- 2 files changed, 19 insertions(+), 18 deletions(-) Index: linu

[patch 15/18] Use page_cache_xxx in fs/ext3

Use page_cache_xxx in fs/ext3 Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext3/dir.c |3 ++- fs/ext3/inode.c | 39 --- 2 files changed, 22 insertions(+), 20 deletions(-) Index:

[patch 14/18] Use page_cache_xxx in ext2

Use page_cache_xxx functions in fs/ext2/* Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext2/dir.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) Index: linux-2.6.24-rc6

[patch 12/18] Use page_cache_xxx in mm/fadvise.c

Use page_cache_xxx in mm/fadvise.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/fadvise.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6.24-rc6-mm1/

[patch 13/18] Use page_cache_xxx in fs/splice.c

Use page_cache_xxx in fs/splice.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/splice.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) Index: linux-2.6.24-rc6-mm1

[patch 11/18] Use page_cache_xxx in mm/mpage.c

Use page_cache_xxx in mm/mpage.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/mpage.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) Index: linux-2.6.24-rc6-mm

[patch 08/18] Use page_cache_xxx in fs/libfs.c

Use page_cache_xxx in fs/libfs.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/libfs.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Index: linux-2.6.24-rc6-mm

[patch 09/18] Use page_cache_xxx in fs/sync

Use page_cache_xxx in fs/sync. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/sync.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6.24-rc6-m

[patch 10/18] Use page_cache_xxx in fs/buffer.c

V2->V3: - alloc_page_buffers(): Add comment to explain use of page->mapping - Consistently determine mapping if there is a reference chain page->mapping->host to determine the inode. Use page_cache_xxx in fs/buffer.c. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed

[patch 06/18] Use page_cache_xxx in mm/filemap_xip.c

Use page_cache_xxx in mm/filemap_xip.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/filemap_xip.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) Index: linux-2.6.24-rc6-mm1/mm/f

[patch 05/18] Use page_cache_xxx in mm/rmap.c

ave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/rmap.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) Index: linux-2.6.24-rc6-mm1/mm/rmap.c === --- l

[patch 07/18] Use page_cache_xxx in mm/migrate.c

V2->V3: - Only use mapping in remove_file_migration_ptes after it was checked for NULL. Use page_cache_xxx in mm/migrate.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/migrate.c |3 ++- 1 file changed, 2 i

[patch 02/18] Use page_cache_xxx functions in mm/filemap.c

Convert the uses of PAGE_CACHE_xxx. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/filemap.c | 91 +-- 1 file changed, 46 insertions(+), 45 deletions(-) Index: linu

[patch 04/18] Use page_cache_xxx in mm/truncate.c

Use page_cache_xxx in mm/truncate.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/truncate.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) Index: linux-2.6.24-rc6-mm1/m

[patch 03/18] Use page_cache_xxx in mm/page-writeback.c

Use page_cache_xxx in mm/page-writeback.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/page-writeback.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: mm/mm/page

[patch 00/18] Page cache: Replace PAGE_CACHE_xx with inline functions V3

This patchset cleans up page cache handling by replacing open coded shifts and adds with inline function calls. The ultimate goal is to replace all uses of PAGE_CACHE_xxx in the kernel through the use of these functions. All the functions take a mapping parameter. The mapping parameter is required

[patch 01/18] Define functions for page cache handling

position based on page number and an offset. This provides a basis that would allow the conversion of all page cache handling in the kernel and ultimately allow the removal of the PAGE_CACHE_* constants. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-

Re: [patch 01/19] Define functions for page cache handling

On Mon, 3 Dec 2007, Andrew Morton wrote: > These will of course all work OK as they are presently implemented. > > But you have callsites doing things like > > page_cache_size(page_mapping(page)); > > which is a whole different thing. Once page_cache_size() is changed to > look inside th

[patch 16/19] Use page_cache_xxx in fs/ext4

Use page_cache_xxx in fs/ext4 Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext4/dir.c |3 ++- fs/ext4/inode.c | 34 +- 2 files changed, 19 insertions(+), 18 deletions(-) Index: mm/f

[patch 19/19] Use page_cache_xxx in drivers/block/rd.c

Use page_cache_xxx in drivers/block/rd.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- drivers/block/rd.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: mm/driver

[patch 17/19] Use page_cache_xxx in fs/reiserfs

Use page_cache_xxx in fs/reiserfs Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/reiserfs/file.c|6 -- fs/reiserfs/inode.c | 33 - fs/reiserfs/ioctl.c

[patch 10/19] Use page_cache_xxx in fs/buffer.c

Use page_cache_xxx in fs/buffer.c. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/buffer.c | 103 +--- 1 file changed, 57 insertions(+), 46 deletions(-) Index: mm

[patch 08/19] Use page_cache_xxx in fs/libfs.c

Use page_cache_xxx in fs/libfs.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/libfs.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Index: m

[patch 18/19] Use page_cache_xxx for fs/xfs

Use page_cache_xxx for fs/xfs Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_aops.c | 55 ++-- fs/xfs/linux-2.6/xfs_lrw.c |4 +-- 2 files changed, 30 inser

[patch 14/19] Use page_cache_xxx in ext2

Use page_cache_xxx functions in fs/ext2/* Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext2/dir.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) Index: mm/f

[patch 15/19] Use page_cache_xxx in fs/ext3

Use page_cache_xxx in fs/ext3 Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext3/dir.c |3 ++- fs/ext3/inode.c | 39 --- 2 files changed, 22 insertions(+), 20 deletions(-) Index

[patch 13/19] Use page_cache_xxx in fs/splice.c

Use page_cache_xxx in fs/splice.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/splice.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) Index: mm

[patch 09/19] Use page_cache_xxx in fs/sync

Use page_cache_xxx in fs/sync. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/sync.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index:

[patch 02/19] Use page_cache_xxx functions in mm/filemap.c

Convert the uses of PAGE_CACHE_xxx. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/filemap.c | 91 +-- 1 file changed, 46 insertions(+), 45 deletions(-) Index: mm/

[patch 06/19] Use page_cache_xxx in mm/filemap_xip.c

Use page_cache_xxx in mm/filemap_xip.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/filemap_xip.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) Index: mm/mm/f

[patch 12/19] Use page_cache_xxx in mm/fadvise.c

Use page_cache_xxx in mm/fadvise.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/fadvise.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: mm/

[patch 04/19] Use page_cache_xxx in mm/truncate.c

Use page_cache_xxx in mm/truncate.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/truncate.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) Index: mm/m

[patch 00/19] Page cache: Replace PAGE_CACHE_xx with inline functions V2

This patchset cleans up page cache handling by replacing open coded shifts and adds with inline function calls. The ultimate goal is to replace all uses of PAGE_CACHE_xxx in the kernel through the use of these functions. All the functions take a mapping parameter. The mapping parameter is required

[patch 07/19] Use page_cache_xxx in mm/migrate.c

Use page_cache_xxx in mm/migrate.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/migrate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: mm/

[patch 03/19] Use page_cache_xxx in mm/page-writeback.c

Use page_cache_xxx in mm/page-writeback.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/page-writeback.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: mm/mm/page

[patch 11/19] Use page_cache_xxx in mm/mpage.c

Use page_cache_xxx in mm/mpage.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/mpage.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) Index: m

[patch 01/19] Define functions for page cache handling

that would allow the conversion of all page cache handling in the kernel and ultimately allow the removal of the PAGE_CACHE_* constants. Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- include/linux/page

[patch 05/19] Use page_cache_xxx in mm/rmap.c

Use page_cache_xxx in mm/rmap.c Reviewed-by: Dave Chinner <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/rmap.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) Index:

Re: [patch 01/19] Define functions for page cache handling

On Thu, 29 Nov 2007, Fengguang Wu wrote: > On Wed, Nov 28, 2007 at 05:10:53PM -0800, Christoph Lameter wrote: > > +static inline loff_t page_cache_mask(struct address_space *a) > > +{ > > + return (loff_t)PAGE_MASK; > > +} > > A tiny question: Why choose

Re: [patch 14/19] Use page_cache_xxx in ext2

On Thu, 29 Nov 2007, David Chinner wrote: > I don't think that gives the same return value. The return value > is supposed to be clamped at a maximum of page_cache_size(mapping). Ok. So this? ext2: Simplify some functions Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]&

Re: [patch 05/19] Use page_cache_xxx in mm/rmap.c

On Thu, 29 Nov 2007, David Chinner wrote: > And the other two occurrences of this in the first patch? Ahh... Ok they are also in rmap.c: rmap: simplify page_referenced_file use of page cache inlines Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/rmap.c |6 +++--

Re: [patch 18/19] Use page_cache_xxx for fs/xfs

Is this correct? Fixes to the use of page_cache_xx functions in xfs Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_aops.c | 18 -- fs/xfs/linux-2.6/xfs_lrw.c |2 +- 2 files changed, 9 insertions(+), 11 deletions(-) Index: mm/fs/xfs

Re: [patch 17/19] Use page_cache_xxx in fs/reiserfs

page_cache_index(p_s_inode->i_mapping, > > + p_s_inode->i_size); > > unsigned long offset = page_cache_offset(p_s_inode->i_mapping, > Reiserfs: Wrong type of inline function Signed-off-by: Christoph Lameter <[EMAIL PR

Re: [patch 16/19] Use page_cache_xxx in fs/ext4

On Thu, 29 Nov 2007, David Chinner wrote: > These three should use the pagesize variable. ext4: use pagesize variable instead of the inline function Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext4/inode.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(

Re: [patch 14/19] Use page_cache_xxx in ext2

ext2: Simplify some functions Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext2/dir.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) Index: mm/fs/ext2/dir.c === --- mm.orig/fs/ext2

Re: [patch 13/19] Use page_cache_xxx in fs/splice.c

On Thu, 29 Nov 2007, David Chinner wrote: > On Wed, Nov 28, 2007 at 05:11:05PM -0800, Christoph Lameter wrote: > > @@ -453,7 +454,7 @@ fill_it: > > */ > > while (page_nr < nr_pages) > > page_cache_release(pages[page_nr++]); > > -

Re: [patch 10/19] Use page_cache_xxx in fs/buffer.c

mapping, curpos); Results in a gcc warning about the possible use of an unitialized variable. How about this? fs/buffer.c enhancements and fixes Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/buffer.c |8 ++

Re: [patch 05/19] Use page_cache_xxx in mm/rmap.c

e_shift(mapping) - PAGE_SHIFT); > > Based on the first hunk, shouldn't this be: > > pgoff_t pgoff = page->index << mapping_order(mapping); Yes that is much simpler rmap: simplify page_referenced_file use of page cache inlines Signed-off-by: Christoph Lameter <

Re: [patch 18/19] Use page_cache_xxx for fs/xfs

In other words the following patch? Fixes to the use of page_cache_xx functions in xfs Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_aops.c | 17 ++--- fs/xfs/linux-2.6/xfs_lrw.c |2 +- 2 files changed, 7 insertions(+), 12 deletions(-)

Re: [patch 01/19] Define functions for page cache handling

On Thu, 29 Nov 2007, David Chinner wrote: > On Wed, Nov 28, 2007 at 05:10:53PM -0800, Christoph Lameter wrote: > > +/* > > + * Index of the page starting on or after the given position. > > + */ > > +static inline pgoff_t page_cache_next(struct address_space *a,

[patch 19/19] Use page_cache_xxx in drivers/block/rd.c

Use page_cache_xxx in drivers/block/rd.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- drivers/block/rd.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: mm/drivers/block/rd.c === --- m

[patch 01/19] Define functions for page cache handling

would allow the conversion of all page cache handling in the kernel and ultimately allow the removal of the PAGE_CACHE_* constants. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- include/linux/pagemap.h | 54 +++ 1 files changed, 54 inse

[patch 10/19] Use page_cache_xxx in fs/buffer.c

Use page_cache_xxx in fs/buffer.c. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/buffer.c | 101 +--- 1 file changed, 56 insertions(+), 45 deletions(-) Index: mm/fs/bu

[patch 17/19] Use page_cache_xxx in fs/reiserfs

Use page_cache_xxx in fs/reiserfs Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/reiserfs/file.c|6 -- fs/reiserfs/inode.c | 33 - fs/reiserfs/ioctl.c |2 +- fs/reiserfs/stree.c |5 +++

[patch 18/19] Use page_cache_xxx for fs/xfs

Use page_cache_xxx for fs/xfs Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_aops.c | 55 +++- fs/xfs/linux-2.6/xfs_lrw.c |4 +-- 2 files changed, 31 insertions(+), 28 deletions(-) Index: mm/fs/xfs/lin

[patch 16/19] Use page_cache_xxx in fs/ext4

Use page_cache_xxx in fs/ext4 Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext4/dir.c |3 ++- fs/ext4/inode.c | 33 + 2 files changed, 19 insertions(+), 17 deletions(-) Index: mm/fs/ext4

[patch 14/19] Use page_cache_xxx in ext2

Use page_cache_xxx functions in fs/ext2/* Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext2/dir.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) Index: linux-2.6/fs/ext2

[patch 15/19] Use page_cache_xxx in fs/ext3

Use page_cache_xxx in fs/ext3 Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/ext3/dir.c |3 ++- fs/ext3/inode.c | 39 --- 2 files changed, 22 insertions(+), 20 deletions(-) Index: mm/fs/ext3

[patch 13/19] Use page_cache_xxx in fs/splice.c

Use page_cache_xxx in fs/splice.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/splice.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) Index: mm/fs/splice.c === --- mm.o

[patch 09/19] Use page_cache_xxx in fs/sync

Use page_cache_xxx in fs/sync. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/sync.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: mm/fs/sync.c === --- mm.orig/fs/sync.c 2007-11-16

[patch 12/19] Use page_cache_xxx in mm/fadvise.c

Use page_cache_xxx in mm/fadvise.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/fadvise.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: mm/mm/fadvise.c === --- mm.orig/mm/fad

[patch 11/19] Use page_cache_xxx in mm/mpage.c

Use page_cache_xxx in mm/mpage.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/mpage.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) Index: linux-2.6/fs/mpage.c === ---

[patch 08/19] Use page_cache_xxx in fs/libfs.c

Use page_cache_xxx in fs/libfs.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/libfs.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Index: mm/fs/libfs.c === --- mm.orig/fs/libfs.c 2007

[patch 04/19] Use page_cache_xxx in mm/truncate.c

Use page_cache_xxx in mm/truncate.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/truncate.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) Index: mm/mm/trun

[patch 06/19] Use page_cache_xxx in mm/filemap_xip.c

Use page_cache_xxx in mm/filemap_xip.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/filemap_xip.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) Index: mm/mm/filemap

[patch 05/19] Use page_cache_xxx in mm/rmap.c

Use page_cache_xxx in mm/rmap.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/rmap.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) Index: mm/mm/rmap.c === --- mm.orig/mm/rmap.c 2007-11

[patch 03/19] Use page_cache_xxx in mm/page-writeback.c

Use page_cache_xxx in mm/page-writeback.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/page-writeback.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: mm/mm/page-writeback.c === --- mm.o

[patch 07/19] Use page_cache_xxx in mm/migrate.c

Use page_cache_xxx in mm/migrate.c Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/migrate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: mm/mm/migrate.c === --- mm.orig/mm/migrate.c2007

[patch 02/19] Use page_cache_xxx functions in mm/filemap.c

Convert the uses of PAGE_CACHE_xxx to use page_cache_xxx instead. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/filemap.c | 91 +-- 1 file changed, 46 insertions(+), 45 deletions(-) Index: mm/mm/fil

[patch 00/19] Page cache: Replace PAGE_CACHE_xx with inline functions

This patchset cleans up page cache handling by replacing open coded shifts and adds with inline function calls. The ultimate goal is to replace all uses of PAGE_CACHE_xxx in the kernel through the use of these functions. All the functions take a mapping parameter. The mapping parameter is required

Re: migratepage failures on reiserfs

On Mon, 5 Nov 2007, Mel Gorman wrote: > The grow_dev_page() pages should be reclaimable even though migration > is not supported for those pages? They were marked movable as it was > useful for lumpy reclaim taking back pages for hugepage allocations and > the like. Would it make sense for memory

Re: [PATCH 7/10] 9p: sysfs support for in-kenel servers

On Sat, 3 Nov 2007, Peter Zijlstra wrote: > On Fri, 2007-11-02 at 20:48 -0700, Greg KH wrote: > > > Also, a sysfs file that causes an action to happen just by reading the > > file is not a safe thing to have. Lots of scripts have been known to > > just walk the whole sysfs tree and open and read

Re: More Large blocksize benchmarks

On Mon, 15 Oct 2007, Chris Mason wrote: > Dave reported that XFS saw much higher write throughput with large > blocksizes, but so far I'm seeing the most benefits during reads. Dave's tests were done with an early large blocksize patchset that had issues with readahead. More recent versions have

Re: SLUB performance regression vs SLAB

: Christoph Lameter <[EMAIL PROTECTED]> --- include/linux/slub_def.h |1 mm/slub.c| 82 ++- 2 files changed, 68 insertions(+), 15 deletions(-) Index: linux-2.6.23-rc8-mm2/include/linux/slub

Re: SLUB performance regression vs SLAB

is what I got so far for batching the frees. I will try to come up with a test next week if nothing else happens before: Patch 1/2 on top of mm: SLUB: Keep counter of remaining objects on the per cpu list Add a counter to keep track of how many objects are on the per cpu list. Signed-off-by:

Re: SLUB performance regression vs SLAB

On Fri, 5 Oct 2007, Matthew Wilcox wrote: > I vaguely remembered something called orasim, so I went looking for it. > I found http://oss.oracle.com/~wcoekaer/orasim/ which is dated from > 2004, and I found http://oss.oracle.com/projects/orasimjobfiles/ which > seems to be a stillborn project. Is

Re: SLUB performance regression vs SLAB

I just spend some time looking at the functions that you see high in the list. The trouble is that I have to speculate and that I have nothing to verify my thoughts. If you could give me the hitlist for each of the 3 runs then this would help to check my thinking. I could be totally off here.

Re: SLUB performance regression vs SLAB

On Thu, 4 Oct 2007, Matthew Wilcox wrote: > Yet here we stand. Christoph is aggressively trying to get slab removed > from the tree. There is a testcase which shows slub performing worse > than slab. It's not my fault I can't publish it. And just because I > can't publish it doesn't mean it do

Re: SLUB performance regression vs SLAB

On Thu, 4 Oct 2007, Matthew Wilcox wrote: > We have three runs, all with 2.6.23-rc3 plus the patches that Suresh > applied from 20070922. The first run is with slab. The second run is > with SLUB and the third run is SLUB plus the tuning parameters you > recommended. There was quite a bit of co

  1   2   3   >