Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()

2007-10-02 Thread David Howells
Jan Kara <[EMAIL PROTECTED]> wrote: > Hmm, why don't you use the return value from raw_inode? It can be > either -EIO or -EINVAL if 'ino' was invalid... Good point. Altered. David - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PRO

Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()

2007-10-02 Thread Jan Kara
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c > index 0079b2c..d8fb795 100644 > --- a/fs/ext2/inode.c > +++ b/fs/ext2/inode.c ... > + > + raw_inode = ext2_get_inode(inode->i_sb, ino, &bh); > if (IS_ERR(raw_inode)) > goto bad_inode; Hmm, why don't you use the return valu

[PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()

2007-10-01 Thread David Howells
Stop the EXT2 filesystem from using iget() and read_inode(). Replace ext2_read_inode() with ext2_iget(), and call that instead of iget(). ext2_iget() then uses iget_locked() directly and returns a proper error code instead of an inode in the event of an error. ext2_fill_super() returns any error