Re: [RFC] set_blocksize() oddity.

1999-04-09 Thread Alexander Viro
On Sat, 10 Apr 1999, Andrea Arcangeli wrote: > On Fri, 9 Apr 1999, Alexander Viro wrote: > > >> The bug of nr_hashed_buffers inconsistency is due where > >> nr_hashed_buffers++ nr_hashed_buffers-- are been placed by me. They has to > >> be placed in the path where pprev is != 0. It's really a

Re: [RFC] set_blocksize() oddity.

1999-04-09 Thread Andrea Arcangeli
On Fri, 9 Apr 1999, Alexander Viro wrote: >> The bug of nr_hashed_buffers inconsistency is due where >> nr_hashed_buffers++ nr_hashed_buffers-- are been placed by me. They has to >> be placed in the path where pprev is != 0. It's really a minor issue >> though. > I'm not sure... I agree co

Re: [RFC] set_blocksize() oddity.

1999-04-09 Thread Alexander Viro
On Fri, 9 Apr 1999, Andrea Arcangeli wrote: > On Fri, 9 Apr 1999, Alexander Viro wrote: > > >Repeat until the complete satisfaction (nr_hashed_buffers going negative ;-/) > > The bug of nr_hashed_buffers inconsistency is due where > nr_hashed_buffers++ nr_hashed_buffers-- are been placed by m

Re: [RFC] set_blocksize() oddity.

1999-04-09 Thread Andrea Arcangeli
On Fri, 9 Apr 1999, Alexander Viro wrote: >Repeat until the complete satisfaction (nr_hashed_buffers going negative ;-/) The bug of nr_hashed_buffers inconsistency is due where nr_hashed_buffers++ nr_hashed_buffers-- are been placed by me. They has to be placed in the path where pprev is != 0. I

Re: [RFC] set_blocksize() oddity.

1999-04-09 Thread MOLNAR Ingo
On Fri, 9 Apr 1999, Alexander Viro wrote: > set_blocksize() seems to do really odd thing: > suppose you have clean buffer (b_count==0, all nice and dandy) with > b_size==foo. > set_blocksize(dev, bar) will leave it on a clean list and will call > remove_from_hash_queue() on it. > se

[RFC] set_blocksize() oddity.

1999-04-09 Thread Alexander Viro
set_blocksize() seems to do really odd thing: suppose you have clean buffer (b_count==0, all nice and dandy) with b_size==foo. set_blocksize(dev, bar) will leave it on a clean list and will call remove_from_hash_queue() on it. set_blocksize(dev,foo) now. Nothing happens with our