Re: [Linux-ha-dev] change of process check in tomcat-ra

2011-11-10 Thread nozawat
Hi Dejan >What is overwritten?Which environment variable do you refer to? It is CATALINA_OPTS. When CATALINA_OPTS is set from the outside, a right process check is not possible. It occurs at following time. 1.-Dname is not set(Outside setting). 2.When -Dname is different. 3.When setting of CATALI

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Florian Haas
On 2011-11-10 17:08, Dejan Muhamedagic wrote: > Hi Lars, > > Pity I didn't see this earlier, could've saved meself some time :) > > On Thu, Nov 10, 2011 at 04:33:02PM +0100, Lars Ellenberg wrote: >> On Thu, Nov 10, 2011 at 04:11:16PM +0100, Florian Haas wrote: >>> Hi Dejan, >>> >>> thanks for the

Re: [Linux-ha-dev] Patch: iscsi RA

2011-11-10 Thread Dejan Muhamedagic
On Thu, Nov 10, 2011 at 04:10:29PM +, Matthew Richardson wrote: > On 10/11/11 12:39, Dejan Muhamedagic wrote: > > Hi, > > > > On Thu, Nov 10, 2011 at 10:11:30AM +, Matthew Richardson wrote: > >> In newer versions of iscsid (RHEL6) the init.d script has been changed, > >> such that the star

Re: [Linux-ha-dev] Patch: iscsi RA

2011-11-10 Thread Matthew Richardson
On 10/11/11 12:39, Dejan Muhamedagic wrote: > Hi, > > On Thu, Nov 10, 2011 at 10:11:30AM +, Matthew Richardson wrote: >> In newer versions of iscsid (RHEL6) the init.d script has been changed, >> such that the start method won't do anything unless discovery etc has >> already occurred at least

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Dejan Muhamedagic
Hi Lars, Pity I didn't see this earlier, could've saved meself some time :) On Thu, Nov 10, 2011 at 04:33:02PM +0100, Lars Ellenberg wrote: > On Thu, Nov 10, 2011 at 04:11:16PM +0100, Florian Haas wrote: > > Hi Dejan, > > > > thanks for the feedback! We've worked in most of your suggested change

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Dejan Muhamedagic
Hey Florian, On Thu, Nov 10, 2011 at 04:11:16PM +0100, Florian Haas wrote: > Hi Dejan, > > thanks for the feedback! We've worked in most of your suggested changes, > see below: > > On 2011-11-10 13:14, Dejan Muhamedagic wrote: > > Hi, [...] > > Start may exit with some arbitrary error code (line

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Lars Ellenberg
On Thu, Nov 10, 2011 at 04:11:16PM +0100, Florian Haas wrote: > Hi Dejan, > > thanks for the feedback! We've worked in most of your suggested changes, > see below: > > More direct would be: > > > > if [ $? -ne 0 ]; then $? in a test is almost always an error. Because you lose the actual v

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Florian Haas
Hi Dejan, thanks for the feedback! We've worked in most of your suggested changes, see below: On 2011-11-10 13:14, Dejan Muhamedagic wrote: > Hi, > > On Thu, Nov 10, 2011 at 10:27:36AM +0100, Florian Haas wrote: >> On 2011-11-09 12:02, Martin Gerhard Loschwitz wrote: >>> Hello everybody, >>> >>>

Re: [Linux-ha-dev] change of process check in tomcat-ra

2011-11-10 Thread Dejan Muhamedagic
On Fri, Nov 04, 2011 at 01:55:57PM +0900, nozawat wrote: > Hi Dejan > > > Are we sure that the pid file is _always_ going to exist and > > contain the PID? > I believe that PID file exists, and I include pid. > BTW, it is the next sentence to be important by this change. > > > What's wrong with s

Re: [Linux-ha-dev] Patch: iscsi RA

2011-11-10 Thread Dejan Muhamedagic
Hi, On Thu, Nov 10, 2011 at 10:11:30AM +, Matthew Richardson wrote: > In newer versions of iscsid (RHEL6) the init.d script has been changed, > such that the start method won't do anything unless discovery etc has > already occurred at least once. > > As a result, there's now a new option in

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Dejan Muhamedagic
Hi, On Thu, Nov 10, 2011 at 10:27:36AM +0100, Florian Haas wrote: > On 2011-11-09 12:02, Martin Gerhard Loschwitz wrote: > > Hello everybody, > > > > I wrote an asterisk OCF resource agent which I am hereby putting up > > for discussion. Any feedback is welcome. > > > > It's available from > > h

[Linux-ha-dev] Patch: iscsi RA

2011-11-10 Thread Matthew Richardson
In newer versions of iscsid (RHEL6) the init.d script has been changed, such that the start method won't do anything unless discovery etc has already occurred at least once. As a result, there's now a new option in iscsid.conf - 'iscsid.startup' which you can set to be a command to be run when isc

Re: [Linux-ha-dev] [Linux-HA] [RfC] Review request for ocf:heartbeat:asterisk (Asterisk OCF RA)

2011-11-10 Thread Florian Haas
On 2011-11-09 12:02, Martin Gerhard Loschwitz wrote: > Hello everybody, > > I wrote an asterisk OCF resource agent which I am hereby putting up > for discussion. Any feedback is welcome. > > It's available from > https://github.com/fghaas/resource-agents/blob/master/heartbeat/asterisk Let's move