[Linux-ha-dev] [PATCH] Low: SAPInstance: make sure sidadm is not uninitialized, when calling cleanup_instance

2011-12-09 Thread alexander . krauth
Hi, here is a second one. Ok to just post the URL's ? Or should the diff still be send to the mailing list ? https://github.com/AlexanderKrauth/resource-agents/commit/4fdd1a420f23abc5005fa290a33d7fa902571d55 Thanks Alex ___ Linux-HA-Dev: Linux

[Linux-ha-dev] [PATCH] Medium: SAPInstance/SAPDatabase: correcting the unique values of RAs parameters

2011-12-09 Thread alexander . krauth
Hi, my first try doing a patch with the new github repo. Can you please check my last push. Is it ok to issue a pull request ? https://github.com/AlexanderKrauth/resource-agents/commit/3acc297348c39dff6107e4c87ce666f98161ae9c https://github.com/AlexanderKrauth/resource-agents/commit/3d511867233

Re: [Linux-ha-dev] [PATCH] Medium: SAPInstance/SAPDatabase: correcting the unique values of RAs parameters

2011-12-09 Thread Dejan Muhamedagic
Hi, On Fri, Dec 09, 2011 at 11:42:23AM +0100, alexander.kra...@basf.com wrote: > Hi, > > my first try doing a patch with the new github repo. Can you please check > my last push. Is it ok to issue a pull request ? Looks fine to me. Cheers, Dejan > https://github.com/AlexanderKrauth/resource-

Re: [Linux-ha-dev] [PATCH] Low: SAPInstance: make sure sidadm is not uninitialized, when calling cleanup_instance

2011-12-09 Thread Dejan Muhamedagic
Hi, On Fri, Dec 09, 2011 at 11:42:26AM +0100, alexander.kra...@basf.com wrote: > Hi, > > here is a second one. Ok to just post the URL's ? Or should the diff still > be send to the mailing list ? If you submit a pull request the maintainers get an email about it. That should be enough. Of cours

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Chris Bowlby
Hi Dejan, It has been recommended, that required options should not have default values. The initial version of the script had a default for that variable, but chrooted_path was not required. During the revision's suggested by Andreas and Florian, chrooted was converted into a required, and un

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Florian Haas
On Fri, Dec 9, 2011 at 6:30 AM, Dejan Muhamedagic wrote: > Hi, > > On Tue, Dec 06, 2011 at 01:39:04PM -0400, Chris Bowlby wrote: >> Hi All, >> >>   Ok, I'll look into csync, and will concede the point on the RA syncing >> the out of chrooted configuration file. >> >> I still need to find a means t

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Dejan Muhamedagic
Hi Florian, On Fri, Dec 09, 2011 at 03:43:43PM +0100, Florian Haas wrote: > On Fri, Dec 9, 2011 at 6:30 AM, Dejan Muhamedagic wrote: > > Hi, > > > > On Tue, Dec 06, 2011 at 01:39:04PM -0400, Chris Bowlby wrote: > >> Hi All, > >> > >>   Ok, I'll look into csync, and will concede the point on the R

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Dejan Muhamedagic
Hi Chris, On Fri, Dec 09, 2011 at 10:33:05AM -0400, Chris Bowlby wrote: > Hi Dejan, > > It has been recommended, that required options should not have default > values. Definitely they cannot have defaults. Sorry, I should've been more precise. > The initial version of the script had a default

Re: [Linux-ha-dev] Additional changes made via DHCPD review process

2011-12-09 Thread Rasto Levrinc
On Fri, Dec 9, 2011 at 4:40 PM, Dejan Muhamedagic wrote: > Hi Chris, > > On Fri, Dec 09, 2011 at 10:33:05AM -0400, Chris Bowlby wrote: >> Hi Dejan, >> >> It has been recommended, that required options should not have default >> values. > > Definitely they cannot have defaults. Sorry, I should've b