Re: [Linux-ha-dev] [PATCH 0 of 2] Added preference points and some bugfixes

2010-03-08 Thread Florian Haas
On 03/08/2010 04:29 PM, Marian Marinov wrote: > Sorry, I hit wall :) Two of my guys at the office got sick and we are going > to > production this friday, so I had to finish my task for the company. That's fine, I was merely checking to make sure that we didn't scare you away, which would have b

Re: [Linux-ha-dev] [PATCH 0 of 2] Added preference points and some bugfixes

2010-03-08 Thread Marian Marinov
Sorry, I hit wall :) Two of my guys at the office got sick and we are going to production this friday, so I had to finish my task for the company. Tonight or tomorrow I'll commit and send the patches. I have to check them and to remove the debugging lines. I don't want any leftover echos again :

Re: [Linux-ha-dev] [PATCH 0 of 2] Added preference points and some bugfixes

2010-03-04 Thread Florian Haas
Marian, you've spoiled us so much with your near real time responses in the past that I feel compelled to get in touch after just three days of no fresh patches. :) Have you hit a roadblock? Can we help? Cheers, Florian On 03/02/2010 02:00 AM, Marian Marinov wrote: > I have introduced preference

Re: [Linux-ha-dev] [PATCH 0 of 2] Added preference points and some bugfixes

2010-03-02 Thread Florian Haas
Marian, a few more comments: > mysql_notify() { > if [ "$OCF_RESKEY_CRM_meta_notify_type" != 'post' ]; then > return $OCF_SUCCESS > fi > case "$OCF_RESKEY_CRM_meta_notify_operation" in > 'promote') > if [ "$OCF_RESKEY_CRM_meta_notify_promote_uname" != "$HOS

Re: [Linux-ha-dev] [PATCH 0 of 2] Added preference points and some bugfixes

2010-03-02 Thread Marian Marinov
Florian, is_slave implements 2 different checks: 1. without a parameter check if the I/O or SQL threads are running. If either is running, this machine is configured as slave 2. with parameter check if both I/O and SQL threads are running. If both are not running, this machine is a slave but n

Re: [Linux-ha-dev] [PATCH 0 of 2] Added preference points and some bugfixes

2010-03-02 Thread Florian Haas
Marian, can you please explain what you are trying to achieve with is_slave() and mysql_demote() acting differently depending on whether they are invoked as "is_slave | mysql_demote 1" vs. just "is_slave | mysql_demote"? Thanks. Cheers, Florian On 03/02/2010 02:00 AM, Marian Marinov wrote: > I

[Linux-ha-dev] [PATCH 0 of 2] Added preference points and some bugfixes

2010-03-01 Thread Marian Marinov
I have introduced preference points calculation based on the log position. I haven't tested the points, they will need some ajustments and I have to test some situatiations which will be problematic for points calclulation. I have fixed a problem that I introduced into is_slave function when I was