Re: [Linux-ha-dev] [PATCH v2] resource-agents: add Linux proxy arp resource agent

2012-04-11 Thread Dejan Muhamedagic
Hi, Just a few comments below. Cheers, Dejan On Wed, Apr 04, 2012 at 01:52:12AM +0200, Christian Franke wrote: Hello Florian, Your question is fully justified - I sincerely apologize for ignoring that comprehensive documentation. I rewrote the patch trying to adhere to the requirements

Re: [Linux-ha-dev] [PATCH v2] resource-agents: add Linux proxy arp resource agent

2012-04-04 Thread Lars Marowsky-Bree
On 2012-04-04T01:52:12, Christian Franke nob...@nowhere.ws wrote: Hello Florian, Your question is fully justified - I sincerely apologize for ignoring that comprehensive documentation. I rewrote the patch trying to adhere to the requirements given in the documentation. Hi Christian,

Re: [Linux-ha-dev] [PATCH v2] resource-agents: add Linux proxy arp resource agent

2012-04-04 Thread Dejan Muhamedagic
On Wed, Apr 04, 2012 at 02:55:52PM +0200, Lars Marowsky-Bree wrote: On 2012-04-04T01:52:12, Christian Franke nob...@nowhere.ws wrote: Hello Florian, Your question is fully justified - I sincerely apologize for ignoring that comprehensive documentation. I rewrote the patch trying

Re: [Linux-ha-dev] [PATCH v2] resource-agents: add Linux proxy arp resource agent

2012-04-04 Thread Christian Franke
On 04/04/2012 02:55 PM, Lars Marowsky-Bree wrote: that patch shares a *lot* of code with IPaddr(2), doesn't it? I wonder if that wouldn't benefit from refactoring, moving shared functions to an include? Thanks for your feedback, I will have a look at that - the gratuitous arp and also some

Re: [Linux-ha-dev] [PATCH v2] resource-agents: add Linux proxy arp resource agent

2012-04-04 Thread Dejan Muhamedagic
Hi Christian, On Wed, Apr 04, 2012 at 06:00:45PM +0200, Christian Franke wrote: On 04/04/2012 02:55 PM, Lars Marowsky-Bree wrote: that patch shares a *lot* of code with IPaddr(2), doesn't it? I wonder if that wouldn't benefit from refactoring, moving shared functions to an include?

Re: [Linux-ha-dev] [PATCH v2] resource-agents: add Linux proxy arp resource agent

2012-04-04 Thread Florian Haas
On Wed, Apr 4, 2012 at 1:52 AM, Christian Franke nob...@nowhere.ws wrote: Hello Florian, Your question is fully justified - I sincerely apologize for ignoring that comprehensive documentation. I rewrote the patch trying to adhere to the requirements given in the documentation. Wow, that is

[Linux-ha-dev] [PATCH v2] resource-agents: add Linux proxy arp resource agent

2012-04-03 Thread Christian Franke
Hello Florian, Your question is fully justified - I sincerely apologize for ignoring that comprehensive documentation. I rewrote the patch trying to adhere to the requirements given in the documentation. Best Regards, Christian --- AUTHORS |1 + doc/man/Makefile.am |1