Re: [Linux-ha-dev] sfex RA: Refine start/stop method

2010-06-15 Thread Dejan Muhamedagic
Hi Kazutomo-san, On Tue, Jun 15, 2010 at 06:47:22PM +0900, NAKAHIRA Kazutomo wrote: > Hi, Dejan, > > Thank you for your speedy response. > > But, the patch seems not to be applied to the > "http://hg.linux-ha.org/agents"; repository now. Happens now and again :) > Could you please apply this

Re: [Linux-ha-dev] sfex RA: Refine start/stop method

2010-06-15 Thread NAKAHIRA Kazutomo
Hi, Dejan, Thank you for your speedy response. But, the patch seems not to be applied to the "http://hg.linux-ha.org/agents"; repository now. Could you please apply this patch to the agents repository? Best regards, NAKAHIRA Kazutomo (2010/06/14 18:05), Dejan Muhamedagic wrote: > Hi Kazutomo-

Re: [Linux-ha-dev] sfex RA: Refine start/stop method

2010-06-14 Thread Dejan Muhamedagic
Hi Kazutomo-san, On Mon, Jun 14, 2010 at 10:48:03AM +0900, NAKAHIRA Kazutomo wrote: > Hi, all > > I refined a sfex RA to speed up start/stop process of the sfex. > > An attached patch modify static "sleep 2/4" in a sfex RA. > Please see attached and comment me if there are any suggestions. Patc

[Linux-ha-dev] sfex RA: Refine start/stop method

2010-06-13 Thread NAKAHIRA Kazutomo
Hi, all I refined a sfex RA to speed up start/stop process of the sfex. An attached patch modify static "sleep 2/4" in a sfex RA. Please see attached and comment me if there are any suggestions. Best regards, NAKAHIRA Kazutomo -- NTT Open Source Software Center Infrastructure Software Technolo

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-27 Thread Xinwei Hu
2008/10/27 Lars Marowsky-Bree <[EMAIL PROTECTED]>: > On 2008-10-27T14:24:53, Lars Marowsky-Bree <[EMAIL PROTECTED]> wrote: > >> On 2008-10-16T17:28:54, Xinwei Hu <[EMAIL PROTECTED]> wrote: >> >> sfex_daemon.c:288: warning: format '%d' expects type 'int', but argument 5 >> has type 'long unsigned i

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-27 Thread Xinwei Hu
2008/10/27 Lars Marowsky-Bree <[EMAIL PROTECTED]>: > On 2008-10-16T17:28:54, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > sfex_daemon.c:288: warning: format '%d' expects type 'int', but argument 5 > has type 'long unsigned int' > sfex_daemon.c:357: warning: ignoring return value of 'daemon', declared

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-27 Thread Lars Marowsky-Bree
On 2008-10-27T14:24:53, Lars Marowsky-Bree <[EMAIL PROTECTED]> wrote: > On 2008-10-16T17:28:54, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > sfex_daemon.c:288: warning: format '%d' expects type 'int', but argument 5 > has type 'long unsigned int' > sfex_daemon.c:357: warning: ignoring return value o

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-27 Thread Lars Marowsky-Bree
On 2008-10-16T17:28:54, Xinwei Hu <[EMAIL PROTECTED]> wrote: sfex_daemon.c:288: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int' sfex_daemon.c:357: warning: ignoring return value of 'daemon', declared with attribute warn_unused_result In function 'open', inlin

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-23 Thread Lars Marowsky-Bree
On 2008-10-23T16:29:27, Xinwei Hu <[EMAIL PROTECTED]> wrote: > Hi all, > > Another update to sfex resource agent, with following changes: > > . wrap the validate code into one function, so that we support validate-all. > . correct typo of pid-of ( my bad to do that after diff :( ) > . ha

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-16 Thread Lars Marowsky-Bree
On 2008-10-17T01:03:07, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > This is incorrect. O_DIRECT needs to be page-aligned. valign() > > provides the proper guarantees w/o needing to know the pagesize. > According to "man 2 open", "Under Linux 2.6, alignment to 512-byte > boundaries suffices." em. Tha

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-16 Thread Xinwei Hu
Hi Lars, Thanks for the review. There are several things I still need your help to be made clear. And about all other bugs not mentioned here, I'll fix and send out a updated version. :) 2008/10/17 Lars Marowsky-Bree <[EMAIL PROTECTED]>: > On 2008-10-16T17:28:54, Xinwei Hu <[EMAIL PROTECTED]

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-16 Thread Lars Marowsky-Bree
On 2008-10-16T17:28:54, Xinwei Hu <[EMAIL PROTECTED]> wrote: Hi Xinwei, thanks for this rewrite! Some comments on the code: > +### > +# Initialization: > + > +#. /usr/lib/heartbeat/ocf-shellfuncs > + > +# switching ocf-shellfunc

RE: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-16 Thread Junko IKEDA
ubject: Re: [Linux-ha-dev] SFEX resource agent for heartbeat > > 2008/10/16 Raoul Bhatia [IPAX] <[EMAIL PROTECTED]>: > > hi, > > > > do you mind me asking what the purpose of sfex is? > > sfex implements a advisory protocol over shared disk. It helps to > pre

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-16 Thread Xinwei Hu
2008/10/16 Raoul Bhatia [IPAX] <[EMAIL PROTECTED]>: > hi, > > do you mind me asking what the purpose of sfex is? sfex implements a advisory protocol over shared disk. It helps to prevent concurrent accessing to the shared storage even when the split-site happens. > cheers, > raoul > > Xinwei Hu w

Re: [Linux-ha-dev] SFEX resource agent for heartbeat

2008-10-16 Thread Raoul Bhatia [IPAX]
hi, do you mind me asking what the purpose of sfex is? cheers, raoul Xinwei Hu wrote: > Hi all, > > Attached is a rewritten version of sfex. It can be applied to tip of > heartbeat. > Here's some explanation about the changes and design notes on it. > > . The fundamental algorithm of sfe

Re: [Linux-ha-dev] sfex

2008-06-20 Thread Lars Marowsky-Bree
On 2008-06-20T12:52:09, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > sfex relies on timing, yes, but with such considerable safety margins > Do we have any systematic method to analysis the "safety margin" already ? > If not, I'll not go with the "considerable" claim. It depends; but I would think th

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Andrew Beekhof
On Thu, Jun 19, 2008 at 18:30, Lars Marowsky-Bree <[EMAIL PROTECTED]> wrote: > On 2008-06-17T21:46:42, Andrew Beekhof <[EMAIL PROTECTED]> wrote: > >> > It's going to be included as an RA. I just wanted to investigate >> > other possibilities. >> a daemon too though right? > > Not yet; it performs i

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Xinwei Hu
2008/6/20 Lars Marowsky-Bree <[EMAIL PROTECTED]>: > On 2008-06-19T22:52:55, Xinwei Hu <[EMAIL PROTECTED]> wrote: > >> > True. It is possible to break sfex, but the probability that that >> > is going to happen is extremely low and could be due only to a >> > very pathological timing. One way to mak

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Lars Marowsky-Bree
On 2008-06-19T22:52:55, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > True. It is possible to break sfex, but the probability that that > > is going to happen is extremely low and could be due only to a > > very pathological timing. One way to make this probability still > > From my previous experienc

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Lars Marowsky-Bree
On 2008-06-17T21:46:42, Andrew Beekhof <[EMAIL PROTECTED]> wrote: > > It's going to be included as an RA. I just wanted to investigate > > other possibilities. > a daemon too though right? Not yet; it performs its checks as part of the monitor ops. Yes, I think this should be a daemon (started &

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Xinwei Hu
2008/6/19 Dejan Muhamedagic <[EMAIL PROTECTED]>: > Hi, > > On Thu, Jun 19, 2008 at 09:26:13PM +0800, Xinwei Hu wrote: >> 2008/6/19 Keisuke MORI <[EMAIL PROTECTED]>: >> > Hi, >> > >> > "Xinwei Hu" <[EMAIL PROTECTED]> writes: >> >> I'm the one who opposed sfex in the previous discussion. >> >> >> >>

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Dejan Muhamedagic
Hi, On Thu, Jun 19, 2008 at 09:26:13PM +0800, Xinwei Hu wrote: > 2008/6/19 Keisuke MORI <[EMAIL PROTECTED]>: > > Hi, > > > > "Xinwei Hu" <[EMAIL PROTECTED]> writes: > >> I'm the one who opposed sfex in the previous discussion. > >> > >> My point was simple that: > >> > >> check-and-reserve on

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Xinwei Hu
2008/6/19 Keisuke MORI <[EMAIL PROTECTED]>: > Hi, > > "Xinwei Hu" <[EMAIL PROTECTED]> writes: >> I'm the one who opposed sfex in the previous discussion. >> >> My point was simple that: >> >> check-and-reserve on disk is not an atomic CAS operation. and lock >> based on that may silently cause

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Keisuke MORI
Hi, "Xinwei Hu" <[EMAIL PROTECTED]> writes: > I'm the one who opposed sfex in the previous discussion. > > My point was simple that: > > check-and-reserve on disk is not an atomic CAS operation. and lock > based on that may silently cause data corruption. > """ sfex doest not rely on the ato

Re: [Linux-ha-dev] sfex

2008-06-19 Thread Lars Marowsky-Bree
On 2008-06-17T17:33:52, Keisuke MORI <[EMAIL PROTECTED]> wrote: > - a quorum plugin > >A quorum plugin is executed only on 'the cluster leader node' in CCM, >and it does not care where the resource is running on, >whereas sfex should run on the same node which the resource >in qu

Re: [Linux-ha-dev] sfex

2008-06-18 Thread Keisuke MORI
Hi Dejan Muhamedagic <[EMAIL PROTECTED]> writes: > Hi Keisuke-san, > > On Tue, Jun 17, 2008 at 05:33:52PM +0900, Keisuke MORI wrote: >> Dejan, >> >> Thank you for taking care of it. >> >> Yes, NTT is very glad and agrees to include sfex into the >> heartbeat repository! >> >> Dejan Muhamedagic

Re: [Linux-ha-dev] sfex

2008-06-18 Thread Xinwei Hu
I'm the one who opposed sfex in the previous discussion. My point was simple that: check-and-reserve on disk is not an atomic CAS operation. and lock based on that may silently cause data corruption. """ I haven't follow the evolution of sfex though, so things might have been changed. Just

Re: [Linux-ha-dev] sfex

2008-06-17 Thread Andrew Beekhof
On Tue, Jun 17, 2008 at 18:58, Dejan Muhamedagic <[EMAIL PROTECTED]> wrote: > Hi, > > On Tue, Jun 17, 2008 at 03:46:52PM +0200, Andrew Beekhof wrote: >> On Tue, Jun 17, 2008 at 10:33, Keisuke MORI <[EMAIL PROTECTED]> wrote: >> > Dejan, >> > >> > Thank you for taking care of it. >> > >> > Yes, NTT i

Re: [Linux-ha-dev] sfex

2008-06-17 Thread Dejan Muhamedagic
Hi, On Tue, Jun 17, 2008 at 03:46:52PM +0200, Andrew Beekhof wrote: > On Tue, Jun 17, 2008 at 10:33, Keisuke MORI <[EMAIL PROTECTED]> wrote: > > Dejan, > > > > Thank you for taking care of it. > > > > Yes, NTT is very glad and agrees to include sfex into the > > heartbeat repository! > > I haven'

Re: [Linux-ha-dev] sfex

2008-06-17 Thread Andrew Beekhof
On Tue, Jun 17, 2008 at 10:33, Keisuke MORI <[EMAIL PROTECTED]> wrote: > Dejan, > > Thank you for taking care of it. > > Yes, NTT is very glad and agrees to include sfex into the > heartbeat repository! I haven't seen the code in a while - but does it require any crm libraries? Thats probably the

Re: [Linux-ha-dev] sfex

2008-06-17 Thread Dejan Muhamedagic
Hi Keisuke-san, On Tue, Jun 17, 2008 at 05:33:52PM +0900, Keisuke MORI wrote: > Dejan, > > Thank you for taking care of it. > > Yes, NTT is very glad and agrees to include sfex into the > heartbeat repository! > > Dejan Muhamedagic <[EMAIL PROTECTED]> writes: > > > Hello, > > > > Since last ye

Re: [Linux-ha-dev] sfex

2008-06-17 Thread Keisuke MORI
Dejan, Thank you for taking care of it. Yes, NTT is very glad and agrees to include sfex into the heartbeat repository! Dejan Muhamedagic <[EMAIL PROTECTED]> writes: > Hello, > > Since last year NTT designed and implemented sfex, a suite of > programs to improve shared disk usage (see linux-ha.

[Linux-ha-dev] sfex

2008-06-16 Thread Dejan Muhamedagic
Hello, Since last year NTT designed and implemented sfex, a suite of programs to improve shared disk usage (see linux-ha.org/sfex) which unfortunately didn't attract attention it deserves. I reviewed the code and attached you'll find some comments and some simple changes. One general remark: all p