On Tue, Oct 24, 2017 at 10:10:13PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 24 Oct 2017 22:04:20 +0200
>
> * Add two jump targets so that a bit of exception handling can be better
> reused at the end of this function.
>
> This issue
From: Markus Elfring
Date: Tue, 24 Oct 2017 22:04:20 +0200
* Add two jump targets so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
* Delete the local variable "err"
On 10/24/2017 02:47 AM, Dan Carpenter wrote:
We intended to test for failure here but accidentally tested for
success. It means that we don't set "*val" to true and it means that
if i2c_smbus_write_byte() does fail then we return success.
Fixes: e7895864b0d7 ("hwmon: (max6621) Add support for
Hi Jean,
On 10/24/2017 12:21 AM, Jean Delvare wrote:
Hi Guenter,
On Mon, 23 Oct 2017 17:55:26 -0700, Guenter Roeck wrote:
Commit 3d8f7a89a197 ("hwmon: (tmp102) Improve handling of initial read
delay") reduced the initial temperature read delay and made it dependent
on the chip's shutdown
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Tuesday, October 24, 2017 12:48 PM
> To: Jean Delvare ; Vadim Pasternak
>
> Cc: Guenter Roeck ; linux-hwmon@vger.kernel.org;
>
We intended to test for failure here but accidentally tested for
success. It means that we don't set "*val" to true and it means that
if i2c_smbus_write_byte() does fail then we return success.
Fixes: e7895864b0d7 ("hwmon: (max6621) Add support for Maxim MAX6621
temperature sensor")
Hi Guenter,
On Mon, 23 Oct 2017 17:55:26 -0700, Guenter Roeck wrote:
> Commit 3d8f7a89a197 ("hwmon: (tmp102) Improve handling of initial read
> delay") reduced the initial temperature read delay and made it dependent
> on the chip's shutdown mode. If the chip was not in shutdown mode at probe,
>