Re: [PATCH 1/2] dt-bindings: hwmon: Document ibm,cffps compatible string

2019-10-15 Thread Rob Herring
cetree/bindings/hwmon/ibm,cffps1.txt | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring

Re: [PATCH v2 2/2] dt-bindings: hwmon: Add AXI FAN Control documentation

2019-10-11 Thread Rob Herring
> + interrupts: > + maxItems: 1 > + > + adi,pulses-per-revolution: We already have 'pulses-per-revolution' in pwm-fan binding, so use that. With that changed, Reviewed-by: Rob Herring > +description: > + Value specifying the number of pulses pe

Re: [PATCH v2 2/2] hwmon: (as370-hwmon) Add DT bindings for Synaptics AS370 PVT

2019-09-02 Thread Rob Herring
; create mode 100644 Documentation/devicetree/bindings/hwmon/as370.txt > Reviewed-by: Rob Herring

Re: [PATCH v2 1/3] dt-bindings: hwmon: Document ibm,cffps2 compatible string

2019-09-02 Thread Rob Herring
ns(-) > Reviewed-by: Rob Herring

Re: [PATCH 3/4] dt-bindings: Add optional label property for ina2xx

2019-08-27 Thread Rob Herring
txt | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH] hwmon: Remove ads1015 driver

2019-07-22 Thread Rob Herring
assume no change or I should review it again? Acked-by: Rob Herring > Documentation/hwmon/ads1015.rst| 90 -- > Documentation/hwmon/index.rst | 1 - > MAINTAINERS| 8 - > drivers/hwmon/Kcon

Re: [PATCH v2 1/2] dt-binding: misc: Add common LPC snoop documentation

2019-04-29 Thread Rob Herring
node > +- nuvoton,lpc-en-dwcapture : enable capture double words support. > + > +Example: > + lpc-snoop: lpc_snoop@f0007040 { lpc-snoop@... With that, Reviewed-by: Rob Herring > + compatible = "nuvoton,npcm750-lpc-bpc-snoop"; > + reg = <0xf0007040 0x14>; > + snoop-ports = <0x80>; > + interrupts = ; > + }; > -- > 2.14.1 >

Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties

2019-03-30 Thread Rob Herring
arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 -- > arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 -- > 8 files changed, 16 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH v4 1/2] hwmon: lochnagar: Add device tree binding document

2019-03-29 Thread Rob Herring
On Fri, Mar 29, 2019 at 4:22 AM Charles Keepax wrote: > > On Thu, Mar 28, 2019 at 12:46:15PM -0500, Rob Herring wrote: > > On Thu, Mar 28, 2019 at 01:09:36PM +, Charles Keepax wrote: > > > Lochnagar is an evaluation and development board for Cirrus > > > Logic S

Re: [PATCH V3 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan

2019-03-28 Thread Rob Herring
t; }; >}; > }; > + > +Example 2: > + fan0: pwm-fan { > + fan0: pwm-fan { This line should go. Otherwise, Reviewed-by: Rob Herring > + compatible =

Re: [PATCH v4 1/2] hwmon: lochnagar: Add device tree binding document

2019-03-28 Thread Rob Herring
On Thu, Mar 28, 2019 at 01:09:36PM +, Charles Keepax wrote: > Lochnagar is an evaluation and development board for Cirrus > Logic Smart CODEC and Amp devices. It allows the connection of > most Cirrus Logic devices on mini-cards, as well as allowing > connection of various application processor

Re: [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size

2019-03-28 Thread Rob Herring
pecified. > > Make it explicit in the binding documentation that this prorperty must > be set as a 8-bit value. > > Signed-off-by: Carlos Menin > --- > Documentation/devicetree/bindings/hwmon/adc128d818.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH RFC V2 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan

2019-03-12 Thread Rob Herring
On Mon, Feb 25, 2019 at 04:59:17PM +0100, Stefan Wahren wrote: > This adds the tachometer interrupt to the pwm-fan binding, which is > necessary for RPM support. > > Signed-off-by: Stefan Wahren > --- > Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 19 +++ > 1 file change

Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75

2019-02-28 Thread Rob Herring
+ "ti,tmp275", > + "ti,tmp75", > + "ti,tmp75c", Some of these are in trivial-devices.yaml already. So you either need to remove them from there. Or you can move all these to trivial-devices and benefit from having a schema. I prefer the latter, but either way is fine. You can remove them from trivial-devices.yaml in a separate patch, so: Acked-by: Rob Herring Rob P.S. Third option is convert this doc to DT schema. Don't tell anyone, but you'll be a the top of my review queue.

Re: [PATCH 1/2] hwmon: (ad741x) Add DT bindings for Analog Devices AD741x

2019-02-25 Thread Rob Herring
41x.txt | 15 +++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/ad741x.txt > Reviewed-by: Rob Herring

Re: [PATCH V2 1/2] dt-bindings: hwmon: Add optional regulator support to pwm-fan

2019-02-18 Thread Rob Herring
changed, 3 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH v3 2/4] dt-bindings: Add LM96000 as a trivial device

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 2:19 PM Jeremy Gebben wrote: > > The LM96000 is a temperature sensor and fan controller based > on the LM85. > > Signed-off-by: Jeremy Gebben > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Rob Herring

Re: [PATCH v2 1/2] dt-bindings: hwmon: ina3221: Add ti,single-shot property

2019-01-11 Thread Rob Herring
le-shot" property to allow changing the > default continuous mode to single-shot operating mode. > > Signed-off-by: Nicolin Chen > --- > Documentation/devicetree/bindings/hwmon/ina3221.txt | 10 ++ > 1 file changed, 10 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH 1/2] dt-bindings: hwmon: ina3221: Add ti,single-shot property

2019-01-11 Thread Rob Herring
le-shot" property to allow changing the > default continuous mode to single-shot operating mode. > > Signed-off-by: Nicolin Chen > --- > Documentation/devicetree/bindings/hwmon/ina3221.txt | 10 ++ > 1 file changed, 10 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH 2/4] dt-bindings: power supply: Document dps650ab

2019-01-11 Thread Rob Herring
On Fri, Jan 04, 2019 at 05:00:30PM +0800, Xiaoting Liu wrote: > Bindings for DPS650AB power, voltage, temperature, and fan monitering. s/monitering/monitoring/ > > Signed-off-by: Xiaoting Liu > --- > Documentation/devicetree/bindings/hwmon/dps650ab.txt | 11 +++ > 1 file changed, 11 in

Re: [PATCH 2/2] devicetree: hwmon: Add bindings documentation for HIH6130

2019-01-03 Thread Rob Herring
100644 Documentation/devicetree/bindings/hwmon/hih6130.txt > Reviewed-by: Rob Herring

Re: [PATCH v2 1/2] dt-bindings: hwmon: add binding documentation for adt7475

2018-11-19 Thread Rob Herring
On Sun, Nov 18, 2018 at 4:56 PM Guenter Roeck wrote: > > On 11/17/18 7:29 AM, Rob Herring wrote: > > On Fri, Nov 09, 2018 at 11:56:06AM +1300, Chris Packham wrote: > >> With the addition of the invert-pwm property the adt7475 needs its own > >> binding documentati

Re: [PATCH v2 1/2] dt-bindings: hwmon: add binding documentation for adt7475

2018-11-17 Thread Rob Herring
On Fri, Nov 09, 2018 at 11:56:06AM +1300, Chris Packham wrote: > With the addition of the invert-pwm property the adt7475 needs its own > binding documentation rather being captured under trivial-devices.txt. > > Signed-off-by: Chris Packham > --- > Changes in v2: > - use pwm-polarity attiribute

Re: [PATCH v3 1/2] hwmon: (adcxx) add devictree bindings documentation

2018-11-17 Thread Rob Herring
On Thu, Nov 15, 2018 at 02:50:12PM +0100, Florian Eckert wrote: > Document the devicetree bindings for the adcxx. > > Signed-off-by: Florian Eckert > --- > Documentation/devicetree/bindings/hwmon/adcxx.txt | 24 > +++ > 1 file changed, 24 insertions(+) > create mode 100644

[PATCH] hwmon: ina3221: Convert to using %pOFn instead of device_node.name

2018-11-16 Thread Rob Herring
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Jean Delvare Cc: Guenter Roeck Cc: linux-hwmon@vger.kernel.org Signed-off-by: Rob Herring --- drivers/hwmon/ina3221.c | 8 1 file changed, 4 insertions

Re: [PATCH v3 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-10-30 Thread Rob Herring
On Mon, Oct 29, 2018 at 05:40:24PM +0530, Manish Narani wrote: > Xilinx AMS have several ADC channels that can be used for measurement of > different voltages and temperatures. Document the same in the bindings. > > Signed-off-by: Manish Narani > --- > .../devicetree/bindings/iio/adc/xilinx-ams.

Re: [PATCH v3 2/2] dt-bindings: hwmon: Add adm127x documentation

2018-10-18 Thread Rob Herring
cetree/bindings/hwmon/adm1275.txt | 25 +++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt > Reviewed-by: Rob Herring

Re: [PATCH v2] hwmon: (sht3x) add devicetree support

2018-10-18 Thread Rob Herring
Adding Wolfram and i2c list... On Thu, Oct 18, 2018 at 9:41 AM Guenter Roeck wrote: > > On Thu, Oct 18, 2018 at 08:47:43AM -0500, Rob Herring wrote: > > On Tue, Oct 16, 2018 at 6:38 PM Guenter Roeck wrote: > > > > > > On Tue, Oct 16, 2018 at 01:02:08PM -0500, Rob

Re: [PATCH v2] hwmon: (sht3x) add devicetree support

2018-10-18 Thread Rob Herring
On Tue, Oct 16, 2018 at 6:38 PM Guenter Roeck wrote: > > On Tue, Oct 16, 2018 at 01:02:08PM -0500, Rob Herring wrote: > > On Mon, Oct 15, 2018 at 2:54 PM Guenter Roeck wrote: > > > > > > On Mon, Oct 15, 2018 at 07:55:58AM +0200, Wojciech Sleńska wrote: > &

Re: [PATCH v2] hwmon: (sht3x) add devicetree support

2018-10-16 Thread Rob Herring
On Mon, Oct 15, 2018 at 2:54 PM Guenter Roeck wrote: > > On Mon, Oct 15, 2018 at 07:55:58AM +0200, Wojciech Sleńska wrote: > > pt., 12 paź 2018 o 22:28 Rob Herring napisał(a): > > > > > > On Fri, Oct 05, 2018 at 07:38:35AM +0200, Wojciech Slenska

Re: [PATCH v2] hwmon: (sht3x) add devicetree support

2018-10-12 Thread Rob Herring
On Fri, Oct 05, 2018 at 07:38:35AM +0200, Wojciech Slenska wrote: Commit msg? > Signed-off-by: Wojciech Slenska > --- > Documentation/devicetree/bindings/hwmon/sht3x.txt | 16 + Please split bindings to separate patch. > drivers/hwmon/sht3x.c | 28 > ++

Re: [PATCH v2] hwmon: (adm1275): Add device tree param for shunt resistor

2018-10-12 Thread Rob Herring
On Fri, Sep 28, 2018 at 12:58:00PM -0700, Kun Yi wrote: > The ADM series of hotswap controllers support extending > the current measurement range by using a sensing resistor > value other than the typical 1 mOhm. For example, using a 0.5 mOhm > sensing resistor doubles the maximal current can be me

Re: [PATCH v9 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-10-05 Thread Rob Herring
in the child node > * * Added status property to indicate connection status > * * Changed to use child node name as the label of input source > > .../devicetree/bindings/hwmon/ina3221.txt | 44 +++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/ina3221.txt > Reviewed-by: Rob Herring

Re: [PATCH v6 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-27 Thread Rob Herring
On Thu, Sep 27, 2018 at 2:49 PM Nicolin Chen wrote: > > Texas Instruments INA3221 is a triple-channel shunt and bus > voltage monitor. This patch adds a DT binding doc for it. > > Signed-off-by: Nicolin Chen > --- > Changelog > v5->v6: > * Removed status property as no need to explicitly list it

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-27 Thread Rob Herring
On Tue, Sep 25, 2018 at 03:59:29PM -0700, Nicolin Chen wrote: > Texas Instruments INA3221 is a triple-channel shunt and bus > voltage monitor. This patch adds a DT binding doc for it. > > Signed-off-by: Nicolin Chen > --- > Changelog > v4->v5: > * Replaced "input-id" with "reg" and added address

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-27 Thread Rob Herring
On Tue, Sep 25, 2018 at 06:52:29PM -0700, Guenter Roeck wrote: > Hi Nicolin, > > On 09/25/2018 03:59 PM, Nicolin Chen wrote: > > Texas Instruments INA3221 is a triple-channel shunt and bus > > voltage monitor. This patch adds a DT binding doc for it. > > > > Signed-off-by: Nicolin Chen > > --- >

Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD

2018-09-27 Thread Rob Herring
On Tue, 18 Sep 2018 14:51:19 -0700, Jae Hyun Yoo wrote: > This commit adds a dt-bindings document for PECI client MFD. > > Cc: Lee Jones > Cc: Rob Herring > Cc: Mark Rutland > Cc: Andrew Jeffery > Cc: James Feist > Cc: Jason M Biils > Cc: Joel Stanley > Cc:

Re: [PATCH v8 01/12] dt-bindings: Add a document of PECI subsystem

2018-09-27 Thread Rob Herring
On Tue, 18 Sep 2018 14:51:13 -0700, Jae Hyun Yoo wrote: > This commit adds a document of generic PECI bus, adapter and client > driver. > > Cc: Rob Herring > Cc: Mark Rutland > Cc: Andrew Jeffery > Cc: Joel Stanley > Signed-off-by: Jae Hyun Yoo > Reviewed-by:

Re: [PATCH v5 01/10] dt-bindings: fsi: Add P9 OCC device documentation

2018-09-10 Thread Rob Herring
On Thu, Aug 30, 2018 at 04:32:32PM -0500, Eddie James wrote: > Document the bindings for the FSI-attached POWER9 On-Chip Controller. > > Signed-off-by: Eddie James > --- > Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt | 15 +++ > 1 file changed, 15 insertions(+) > create mode

[PATCH] hwmon: drop unnecessary OF name NULL checks

2018-08-29 Thread Rob Herring
Checking the child node names is pointless as the DT node name can never be NULL, so remove it. Cc: Jean Delvare Cc: Guenter Roeck Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linux-hwmon@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Rob Herring

Re: [PATCH] hwmon: Convert to using %pOFn instead of device_node.name

2018-08-28 Thread Rob Herring
On Tue, Aug 28, 2018 at 8:57 AM Guenter Roeck wrote: > > On 08/27/2018 06:52 PM, Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Jean Delvare

[PATCH] hwmon: Convert to using %pOFn instead of device_node.name

2018-08-27 Thread Rob Herring
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Jean Delvare Cc: Guenter Roeck Cc: linux-hwmon@vger.kernel.org Signed-off-by: Rob Herring --- drivers/hwmon/aspeed-pwm-tacho.c | 2 +- drivers/hwmon/ibmpowernv.c

Re: [PATCH v7 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-07-30 Thread Rob Herring
On Fri, Jul 27, 2018 at 11:36 AM Jae Hyun Yoo wrote: > > Hi Lee, > > On 7/27/2018 1:26 AM, Lee Jones wrote: > > On Mon, 23 Jul 2018, Jae Hyun Yoo wrote: > > > >> This commit adds PECI client MFD driver. > >> > >> Signed-off-by: Jae Hyun Yoo

Re: [PATCH v1 1/2] dt-binding: bmc: Add NPCM7xx LPC BPC documentation

2018-07-11 Thread Rob Herring
e > + > +Nuvoton BMC NPCM7xx BIOS Post Code (BPC) monitoring two > +configurable I/O addresses written by the host on the > +Low Pin Count (LPC) bus, the capure data stored in 128-word FIFO. s/capure/capture/ Otherwise, Reviewed-by: Rob Herring > + > +NPCM7xx BPC supports

Re: [PATCH v8 1/2] dt-binding: hwmon: Add NPCM7xx PWM and Fan controller documentation

2018-07-05 Thread Rob Herring
oller inputs. > > Signed-off-by: Tomer Maimon > --- > .../devicetree/bindings/hwmon/npcm750-pwm-fan.txt | 84 > ++ > 1 file changed, 84 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/hwmon/npcm750-pwm-fan.txt Reviewed-by: Rob Herri

Re: [PATCH v7 1/2] dt-binding: hwmon: Add NPCM7xx PWM and Fan controller documentation

2018-07-03 Thread Rob Herring
On Tue, Jul 03, 2018 at 12:47:00PM +0300, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM7xx Pulse Width Modulation (PWM) and Fan tach controller. > The PWM controller can support upto 8 PWM output ports. > The Fan tach controller can support upto 16 tachometer

Re: [PATCH v4 1/2] dt-binding: hwmon: Add NPCM7xx PWM and Fan controller documentation

2018-06-26 Thread Rob Herring
On Mon, Jun 25, 2018 at 4:20 PM Tomer Maimon wrote: > > Hi Rob, > > > On 25 June 2018 at 20:14, Rob Herring wrote: >> >> On Sun, Jun 24, 2018 at 03:41:54PM +0300, Tomer Maimon wrote: >> > Added device tree binding documentation for Nuvoton BMC >> >

Re: [PATCH v4 1/2] dt-binding: hwmon: Add NPCM7xx PWM and Fan controller documentation

2018-06-25 Thread Rob Herring
On Sun, Jun 24, 2018 at 03:41:54PM +0300, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM7xx Pulse Width Modulation (PWM) and Fan tach controller. > The PWM controller can support upto 8 PWM output ports. > The Fan tach controller can support upto 16 tachometer

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-18 Thread Rob Herring
On Wed, Apr 18, 2018 at 3:28 PM, Jae Hyun Yoo wrote: > On 4/18/2018 7:32 AM, Rob Herring wrote: >> >> On Tue, Apr 17, 2018 at 3:40 PM, Jae Hyun Yoo >> wrote: >>> >>> On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote: >>>> >>>> >>>&g

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-18 Thread Rob Herring
On Tue, Apr 17, 2018 at 3:40 PM, Jae Hyun Yoo wrote: > On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote: >> >> On 4/16/2018 4:22 PM, Jae Hyun Yoo wrote: >>> >>> On 4/16/2018 11:14 AM, Rob Herring wrote: >>>> >>>> On Tue, Apr 10, 2018 at 11:32:09A

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-18 Thread Rob Herring
On Tue, Apr 17, 2018 at 5:06 PM, Jae Hyun Yoo wrote: > On 4/17/2018 11:16 AM, Jae Hyun Yoo wrote: >> >> On 4/17/2018 6:16 AM, Rob Herring wrote: >>> >>> On Mon, Apr 16, 2018 at 6:12 PM, Jae Hyun Yoo >>> wrote: >>>> >>>> On 4/16/

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-17 Thread Rob Herring
On Mon, Apr 16, 2018 at 6:12 PM, Jae Hyun Yoo wrote: > On 4/16/2018 11:10 AM, Rob Herring wrote: >> >> On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: >>> >>> This commit adds a dt-bindings document of PECI adapter driver for Aspeed >>>

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-16 Thread Rob Herring
On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: > This commit adds dt-bindings documents for PECI cputemp and dimmtemp client > drivers. "dt-bindings: hwmon: ..." for the subject. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-16 Thread Rob Herring
On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: > This commit adds a dt-bindings document of PECI adapter driver for Aspeed > AST24xx/25xx SoCs. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Vernon Mauery > Cc: Alan Cox > Cc

Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

2018-04-16 Thread Rob Herring
On Tue, Apr 10, 2018 at 11:32:03AM -0700, Jae Hyun Yoo wrote: > This commit adds documents of generic PECI bus, adapter and client drivers. "dt-bindings: ..." for the subject prefix please. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Ve

Re: [PATCH V2 3/9] dt-bindings: Tegra186 tachometer device tree bindings

2018-04-10 Thread Rob Herring
On Mon, Apr 9, 2018 at 9:37 AM, Mikko Perttunen wrote: > > > On 04/09/2018 04:21 PM, Rob Herring wrote: >> >> On Mon, Apr 9, 2018 at 12:38 AM, Mikko Perttunen wrote: >>> >>> Rob, >> >> >> Please don't top post to lists. >> &g

Re: [PATCH v3 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-04-09 Thread Rob Herring
On Wed, Mar 28, 2018 at 01:53:53PM -0700, Tim Harvey wrote: > On Wed, Mar 28, 2018 at 1:23 PM, Guenter Roeck wrote: > > On Wed, Mar 28, 2018 at 12:17:34PM -0700, Tim Harvey wrote: > >> On Wed, Mar 28, 2018 at 9:24 AM, Guenter Roeck wrote: > >> > On Wed, Mar 28, 2018 at 08:14:00AM -0700, Tim Harve

Re: [PATCH V2 3/9] dt-bindings: Tegra186 tachometer device tree bindings

2018-04-09 Thread Rob Herring
to control fans and types of fans, so yes, the interface of control and feedback lines between a fan and its controller should absolutely be generic. Rob > > Thanks, > Mikko > > > On 03/27/2018 05:52 PM, Rob Herring wrote: >> >> On Wed, Mar 21, 2018 at 10:10

Re: [PATCH V2 3/9] dt-bindings: Tegra186 tachometer device tree bindings

2018-03-27 Thread Rob Herring
On Tue, Mar 27, 2018 at 09:52:49AM -0500, Rob Herring wrote: > On Wed, Mar 21, 2018 at 10:10:38AM +0530, Rajkumar Rampelli wrote: > > Supply Device tree binding documentation for the NVIDIA > > Tegra186 SoC's Tachometer Controller > > > > Signed-off-by: Rajkum

Re: [PATCH V2 3/9] dt-bindings: Tegra186 tachometer device tree bindings

2018-03-27 Thread Rob Herring
On Wed, Mar 21, 2018 at 10:10:38AM +0530, Rajkumar Rampelli wrote: > Supply Device tree binding documentation for the NVIDIA > Tegra186 SoC's Tachometer Controller > > Signed-off-by: Rajkumar Rampelli > --- > > V2: Renamed compatible string to "nvidia,tegra186-pwm-tachometer" > Renamed dt pr

Re: [PATCH v2 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-03-09 Thread Rob Herring
On Mon, Mar 05, 2018 at 02:02:38PM -0800, Tim Harvey wrote: > This patch adds documentation of device-tree bindings for the > Gateworks System Controller (GSC). > > Signed-off-by: Tim Harvey > --- > Documentation/devicetree/bindings/mfd/gsc.txt | 159 > ++ > 1 file chang

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-03-01 Thread Rob Herring
On Wed, Feb 21, 2018 at 05:20:29PM +0200, Mikko Perttunen wrote: > On 21.02.2018 16:46, Guenter Roeck wrote: > > On 02/20/2018 11:15 PM, Mikko Perttunen wrote: > > > AIUI, the PWM framework already exposes a sysfs node with period > > > information. We should just use that instead of adding a new d

Re: [PATCH v2 1/2] hwmon: (jc42) optionally try to disable the SMBUS timeout

2017-11-28 Thread Rob Herring
way. > > Signed-off-by: Peter Rosin > --- > Documentation/devicetree/bindings/hwmon/jc42.txt | 4 Acked-by: Rob Herring > drivers/hwmon/jc42.c | 21 + > 2 files changed, 25 insertions(+) -- To unsubscribe from this list: send the line

Re: [PATCH v3 04/12] dt-bindings: fsi: Add P9 OCC hwmon device documentation

2017-11-21 Thread Rob Herring
On Mon, Nov 20, 2017 at 05:53:33PM -0600, Eddie James wrote: > From: "Edward A. James" > > Document the bindings for the FSI-based OCC hwmon device. > > Signed-off-by: Edward A. James > --- > .../devicetree/bindings/fsi/ibm,p9-occ-hwmon.txt | 16 > > 1 file changed, 1

Re: [PATCH v3 03/12] dt-bindings: i2c: Add P8 OCC hwmon device documentation

2017-11-21 Thread Rob Herring
> 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/ibm,p8-occ-hwmon.txt Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.

Re: [PATCH v4 1/3] DT: i2c: W83773G is a trivial device

2017-11-15 Thread Rob Herring
On Mon, Nov 13, 2017 at 11:27:32AM +0800, Lei YU wrote: > Signed-off-by: Lei YU > --- > Documentation/devicetree/bindings/trivial-devices.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt > b/Documentation/devicetree/bindings/triv

Re: [PATCH v4 1/6] dt-bindings: pmbus: Add Maxim MAX31785 documentation

2017-11-06 Thread Rob Herring
hwmon/max31785.txt Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] dt-bindings: hwmon: aspeed-pwm-tacho: Add reset node

2017-11-06 Thread Rob Herring
s had the reset controller, as > the hardware is unusable without it. > > Signed-off-by: Joel Stanley > --- > .../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 14 > +- > 1 file changed, 5 insertions(+), 9 deletions(-) Acked-by: Rob Herring -- To unsub

Re: [PATCH 1/2] hwmon: (jc42) optionally try to disable the SMBUS timeout

2017-10-17 Thread Rob Herring
On Fri, Oct 13, 2017 at 01:35:27PM -0700, Guenter Roeck wrote: > On Fri, Oct 13, 2017 at 04:26:57PM +0200, Peter Rosin wrote: > > On 2017-10-13 15:50, Guenter Roeck wrote: > > > On 10/13/2017 02:27 AM, Peter Rosin wrote: > > >> With a nxp,se97 chip on an atmel sama5d31 board, the I2C adapter driver

Re: [PATCH v2 3/4] dt-bindings: hwmon: Add ti-max-expected-current-microamp property to ina2xx

2017-10-17 Thread Rob Herring
On Thu, Oct 12, 2017 at 02:36:04PM +0200, Maciej Purski wrote: > Add optional max expected current property which allows calibrating > the ina sensor in order to achieve requested measure scale. Document > the changes in Documentation/hwmon/ina2xx. > > Signed-off-by: Maciej Purski > --- > Docume

Re: [PATCH 3/4] dt-bindings: hwmon: Add max-expected-current property to ina2xx

2017-10-05 Thread Rob Herring
On Thu, Oct 05, 2017 at 05:15:07PM +0200, Maciej Purski wrote: > On 10/01/2017 12:31 PM, Jonathan Cameron wrote: > > On Thu, 28 Sep 2017 14:50:14 +0200 > > Maciej Purski wrote: > > > > > Add optional max expected current property which allows calibrating > > > the ina sensor in order to achieve r

Re: [PATCH 1/9] hwmon: gpio-fan: Move DT bindings to the right place

2017-10-05 Thread Rob Herring
-by: Linus Walleij > --- > Documentation/devicetree/bindings/{gpio => hwmon}/gpio-fan.txt | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename Documentation/devicetree/bindings/{gpio => hwmon}/gpio-fan.txt (100%) Acked-by: Rob Herring -- To unsubscribe from this list: se

Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation

2017-09-19 Thread Rob Herring
On Thu, Sep 14, 2017 at 2:06 AM, Florian Eckert wrote: > Hello Rob > > > + > > +Requires node properties: > > +- compatible value : > > + "lantiq,cputemp" Kind of non-specific. How is this device even accessed without any other property? >>> >>> >>> >>>

Re: [PATCH 2/2] hwmon: add dt binding for max1619

2017-09-19 Thread Rob Herring
On Tue, Sep 19, 2017 at 1:11 PM, Alan Tull wrote: > On Mon, Sep 18, 2017 at 4:11 PM, Rob Herring wrote: >> On Mon, Sep 11, 2017 at 12:58:57PM -0700, Guenter Roeck wrote: >>> On Mon, Sep 11, 2017 at 02:16:49PM -0500, Alan Tull wrote: >>> > Add new d

Re: [PATCH 1/2] dt-bindings: hwmon: add compatible for max1619

2017-09-18 Thread Rob Herring
dless. This could be in trivial-devices.txt instead. Either way, Acked-by: Rob Herring Rob > > Alan > > > On Mon, Sep 11, 2017 at 2:16 PM, Alan Tull wrote: > > > > Add Oleksij Rempel > > > >> Add new device tree bindings document for max1619 device &g

Re: [PATCH 2/2] hwmon: add dt binding for max1619

2017-09-18 Thread Rob Herring
On Mon, Sep 11, 2017 at 12:58:57PM -0700, Guenter Roeck wrote: > On Mon, Sep 11, 2017 at 02:16:49PM -0500, Alan Tull wrote: > > Add new device tree binding for max1619. > > > > Signed-off-by: Alan Tull > > Technically that should already work, without explicit binding, > or did the i2c core chan

Re: [patch v2 2/2] dt-bindings: hwmon: add binding documentation for max6621 device

2017-09-18 Thread Rob Herring
ddress of the device. This could go in trivial-devices.txt instead. Either way, Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/3] dt-bindings: hwmon: pmbus: Add Maxim MAX31785 documentation

2017-09-18 Thread Rob Herring
On Fri, Sep 08, 2017 at 02:39:17PM +1000, Andrew Jeffery wrote: > Signed-off-by: Andrew Jeffery > --- > .../devicetree/bindings/hwmon/pmbus/max31785.txt | 158 > + I think this needs to be located by what it does (fan control), not what interface it has (pmbus). I'm not a

Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation

2017-09-13 Thread Rob Herring
On Wed, Sep 13, 2017 at 12:36 AM, Florian Eckert wrote: > Hello Rob > >>> > --- /dev/null >>> > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt >>> > @@ -0,0 +1,10 @@ >>> > +Lantiq cpu temperatur sensor >> >> >> s/temperatur/temperature/ > > > Will update this in a follow up page bas

Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation

2017-09-12 Thread Rob Herring
On Fri, Sep 01, 2017 at 07:26:22AM -0700, Guenter Roeck wrote: > On Fri, Sep 01, 2017 at 08:58:18AM +0200, Florian Eckert wrote: > > Document the devicetree bindings for the ltq-cputemp > > > > Signed-off-by: Florian Eckert > > I see nothing special with the bindings, and they are in line with o

Re: [PATCH v5 1/3] dt-bindings: hwmon: Document the IBM CCF power supply version 1

2017-08-25 Thread Rob Herring
de 100644 Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power supply device

2017-08-17 Thread Rob Herring
On Thu, Aug 10, 2017 at 05:19:44PM -0500, Eddie James wrote: > From: "Edward A. James" > > Signed-off-by: Edward A. James > --- > .../devicetree/bindings/i2c/ibm,power-ps.txt| 21 > + > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/

Re: [PATCH v2 1/4] dt-bindings: hwmon: pmbus: Add Maxim MAX31785 documentation

2017-08-10 Thread Rob Herring
On Wed, Aug 02, 2017 at 04:45:38PM +0930, Andrew Jeffery wrote: > Signed-off-by: Andrew Jeffery > --- > .../devicetree/bindings/hwmon/pmbus/max31785.txt | 126 > + > 1 file changed, 126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/max317

Re: [PATCH v2 10/10] dt-bindings: i2c: Add P8 OCC hwmon driver documentation

2017-08-03 Thread Rob Herring
On Thu, Jul 27, 2017 at 09:30:29AM -0500, Eddie James wrote: > From: "Edward A. James" > > Document the bindings for I2C-based OCC hwmon driver. > > Signed-off-by: Edward A. James > --- > .../devicetree/bindings/i2c/ibm,p8-occ-hwmon.txt | 25 > ++ > 1 file changed, 25 in

[PATCH] hwmon: Convert to using %pOF instead of full_name

2017-07-18 Thread Rob Herring
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring Cc: Dirk Eibach Cc: Jean Delvare Cc: Guenter Roeck Cc: linux-hwmon@vger.kernel.org

Re: [PATCHv5 2/6] dt-bindings: mfd: da9052: support TSI as ADC

2017-07-07 Thread Rob Herring
bastian Reichel > --- > Documentation/devicetree/bindings/mfd/da9052-i2c.txt | 8 > 1 file changed, 8 insertions(+) Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kerne

Re: [PATCH v3 2/3] hwmon: ltc2990: add devicetree binding

2017-07-07 Thread Rob Herring
> 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/ltc2990.txt Otherwise, Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kerne

Re: [PATCH 1/7] drivers/hwmon: Add On-Chip Controller (OCC) hwmon driver

2017-06-26 Thread Rob Herring
On Thu, Jun 22, 2017 at 05:48:30PM -0500, Eddie James wrote: > From: "Edward A. James" > > The OCC is a device embedded on a POWER processor that collects and > aggregates sensor data from the processor and system. The OCC can > provide the raw sensor data as well as perform thermal and power > m

Re: [PATCH v4 1/2] Documentation: bindings: add amlogic,meson-gxbb-scpi-sensors compatible

2017-06-07 Thread Rob Herring
tion/devicetree/bindings/arm/arm,scpi.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors

2017-04-27 Thread Rob Herring
On Thu, Apr 27, 2017 at 11:28:37AM -0700, Markus Mayer wrote: > On 25 April 2017 at 12:29, Markus Mayer wrote: > > Hi Rob, > > > > On 18 April 2017 at 13:17, Markus Mayer wrote: > >> From: Markus Mayer > >> > >> Provide bindings for the Broadcom STB DDR PHY Front End (DPFE). > > > > Would you be

Re: [PATCH v2 2/2] devicetree: Document the max31760 device binding.

2017-04-19 Thread Rob Herring
On Tue, Apr 11, 2017 at 02:32:18PM -0700, John Muir wrote: > v2: > - Fixup based on comments. While you should have a commit msg here, the patch versioning goes below the '---'. This history is not too useful either. You should describe what you changed so reviewers don't have to go find the pre

Re: [PATCH 2/3] dt-bindings: hwmon: Add bindings for Google Chromium EC HWMON

2017-04-14 Thread Rob Herring
On Thu, Apr 13, 2017 at 4:07 PM, Guenter Roeck wrote: > On Thu, Apr 13, 2017 at 03:01:40PM -0500, Rob Herring wrote: >> On Fri, Apr 07, 2017 at 03:00:09PM -0700, Moritz Fischer wrote: >> > From: Moritz Fischer >> > >> > Add bindings for the Chromium EC HWMO

Re: [PATCH 2/3] dt-bindings: hwmon: Add bindings for Google Chromium EC HWMON

2017-04-13 Thread Rob Herring
On Fri, Apr 07, 2017 at 03:00:09PM -0700, Moritz Fischer wrote: > From: Moritz Fischer > > Add bindings for the Chromium EC HWMON. The Chromium EC HWMON > allows monitoring of temperature sensors and fans attached to the > EC. > > Signed-off-by: Moritz Fischer > --- > .../devicetree/bindings/h

Re: [PATCH 2/2] devicetree: Document the max31760 device binding.

2017-04-10 Thread Rob Herring
On Mon, Apr 10, 2017 at 10:42 AM, Rob Herring wrote: > On Tue, Apr 04, 2017 at 12:20:34PM -0700, John Muir wrote: >> Signed-off-by: John Muir >> --- >> .../devicetree/bindings/hwmon/max31760.txt | 58 >> ++ >> 1 file changed, 58 ins

Re: [PATCH 2/2] devicetree: Document the max31760 device binding.

2017-04-10 Thread Rob Herring
On Tue, Apr 04, 2017 at 12:20:34PM -0700, John Muir wrote: > Signed-off-by: John Muir > --- > .../devicetree/bindings/hwmon/max31760.txt | 58 > ++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/max31760.txt > > diff

Re: [PATCH linux v5 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver

2017-03-30 Thread Rob Herring
each child node: > +- reg : should specify PWM source port. > + integer value in the range 0 to 7 with 0 indicating PWM port A and > + 7 indicating PWM port H. > + > +- aspeed-fan-tach-ch : should specify the Fan tach input channel. aspeed,fan-tach-ch With that, Acked-by

Re: [PATCH v5] hwmon: ads7828 optional parameters from the device tree

2017-03-24 Thread Rob Herring
On Wed, Mar 22, 2017 at 07:05:55AM -0600, Sam Povilus wrote: > On Wed, Mar 22, 2017 at 09:42:40AM +0100, Wolfram Sang wrote: > > > > > .../devicetree/bindings/i2c/trivial-devices.txt| 2 -- > > > > This file is about to get moved one directory up: > > > > https://git.kernel.org/pub/scm/linu

Re: [PATCH v5] hwmon: ads7828 optional parameters from the device tree

2017-03-24 Thread Rob Herring
On Mon, Mar 20, 2017 at 09:24:34PM -0600, Sam Povilus wrote: > Adding the ability for the ads7828 and ads7830 to use the device tree to > get their optional parameters, instead of using platform devices. This > allows people using custom boards to also use the ads7828 in a non-default > manner. >

Re: [PATCH linux v4 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver

2017-03-20 Thread Rob Herring
On Fri, Mar 10, 2017 at 05:53:50PM -0800, Jaghathiswari Rankappagounder Natarajan wrote: > This binding provides interface for adding values related to ASPEED > AST2400/2500 PWM and Fan tach controller support. > The PWM controller can support upto 8 PWM output ports. > The Fan tach controller can

Re: [PATCH v3 1/2] Documentation: bindings: Introduce scpi,sensors-scale

2017-03-15 Thread Rob Herring
On Wed, Mar 15, 2017 at 06:20:33PM +, Sudeep Holla wrote: > > > On 09/03/17 10:17, Carlo Caione wrote: > > From: Carlo Caione > > > > Document the new property `scpi,sensors-scale` used by the hwmon-scpi > > driver to convert the sensor readings to the correct / expected scale. > > > > I

  1   2   >