Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Guenter Roeck
On Tue, Oct 09, 2018 at 04:42:42PM -0400, Steven Rostedt wrote: > On Tue, 9 Oct 2018 13:39:37 -0700 > Guenter Roeck wrote: > > > > Personally a checkpatch warning bugs me more than having an extra > > > line :) > > > > > Same here. If we no longer believe in the 80-column limit, we should

Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Steven Rostedt
On Tue, 9 Oct 2018 13:39:37 -0700 Guenter Roeck wrote: > > Personally a checkpatch warning bugs me more than having an extra > > line :) > > > Same here. If we no longer believe in the 80-column limit, we should remove > it, > not use it to hide other problems in the noise. Note, this is

Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Steven Rostedt
On Tue, 9 Oct 2018 13:39:37 -0700 Guenter Roeck wrote: > > Personally a checkpatch warning bugs me more than having an extra > > line :) > > > Same here. If we no longer believe in the 80-column limit, we should remove > it, > not use it to hide other problems in the noise. Yes, please, can

Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Guenter Roeck
On Tue, Oct 09, 2018 at 12:57:43PM -0700, Nicolin Chen wrote: > On Tue, Oct 09, 2018 at 03:49:45PM -0400, Steven Rostedt wrote: > > > > > Trace events are useful for people who collect data from the > > > > > ftrace output. This patch adds initial trace events for the > > > > > hwmon core. To call

Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Nicolin Chen
On Tue, Oct 09, 2018 at 03:49:45PM -0400, Steven Rostedt wrote: > > > > Trace events are useful for people who collect data from the > > > > ftrace output. This patch adds initial trace events for the > > > > hwmon core. To call hwmon_attr_base() for aligned attr index > > > > numbers, this patch

Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Steven Rostedt
On Tue, 9 Oct 2018 12:11:11 -0700 Nicolin Chen wrote: > On Tue, Oct 09, 2018 at 02:57:21PM -0400, Steven Rostedt wrote: > > > > Trace events are useful for people who collect data from the > > > ftrace output. This patch adds initial trace events for the > > > hwmon core. To call

Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Nicolin Chen
On Tue, Oct 09, 2018 at 02:57:21PM -0400, Steven Rostedt wrote: > > Trace events are useful for people who collect data from the > > ftrace output. This patch adds initial trace events for the > > hwmon core. To call hwmon_attr_base() for aligned attr index > > numbers, this patch also moves the

Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Steven Rostedt
On Tue, 9 Oct 2018 11:26:02 -0700 Nicolin Chen wrote: > Trace events are useful for people who collect data from the > ftrace output. This patch adds initial trace events for the > hwmon core. To call hwmon_attr_base() for aligned attr index > numbers, this patch also moves the function upward.

[PATCH] hwmon: (core) Add trace events to _attr_show/store functions

2018-10-09 Thread Nicolin Chen
Trace events are useful for people who collect data from the ftrace output. This patch adds initial trace events for the hwmon core. To call hwmon_attr_base() for aligned attr index numbers, this patch also moves the function upward. Ftrace outputs: ...: hwmon_attr_show_string: index=2,