Re: [lm-sensors] [RFC PATCH 2/9] hwmon: lis3: regulator control

2010-10-02 Thread Onkalo Samu
On Sat, 2010-10-02 at 19:33 +0200, ext Jonathan Cameron wrote: > On 10/01/10 12:46, Samu Onkalo wrote: > > Based on pm_runtime control, turn lis3 regulators on and off. > > Perform context save and restore on transitions. > > As this is a simple save and restore state patch I'm happy to comment on

Re: [lm-sensors] [RFC PATCH 1/9] hwmon: lis3: pm_runtime support

2010-10-02 Thread Onkalo Samu
Thanks for comments. On Sat, 2010-10-02 at 19:14 +0200, ext Jonathan Cameron wrote: > On 10/01/10 12:46, Samu Onkalo wrote: > > Add pm_runtime support to lis3 core driver. > > Add pm_runtime support to lis3 i2c driver. > > > > spi and hp_accel drivers are not yet supported. Old always > > on fun

Re: [lm-sensors] [RFC PATCH 5/9] hwmon: lis3: Power on corrections

2010-10-02 Thread Jonathan Cameron
On 10/01/10 12:46, Samu Onkalo wrote: > Sometimes lis3 chip seems to fail to setup factory tuning at boot up. > This probably happens if there is some odd power ramp down ramp up sequence > for example in device restart. Set boot bit in control2 register to > trig boot sequence manually and wait un

Re: [lm-sensors] [RFC PATCH 2/9] hwmon: lis3: regulator control

2010-10-02 Thread Jonathan Cameron
On 10/01/10 12:46, Samu Onkalo wrote: > Based on pm_runtime control, turn lis3 regulators on and off. > Perform context save and restore on transitions. As this is a simple save and restore state patch I'm happy to comment on it. Mostly fine, though I have a couple of minor questions. > > Signed

Re: [lm-sensors] [RFC PATCH 1/9] hwmon: lis3: pm_runtime support

2010-10-02 Thread Jonathan Cameron
On 10/01/10 12:46, Samu Onkalo wrote: > Add pm_runtime support to lis3 core driver. > Add pm_runtime support to lis3 i2c driver. > > spi and hp_accel drivers are not yet supported. Old always > on functionality remains for those. > > For sysfs there is 5 second delay before turning off the > chip

Re: [lm-sensors] [RFC PATCH 0/9] lis3 accelerator feature update

2010-10-02 Thread Guenter Roeck
On Sat, Oct 02, 2010 at 08:27:05AM -0400, Jonathan Cameron wrote: > On 10/02/10 09:25, Jean Delvare wrote: > > Hi Guenter, > > > > On Fri, 1 Oct 2010 19:53:11 -0700, Guenter Roeck wrote: > >> On Fri, Oct 01, 2010 at 07:46:47AM -0400, Samu Onkalo wrote: > >>> This patch set is done to top of 2.6.36

Re: [lm-sensors] [RFC PATCH 0/9] lis3 accelerator feature update

2010-10-02 Thread Jonathan Cameron
On 10/02/10 09:25, Jean Delvare wrote: > Hi Guenter, > > On Fri, 1 Oct 2010 19:53:11 -0700, Guenter Roeck wrote: >> On Fri, Oct 01, 2010 at 07:46:47AM -0400, Samu Onkalo wrote: >>> This patch set is done to top of 2.6.36-RC5 >>> >>> Changes are tested only with I2C interface using 8bit sensor sinc

Re: [RFC PATCH 0/9] lis3 accelerator feature update

2010-10-02 Thread Jean Delvare
Hi Guenter, On Fri, 1 Oct 2010 19:53:11 -0700, Guenter Roeck wrote: > On Fri, Oct 01, 2010 at 07:46:47AM -0400, Samu Onkalo wrote: > > This patch set is done to top of 2.6.36-RC5 > > > > Changes are tested only with I2C interface using 8bit sensor since I don't > > have other possibilities. > >