10-bit address support in i2c-omap and i2c-davinci

2011-11-07 Thread Jean Delvare
Both bus drivers i2c-omap and i2c-davinci apparently handle 10-bit addresses: (i2c-omap.c) if (msg-flags I2C_M_TEN) w |= OMAP_I2C_CON_XA; (i2c-davinci.c) /* if the slave address is ten bit address, enable XA bit */ if (msg-flags I2C_M_TEN)

RE: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness

2011-11-07 Thread Voss, Nikolaus
Hi, IMHO, you should split this patch into three or more smaller patches. You're doing lots of different things in one commit and it'll be a pain to bisect should this cause any issues to anyone. I didn't split the patch because it is virtually a complete rewrite. Due to the severe

RE: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness

2011-11-07 Thread Voss, Nikolaus
IMHO, you should split this patch into three or more smaller patches. You're doing lots of different things in one commit and it'll be a pain to bisect should this cause any issues to anyone. I didn't split the patch because it is virtually a complete rewrite. Due to the severe

Re: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness

2011-11-07 Thread Jean Delvare
On Mon, 7 Nov 2011 12:06:52 +0100, Voss, Nikolaus wrote: IMHO, you should split this patch into three or more smaller patches. You're doing lots of different things in one commit and it'll be a pain to bisect should this cause any issues to anyone. I didn't split the patch

Re: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness

2011-11-07 Thread Nicolas Ferre
On 11/07/2011 01:04 PM, Jean Delvare : On Mon, 7 Nov 2011 12:06:52 +0100, Voss, Nikolaus wrote: IMHO, you should split this patch into three or more smaller patches. You're doing lots of different things in one commit and it'll be a pain to bisect should this cause any issues to anyone. I

Re: 10-bit address support in i2c-omap and i2c-davinci

2011-11-07 Thread Kevin Hilman
Adding linux-omap and linux-davinci lists Jean Delvare kh...@linux-fr.org writes: Both bus drivers i2c-omap and i2c-davinci apparently handle 10-bit addresses: (i2c-omap.c) if (msg-flags I2C_M_TEN) w |= OMAP_I2C_CON_XA; (i2c-davinci.c) /* if the slave address

Re: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness

2011-11-07 Thread Hubert Feurstein
Hi, sorry, but your patch still does not apply. You fixed the tab issue, but it seems that there are still some bad whitespaces left which corrupt your patch. Regards Hubert -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to

Re: 10-bit address support in i2c-omap and i2c-davinci

2011-11-07 Thread Jean Delvare
On Mon, 07 Nov 2011 07:09:38 -0800, Kevin Hilman wrote: Adding linux-omap and linux-davinci lists Good point, sorry for missing that. Maybe the following would help? List i2c-omap and i2c-davinci in MAINTAINERS. Signed-off-by: Jean Delvare kh...@linux-fr.org --- MAINTAINERS |3 +++ 1 file

[PATCH] omap4: i2c: add post idle reset registers flag

2011-11-07 Thread David Anders
omap44xx i2c devices need to have the registers reset post idle similar to omap3xxx devices. this adds the additional flag for OMAP_I2C_FLAG_RESET_REGS_POSTIDLE to the omap44xx i2c_dev_attr. Signed-off-by: David Anders x0132...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |3 ++- 1

Re: [PATCH] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

2011-11-07 Thread Barry Song
2011/11/2 Russell King - ARM Linux li...@arm.linux.org.uk: On Wed, Nov 02, 2011 at 10:39:04AM +, Jamie Iles wrote: +   clk = clk_get(pdev-dev, NULL); +   if (IS_ERR(clk)) { +           err = PTR_ERR(clk); +           dev_err(pdev-dev, Clock get failed\n); +           goto out; +  

[PATCH v2] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

2011-11-07 Thread Barry Song
From: Zhiwu Song zhiwu.s...@csr.com SiRFprimaII is the latest generation application processor from CSR’s multi-function SoC product family. The SoC support codes are in arch/arm/mach-prima2 from Linux mainline 3.0. There are two I2C controllers on primaII, features include: ■ Two I2C controller

Re: MCP4728 address change

2011-11-07 Thread Jean Delvare
Hi Wayne, On Mon, 7 Nov 2011 11:25:42 +, Wayne Tams wrote: I have been tasked with writing a driver for a Microchip Quad DAC with EEPROM memory, MCP4728 if you would like to look it up. This device has a feature that I have not come across before, the device's I2C address is set in