Re: [PATCH] i2c-davinci: Implement a bus recovery that actually works

2014-03-10 Thread Mike Looijmans
On 03/09/2014 09:28 PM, Wolfram Sang wrote: On Fri, Feb 28, 2014 at 11:32:05AM +0100, mike.looijm...@topic.nl wrote: From: Mike Looijmans milo-softw...@users.sourceforge.net Having a board where the I2C bus locks up occasionally made it clear that the bus recovery in the i2c-davinci driver

Re: [PATCH] i2c-davinci: Implement a bus recovery that actually works

2014-03-10 Thread Wolfram Sang
I won't be doing those changes though. My sponsor's budget is limited, so I'm just having to do the minimum I can get away with. Pity. Are you available for testing in case someone comes up with a patch? signature.asc Description: Digital signature

Re: [PATCH V2] i2c: mxs: Use devm_ioremap_resource()

2014-03-10 Thread Wolfram Sang
On Mon, Mar 10, 2014 at 08:34:10AM +0900, Jingoo Han wrote: Use devm_ioremap_resource() in order to make the code simpler, and remove redundant return value check of platform_get_resource() because the value is checked by devm_ioremap_resource(). Signed-off-by: Jingoo Han jg1@samsung.com

Re: [RFC PATCH] i2c: new bus driver for efm32

2014-03-10 Thread Wolfram Sang
Hi Uwe, +#include linux/platform_data/efm32-i2c.h Shouldn't a new platform like efm32 be DT only? + +struct efm32_i2c_ddata { + struct i2c_adapter adapter; + spinlock_t lock; No need, see later. + struct clk *clk; + void __iomem *base; + unsigned int irq; +

[PATCH] i2c: bfin: turn to Resource-managed API in probe function

2014-03-10 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com No need to free managed resources any more. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- drivers/i2c/busses/i2c-bfin-twi.c | 40 +-- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git

RE: [PATCH 1/2] i2c: designware-pci: add 10-bit addressing mode functionality for BYT I2C

2014-03-10 Thread Chew, Chiau Ee
-Original Message- From: Wolfram Sang [mailto:w...@the-dreams.de] Sent: Sunday, March 09, 2014 4:54 PM To: Chew, Chiau Ee Cc: Mika Westerberg; linux-i2c@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH 1/2] i2c: designware-pci: add 10-bit addressing mode

Re: [PATCH] i2c-davinci: Implement a bus recovery that actually works

2014-03-10 Thread Mike Looijmans
On 03/10/2014 08:26 AM, Wolfram Sang wrote: I won't be doing those changes though. My sponsor's budget is limited, so I'm just having to do the minimum I can get away with. Pity. Are you available for testing in case someone comes up with a patch? Not really, the customer is using a

Re: [PATCH] i2c-davinci: Handle signals gracefully

2014-03-10 Thread Mike Looijmans
On 03/09/2014 09:21 PM, Wolfram Sang wrote: On Thu, Jan 09, 2014 at 12:11:25PM +0100, Mike Looijmans wrote: When a signal is caught while the i2c-davinci bus driver is transferring, the drive just abandons the transfer and leaves the controller to fend for itself. The next I2C transaction will

Re: [PATCH] i2c: mv64xxx: Fix compilation breakage

2014-03-10 Thread Maxime Ripard
On Fri, Mar 07, 2014 at 04:08:36PM +, Russell King - ARM Linux wrote: On Fri, Mar 07, 2014 at 03:59:30PM +0100, Maxime Ripard wrote: @@ -900,7 +902,8 @@ mv64xxx_i2c_probe(struct platform_device *pd) exit_free_irq: free_irq(drv_data-irq, drv_data); exit_reset: - if

[PATCH] i2c-cadence: Do not let signals interrupt I2C transfers

2014-03-10 Thread Mike Looijmans
Pressing CTRL-C while communicating with an I2C device leads to erratic behaviour. The cause is that the controller will interrupt the I2C transfer in progress, and leave the client device in an undefined state. Many drivers do not handle error return codes on I2C transfers. The calling driver has

Re: [PATCH] i2c: mv64xxx: Fix compilation breakage

2014-03-10 Thread Russell King - ARM Linux
On Mon, Mar 10, 2014 at 11:58:08AM +0100, Maxime Ripard wrote: On Fri, Mar 07, 2014 at 04:08:36PM +, Russell King - ARM Linux wrote: On Fri, Mar 07, 2014 at 03:59:30PM +0100, Maxime Ripard wrote: @@ -900,7 +902,8 @@ mv64xxx_i2c_probe(struct platform_device *pd) exit_free_irq:

Re: [PATCH 2/2] i2c: designware-pci: set ideal HCNT, LCNT and SDA hold time value

2014-03-10 Thread Wolfram Sang
On Mon, Mar 10, 2014 at 11:34:49AM +, Chew, Chiau Ee wrote: -Original Message- From: Wolfram Sang [mailto:w...@the-dreams.de] Sent: Sunday, March 09, 2014 5:04 PM To: Chew, Chiau Ee Cc: Mika Westerberg; linux-i2c@vger.kernel.org; linux-ker...@vger.kernel.org Subject:

Re: [PATCH 1/2] i2c: designware-pci: add 10-bit addressing mode functionality for BYT I2C

2014-03-10 Thread Wolfram Sang
+#define DW_DEFAULT_FUNCTIONALITY (I2C_FUNC_I2C | \ + I2C_FUNC_SMBUS_BYTE | \ + I2C_FUNC_SMBUS_BYTE_DATA | \ + I2C_FUNC_SMBUS_WORD_DATA | \ +

Re: [PATCH 2/2] i2c: designware-pci: set ideal HCNT, LCNT and SDA hold time value

2014-03-10 Thread Wolfram Sang
On Fri, Mar 07, 2014 at 10:12:51PM +0800, Chew Chiau Ee wrote: From: Chew, Chiau Ee chiau.ee.c...@intel.com On Intel BayTrail, there was case whereby the resulting fast mode bus speed becomes slower (~20% slower compared to expected speed) if using the HCNT/LCNT calculated in the core layer.

Re: [PATCH] i2c-davinci: Handle signals gracefully

2014-03-10 Thread Wolfram Sang
Even more, you should complete the whole transfer. There are devices where things can really go wrong if you send a half-complete command and then start with the next one. So, not checking signals at all is the way to go for I2C drivers. There is some cruft left, so I am happy about

Re: [PATCH 1/1] i2c: s3c2410: Trivial cleanup in header file

2014-03-10 Thread Sachin Kamat
On 14 February 2014 12:01, Sachin Kamat sachin.ka...@linaro.org wrote: Commit 436d42c61c3e (ARM: samsung: move platform_data definitions) moved the files to the current location but forgot to remove the pointer to its previous location. Clean it up. While at it also change the header file

Re: [PATCH 0/5] mv64xxx updates

2014-03-10 Thread Wolfram Sang
I will test it tomorrow and let you know if it fixed the bug. I will also take time to review the RFC patches. I applied the other three patches now. signature.asc Description: Digital signature

Re: [PATCH v2] i2c:at91: Add device tree property to set clock-frequency

2014-03-10 Thread Wolfram Sang
@@ -711,6 +711,7 @@ static int at91_twi_probe(struct platform_device *pdev) struct resource *mem; int rc; u32 phy_addr; + int bus_clk_rate; dev = devm_kzalloc(pdev-dev, sizeof(*dev), GFP_KERNEL); if (!dev) @@ -756,7 +757,12 @@ static int

Re: [PATCH 1/1] i2c: s3c2410: Trivial cleanup in header file

2014-03-10 Thread Wolfram Sang
On Fri, Feb 14, 2014 at 12:01:30PM +0530, Sachin Kamat wrote: Commit 436d42c61c3e (ARM: samsung: move platform_data definitions) moved the files to the current location but forgot to remove the pointer to its previous location. Clean it up. While at it also change the header file protection

Re: [PATCH] drivers: i2c: i2c-st: Fix return in case of arbitration lost

2014-03-10 Thread Wolfram Sang
On Fri, Feb 28, 2014 at 01:52:56PM +0100, Maxime COQUELIN wrote: This patch fixes the error returned to the i2c_transfer function to -EAGAIN in case of arbitratin lost, so that the retry mechanism can be used. Signed-off-by: Maxime Coquelin maxime.coque...@st.com Applied to for-next,

Re: [PATCH] i2c-cadence: Do not let signals interrupt I2C transfers

2014-03-10 Thread Sören Brinkmann
Hi Mike, The cadence driver is not in mainline yet. I think for our vendor tree we can pretty much take it this way. Regarding getting this into mainline, I'll send another iteration of the change set and include these changes. On Mon, 2014-03-10 at 12:12PM +0100, Mike Looijmans wrote: Pressing

[PATCH 2/2] i2c: exynos5: remove unnecessary cast of void pointer

2014-03-10 Thread Jingoo Han
Remove unnecessary cast of void pointer, because 'algo_data' of 'struct i2c_adapter' is a void pointer. Casting the void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language. Signed-off-by: Jingoo Han jg1@samsung.com ---

[PATCHv2 RESEND] i2c: designware-pci: set ideal HCNT, LCNT and SDA hold time value

2014-03-10 Thread Chew Chiau Ee
From: Chew, Chiau Ee chiau.ee.c...@intel.com On Intel BayTrail, there was case whereby the resulting fast mode bus speed becomes slower (~20% slower compared to expected speed) if using the HCNT/LCNT calculated in the core layer. Thus, this patch is added to allow pci glue layer to pass in

[PATCH v3] i2c:at91: Add device tree property to set clock-frequency

2014-03-10 Thread Marek Roszko
This adds the ability to set clock-frequency in the device tree for the at91 i2cbus following the naming of other i2c bus implementations. If the property is not set,the clock frequency will default to the previously used define of 100KHz. Signed-off-by: Marek Roszko mark.ros...@gmail.com ---

RE: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-10 Thread Yao Yuan
On Thu, Mar 10, 2014 at 10:01:42 AM, Marek Vasut wrote: On Thu, Mar 06, 2014 at 12:57:42PM +0100, Marek Vasut wrote: On Thursday, March 06, 2014 at 06:02:03 AM, Yao Yuan wrote: On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan