Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-20 Thread Uwe Kleine-König
Moin Wolfram, On Fri, Mar 20, 2015 at 08:15:04AM +0100, Wolfram Sang wrote: On Thu, Mar 19, 2015 at 09:17:51PM +0100, Uwe Kleine-König wrote: Hello Wolfram, On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com After

Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-20 Thread Uwe Kleine-König
On Fri, Mar 20, 2015 at 08:31:35AM +0100, Wolfram Sang wrote: After more discussion, brave users, and additional datasheet evaluation, some API updates for the new I2C slave framework became imminent. The slave events now get some easier to understand naming. Also, the event

Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-20 Thread Wolfram Sang
After more discussion, brave users, and additional datasheet evaluation, some API updates for the new I2C slave framework became imminent. The slave events now get some easier to understand naming. Also, the event handling has been simplified to only send one event per interrupt.

Re: [PATCH 2/3] Documentation: i2c: describe the new slave mode

2015-03-20 Thread Uwe Kleine-König
Hello Wolfram, On Fri, Mar 20, 2015 at 08:30:13AM +0100, Wolfram Sang wrote: +Finally, Linux can also be an I2C slave in case I2C controllers have slave +support. Besides this HW requirement, one also needs a software backend I wouldn't have written Finally, While it's great

Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-20 Thread Wolfram Sang
On Thu, Mar 19, 2015 at 09:17:51PM +0100, Uwe Kleine-König wrote: Hello Wolfram, On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com After more discussion, brave users, and additional datasheet evaluation, some API updates

Re: [PATCH 2/3] Documentation: i2c: describe the new slave mode

2015-03-20 Thread Wolfram Sang
+Finally, Linux can also be an I2C slave in case I2C controllers have slave +support. Besides this HW requirement, one also needs a software backend I wouldn't have written Finally, While it's great that we have slave support now, being enthusiastic here looks strange if someone reads

Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-20 Thread Wolfram Sang
On Fri, Mar 20, 2015 at 08:44:47AM +0100, Uwe Kleine-König wrote: On Fri, Mar 20, 2015 at 08:31:35AM +0100, Wolfram Sang wrote: After more discussion, brave users, and additional datasheet evaluation, some API updates for the new I2C slave framework became imminent.

Re: [PATCH 2/3] Documentation: i2c: describe the new slave mode

2015-03-20 Thread Wolfram Sang
On Fri, Mar 20, 2015 at 08:42:14AM +0100, Uwe Kleine-König wrote: Hello Wolfram, On Fri, Mar 20, 2015 at 08:30:13AM +0100, Wolfram Sang wrote: +Finally, Linux can also be an I2C slave in case I2C controllers have slave +support. Besides this HW requirement, one also needs a

Re: [PATCH v3 1/4] i2c: mux-pinctrl: Rework to honor disabled child nodes

2015-03-20 Thread Wolfram Sang
Ok, I see what you mean. I had a look at the place in question and wonder what to return from i2c_add_mux_adapter() in the disabled case so that i2c-mux-pinctrl is still happy with the returned value. Ouch, you are right. The crux of interfaces returning NULL instead of an ERR_PTR :( I'll

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-03-20 Thread grygorii.stras...@linaro.org
Hi, On 03/18/2015 10:31 PM, Wolfram Sang wrote: Hi, so, the bus recovery patches look fine to me in general. It is only this one question left which I always had with bus recovery. Maybe you guys can join me thinking about it. Ok. Thanks and sorry for delayed reply - missed your e-mail :(