Hi Wolfram,
Thank you for the patches.
For the whole series,
Tested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
On Thursday 19 November 2015 16:56:40 Wolfram Sang wrote:
> Hello RCar Fans!
>
> So, here is V3 of this series. After a debugging session with Lauren
1 chip has more flexible configuration, so using either IIC or
> I2C should be possible. You can sample those pins on EXIO_A with the
> ZEBAX break out adapter.
>
> And either way you should be able to compare the results of the I2C
> and IIC masters with GPIO using the bitbang impl
; - if (i == num - 1)
> - rcar_i2c_flags_set(priv, ID_LAST_MSG);
> + priv->msg = [i];
> + priv->msgs_left = num - i;
>
> rcar_i2c_prepare_msg(priv);
--
Regards,
Laurent Pinchart
[0.00] Booting Linu
g multimedia development on Koelsch. I'll check whether I
can continue that on Lager. In the meantime I could also capture I2C traces
using a scope and send them to you.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of
Hi Geert,
On Friday 30 October 2015 09:16:40 Geert Uytterhoeven wrote:
> On Fri, Oct 30, 2015 at 5:35 AM, Laurent Pinchart wrote:
> > [9.641533] Unable to handle kernel paging request at virtual address
> >
> > [9.648927] pgd = eb2adf40
> > [
}
>
> dev_info(dev, "probed\n");
>
> return 0;
> +
> + out_pm_disable:
> + pm_runtime_disable(dev);
> + return ret;
> }
>
> static int rcar_i2c_remove(struct platform_device *pdev)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
en reverting this patch :-/
> Could it be another I2C device interfering?
I wouldn't rule anything out, but I don't see why reverting this patch would
help then.
> Do you happen to know if you have an earlier revision of Koelsch?
RTPORC7791SEB00010S
KOELSCH SN.057
I'm not sure if that tel
ager dts to use i2c-rcar
> (instead of i2c-sh_mobile).
>
> Can you enable CONFIG_I2C_DEBUG_CORE in the config, apply this patch,
> and send me the trace output and bootlog?
Please find both attached to this e-mail.
--
Regards,
Laurent Pinchart
[0.00] Booting Linux
Hi Wolfram,
On Thursday 22 October 2015 13:05:05 Wolfram Sang wrote:
> On Thu, Oct 22, 2015 at 02:10:52AM +0300, Laurent Pinchart wrote:
> > On Thursday 03 September 2015 22:20:09 Wolfram Sang wrote:
> > > From: Wolfram Sang <wsa+rene...@sang-engineering.com>
> > &g
gs_has(priv, ID_DONE),
> + num * adap->timeout);
> + if (!time_left) {
> + rcar_i2c_init(priv);
> + ret = -ETIMEDOUT;
> + } else if (rcar_i2c_flags_has(priv, ID_NACK)) {
> + ret = -ENXIO;
> + } else if (rcar_i2c_flags_has(priv, ID_ARBLOST)) {
> + ret = -EAGAIN;
> + } else {
> + ret = num - priv->msgs_left; /* The number of transfer */
> }
> out:
> pm_runtime_put(dev);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
so, the repeated start handling needs to be rewritten and I
> am not sure this goes well with polling.
I meant without polling. Does the hardware design prevent from using I2C in
interrupt mode in a race-free way ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
i2c: rcar: check master irqs before slave irqs
> i2c: rcar: revoke START request early
> i2c: rcar: clean up after refactoring
>
> drivers/i2c/busses/i2c-rcar.c | 193 +++
> 1 file changed, 71 insertions(+), 122 deletions(-)
--
Regards,
I2C_RCAR_GEN2 here ? You can
always add I2C_RCAR_GEN3 later if you find differences.
{},
};
MODULE_DEVICE_TABLE(of, rcar_i2c_dt_ids);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More
On Thursday 06 August 2015 02:38:49 Wolfram Sang wrote:
On Thu, Aug 06, 2015 at 03:34:05AM +0300, Laurent Pinchart wrote:
Hi Wolfram,
Thank you for the patch.
On Wednesday 05 August 2015 15:18:25 Wolfram Sang wrote:
From: Wolfram Sang wsa+rene...@sang-engineering.com
Enable
+ reg = 0xc042;
The node name doesn't match the reg property anymore. Isn't that considered as
a problem ?
+ };
};
/* Expansion GEN2_I2C_* */
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body
.
With that change,
Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
to the
right documentation ?
PCLK is the APB clock. See R19UH0037EJ1200_SMU.pdf, chapter 4.13.
Is that the functional clock, while SCLK is the clock used to control serial
communication ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body
= 0 32 IRQ_TYPE_EDGE_RISING;
+ clocks = iic0_sclk;
+ clock-names = sclk;
+ };
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
);
+MODULE_DEVICE_TABLE(of, em_i2c_ids);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
you briefly explain what the two clocks are for ? Or point me to the
right documentation ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
drivers/i2c/busses/i2c-rcar.c | 5 +++--
drivers/i2c/busses/i2c-sh_mobile.c | 9 +
2 files changed, 8 insertions(+), 6 deletions(-)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux
alexander.sverd...@nokia.com
Tested-by: Łukasz Gemborowski lukasz.gemborow...@nokia.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/muxes/i2c-mux-pca9541.c |4 ++--
drivers/i2c/muxes/i2c-mux-pca954x.c |2 +-
2 files changed, 3 insertions(+), 3 deletions
, this board did not
need the workaround at all, only some revisions of the r8a7740 are
affected.
After a short discussion with Simon, we agreed this should go via I2C.
Looks good to me.
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Wolfram Sang (2):
i2c: sh_mobile: add
the
patch in question around rc4/rc5. I'd still like to know if the
non-disposing of the mapping in platform_get_irq() is intentional.
I'll defer that to Rob. I'm fine with the revert at the moment.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux
Hi Uwe,
On Thursday 05 March 2015 09:53:53 Uwe Kleine-König wrote:
On Wed, Mar 04, 2015 at 04:44:28PM +0200, Laurent Pinchart wrote:
If a reset GPIO is specified but not available we must defer probing, as
the device could be held in reset. Use devm_gpiod_request_optional() to
handle
?).
Ouch, my bad.
Wolfram, any opinion ? The original patch fixes a real bug, so we shouldn't
just revert it.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
(CC'ing Dmitry)
On Monday 02 March 2015 07:40:49 Wolfram Sang wrote:
On Thu, Feb 26, 2015 at 04:27:49PM +0200, Laurent Pinchart wrote:
On Monday 26 January 2015 13:09:47 Wolfram Sang wrote:
If you drop adi,adxl346, checkpatch will start complaining if it
encounters it in a .dts.
Boah
to this patch ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c
b/drivers/i2c/muxes/i2c-mux-pca954x.c index ec11b404b433..0042cf3d77db
100644
-by: Wolfram Sang wsa+rene...@sang-engineering.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/i2c-slave-eeprom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c
index
an OF
match table to the adxl34x driver.
Laurent Pinchart (2):
DT: i2c: Deprecate adi,adxl34x compatible string
input: adxl34x: Add OF match support
.../devicetree/bindings/i2c/trivial-devices.txt | 3 +--
drivers/input/misc/adxl34x-i2c.c| 21 +
2
, but it could be a preliminary patch on top of which to add idle-
disconnect DT support :-)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
DT nodes should use the more specific adi,adxl345 and adi,adxl346
compatible values instead. As the ADXL346 is backward-compatible with
the ADXL345, ADXL346 nodes must list both adi,adxl346 and adi,adxl345,
in that order.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
detection of the device model.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/input/misc/adxl34x-i2c.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/input/misc/adxl34x-i2c.c b/drivers/input/misc/adxl34x-i2c.c
index
that list the adi,adxl34x compatible value in positions other than
the first.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
need to differentiate between the devices based on the
compatible string (as runtime model detection is possible) we don't need to
add a match entry for adi,adxl346.
Why did we discuss then? Now, I am confused as well...
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send
On Thursday 15 January 2015 13:06:32 Dmitry Torokhov wrote:
On Thu, Jan 15, 2015 at 10:34:29PM +0200, Laurent Pinchart wrote:
On Thursday 15 January 2015 21:00:37 Geert Uytterhoeven wrote:
On Thu, Jan 15, 2015 at 7:54 PM, Dmitry Torokhov wrote:
I still do not understand what we
Hi Dmitry,
On Thursday 15 January 2015 13:50:53 Dmitry Torokhov wrote:
On Thu, Jan 15, 2015 at 11:34:00PM +0200, Laurent Pinchart wrote:
On Thursday 15 January 2015 13:06:32 Dmitry Torokhov wrote:
On Thu, Jan 15, 2015 at 10:34:29PM +0200, Laurent Pinchart wrote:
On Thursday 15 January 2015
Hi Wolfram,
On Thursday 15 January 2015 13:53:22 Wolfram Sang wrote:
On Thu, Dec 18, 2014 at 02:49:28PM +0200, Laurent Pinchart wrote:
On Thursday 18 December 2014 09:21:51 Wolfram Sang wrote:
On Thu, Dec 18, 2014 at 04:15:23AM +0200, Laurent Pinchart wrote:
The I2C subsystem can match
On Thursday 15 January 2015 16:19:19 Laurent Pinchart wrote:
On Thursday 15 January 2015 13:53:22 Wolfram Sang wrote:
On Thu, Dec 18, 2014 at 02:49:28PM +0200, Laurent Pinchart wrote:
On Thursday 18 December 2014 09:21:51 Wolfram Sang wrote:
On Thu, Dec 18, 2014 at 04:15:23AM +0200, Laurent
in
DT for 346 devices, as they're compatible with the 345.
I agree.
2) also add 34x as a compatible but mark it as deprecateed
3) delete 34x from trivial devices
OK.
Yay :)
I'll submit patches very soon.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send
Hi Geert,
On Thursday 18 December 2014 21:23:46 Laurent Pinchart wrote:
On Thursday 18 December 2014 14:03:18 Geert Uytterhoeven wrote:
On Thu, Dec 18, 2014 at 1:49 PM, Laurent Pinchart wrote:
There are three compatible strings defined for the ADXL345 and ADXL346
in Documentation
dev_dbg(dev, request_channel failed for %s (%d)\n, chan_name,
PTR_ERR(chan));
but that's up to you.
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
return chan;
}
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list
Hi Wolfram,
On Thursday 18 December 2014 09:21:51 Wolfram Sang wrote:
On Thu, Dec 18, 2014 at 04:15:23AM +0200, Laurent Pinchart wrote:
The I2C subsystem can match devices without explicit OF support based on
the part of their compatible property after the comma. However, this
mechanism
Hi Geert,
On Thursday 18 December 2014 14:03:18 Geert Uytterhoeven wrote:
On Thu, Dec 18, 2014 at 1:49 PM, Laurent Pinchart wrote:
There are three compatible strings defined for the ADXL345 and ADXL346 in
Documentation/devicetree/bindings/i2c/trivial-devices.txt: adi,adxl345,
adi,adxl346
value first and the adi,adxl34x
fallback value second. This prevents the device node from being matched
with the adxl34x driver.
Fix this by adding an OF match table with an adi,adxl34x compatible
entry.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/input
Hi Alexander,
On Tuesday 16 December 2014 09:09:22 Alexander Sverdlin wrote:
Hello Laurent,
On 15/12/14 09:40, ext Laurent Pinchart wrote:
of: i2c: Add DT bindings for idle states to PCA954x mux driver
Introduce two new device tree bindings to specify idle state of PCA954x
family
Hi Alexander,
On Tuesday 16 December 2014 13:49:13 Alexander Sverdlin wrote:
On 16/12/14 12:07, ext Laurent Pinchart wrote:
of: i2c: Add DT bindings for idle states to PCA954x mux driver
Introduce two new device tree bindings to specify idle state of PCA954x
family of I2C
pca954x_select_chan(to_i2c_adapter(client-dev.parent),
+client, data-idle_chan);
+ else
+ return i2c_smbus_write_byte(client, 0);
}
#endif
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
.
I hope this explains the problem well.
Yes and it has nothing to do with channels being exhausted, the problem I
assumed earlier!!
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More
Hi Wolfram,
On Wednesday 10 December 2014 15:23:15 Wolfram Sang wrote:
On Wed, Dec 10, 2014 at 04:19:36PM +0200, Laurent Pinchart wrote:
(CC'ing the dmaengine mailing list)
Thanks!
On Wednesday 10 December 2014 09:01:55 Wolfram Sang wrote:
On Wed, Dec 10, 2014 at 02:44:01PM +0900
the chance of deferred probe is a good idea in my opinion
:-)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is unavailable I
currently don't see another way than moving the channel request at the time of
the transfer.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Uytterhoeven geert+rene...@glider.be
Just for the record, even if it's too late,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/i2c-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index
| 203 --
4 files changed, 203 insertions(+), 19 deletions(-)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Hi Wolfram,
Thank you for the patch.
On Friday 31 October 2014 11:51:17 Wolfram Sang wrote:
From: Wolfram Sang wsa+rene...@sang-engineering.com
Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
arch/arm/boot/dts
Hi Wolfram,
Thank you for the patch.
On Friday 31 October 2014 11:51:18 Wolfram Sang wrote:
From: Wolfram Sang wsa+rene...@sang-engineering.com
Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
arch/arm/boot/dts
Controller driver);
MODULE_AUTHOR(Magnus Damm);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ezequiel,
On Thursday 30 October 2014 08:58:28 Ezequiel Garcia wrote:
On 10/25/2014 07:13 PM, Laurent Pinchart wrote:
Hello,
I recently ran into an issue with the OF IRQ parsing code in the I2C core
(of_i2c_register_devices in drivers/i2c/i2c-core.c).
My DT contains
to the queue. Maybe he can bring some light to what
happened to his series.
That's exactly what I need :-) Thierry, do you plan to respin the series ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord
i2c_get_irq() function
though. Wolfram, would you be fine with that ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Thierry,
On Thursday 30 October 2014 14:02:09 Thierry Reding wrote:
On Thu, Oct 30, 2014 at 02:53:42PM +0200, Laurent Pinchart wrote:
On Monday 27 October 2014 13:58:19 Wolfram Sang wrote:
The i2c@e652 node is probed before the gpio@e6051000 node. The
of_i2c_register_devices
, would you be fine with that ?
I'd think it will look pretty similar to platform_get_irq, no? That is
fine with me.
It would, but as Thierry pointed out it should be possible to hide the details
in the I2C core. I'll submit a patch shortly.
--
Regards,
Laurent Pinchart
--
To unsubscribe from
The function will be used by the I2C core which can be compiled as a
module.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/of/irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 1471e0a223a5..0d7765807f49
() but additionally returns
-EPROBE_DEFER if the irqchip isn't available, allowing us to defer I2C
client probing.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/i2c/i2c-core.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c
Clients instantiated from OF get an IRQ mapping created at device
registration time. Dispose the mapping when the client is removed.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/i2c/i2c-core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
client-irq set to 0.
As we can't control the probe order in the general case we need to rely on
deferred probing. This patch series is an attempt to do so, by moving IRQ
mapping from device registration time to device probe time were probing can be
deferred.
Laurent Pinchart (3):
of/irq: Export
On Thursday 30 October 2014 15:16:44 Wolfram Sang wrote:
On Thu, Oct 30, 2014 at 03:59:36PM +0200, Laurent Pinchart wrote:
The function will be used by the I2C core which can be compiled as a
module.
Signed-off-by: Laurent Pinchart
laurent.pinchart+rene...@ideasonboard.com
I think
Hi Jean-Michel,
On Thursday 23 October 2014 07:59:53 Jean-Michel Hautbois wrote:
2014-10-23 1:37 GMT+02:00 Laurent Pinchart:
On Wednesday 22 October 2014 17:30:47 Jean-Michel Hautbois wrote:
Some I2C devices have multiple addresses assigned, for example each
address corresponding
,
+ const char *name,
+ u16 default_addr);
+
extern void i2c_unregister_device(struct i2c_client *);
#endif /* I2C */
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord
to create i2c client %u\n, i);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
+ adv7604_dummy_client(sd, i);
if (state-i2c_clients[i] == NULL) {
err = -ENOMEM;
v4l2_err(sd, failed to create i2c client %u\n, i);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line
by putting the mux to disconnected state and
clearing last_chan in the resume hook.
Signed-off-by: Jisheng Zhang jszh...@marvell.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 15 +++
1 file changed, 15 insertions
as errors
make[3]: *** [drivers/i2c/muxes/i2c-mux-pca954x.o] Error 1
I've sent a patch for this to Wolfram and the i2c discuss list.
https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-nextid=642653d16a0f8e78b7a25d930b62aa771ebc939c
--
Regards,
Laurent Pinchart
usable without GPIOLIB support.
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig
index f7f9865b
Hi Arnd,
On Thursday 05 June 2014 13:24:16 Arnd Bergmann wrote:
On Thursday 05 June 2014 12:56:08 Laurent Pinchart wrote:
On Thursday 05 June 2014 12:44:47 Arnd Bergmann wrote:
commit 4807e8459bce (i2c: mux: pca954x: Use the descriptor-based GPIO
API) moved this driver over to the gpio
Fix it by including the right header.
Reported-by: Jim Davis jim.ep...@gmail.com
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c
b
Hi Alexandre,
On Tuesday 03 June 2014 10:38:53 Alexandre Courbot wrote:
On 06/03/2014 09:22 AM, Laurent Pinchart wrote:
The DT bindings for the pca954x document that the reset GPIO is
specified through the reset-gpios property. However, the driver
erroneously uses a property name of reset
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c
b/drivers/i2c/muxes/i2c-mux-pca954x.c
index 550bd36..c2c443f 100644
Hi Jingoo,
Thank you for the patch.
On Wednesday 07 May 2014 13:27:22 Jingoo Han wrote:
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
Acked-by: Laurent Pinchart laurent.pinch
to the platform data adap_id field defined in the pca954x
DT bindings.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
haven't explain *why*
you need to have fixed bus numbers. Why do you need to know the bus number at
all ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
to comment on whether bus numbering has ever been considered
to be a kernel ABI, other people should be able to comment on that. Any chance
to fix the application to find the bus numbers dynamically ?
On Thu, Apr 17, 2014 at 4:15 PM, Laurent Pinchart wrote:
On Thursday 17 April 2014 13:54:44 Frank
is
instantiated in board code with i2c_board_info then there will be no DT node
corresponding to the device (client-dev.of_node will be NULL). If the device
is instead instantiated from DT there will be no platform data (client-
dev.platform_data will be NULL).
On 20/03/14 01:51 PM, Laurent Pinchart
thus only accesses its
private pointer or copy.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
. This is why there is no DT
property similar to the platform data adap_id field defined in the pca954x DT
bindings.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hi Wolfram,
On Wednesday 11 December 2013 13:47:34 Laurent Pinchart wrote:
Hi Wolfram,
Could you please pick this patch up for v3.14 ?
Ping ?
On Thursday 28 November 2013 16:36:21 Simon Horman wrote:
On Wed, Nov 27, 2013 at 02:18:23AM +0100, Laurent Pinchart wrote:
Hardware supported
wasn't sure to like, but it will be reworked when making
clock speed computation dynamic anyway, so we can keep it as-is for now.
There is no standard behaviour (use sane default or fail) yet. It is
somewhere on the I2C todo list :/
--
Regards,
Laurent Pinchart
signature.asc
Description
-engineering.com);
+MODULE_LICENSE(GPL v2);
+MODULE_DEVICE_TABLE(of, riic_i2c_dt_ids);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
),
+ SH_PFC_FUNCTION(riic2),
+ SH_PFC_FUNCTION(riic3),
};
#define PFC_REG(idx, name, reg)
\
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More
;
+ status = disabled;
+ };
};
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
+ pagesize = 64;
+ };
+};
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Wolfram,
On Tuesday 17 December 2013 23:13:09 Wolfram Sang wrote:
On Tue, Dec 17, 2013 at 10:55:31PM +0100, Laurent Pinchart wrote:
On Tuesday 17 December 2013 22:44:36 Wolfram Sang wrote:
From: Wolfram Sang w...@sang-engineering.com
I decided to put the pinmuxing into the dtsi
Hi Wolfram,
Could you please pick this patch up for v3.14 ?
On Thursday 28 November 2013 16:36:21 Simon Horman wrote:
On Wed, Nov 27, 2013 at 02:18:23AM +0100, Laurent Pinchart wrote:
Hardware supported by the i2c sh_mobile and rcar drivers is only found
on SUPERH or ARCH_SHMOBILE platforms
This simplifies error and removal paths.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c
b/drivers/i2c/muxes/i2c
This helps avoiding duplicate includes.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c
b/drivers/i2c/muxes/i2c-mux-pca954x.c
Cc: devicet...@vger.kernel.org
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
.../devicetree/bindings/i2c/i2c-mux-pca954x.txt| 46 ++
1 file changed, 46 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
diff
Hello,
This patch set adds DT support for a reset GPIO to the pca954x I2C mux. It
starts by two cleanup patches for the driver, adds missing DT bindings
documentation and finally adds support for the reset GPIO.
Cc: devicet...@vger.kernel.org
Laurent Pinchart (4):
i2c: pca954x: Sort headers
Hardware supported by the i2c sh_mobile and rcar drivers is only found
on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST
compilation to them.
Cc: Wolfram Sang w...@the-dreams.de
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Hi Simon,
On Tuesday 29 October 2013 14:58:07 Simon Horman wrote:
On Tue, Oct 29, 2013 at 06:02:24AM +0100, Wolfram Sang wrote:
On Mon, Oct 28, 2013 at 11:49:23PM +0100, Laurent Pinchart wrote:
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare
1 - 100 of 121 matches
Mail list logo
