Re: [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-11-30 Thread Wolfram Sang
On Mon, Nov 30, 2015 at 02:51:41PM +0100, Wolfram Sang wrote: > On Sun, Sep 27, 2015 at 04:57:08PM +0200, Hans de Goede wrote: > > According to the datasheets to n factor for dividing the tclk is > > 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is > > on other mv64xxx implemen

Re: [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-11-30 Thread Wolfram Sang
On Sun, Sep 27, 2015 at 04:57:08PM +0200, Hans de Goede wrote: > According to the datasheets to n factor for dividing the tclk is > 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is > on other mv64xxx implementations. > > I've contacted Allwinner about this and they have confir

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-10-25 Thread Olliver Schinagl
Hey Wolfram, On 20-10-15 17:58, Wolfram Sang wrote: WIth Hans having figured it out and fixing it, I'll absolutly will take a nother look and check with a scope if it all works out now. Have you done this already? /me is always looking for Tested-by: tags :) And here you have it. Tested-by: O

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-10-20 Thread Olliver Schinagl
I shamefully admit I have not. My plate is very full at the moment, but I will make room for this upcoming weekend as I have a few other patches to test aswell. Sorry for the delay! On 20-10-15 18:58, Wolfram Sang wrote: WIth Hans having figured it out and fixing it, I'll absolutly will take a

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-10-20 Thread Wolfram Sang
> WIth Hans having figured it out and fixing it, I'll absolutly will take a > nother look and check with a scope if it all works out now. Have you done this already? /me is always looking for Tested-by: tags :) signature.asc Description: Digital signature

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-10-01 Thread Olliver Schinagl
Hey Maxime, On 29-09-15 14:09, Maxime Ripard wrote: On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote: Hey Hans, On 27-09-15 16:57, Hans de Goede wrote: According to the datasheets to n factor for dividing the tclk is 2 to the power n on Allwinner SoCs, not 2 to the power n + 1

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-09-29 Thread Maxime Ripard
On Sun, Sep 27, 2015 at 06:53:03PM +0200, Andrew Lunn wrote: > > >+ if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") || > > >+ of_device_is_compatible(np, "allwinner,sun6i-a31-i2c")) > > Rather than have to extend this list every so often, how about adding > a helper of_device_is_c

Re: [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-09-29 Thread Maxime Ripard
On Sun, Sep 27, 2015 at 04:57:08PM +0200, Hans de Goede wrote: > According to the datasheets to n factor for dividing the tclk is > 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is > on other mv64xxx implementations. > > I've contacted Allwinner about this and they have confir

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-09-29 Thread Maxime Ripard
On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote: > Hey Hans, > > On 27-09-15 16:57, Hans de Goede wrote: > >According to the datasheets to n factor for dividing the tclk is > >2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is > >on other mv64xxx implementations

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-09-29 Thread Hans de Goede
Hi, On 27-09-15 18:53, Andrew Lunn wrote: On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote: Hey Hans, On 27-09-15 16:57, Hans de Goede wrote: According to the datasheets to n factor for dividing the tclk is 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-09-27 Thread Peter Korsgaard
> "Hans" == Hans de Goede writes: > According to the datasheets to n factor for dividing the tclk is s/to/the/ -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-09-27 Thread Andrew Lunn
On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote: > Hey Hans, > > On 27-09-15 16:57, Hans de Goede wrote: > >According to the datasheets to n factor for dividing the tclk is > >2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is > >on other mv64xxx implementations

Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-09-27 Thread Olliver Schinagl
Hey Hans, On 27-09-15 16:57, Hans de Goede wrote: According to the datasheets to n factor for dividing the tclk is 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is on other mv64xxx implementations. Ah! I've contacted Allwinner about this and they have confirmed that the d

[PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2015-09-27 Thread Hans de Goede
According to the datasheets to n factor for dividing the tclk is 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is on other mv64xxx implementations. I've contacted Allwinner about this and they have confirmed that the datasheet is correct. This commit fixes the clk-divider cal