On Sun, Nov 18, 2012 at 06:25:08AM +0100, Marek Vasut wrote:
> There is no reason to disable the I2C SMBus quick mode on this
> IP block. Enable it. This essentially fixes the problem with the
> "i2c-detect" command for probing the bus.
>
> Signed-off-by: Marek Vasut
Applied to for-next, thanks!
Tim,
On Mon, Nov 19, 2012 at 1:05 PM, Tim Michals wrote:
> I tested both patches using Linux version 3.7.0-rc4 with the following
> command:
> # i2cdetect -r 0 20 30
> Usage: i2cdetect [-y] [-a] [-q|-r] I2CBUS [FIRST LAST]
>i2cdetect -F I2CBUS
>i2cdetect -l
> I2CBUS is an inte
Dear Tim Michals,
[...]
> > The register layout differs. You might want to check if all the register
> > programing is correct. Make sure the placement of various bits is
> > correct. Also
> > see how the DMA operates with the transfer length on MX23 and MX28 ...
> > there are
> > quite a few dif
Dear Tim Michals,
[...]
> > ~ # /i2cdetect.static -r 0 20 30
> > WARNING! This program can confuse your I2C bus, cause data loss and
> > worse! I will probe file /dev/i2c-0 using read byte commands.
> > I will probe address range 0x14-0x1e.
> > Continue? [Y/n]
> >
> > 0 1 2 3 4 5 6 7
Dear Tim Michals,
> Mr. Marek Vasut,
Ugh, I feel so old ;-D
[...]
> diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
> index 286ca19..0670da7 100644
> --- a/drivers/i2c/busses/i2c-mxs.c
> +++ b/drivers/i2c/busses/i2c-mxs.c
> @@ -287,12 +287,14 @@ read_init_dma_fail:
> s
There is no reason to disable the I2C SMBus quick mode on this
IP block. Enable it. This essentially fixes the problem with the
"i2c-detect" command for probing the bus.
Signed-off-by: Marek Vasut
Cc: Fabio Estevam
Cc: Tim Michals
Cc: Wolfram Sang
---
drivers/i2c/busses/i2c-mxs.c |2 +-
1
