Re: sata_promise: random/intermittent errors

2007-02-19 Thread Mikael Pettersson
On Mon, 19 Feb 2007 12:43:50 +0800, Marc Marais wrote: I've decided to post this to the linux-ide list to see if I can get to the bottom of this problem I'm experiencing with sata_promise and my PATA drives. I've pasted a thread from the linux-raid list where I was trying to

Re: 2.6.20-mm2

2007-02-19 Thread Rafael J. Wysocki
On Monday, 19 February 2007 01:00, Andrew Morton wrote: On Mon, 19 Feb 2007 00:25:48 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: netconsole is good. I know. :-) In the meantime, I've got something worse on another x86_64 box: Asus Laptop ACPI Extras version 0.30 L5D

Re: 2.6.20-mm2

2007-02-19 Thread Michal Piotrowski
On 19/02/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Monday, 19 February 2007 01:00, Andrew Morton wrote: On Mon, 19 Feb 2007 00:25:48 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: netconsole is good. I know. :-) In the meantime, I've got something worse on another x86_64

Re: [git patches] more IDE updates

2007-02-19 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Contains: IRQ-ack fix for ICH chipsets (Albert Lee), ide-floppy unformatted media fix (Alan Cox), more fixes for IDE PCI drivers (Sergei Shtylyov), new driver for Toshiba Cell Reference Board (Kou Ishizaki kou.ishizaki at toshiba.co.jp) and a bunch of

Re: [git patches] more IDE updates

2007-02-19 Thread Sergei Shtylyov
Hello. Sergei Shtylyov wrote: Contains: IRQ-ack fix for ICH chipsets (Albert Lee), ide-floppy unformatted media fix (Alan Cox), more fixes for IDE PCI drivers (Sergei Shtylyov), new driver for Toshiba Cell Reference Board (Kou Ishizaki kou.ishizaki at toshiba.co.jp) and a bunch of rather

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-19 Thread Alan
I fear that the hardest part is yet to come, when we integrate the driver for the the PS3 (currently called gelic_net) into spidernet. The trouble is that the hardware is sufficiently similar to share all the high-level mechanisms like the DMA data structures and descriptor chains, but the

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-19 Thread Benjamin Herrenschmidt
On Mon, 2007-02-19 at 21:56 +, Alan wrote: I fear that the hardest part is yet to come, when we integrate the driver for the the PS3 (currently called gelic_net) into spidernet. The trouble is that the hardware is sufficiently similar to share all the high-level mechanisms like the DMA

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-19 Thread Benjamin Herrenschmidt
On Mon, 2007-02-19 at 21:56 +, Alan wrote: I fear that the hardest part is yet to come, when we integrate the driver for the the PS3 (currently called gelic_net) into spidernet. The trouble is that the hardware is sufficiently similar to share all the high-level mechanisms like the DMA

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-19 Thread Alan
into one in drivers/ide but really want splitting for libata with some kind of libata-pmac owning the shared stuff You meand driver/ide/ppc/pmac.c ? Yes moving them out of the macio_asic to a PCI device at one point, so yes, maybe you are right, I should move the DMA bits to some common

Re: [PATCH] (pata-2.6 fix queue) cmd64x: interrupt status fixes (resend)

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Thursday 15 February 2007 14:53, Sergei Shtylyov wrote: The driver's ide_dma_test_irq() method was reading the MRDMODE register even on PCI0643/6 where it was write-only -- fix this by always reading the backward- compatible interrupt bits, renaming dma_alt_stat to irq_stat as these

Re: [PATCH] (pata-2.6 fix queue) cmd64x: add/fix enablebits

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 February 2007 23:35, Sergei Shtylyov wrote: The IDE core looks at the wrong bit when checking if the secondary channel is enabled on PCI0646 -- CFR bit 8 is read-ahead disable, bit 3 is the correct one. I guess that you meant CNTRL here? [ I corrected this in the applied

Re: [PATCH] (pata-2.6 fix queue) cmd64x: procfs code fixes/cleanups

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Thursday 15 February 2007 20:17, Sergei Shtylyov wrote: Fix several issues with the driver's procfs output: - when testing if channel is enabled, the code looks at the simplex bits, not at the real enable bits -- add #define for the primary channel enable bit; - UltraDMA modes 0,

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Tuesday 20 February 2007 00:46, Alan wrote: into one in drivers/ide but really want splitting for libata with some kind of libata-pmac owning the shared stuff You meand driver/ide/ppc/pmac.c ? Yes moving them out of the macio_asic to a PCI device at one point, so yes, maybe

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-19 Thread Benjamin Herrenschmidt
On Mon, 2007-02-19 at 23:46 +, Alan wrote: into one in drivers/ide but really want splitting for libata with some kind of libata-pmac owning the shared stuff You meand driver/ide/ppc/pmac.c ? Yes moving them out of the macio_asic to a PCI device at one point, so yes, maybe

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-19 Thread Benjamin Herrenschmidt
On Tue, 2007-02-20 at 00:17 +0100, Bartlomiej Zolnierkiewicz wrote: On Tuesday 20 February 2007 00:46, Alan wrote: into one in drivers/ide but really want splitting for libata with some kind of libata-pmac owning the shared stuff You meand driver/ide/ppc/pmac.c ? Yes

Re: libata FUA revisited

2007-02-19 Thread Robert Hancock
Jens Axboe wrote: But we can't really change that, since you need the cache flushed before issuing the FUA write. I've been advocating for an ordered bit for years, so that we could just do: 3. w/FUA+ORDERED normal operation - barrier issued - write barrier FUA+ORDERED - normal operation

Re: pata_amd dropping to PIO on resume

2007-02-19 Thread Alan
Deleting the ata_pci_clear_simplex() call, then adding ATA_FLAG_IGN_SIMPLEX to the ata_port_info info[] array, is also worth trying. I think I know what is going on here. Firstly the simplex bits need re-clearing on a resume. On my todo list now I'm back - To unsubscribe from this list: send

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-02-19 Thread Olaf Hering
On Sat, Feb 03, Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void +++ b/drivers/ide/ppc/pmac.c @@ -1984,10 +1984,8 @@ static void pmac_ide_dma_host_off(ide_dr { } -static int -pmac_ide_dma_host_on (ide_drive_t *drive) +static int

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Monday 19 February 2007 23:20, Olaf Hering wrote: On Sat, Feb 03, Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void +++ b/drivers/ide/ppc/pmac.c @@ -1984,10 +1984,8 @@ static void pmac_ide_dma_host_off(ide_dr { } -static int

Re: 2.6.20-mm2

2007-02-19 Thread Rafael J. Wysocki
On Monday, 19 February 2007 12:45, Michal Piotrowski wrote: On 19/02/07, Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Monday, 19 February 2007 01:00, Andrew Morton wrote: On Mon, 19 Feb 2007 00:25:48 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: netconsole is good. I

Re: 2.6.20-mm2

2007-02-19 Thread Rafael J. Wysocki
On Monday, 19 February 2007 01:00, Andrew Morton wrote: On Mon, 19 Feb 2007 00:25:48 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: netconsole is good. I know. :-) In the meantime, I've got something worse on another x86_64 box: Asus Laptop ACPI Extras version 0.30 L5D

[PATCH] sata_nv: delay on switching between NCQ and non-NCQ commands

2007-02-19 Thread Robert Hancock
This patch appears to solve some problems with commands timing out in cases where an NCQ command is immediately followed by a non-NCQ command (or possibly vice versa). This is a rather ugly solution, but until we know more about why this is needed, this is about all we can do. Signed-off-by:

[PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-02-19 Thread Robert Hancock
Here's a revised version of my previous patch to warn the user if a drive's transfer rate is limited because of a 40-wire cable detection. This one hopefully addresses Alan's previous comments - we now do this at the very end of the function, and the ugly if condition has been cleaned up

[PATCH 0/5] sata_nv: various cleanups and fixes

2007-02-19 Thread Robert Hancock
This patch series contains several fixes for issues I noticed while debugging some command timeout problems. None of these proved to be related to that issue, but they fall into the category of things we should be doing anyway. Split into separate patches to ease bisecting in case of issues.

[PATCH 2/5] sata_nv: cleanup CPB and APRD initialization

2007-02-19 Thread Robert Hancock
Clean up the initialization of the CPB and APRD structures so that we strictly follow the rules for ordering of writes to the CPB flags and response flags, and prevent duplicate initialization. Signed-off-by: Robert Hancock [EMAIL PROTECTED] --- linux-2.6.20-git6edit/drivers/ata/sata_nv.c

[PATCH 1/5] sata_nv: Add CPB register info to error_handler output

2007-02-19 Thread Robert Hancock
When error handling occurs with pending commands, output the contents of the next CPB count and next CPB index registers as well as the others, since these may be useful for debugging. Signed-off-by: Robert Hancock [EMAIL PROTECTED] --- linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-15

[PATCH 5/5] sata_nv: enable hotplug interrupt and fix some readl/readw mismatches

2007-02-19 Thread Robert Hancock
We already have code that handles hotplug interrupt indications in ADMA mode, this turns on the control flag that actually enables these interrupts. Also fixes some cases in the same functions where a 16-bit register was read using a readl instead of a readw. Signed-off-by: Robert Hancock [EMAIL

[PATCH 3/5] sata_nv: Cleanup taskfile setup

2007-02-19 Thread Robert Hancock
This edits the taskfile setup to more closely match the way that libata sends the taskfile for other controllers. This avoids putting taskfile writes into the CPB buffer that are not needed according to the taskfile flags. Signed-off-by: Robert Hancock [EMAIL PROTECTED] ---

[PATCH 4/5] sata_nv: Use notifier for completion checks

2007-02-19 Thread Robert Hancock
The hardware provides us a notifier register that indicates what command tags have completed. Use this to determine which CPBs to check, rather than blindly checking all active CPBs. This should provide a minor performance win, since if the controller has touched some of these incomplete CPBs,

Re: 2.6.20-mm2

2007-02-19 Thread Rafael J. Wysocki
On Sunday, 18 February 2007 20:43, Andrew Morton wrote: On Sun, 18 Feb 2007 13:44:54 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Sunday, 18 February 2007 06:51, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.20-mm2/ Will appear later

[PATCH RFC] libata: FUA updates

2007-02-19 Thread Robert Hancock
This updates libata FUA support to be more more in line with reality. FUA support remains off by default. Add a setting for the fua command-line parameter on libata which enables FUA only on NCQ-supporting disks. Update the ata_dev_supports_fua function to remove the blacklisting of Maxtor

Re: [PATCH] ide-cs: Update device table

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Sunday 18 February 2007 09:49, Magnus Damm wrote: ide-cs: Update device table Add CFA devices from I-O Data, Mitsubishi and Viking. Add SanDisk comment. Signed-off-by: Magnus Damm [EMAIL PROTECTED] applied, thanks - To unsubscribe from this list: send the line unsubscribe linux-ide in

Re: sata_promise: random/intermittent errors

2007-02-19 Thread Marc Marais
On Mon, 19 Feb 2007 11:26:24 +0100 (MET), Mikael Pettersson wrote On Mon, 19 Feb 2007 12:43:50 +0800, Marc Marais wrote: I've decided to post this to the linux-ide list to see if I can get to the bottom of this problem I'm experiencing with sata_promise and my PATA drives. I've pasted

Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

2007-02-19 Thread Tejun Heo
Rafael J. Wysocki wrote: Update: I get the same BUG with 2.6.20-git13 100% of the time during the resume. The system seems to be fully functional nonetheless. Known bug, will be fixed soon. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: 2.6.20-mm2

2007-02-19 Thread Andrew Morton
On Tue, 20 Feb 2007 02:20:21 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Sunday, 18 February 2007 20:43, Andrew Morton wrote: On Sun, 18 Feb 2007 13:44:54 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Sunday, 18 February 2007 06:51, Andrew Morton wrote: