Re: Early ATA devices

2007-08-01 Thread Tejun Heo
Alan Cox wrote: So I've been doing a scan of the code versus the early ATA specifications (English translation not the original Latin ;)) I've found a couple of problem cases we don't deal with but I'm not sure matter, and an inconsistency #1We assume identify works. Early ATA

Re: Boot fails on Intel SATA controller

2007-08-01 Thread Tejun Heo
Hello, Luiz Fernando N. Capitulino wrote: Hi there, A Mandriva user is reporting that his machine hangs while booting kernels 2.6.22.1 and 2.6.23-rc1. But boots fine with 2.6.21. Here is the 2.6.22 boot log: SCSI subsystem initialized Loading scsi_mod.ko module Loading

[PATCH UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-01 Thread Tejun Heo
From: Mark Lord [EMAIL PROTECTED] Add support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, atapi_scmd85=1 can be used to globally disable this feature, if ever desired. tj: renamed

Re: [patch 3/4] Enable link power management for ata drivers

2007-08-01 Thread Tejun Heo
Kristen Carlson Accardi wrote: libata drivers can define a function (enable_pm) that will perform hardware specific actions to enable whatever power management policy the user set up from the scsi sysfs interface if the driver supports it. This power management policy will be activated

Re: [patch 1/4] Store interrupt value

2007-08-01 Thread Tejun Heo
Kristen Carlson Accardi wrote: Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Acked-by: Tejun Heo [EMAIL PROTECTED] -- tejun -

ST340823A disk size issue

2007-08-01 Thread Mikko Rapeli
Hello, (More details at http://bugzilla.kernel.org/show_bug.cgi?id=8816 ) My home server disk doesn't work with latest kernels since its size is reported or probed correctly. With 2.6.22.1 I get: Probing IDE interface ide1... hdd: ST340823A, ATA DISK drive hdd: selected mode 0x42 ... hdd: max

Re: [patch 3/4] Enable link power management for ata drivers

2007-08-01 Thread edwintorok
On 8/1/07, Tejun Heo [EMAIL PROTECTED] wrote: + if (ata_id_has_hipm(dev-id) || ata_id_has_dipm(dev-id)) + dev-flags |= ATA_DFLAG_IPM; Is it safe to use ALPM on a device which only claims to support DIPM? I have tested on a Dell Inspiron 6400, it has ICH7-M (82801GBM) chipset.

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Tejun Heo
Tejun Heo wrote: Arjan van de Ven wrote: They were hardware problems. I don't think any amount of proper implementation can fix them. I have one DVD RAM somewhere in my pile of hardware which locks up solidly if any link PS mode is used and had a and the AHCI ALPM code decides to use power

Re: [PATCH 1/2] [IDE] Platform IDE driver

2007-08-01 Thread Sergei Shtylyov
Hello. Segher Boessenkool wrote: This doesn't mean that shift is better anyway. If everyone considers it better, I give up. But be warned that shift (stride) is not the only property characterizing register accesses -- the regs might be only accessible as 16/32-bit quantities, for

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-08-01 Thread Sergei Shtylyov
Hello. Segher Boessenkool wrote: +[EMAIL PROTECTED] { +compatible = mmio-ide; +device_type = ide; Why not ata? The hardware is called (E)IDE, the protocol is called ATA. Sorry for not denouncing this earlier. :-) ATA is the name of ANSI standard describing

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ... Signed-off-by: Alan Cox [EMAIL PROTECTED] --- drivers/ata/sata_mv.c~ 2007-07-09 13:19:57.003052904 +0100 +++ drivers/ata/sata_mv.c 2007-07-09 13:19:57.004052752 +0100

Re: Early ATA devices

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: #1 We assume identify works. Early ATA actually lists this command as optional ITYM we assume identify command exists on the device? We certainly do not assume IDENTIFY command, if exists, succeeds. What is the proper probing method -- notice if command-aborted is

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: I've had a Highpoint Rocket 1540 (not RocketRAID) SATA controller for a while now, using a proprietary binary driver from Highpoint in a linux 2.4 kernel. The chipset is an hpt374. The hpt366 driver freezes on boot, as reported by others. Can we

Re: ST340823A disk size issue

2007-08-01 Thread Alan Cox
On Wed, 1 Aug 2007 12:29:04 +0300 Mikko Rapeli [EMAIL PROTECTED] wrote: Hello, (More details at http://bugzilla.kernel.org/show_bug.cgi?id=8816 ) My home server disk doesn't work with latest kernels since its size is reported or probed correctly. With 2.6.22.1 I get: You've got an odd

Re: [PATCH UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-01 Thread Tejun Heo
Jeff Garzik wrote: Tejun Heo wrote: From: Mark Lord [EMAIL PROTECTED] Add support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, atapi_scmd85=1 can be used to globally disable this feature,

Re: Access beyond end of device

2007-08-01 Thread Luiz Fernando N. Capitulino
Em Wed, 1 Aug 2007 01:12:26 +0100 Alan Cox [EMAIL PROTECTED] escreveu: | On Tue, 31 Jul 2007 15:15:46 -0300 | Luiz Fernando N. Capitulino [EMAIL PROTECTED] wrote: | | Em Tue, 31 Jul 2007 15:04:14 -0300 | Luiz Fernando N. Capitulino [EMAIL PROTECTED] escreveu: | | | Since I've started using

Re: Boot fails on Intel SATA controller

2007-08-01 Thread Quel Qun
-- Original message -- From: Tejun Heo [EMAIL PROTECTED] Hello, Luiz Fernando N. Capitulino wrote: Hi there, A Mandriva user is reporting that his machine hangs while booting kernels 2.6.22.1 and 2.6.23-rc1. But boots fine with 2.6.21.

Re: [PATCH] mark PCI resource with start 0 as unassigned

2007-08-01 Thread Sergei Shtylyov
Segher Boessenkool wrote: setup-pci is for SFF8038i devices. It therefore knows that for assigned resources they must be I/O. It also assumes that zero is not a valid I/O port just like zero is not a valid IRQ. Stick a real IDE resource at zero and drivers/ide can't cope. But 0 _is_ a

Re: [PATCH] pata_sis: fix MWDMA for = UDMA66 chipsets and UDMA for UDMA33 chipsets

2007-08-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: * Fix MWDMA timings setup in sis_old_set_dmamode() and sis_66_set_dmamode(). The old timings were overclocked (even worse behavior than sis5513 IDE driver which depends on BIOS to program correct timings), the new timings are taken from the datasheet (they

Re: [PATCH] libata: blacklist SAMSUNG HD401LJ / ZZ100-15 for NCQ

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: SAMSUNG HD401LJ / ZZ100-15 does spurious completion of NCQ commands. Disable NCQ. Reported by Ulrich in bugzilla #8805. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Ulrich [EMAIL PROTECTED] --- And, finally one from samsung. How come vendors got this right previously but

Re: [PATCH] pci: rename __pci_reenable_device() to pci_reenable_device()

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: Rename __pci_reenable_device() to pci_reenable_device(). Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Jeff, Greg wanted to drop the preceding underscores before exporting the function and the updated patch was posted but the earlier version was applied. This patch renames

Re: [patch 1/4] Store interrupt value

2007-08-01 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] ACK. Regenerate against current kernel and I'll

Re: [PATCH UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: From: Mark Lord [EMAIL PROTECTED] Add support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, atapi_scmd85=1 can be used to globally disable this feature, if ever desired. tj:

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: I must have been half asleep when doing the original code Signed-off-by: Alan Cox [EMAIL PROTECTED] applied to #upstream-fixes - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] libata-sff; Unbreak non DMA capable controllers again

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: Seems nobody else is checking/testing this case as it keeps getting horked. If we have no BAR4 mapping on an SFF controller this is *NOT* an error, it just means it isn't doing BMDMA. Signed-off-by: Alan Cox [EMAIL PROTECTED] applied to #upstream-fixes - To unsubscribe from

Re: Boot fails on Intel SATA controller

2007-08-01 Thread Luiz Fernando N. Capitulino
Em Wed, 01 Aug 2007 23:36:07 +0900 Tejun Heo [EMAIL PROTECTED] escreveu: | Quel Qun wrote: | -- Original message -- | From: Tejun Heo [EMAIL PROTECTED] | Hello, | | Luiz Fernando N. Capitulino wrote: | Hi there, | | A Mandriva user is reporting that his

Re: Boot fails on Intel SATA controller

2007-08-01 Thread Tejun Heo
Quel Qun wrote: -- Original message -- From: Tejun Heo [EMAIL PROTECTED] Hello, Luiz Fernando N. Capitulino wrote: Hi there, A Mandriva user is reporting that his machine hangs while booting kernels 2.6.22.1 and 2.6.23-rc1. But boots fine with 2.6.21.

Re: Early ATA devices

2007-08-01 Thread Alan Cox
On Wed, 01 Aug 2007 09:47:49 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Alan Cox wrote: #1 We assume identify works. Early ATA actually lists this command as optional ITYM we assume identify command exists on the device? We certainly do not assume IDENTIFY command, if exists,

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 12:24:44 +0900 Tejun Heo [EMAIL PROTECTED] wrote: It would be *really* great if we can find more about how they do it. How and when it's enabled and on which systems. Is it possible to find this out? No - it's really not a good idea for us to go and ask other OS's how

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-08-01 Thread Alan Cox
On Wed, 01 Aug 2007 09:49:19 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Alan Cox wrote: Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ... Signed-off-by: Alan Cox [EMAIL PROTECTED] --- drivers/ata/sata_mv.c~ 2007-07-09

Re: [PATCH] mark PCI resource with start 0 as unassigned

2007-08-01 Thread Alan Cox
On Wed, 01 Aug 2007 18:22:36 +0400 Sergei Shtylyov [EMAIL PROTECTED] wrote: Segher Boessenkool wrote: setup-pci is for SFF8038i devices. It therefore knows that for assigned resources they must be I/O. It also assumes that zero is not a valid I/O port just like zero is not a valid IRQ.

[git patches] libata fixes

2007-08-01 Thread Jeff Garzik
The only notable: GregKH wanted the pci_reenable_device() change associated with ata_piix to go in before the release, to avoiding release with an imperfect API. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Bob Ham
On Wed, 2007-08-01 at 17:40 +0400, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: I've had a Highpoint Rocket 1540 (not RocketRAID) SATA controller for a while now, using a proprietary binary driver from Highpoint in a linux 2.4 kernel. The chipset is an hpt374. The

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 18:23:21 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Tejun Heo wrote: Arjan van de Ven wrote: They were hardware problems. I don't think any amount of proper implementation can fix them. I have one DVD RAM somewhere in my pile of hardware which locks up solidly if any

Re: Access beyond end of device

2007-08-01 Thread Alan Cox
Ok, the disk has a host protected area and now I'm telling libata to disable it. The error messages has disappeared. But... Is it safe to do it? I've read somewhere that the BIOS and other softwares may use that area. On some systems. Its also used for different things on others

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Matthew Wilcox
On Tue, Jul 31, 2007 at 09:18:08AM -0500, James Bottomley wrote: The other comment is that power saving seems to be a property of the transport rather than the host. If you do it in the transport classes, then you can expose all the knobs the actual transport possesses (which is,

Re: NV Cache Feature Support in libata

2007-08-01 Thread Fajun Chen
Did you refer to HDIO_DRIVE_CMD ioctl in old IDE code? I couldn't get it working on libata. Based on libata-scsi code, only PIO data in and Non-data protocol are supported for HDIO_DRIVE_CMD while NV Cache commands requires DMA based on ATA8 spec. I tried to use ATA pass through command for NV

Re: Early ATA devices

2007-08-01 Thread Alan Cox
So in theory we can persuade libata to drive original MFM/RLL disks with relatively few changes Crazy :) Would look something like this (but with geometry handling and some setup work) /** * An original IDE/ST412/ST506 driver for libata * * Information for hardware

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Bob Ham
On Wed, 2007-08-01 at 19:58 +0400, Sergei Shtylyov wrote: Bob Ham wrote: I've had a Highpoint Rocket 1540 (not RocketRAID) SATA controller for a while now, using a proprietary binary driver from Highpoint in a linux 2.4 kernel. The chipset is an hpt374. The hpt366 driver freezes on

Re: Marvell 7042 (sata_mv) fails to initialize drive

2007-08-01 Thread Michal Piotrowski
Hi Markus, On 31/07/07, Markus Gutschke [EMAIL PROTECTED] wrote: I just tried hooking up a Hitachi 1TB SATA-II drive to a Marvell 7042 based controller, and the most recent Linux kernel (2.6.23-rc1) fails to properly initialize the interface. Does 2.6.22.1 work? Here are the relevant kernel

Re: 2.6.23-rc1-mm2 (checks-for-80wire-cable-use-in-pata_via)

2007-08-01 Thread Laurent Riffard
Le 01.08.2007 08:09, Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm2/ ... +libata-acpi-checks-for-80wire-cable-use-in-pata_via.patch ... sata/pata things Alan, this does not work after a suspend-resume cycle, I get a ACPI get

[PATCH 3/3] aec62xx: always tune PIO

2007-08-01 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/aec62xx.c === --- a/drivers/ide/pci/aec62xx.c +++

[PATCH 1/3] sis5513: DMA setup fixes

2007-08-01 Thread Bartlomiej Zolnierkiewicz
* Add sis_ata133_get_base() helper function for obtaining the address of the drive control registers on chipset_family == ATA_133 chipsets. * Add three helper functions for programming PIO/MWDMA timings: - sis_ata16_program_timings() (for ATA_16/33/66/100a chipset families) -

Re: [patch 3/4] Enable link power management for ata drivers

2007-08-01 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 17:27:39 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: snippy Is it safe to use ALPM on a device which only claims to support DIPM? Yes - I doubled checked this with the AHCI people - and of course you have Edvin's testing to prove it does fine.

Re: [patch 1/4] Store interrupt value

2007-08-01 Thread Kristen Carlson Accardi
Store interrupt value Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

Re: Marvell 7042 (sata_mv) fails to initialize drive

2007-08-01 Thread Markus Gutschke
I have done some more testing, and it now looks as if this was actually a hardware fault. Reseating the PCI-E card made the problem go away (knock on wood). I am a little puzzled that it is possible for the card to show up on the PCI bus, and for the driver to be able to detect whether a disk

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 12:24:44 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: I don't think the interface you're suggesting is a good one. Do you? I think if it's applicable to SCSI at all it is fine. If it is not, then I think we need to make do with the

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 01 August 2007, Sergei Shtylyov wrote: Does this patch change anything? Heh, did you *really* hope it will? :-D Well, ugh, yes? :) [PATCH] hpt366: always tune PIO Index: b/drivers/ide/pci/hpt366.c

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Sergei Shtylyov
Bob Ham wrote: hpt37x: DPLL did not stabilize. pata_hpt37x: BIOS has not set timing clocks. hpt37x: DPLL did not stabilize. Yes, this ia a known issue, and the fix for it is in the -mm tree: I applied just that pata_hpt37x.c patch, not the whole -mm tree. It locks the machine hard

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Bob Ham
On Wed, 2007-08-01 at 19:58 +0400, Sergei Shtylyov wrote: hpt37x: DPLL did not stabilize. pata_hpt37x: BIOS has not set timing clocks. hpt37x: DPLL did not stabilize. Yes, this ia a known issue, and the fix for it is in the -mm tree: I applied just that pata_hpt37x.c patch, not the

Re: [PATCH] fix runtogether printk's in cmd64x IDE driver

2007-08-01 Thread Bartlomiej Zolnierkiewicz
On Sunday 29 July 2007, Meelis Roos wrote: Fix a couple of runtogether printks in cmd64x.c IDE driver by adding proper newlines. Signed-off-by: Meelis Roos [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Bartlomiej Zolnierkiewicz
On Wednesday 01 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: On Wednesday 01 August 2007, Sergei Shtylyov wrote: Does this patch change anything? Heh, did you *really* hope it will? :-D Well, ugh, yes? :) Here we have some really nasty screw-up I'm

[patch 0/3] Updated ALPM patches

2007-08-01 Thread Kristen Carlson Accardi
Hi, This is an updated series of ALPM patches. I moved all link power management stuff out of scsi sysfs and just use the shost_addr pointer in the host template to create the sysfs files. This provides the same interface as before, without requiring any scsi changes. I also fixed a bug in the

[patch 1/3] Store interrupt value

2007-08-01 Thread Kristen Carlson Accardi
Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

[patch 2/3] Enable link power management for ata drivers

2007-08-01 Thread Kristen Carlson Accardi
libata drivers can define a function (enable_pm) that will perform hardware specific actions to enable whatever power management policy the user set up from the scsi sysfs interface if the driver supports it. This power management policy will be activated after all disks have been enumerated

[patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-08-01 Thread Kristen Carlson Accardi
This patch will set the correct bits to turn on Aggressive Link Power Management (ALPM) for the ahci driver. This will cause the controller and disk to negotiate a lower power state for the link when there is no activity (see the AHCI 1.x spec for details). This feature is mutually exclusive

Re: ST340823A disk size issue

2007-08-01 Thread Mikko Rapeli
On Wed, Aug 01, 2007 at 10:34:03PM +0200, Bartlomiej Zolnierkiewicz wrote: Could you try attached patch? [PATCH] ide-disk: workaround for buggy HPA support on ST340823A Umh, it's getting late but some makefile magic maybe missing, or I should do a clean build? $ make drivers/ide/ide-disk.ko

[git patches] IDE fixes

2007-08-01 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/arm/icside.c |3 +- drivers/ide/ide-tape.c |2 +- drivers/ide/pci/alim15x3.c |2 +- drivers/ide/pci/cmd64x.c |4 +- drivers/ide/pci/cs5520.c

Re: ST340823A disk size issue

2007-08-01 Thread Alan Cox
Could you try attached patch? [PATCH] ide-disk: workaround for buggy HPA support on ST340823A Title is wrong. The disc is performing correctly but if you dump the request you should see a 1024 byte request for the last odd sector number and the drive response is likewise correct. Thus NAK

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Alan Cox
hpt37x: Bus clock 66 MHz, using DPLL. Oh?! hpt366.c detected 33 MHz... :-O Interesting as it should be using the same algorithm as hpt366 now. ACPI: PCI Interrupt :00:0d.0[A] - GSI 16 (level, low) - IRQ 17 scsi2: pata_hpt37x scsi3: pata_hpt37x ata3: PATA max UDMA/100 cmd

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-01 Thread Alan Cox
Too bad, this is the standard HPT subsystem ID of 0x0001... So, nothing comes to my mind other than add a module parameter to hpt366.c to specify that we're using the crippled SATA bridge... well, maybe it would also make sense to scan the BIOS for the signatures... Since you don't

Re: ST340823A disk size issue

2007-08-01 Thread Bartlomiej Zolnierkiewicz
On Thursday 02 August 2007, Alan Cox wrote: If you fix the printk, add patch description (can use the one from my patch) and add Signed-off-by: I would happily apply it and dump mine version. Sorry but the patch is wrong - plain and simple. It works over the bug but its not the real

Re: ST340823A disk size issue

2007-08-01 Thread Bartlomiej Zolnierkiewicz
On Thursday 02 August 2007, Bartlomiej Zolnierkiewicz wrote: Otherwise this patch looks fine and is a bit simpler than my patch. If you fix the printk, add patch description (can use the one from my patch) and add Signed-off-by: I would happily apply it and dump mine version. On the second

Re: [patch 3/4] Enable link power management for ata drivers

2007-08-01 Thread Tejun Heo
Kristen Carlson Accardi wrote: On Wed, 01 Aug 2007 17:27:39 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: snippy Is it safe to use ALPM on a device which only claims to support DIPM? Yes - I doubled checked this with the AHCI people - and of course you have