Re: Promise SATA TX4 300 port timeout with sata_promise in 2.6.22, kernel panic in 2.6.23

2007-11-12 Thread Patric Karlsson
Tejun Heo wrote: Hello, I Stratford wrote: The purpose of the mail is to document and share my experience in the hope that someone might find it useful, either for debugging their own TX4 300-centric system issues or figuring out what is up with sata_promise and the TX4 300 in 3Gbps mode. I

Re: Promise SATA TX4 300 port timeout with sata_promise in 2.6.22, kernel panic in 2.6.23

2007-11-12 Thread Tejun Heo
Patric Karlsson wrote: Tejun Heo wrote: It seems those 3Gbps promise controllers have hard time getting out of transmission errors. Is it because hardreset doesn't work? Can we fix it? Also, if 3Gbps can't be made reliable on those controllers, how about limiting it to 1.5Gbps by default

[PATCH] ata_piix: add SATELLITE U205 to broken suspend list

2007-11-12 Thread Tejun Heo
Satellite U205 has alternate product name where the satellite part is all capatalized. Add it to the blacklist. This is reported by Ross Patterson in kernel bugzilla bug #7780. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Ross Patterson [EMAIL PROTECTED] --- This patch has been queued in

possibly a dumb question about sb600/700

2007-11-12 Thread Tejun Heo
Hello, I've been looking at PATA support for sb600 and 700 and found something weird. * IDE atiixp.c has a separate entry for sb600 such that it only probes the first port but sb700 doesn't use the entry. So, does sb600 has one PATA channel but sb700 has two? * libata pata_atiixp.c doesn't

Re: Promise SATA TX4 300 port timeout with sata_promise in 2.6.22, kernel panic in 2.6.23

2007-11-12 Thread Mikael Pettersson
On Mon, 12 Nov 2007 13:12:19 +0900, Tejun Heo wrote: I Stratford wrote: The purpose of the mail is to document and share my experience in the hope that someone might find it useful, either for debugging their own TX4 300-centric system issues or figuring out what is up with sata_promise and

Re: 2.6.24-rc SB600 AHCI no go on =4GB of RAM

2007-11-12 Thread Srihari Vijayaraghavan
Tejun Heo [EMAIL PROTECTED] wrote: [...] Hmmm.. weird. The workaround is still there. Please post boot log. OK, that's good to hear. Alas, after the Fedora 7 to 8 upgrade, I'm no longer able to compile a kernel (some uhci-hcd module not found for the initrd). And I was too quick to overwrite

Re: Promise SATA TX4 300 port timeout with sata_promise in 2.6.22, kernel panic in 2.6.23

2007-11-12 Thread Tejun Heo
Hello, Mikael Pettersson wrote: Also, if 3Gbps can't be made reliable on those controllers, how about limiting it to 1.5Gbps by default with appropriate warning messages? Without PMP, it's not like we're gonna earn anything by driving the thing at 3Gbps. There are two things going on here:

Re: possibly a dumb question about sb600/700

2007-11-12 Thread Alan Cox
On Mon, 12 Nov 2007 18:05:44 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Hello, I've been looking at PATA support for sb600 and 700 and found something weird. * IDE atiixp.c has a separate entry for sb600 such that it only probes the first port but sb700 doesn't use the entry. So, does

Re: possibly a dumb question about sb600/700

2007-11-12 Thread Tejun Heo
Alan Cox wrote: On Mon, 12 Nov 2007 18:05:44 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Hello, I've been looking at PATA support for sb600 and 700 and found something weird. * IDE atiixp.c has a separate entry for sb600 such that it only probes the first port but sb700 doesn't use the

Re: question about sata-error on boot.

2007-11-12 Thread Tejun Heo
(cc Robert Hancock, maybe we need ATA_LFLAG_HRST_TO_RESUME for these controllers?) Andrew Morton wrote: On Fri, 2 Nov 2007 19:34:20 +0100 Hemmann, Volker Armin [EMAIL PROTECTED] wrote: Hi, (cc linux-ide) for some time (and I can't say for how long, but the board is less than a month

Re: possibly a dumb question about sb600/700

2007-11-12 Thread Alan Cox
Alright, then. I was just worried about the asymmetry. Oh, this _reminds me of another problem regarding enable bits. There's a system (wyse thin client) with pata_amd controller where the enable bit isn't set by the BIOS and there's no reliable way to identify the system (no DMI). Do you

Re: possibly a dumb question about sb600/700

2007-11-12 Thread Tejun Heo
Alan Cox wrote: Alright, then. I was just worried about the asymmetry. Oh, this _reminds me of another problem regarding enable bits. There's a system (wyse thin client) with pata_amd controller where the enable bit isn't set by the BIOS and there's no reliable way to identify the system

Re: Hang during boot in piix_init_pcs (ata_piix.c) with macbook pro

2007-11-12 Thread Tejun Heo
[cc'ing Jason] Hello, Thomas. Thomas Rohwer wrote: My next try would be to put in a custom version ich8_map_db with port_enable=1 (and possibly {P0, P2, NA, NA} in the first line of .map) and use this map for pci id 8086:2828, because I think the notebook has only one sata port anyway. Is

Re: possibly a dumb question about sb600/700

2007-11-12 Thread Alan Cox
On Mon, 12 Nov 2007 23:44:30 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Alan Cox wrote: Alright, then. I was just worried about the asymmetry. Oh, this _reminds me of another problem regarding enable bits. There's a system (wyse thin client) with pata_amd controller where the enable bit

Re: [PATCH 5/9] ide: use -data_phase to set -handler in do_rw_taskfile()

2007-11-12 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Use -data_phase to set -handler in do_rw_taskfile() instead of setting -handler in callers of ide_raw_taskfile()/do_rw_taskfile(). * Unexport task_no_data_intr() and make it static. There should be no functionality changes caused by this patch.

Re: [PATCH 8/9] ide-disk: add ide_tf_set_cmd() helper

2007-11-12 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Add ide_tf_set_cmd() helper for selecting/setting command and data phase (note: DMA data phases are there for completness, they are not required ATM). * Set IDE_TFLAG_WRITE taskfile flag for write requests in __ide_do_rw_disk(). * Convert

libata , Silicon Image 3124

2007-11-12 Thread Kasimir Müller
Hi tejun, Since I am using portmultiplier on sil 3124, I see the following errors in /var/log/messages Presently I'm using kernel 2.6.23.1 with libata-patch libata-tj-2.6.23-20071011 on Suse 10.3 First I saw this messages every 5-10 minutes. After putting all Disks in the Blacklist of

Delkin Cardbus IDE, a.k.a. ASKA Ninja chipset

2007-11-12 Thread Mark Lord
Mark Lord wrote: Alan Cox wrote: On Wed, 07 Nov 2007 17:37:07 -0500 Mark Lord [EMAIL PROTECTED] wrote: delkin_cb is also missing from libata. I was going to port it over once, but no longer have a cardbus slot in either of my notebooks here. Yes I looked at it but it didn't have any proper

Re: Delkin Cardbus IDE, a.k.a. ASKA Ninja chipset

2007-11-12 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: Alan Cox wrote: On Wed, 07 Nov 2007 17:37:07 -0500 Mark Lord [EMAIL PROTECTED] wrote: delkin_cb is also missing from libata. I was going to port it over once, but no longer have a cardbus slot in either of my notebooks here. Yes I looked at it but it

Re: Delkin Cardbus IDE, a.k.a. ASKA Ninja chipset

2007-11-12 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: Mark Lord wrote: Alan Cox wrote: On Wed, 07 Nov 2007 17:37:07 -0500 Mark Lord [EMAIL PROTECTED] wrote: delkin_cb is also missing from libata. I was going to port it over once, but no longer have a cardbus slot in either of my notebooks here. Yes I looked

Re: Hang during boot in piix_init_pcs (ata_piix.c) with macbook pro

2007-11-12 Thread Thomas Rohwer
Hello, Yes, adding a separate entry for ich8m is the correct approach w/ port_enable=1 seems like the correct approach. Does it fix the problem? thanks for the information. I tried it now, and at least my hard drive is still working and the pcs is not updated anymore. I will report after

Re: Delkin Cardbus IDE, a.k.a. ASKA Ninja chipset

2007-11-12 Thread Mark Lord
Alan Cox wrote: On Mon, 12 Nov 2007 15:11:16 -0500 Mark Lord [EMAIL PROTECTED] wrote: Mark Lord wrote: Alan Cox wrote: On Wed, 07 Nov 2007 17:37:07 -0500 Mark Lord [EMAIL PROTECTED] wrote: delkin_cb is also missing from libata. I was going to port it over once, but no longer have a

[PATCH 1/13] serverworks: cleanup -set_dma_mode method

2007-11-12 Thread Bartlomiej Zolnierkiewicz
IDE core guarantees that -set_dma_mode will be called only for DMA modes set in SWDMA/MWDMA/UDMA masks. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c | 25 ++---

[PATCH 3/13] ide: (hopefully) fix VDMA for CS5520

2007-11-12 Thread Bartlomiej Zolnierkiewicz
* Set the correct hwif-dma_base for the second channel in ide_get_or_set_dma_base(). * Remove DMA enable code from cs5520_set_pio_mode(), this can be handled by the generic -dma_host_on method now. * Add VDMA check to ide_config_drive_speed(). * drive-using_dma was never enabled since

[PATCH 4/13] cy82c693: correct DMA modes clipping

2007-11-12 Thread Bartlomiej Zolnierkiewicz
* Mask device DMA masks by ATA_{S,M}WDMA2 in cy82c693_ide_dma_on(). * Remove clipping of DMA modes by id-tDMA in cy82c693_dma_enable(): - id-tDMA may not be defined on newer devices - id-vendor6/id-tDMA word is in LE endianness (cy82c693 seems to be Alpha specific though) * Bump driver

[PATCH 7/13] icside: add ide_toggle_bounce() calls

2007-11-12 Thread Bartlomiej Zolnierkiewicz
Add ide_toggle_bounce() call to -ide_dma_on/-dma_off_quietly methods so they match generic __ide_dma_on()/ide_dma_off_quietly(). Since there is no PCI device there should be no functionality changes caused by this patch. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej

[PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls

2007-11-12 Thread Bartlomiej Zolnierkiewicz
Add ide_toggle_bounce() call to -ide_dma_on/-dma_off_quietly methods so they match generic __ide_dma_on()/ide_dma_off_quietly(). Cc: Jeremy Higdon [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sgiioc4.c |2 ++ 1 file changed, 2

[PATCH 8/13] au1xxx-ide: add ide_toggle_bounce() calls

2007-11-12 Thread Bartlomiej Zolnierkiewicz
Add ide_toggle_bounce() call to -ide_dma_on/-dma_off_quietly methods so they match generic __ide_dma_on()/ide_dma_off_quietly(). Since there is no PCI device there should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] ---

[PATCH 9/13] ide: remove -ide_dma_on and -dma_off_quietly methods from ide_hwif_t

2007-11-12 Thread Bartlomiej Zolnierkiewicz
* Make ide_dma_off_quietly() and __ide_dma_on() always available. * Drop __ prefix from __ide_dma_on(). * Check for presence of -dma_host_on instead of -ide_dma_on. * Convert all users of -ide_dma_on and -dma_off_quietly methods to use ide_dma_on() and ide_dma_off_quietly() instead. *

[PATCH 10/13] ide-cris: fix DMA methods

2007-11-12 Thread Bartlomiej Zolnierkiewicz
* Rename cris_dma_{on,off}() to cris_dma_host_{on,off}(). * Remove no longer needed -dma_off_quietly (IDE core has the needed code now). * Make cris_dma_host_on() void. Cc: Mikael Starvik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] ---

[PATCH 11/13] atiixp: remove -dma_host_on and -dma_host_off methods

2007-11-12 Thread Bartlomiej Zolnierkiewicz
* Enable/disable UDMA in atiixp_set_dma_mode(). * Remove no longer needed atiixp_dma_host_{on,off}() and save_mdma_mode[]. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Needs to be tested, I'll check it with SB400 unless somebody beats me to it...

[PATCH 13/13] ide: merge -dma_host_{on,off} methods into -dma_host_set method

2007-11-12 Thread Bartlomiej Zolnierkiewicz
Merge -dma_host_{on,off} methods into -dma_host_set method which takes 'int on' argument. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |9 +-- drivers/ide/cris/ide-cris.c |