Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-01 Thread Mark Lord
I wanted to use the newer pata support in the SATA lib, but got frustrated real fast by the lack of disk-parameter support in the new pata library (hdparm is mostly broken; and the SCSI utils aren't really intended for ATA(or SATA?) disks using the SCSI interface. ... Most hdparm flags work

[PATCH 2.6.24 1/1] sata_sil24: prevent hba lockup when pass-through ATA commands are used

2008-01-01 Thread Gwendal Grignou
Fix commands timeout with Sil3124/3132 based HBA when pass-through ATA commands [where ATA_QCFLAG_RESULT_TF is set] are used while other commands are active on other devices connected to the same port with a Port Multiplier. Due to a hardware bug, these commands must be sent alone, like ATAPI

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Gabor Gombas
Hi, Just FYI I've tried to enable ADMA again (now running 2.6.24-rc6) but the bug is still present: Jan 1 16:11:21 host kernel: ata7: EH in ADMA mode, notifier 0x0 notifier_error 0x0 gen_ctl 0x1501000 status 0x400 next cpb count 0x0 next cpb idx 0x0 Jan 1 16:11:21 host kernel: ata7: CPB 0:

Re: [PATCH 1/2] trm290: cannot call ide_setup_dma()

2008-01-01 Thread Bartlomiej Zolnierkiewicz
On Sunday 30 December 2007, Sergei Shtylyov wrote: The TRM-290 chip is *not* SFF-8038i compatible and therefore can *not* call ide_setup_dma() -- fix this and also cleanup the code a bit... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the

Re: [PATCH 2/2] ide_setup_dma() assumes 8 ports

2008-01-01 Thread Bartlomiej Zolnierkiewicz
On Sunday 30 December 2007, Sergei Shtylyov wrote: According to http://marc.info/?l=linux-idem=114346138611631, the drivers must always register 8 DMA ports with ide_setup_dma(), so its last argument is not needed. While at it, kill some useless parens in that function... Signed-off-by:

[PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Bartlomiej Zolnierkiewicz
* Replace driver versions in comments by DRV_VERSION define. * Add MODULE_VERSION(DRV_VERSION) to drivers defining DRV_VERSION. While at it: * Replace local version defines by DRV_VERSION. * Bump driver version in ide-floppy to match generic format (0.99.newide - 1.00). * Change printk()

[PATCH 3/3] ide: update/add my Copyrights

2008-01-01 Thread Bartlomiej Zolnierkiewicz
The last years stuff and a trip down memory lane... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |8 drivers/ide/ide-disk.c |9 + drivers/ide/ide-dma.c |7 +++ drivers/ide/ide-floppy.c |5 +++--

[PATCH 2/3] ide: delete filenames from comments

2008-01-01 Thread Bartlomiej Zolnierkiewicz
Delete filenames from comments. While at it: * Delete versions from comments in ide-dma.c, ide-iops.c, ide-probe.c, ide-proc.c, ide-taskfile.c, and setup-pci.c (all these files are a part of IDE core module), and also ide-timing.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 06:40:38PM +0100, Bartlomiej Zolnierkiewicz wrote: * Replace driver versions in comments by DRV_VERSION define. * Add MODULE_VERSION(DRV_VERSION) to drivers defining DRV_VERSION. ... Could you limit this to actively maintained version numbers and also remove the

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Bartlomiej Zolnierkiewicz
On Tuesday 01 January 2008, Adrian Bunk wrote: On Tue, Jan 01, 2008 at 06:40:38PM +0100, Bartlomiej Zolnierkiewicz wrote: * Replace driver versions in comments by DRV_VERSION define. * Add MODULE_VERSION(DRV_VERSION) to drivers defining DRV_VERSION. ... Could you limit this to

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Jon Masters
On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: On the second thought: maybe we will be better off with limiting MODULE_VERSION() to the device drivers and the IDE core module for now, and just removing all these private version numbers from host drivers (with one or two

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Tejun Heo
[cc'ing Robert Hancock and NVidia people] Whole thread can be read from the following URL. http://thread.gmane.org/gmane.linux.ide/21710 In a nutshell, with ADMA enabled, FLUSH_EXT occasionally times out. I first suspected faulty disk (reallocation failure on flush) but SMART reports nothing

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Tejun Heo wrote: [cc'ing Robert Hancock and NVidia people] Whole thread can be read from the following URL. http://thread.gmane.org/gmane.linux.ide/21710 In a nutshell, with ADMA enabled, FLUSH_EXT occasionally times out. I first suspected faulty disk (reallocation failure on flush) but

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Robert Hancock wrote: Tejun Heo wrote: [cc'ing Robert Hancock and NVidia people] Whole thread can be read from the following URL. http://thread.gmane.org/gmane.linux.ide/21710 In a nutshell, with ADMA enabled, FLUSH_EXT occasionally times out. I first suspected faulty disk (reallocation

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Tejun Heo
Robert Hancock wrote: This is kind of a longstanding problem which has been partially worked around, but it seems not entirely. This is what I had diagnosed some time ago: recently, some issues cropped up with command timeouts when a cache flush command was immediately followed by an NCQ

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Matt Domsch
On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: On the second thought: maybe we will be better off with limiting MODULE_VERSION() to the device drivers and the IDE core module for now, and just removing all

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Jon Masters
On Tue, 2008-01-01 at 22:46 -0600, Matt Domsch wrote: On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: On the second thought: maybe we will be better off with limiting MODULE_VERSION() to the device

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Jeff Garzik
Tejun Heo wrote: Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? FLUSH is used regularly. We really need to fix this. I reiterate my opinion :) ... We should remove ADMA support from sata_nv. It's only in a few chips, it's not appearing in any new chips, and nasty

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Jeff Garzik wrote: Tejun Heo wrote: Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? FLUSH is used regularly. We really need to fix this. I reiterate my opinion :) ... We should remove ADMA support from sata_nv. It's only in a few chips, it's not appearing in any new

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Tejun Heo
Robert Hancock wrote: Jeff Garzik wrote: Tejun Heo wrote: Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? FLUSH is used regularly. We really need to fix this. I reiterate my opinion :) ... We should remove ADMA support from sata_nv. It's only in a few chips, it's

Re: Maybe Sorry for that but where should i write .)

2008-01-01 Thread Tejun Heo
Boaz Harrosh wrote: On Sat, Dec 29 2007 at 3:50 +0200, thanatos [EMAIL PROTECTED] wrote: I got a sata controller ignitio 00:11.0 SATA controller: Initio Corporation INI-1623 PCI SATA-II Controller (rev 02) (prog-if 00 [Vendor specific]) Subsystem: Initio Corporation INI-1623 PCI