[PATCH] pata: "I do not think it means, what you think it means."

2008-02-26 Thread Alan Cox
When masking mask out the modes that are unsupported not the ones that are supported. This makes life happier. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc2-mm1/drivers/ata/pata_hpt366.c linux-2.6.25-r

Re: [RFC] Disk shock protection (revisited)

2008-02-26 Thread Alan Cox
> The general idea: A daemon running in user space monitors input data > from an accelerometer. When the daemon detects a critical condition, That sounds like a non starter. What if the box is busy, what if the daemon or something you touch needs memory and causes paging ? Given the accelerometer

Re: ops->qc_defer not invoked on ata_exec_internal_sg() paths ?

2008-02-26 Thread Alan Cox
On Mon, 25 Feb 2008 19:20:59 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > The optional .qc_defer() methods don't seem to be called > on the ata_exec_internal_sg() path. > > At present, this is probably okay. But in the future, > as we add functionality for link power management > and hotplug pol

Old errata docs

2008-02-25 Thread Alan Cox
Does anyone have in their posession the old errata docs for the HPT370 controller. I'm seeing two reports now where there is some kind of FIFO corruption pattern (shifted data and duplicated dwords) on the drives which are UDMA100 blacklisted, so presumably more is required for the workaround. Ala

Re: [git patches] libata fixes

2008-02-24 Thread Alan Cox
> From the patch description it can't be told whether the patch itself is > correct and only the patch description is bogus... zero length PRD misparsing. If I remember rightly old IDE never generates 64K PRD slots because other hardware can't handle it either (CS5520/30 etc) - To unsubscribe from

Re: ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)

2008-02-23 Thread Alan Cox
O> I don't see the connection between (no-)smp and ata. Something with > interrupt routing/IPI, missing irq ack? Booting another !SMP kernel > works fine. The problem also exists in 2.6.24-rc2. Almost certainly interrupt routing try smp but with noapic and see if it fails as well ? - To unsubscrib

Re: [MCP-55] IDE problem after bios update

2008-02-22 Thread Alan Cox
On Fri, 22 Feb 2008 20:57:54 +0100 Daniel Schroeder <[EMAIL PROTECTED]> wrote: > hi there, > > this is an asus m2n32-sli deluxe with nvidia chipset. After updating the > bios from 1503 to 1701 following in dmesg, and ide drive doesn't work. > Kernel is 2.6.24.2 If it broke with the BIOS change

Re: ata-piix.c (and libata.ko) in RHEL5.1 (build 78 currently) - this kernel is 2.6.18 baqsed

2008-02-22 Thread Alan Cox
> 3) It is critical to ensure that the ATA "ctl" register is never > written to when no drive is attached. This means bracketing the SRST > sequence to first do a PCS detection before permitting the SRST. > If "ctl" is accessed with no drive attached, the machine locks up hard. At least for PATA

Re: ata-piix.c (and libata.ko) in RHEL5.1 (build 78 currently) - this kernel is 2.6.18 baqsed

2008-02-22 Thread Alan Cox
On Fri, Feb 22, 2008 at 09:52:45AM -0500, Richardson, Charlotte wrote: > There is a hack in its probe routine that disables this. I've disabled the > hack and ran a long test of > hotplugs yesterday (added and removed a DVD drive connected to the ESB2 IDE - > this is Intel > device 0x269E) for 26

Re: What's needed for PMP support?

2008-02-22 Thread Alan Cox
> Heck, if .dev_select() took a *device* instead of a *port* > as it's parameter, then I could probably manage it fine in there. dev_select gets called during probing before the relevant structures are neccessarily set up. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in

Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-22 Thread Alan Cox
On Fri, 22 Feb 2008 12:55:20 +0800 "Huang, Shane" <[EMAIL PROTECTED]> wrote: > Jeff: > > SB700 SATA controller can support 64 bit DMA, the previous commit > badc2341579511a247f5993865aa68379e283c5c was added with > careless reference to SB600, which should be modified by this patch. Does the SB7

[PATCH RFC] libata-core: do something about flush cache

2008-02-20 Thread Alan Cox
does *not* automatically flush other sectors. Instead we must re-issue the flush. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc2-mm1/drivers/ata/libata-core.c linux-2.6.25-rc2-mm1/drivers/ata/libata-

Re: [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it

2008-02-18 Thread Alan Cox
On Mon, Feb 18, 2008 at 03:53:46PM -0500, Mark Lord wrote: > + /* some SATA bridges need us to indicate data xfer direction > */ > + if (atapi_dmadir || (dev->id[62] & 0x8000)) The rest of the code uses ata_ inlines/defines in ata.h for things like this and religiously che

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Alan Cox
> I think, but didn't look real good nor test yet, that pata_legacy also > needs something comparable to select_proc? Or is that implemented in > some generic manner? It sets it in the timing routine: pata_legacy:ht6560b_set_piomode - To unsubscribe from this list: send the line "unsubs

Re: DMA on ht6560b?

2008-02-18 Thread Alan Cox
> Hmm. But what do you then think that 2.2 did? PIO4 > I mean it now does 1.15M/s and in 2.2 it would do ~4M/s with DMA on. It's never done DMA. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Alan Cox
On Mon, 18 Feb 2008 13:50:02 +0100 Jan Evert van Grootheest <[EMAIL PROTECTED]> wrote: > Prefetch needs to be set for some ide devices to work when connected to > a ht6560b interface. This was not always done properly, causing a system > with a HD and CD on the primary interface to not work proper

Re: DMA on ht6560b?

2008-02-18 Thread Alan Cox
> I think the ht6560b controller supports DMA. The data sheet doesn't. It's a PIO controller capable of PIO4 with 32bit host to cpu transfers are best. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 2/2] libata: implement support for 32-bit PIO transfers

2008-02-17 Thread Alan Cox
: implement support for 32-bit PIO transfers > > When ATA_DFLAG_32BIT_PIO is set in ata flags, PIO transfers > will be performed in 32-bit, just like with the plain old IDE > drivers. Acked-by: Alan Cox <[EMAIL PROTECTED]> Although I think ata_data_xfer_32() would be safer and e

Re: [PATCH 0/2] libata: implement 32-bit transfers for PIO mode

2008-02-17 Thread Alan Cox
> Thus, I have implemented the 32-bit mode to bring the performance back > to the level of the old IDE driver. I jumped from 1.5 MB/s to 2.5 MB/s, > which is an important difference at this level of performance, especially > when large files are read. The 32-bit mode is enabled using the ioctl > wh

Re: ICH7: ata_piix twice as fast as ahci?

2008-02-17 Thread Alan Cox
> Am I interpreting this correctly as having to choose between fast iops > with low cpu (+ hotplug) with ahci and twice the linear read speed > with ata_piix? Some drives do weird things when NCQ is used and turn off some of their caching in that case so it depends on the drive what happens to lin

Re: ICH7: ata_piix twice as fast as ahci?

2008-02-17 Thread Alan Cox
On Sun, 17 Feb 2008 16:41:42 +0100 Joris <[EMAIL PROTECTED]> wrote: > Hello List, > > Odd problem on my machines: the sata disks appear to be a lot slower > when used via ata_piix vs the ahci driver. I would expect that. AHCI allows the use of NCQ and unloads a ton of work from the processor. It

Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h

2008-02-15 Thread Alan Cox
On Fri, 15 Feb 2008 15:08:50 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > On Fri, 2008-02-15 at 22:53 +0000, Alan Cox wrote: > > > > NAK. This is a sparse bug, fix sparse. > > > > > > Yes, fair enough, but that's not all the patch is about. >

Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h

2008-02-15 Thread Alan Cox
> > NAK. This is a sparse bug, fix sparse. > > Yes, fair enough, but that's not all the patch is about. > > 1) it's using a max_t and min_t to force the comparisons as shorts, why > not just make it a static inline? Because max_t and min_t also force the comparsion types > 2) the static inline

Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h

2008-02-15 Thread Alan Cox
On Fri, 15 Feb 2008 14:06:55 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > Move to using a static inline which will force the same typechecking > that min_t/max_t do (in this case, short). As a bonus, avoid a ton > of sparse warnings like: > > drivers/ata/pata_ali.c:176:14: warning: symbol

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-15 Thread Alan Cox
> So, why is ide-scsi still in the tree? Is there some use case besides > cdrecord? (Which can use /dev/hda already without the ide-scsi blob...) With old IDE only ide-scsi can handle some of the more obscurely weird devices, and some tape drives fail with ide-tape but work with ide-scsi + osst/s

Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c

2008-02-14 Thread Alan Cox
: warning: symbol 'winbond' shadows an > earlier one > drivers/ata/pata_legacy.c:129:12: originally declared here > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "u

Re: [PATCH 11/11] ata: fix sparse warnings in pata_legacy.c

2008-02-14 Thread Alan Cox
On Wed, 13 Feb 2008 21:14:32 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > Let's use ld for legacy_data instead of shadowing these static > int variables. NAK - I purposefully used names that indicate what device the private data is being used for in order to make it clear. Changing qdi and

Re: [PATCH 05/11] ata: replace macro with static inline in libata.h

2008-02-14 Thread Alan Cox
ppears to be a sparse bug. 1-4/6-10 Acked-by: Alan Cox <[EMAIL PROTECTED]> Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: libata/sata_sil24 cache alignment problem?

2008-02-13 Thread Alan Cox
> I hadn't considered that approach due to the way the ata_port is allocated: > > > libata-core.c: > > host = scsi_host_alloc(ent->sht, sizeof(struct ata_port)); > > > > hosts.c: > > struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int > > privsize) > > { > > sho

Re: libata/sata_sil24 cache alignment problem?

2008-02-13 Thread Alan Cox
O> I'm counting on kmalloc to return a cache aligned buffer. I found > some reason to think it does, but I don't remember offhand what that Its defined to > reason was, or if it's configurable per-architecture. The buffer has > to be both physically and virtually contiguous, I was tempted to ju

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-12 Thread Alan Cox
> Why does the calgary driver need this? Can we just use pci_get_device() > instead? Why do you need to walk the device list backwards? Do you get > false positives going forward? It doesn't look to be performance critical so the driver can pci_get_device until the end and use the final hit any

Re: libata/sata_sil24 cache alignment problem?

2008-02-12 Thread Alan Cox
> I tell you what ... find me a parisc box that actually has IDE and we > might have told you ... The NS87415 variant IDE has been tested on parisc and didn't blow up - must just be lucky. > (actually, the pa8800's have IDE CD's on a cmd640 chip, but that oopses > on boot for no reason we've trac

Re: libata/sata_sil24 cache alignment problem?

2008-02-12 Thread Alan Cox
> Has anyone else reported a problem like this? It requires > non-coherent DMA, and a lack of a cache invalidate instruction, and > one of the drivers that has this problem (it looks like sata_qstor > does too, I haven't looked at others), so maybe that doesn't cover > any other architectures. No

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Alan Cox
On Wed, 13 Feb 2008 08:04:07 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > > - couple of fixes and preparatory patches > > > > > > - rework o

Re: [PATCH] libata: Forcing PIO0 mode on reset must not freeze system

2008-02-11 Thread Alan Cox
> In the above example, even the reset sequence itself can cause hang if > the hardware is implemented slightly differently. The reason why > set_piomode() locks up but reset sequence doesn't is simple dumb luck. > I think the proper fix is to tell libata to detach the cdrom before > undocking. J

Re: [PATCH] libata: Forcing PIO0 mode on reset must not freeze system

2008-02-11 Thread Alan Cox
On Mon, Feb 11, 2008 at 11:29:07AM +0100, Holger Macht wrote: > > In the above example, even the reset sequence itself can cause hang if > > the hardware is implemented slightly differently. The reason why > > set_piomode() locks up but reset sequence doesn't is simple dumb luck. > > Another thin

Re: [PATCH] libata: Forcing PIO0 mode on reset must not freeze system

2008-02-11 Thread Alan Cox
On Mon, Feb 11, 2008 at 11:04:46AM +0100, Holger Macht wrote: > Wouldn't the proper fix be to call ata_acpi_handle_hotplug _somewhere_? > (which is currently called nowhere AFAICS) I think so. The T61 at least generated ACPI dock and undock messages for IDE master/slaves and we can use those. - T

Re: is there a value to CONFIG_NO_ATA_LEGACY?

2008-02-10 Thread Alan Cox
On Sun, 10 Feb 2008 14:44:16 -0500 (EST) "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > in drivers/ata/libata-sff.c: > > ... > #if defined(CONFIG_NO_ATA_LEGACY) > /* Some platforms with PCI limits cannot address compat >port space. In that case we punt if

[PATCH] isolate and rework cable logic try 2

2008-02-08 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/ata/libata-core.c linux-2.6.24-mm1/drivers/ata/libata-core.c --- linux.vanilla-2.6.24-mm1/drivers/ata/libata-core.c 2008-02-06 14:14:39.0

Re: [PATCH] libata: Cable strategy

2008-02-08 Thread Alan Cox
On Fri, 08 Feb 2008 10:45:21 -0500 Chuck Ebbert <[EMAIL PROTECTED]> wrote: > On 02/08/2008 10:21 AM, Alan Cox wrote: > > + ata_link_for_each_dev(dev, link) { > > + if (!ata_is_40wire(dev)) > > +

Re: current mainline ide doesn't like qemu/kvm (or vice versa)

2008-02-08 Thread Alan Cox
On Fri, 8 Feb 2008 16:25:08 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > When trying to put some stress on qemu by running the xfs testsuite > I get the following: > > debian:~/xfs-cmds/xfstests# sh check > [ 438.166822] SGI XFS with ACLs, security attributes, realtime, large block > n

[PATCH] pata_ninja32: setup changes

2008-02-08 Thread Alan Cox
Forcibly set more of the configuration at init time. This seems to fix at least one problem reported. We don't know what most of these bits do, but we do know what windows stuffs there. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/

[PATCH] pata_legacy: typo fix

2008-02-08 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c linux-2.6.24-mm1/drivers/ata/pata_legacy.c --- linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c 2008-02-06 14:14:39.0

[PATCH] libata: Cable strategy

2008-02-08 Thread Alan Cox
doesn't work. Lots of cases in bugzilla show up as only the slave detecting the cable. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/ata/libata-core.c linux-2.6.24-mm1/drivers/ata/li

[PATCH] pata_amd: Note in the module description it handles Nvidia

2008-02-08 Thread Alan Cox
This has confused a few people so fix it Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/ata/pata_amd.c linux-2.6.24-mm1/drivers/ata/pata_amd.c --- linux.vanilla-2.6.24-mm1/drivers/ata/pata

Re: [PATCH #upstream-fixes] pata_via: fix SATA cable detection on cx700

2008-02-06 Thread Alan Cox
On Thu, 07 Feb 2008 10:18:53 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > The first port of cx700 is SATA. Fix cable detection. That should be set anyway by the drive detect but it does no harm and fixes stuff if there is no drive. Acked-by: Alan Cox <[EMAIL PROTECTED]> - To u

Re: [PATCH #upstream-fixes] libata: ignore deverr on SETXFER if mode is configured

2008-02-06 Thread Alan Cox
To > implement this, device is revalidated even after device error on > SETXFER. > > This fixes kernel bugzilla bug 8563. Tidy Acked-by: Alan Cox <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EM

Re: [PATCH 7/9] libata: stop overloading port_info->private_data

2008-02-04 Thread Alan Cox
On Wed, 30 Jan 2008 18:29:01 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > port_info->private_data is currently used for two purposes - to record > private data about the port_info or to specify host->private_data to > use when allocating ata_host. Sensible point, horrible implementation - I'd NA

Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

2008-02-04 Thread Alan Cox
> * Every driver for SFF controllers now uses ata_pci_default_filter() > unless the driver has custom implementation. That is only needed for DMA capable devices. I guess it does no harm to be consistent and call it anyway but you then say .. > * No reason to set ata_pci_default_filter() for PI

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> By the linux software definition maybe. But I've defined scsi as that which > uses a 50 wire cable using 50 contact centronics connectors since the > mid '70's, and which often needs a ready supply of nubile virgins t 25, 50 or 68, with multiple voltage levels, plus of course it might be over

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> I've seen a lot of verbosity out of SCSI messages, but I haven't seen a > straightforward interpretation of the problem in there. It's all > information useful for debugging, not information useful for system > administration. It tells you what is going on. Unfortunately that frequently requi

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> That could stand to be moved or renamed, it is well buried in the menu for > the > REAL scsi stuffs, which I don't have any of. Yes you do - USB storage and ATAPI are SCSI - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] Mor

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> The SCSI error reporting really ought to include a simple interpretation > of the error for end users ("The drive doesn't support this command" "A > sector's data got lost" "The drive timed out" "The drive failed" "The > drive is entirely gone"). There's too much similarity between the message

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-29 Thread Alan Cox
> Needless parens all over the code like this... > Also, you could have made it either 2 (getting rid of |= operator) or 4 > lines (read/write, &=, and |=). mode |= dev << 4; - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAI

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> things in the kernel that refer to SCSI probably should say "storage" (or > "ATA", really, but that would make the acronyms confusing). SCSI is a command protocol. It is what your CD-ROM drive and USB storage devices talk (albeit with a bit of an accent). Alan - To unsubscribe from this list:

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> Don't know. Is there an easy way to find out? E820 map on boot shows you I think. > By the way, and on a totally different subject. I wonder if this: > MODULE_DESCRIPTION("low-level driver for AMD PATA IDE"); > mightn't be changed to something like: > MODULE_DESCRIPTION("low-level driver for A

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> Is this >4GB or >=4GB? I've seen contradictory reports, and I've got 4GB. Depends how the memory is mapped. Any memory physically above the 4GB boundary Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> As slight change here, I was going to use the same .config as 2.6.24-rc8, but > just discovered that neither rc8 nor final is finding the drivers for my If it is not finding a driver that is nothing to do with libata. It means it's not being loaded by the distribution, or the distribution kerne

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Alan Cox
> not one problem but lots---is sufficiently widespread that a Mini HOWTO, > say, would be really welcome and, I'm guessing, widely used. We don't see very many libata problems at the distro level and they for the most part boil down to - error messages looking different - Most bugs I get are th

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Alan Cox
On Mon, Jan 28, 2008 at 01:38:40PM -0500, Mark Lord wrote: > >[ 31.195305] ata2.00: ATAPI: LITE-ON DVDRW SHM-165H6S, HS06, max UDMA/66 > >[ 31.243813] ata2.01: ATA-7: MAXTOR STM3320620A, 3.AAE, max UDMA/100 > >[ 31.243816] ata2.01: 625142448 sectors, multi 16: LBA48 > >[ 31.243825] ata2.00

[PATCH] pata_legacy: multiple updates (rediff as asked)

2008-01-28 Thread Alan Cox
- Fix probe logic to support multiple devices better - Fold in qdi and winbond support - Fix promise 202C30 probe - Restructure diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24/drivers/ata/pata_legacy.c linux-2.6.24/drivers/ata/pata_legacy.c --- linux.vanilla-

[PATCH] pata_sl82c105: dual channel support

2008-01-28 Thread Alan Cox
Use qc_defer to serialize the two channels Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24/drivers/ata/pata_sl82c105.c linux-2.6.24/drivers/ata/pata_sl82c105.c --- linux.vanilla-2.6.24/drivers/ata/pata_sl82

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-23 Thread Alan Cox
On Wed, 23 Jan 2008 16:38:06 +0300 Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Hello. > > Alan Cox wrote: > > >>Why you chose to use ioread32() and iowrite32() if your device is > >> strictly > >>memory mapped? Those functions add som

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-22 Thread Alan Cox
> Why you chose to use ioread32() and iowrite32() if your device is > strictly > memory mapped? Those functions add some overhead, and boil down to readl() > and There are distinct portability advantages but you shouldn't mix ioread32/iowrite32 with ioremap as that isn't guaranteed to work

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread Alan Cox
> However, I'd like to see if we can track the problem through the SG_IO > direct path ... how many adjacent page bytes are corrupt? Just a few or > a large number (I'm wondering if it's an off by one or off by alignment > type bug)? Which ATA controller is involved - in theory ATA DMA is byte al

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-22 Thread Alan Cox
On Tue, 22 Jan 2008 15:11:37 +0300 Anton Salnikov <[EMAIL PROTECTED]> wrote: > > > +static inline u32 ioread(u32 reg) > > > +{ > > > + return ioread32(base + reg); > > > +} > > > + > > > +static inline void iowrite(u32 val, u32 reg) > > > +{ > > > + iowrite32(val, base + reg); > > > +} > > > > Wh

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
> Could you point me to some bugreports? > > I would like to know more about hosts/conditions for which it happens. The timer reset path races the I/O path races the interrupt path. That was the vomitously foul race that persuaded me to go libata instead. I seem to remember explaining this all so

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-21 Thread Alan Cox
> +static inline u32 ioread(u32 reg) > +{ > + return ioread32(base + reg); > +} > + > +static inline void iowrite(u32 val, u32 reg) > +{ > + iowrite32(val, base + reg); > +} Why not just use ioread32/iowrite32 directly ? Otherwise this looks way way better. Alan - To unsubscribe from th

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
> I still don't think it's worth the trouble. There's currently only one > reported device which forgets to raise IRQ on media error. The behavior Most people wouldn't realise what is going on. > > Old IDE says it works for PATA. For SATA I can see it might need more > > care and you might simp

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
> Can you elaborate a bit? I don't really think completing a command > after 30sec timeout contributes a lot to driver stability. Timeout, timeout, timeout, reset, timeout.. (repeat), failed I/O This gives the end user no information about the fault, nor does it let the upper layers of SCSI and

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
> Just a data point, even ICHs lock up after PHY event if the wrong TF > register is accessed. I just don't think tempting with TF regs after > timeout is worth the cost. For SATA maybe, for PATA I don't have any controllers with your bug so its wrong for libata to cripple the PATA support or wor

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
> while IDE thinks that IRQ might be lost and complete the command if the > TF status register says so. For PATA at least that makes a lot of sense. It would probably make the Promise driver a lot more stable too. > It could be that the particular device doesn't raise IRQ on certain > error condi

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
> transmission failure as timeouts. Of course, if we're ticking the timer > while the command is not in flight, that's a bug. If there are cases > where 30 secs isn't enough, can you please point me to those reports? I have been, in bugzilla - the raid failure example where old IDE eventually re

Re: [PATCH] pdc2026x: remove surplus initialiser

2008-01-19 Thread Alan Cox
On Sat, 19 Jan 2008 19:54:03 +0300 Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Hello. > > Alan Cox wrote: > > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > > diff -u --new-file --recursive --exclude-from /usr/src/exclude > > linux.vanilla-

[PATCH] pdc2026x: remove surplus initialiser

2008-01-19 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc8-mm1/drivers/ide/pci/pdc202xx_old.c linux-2.6.24-rc8-mm1/drivers/ide/pci/pdc202xx_old.c --- linux.vanilla-2.6.24-rc8-mm1/drivers/ide/pci/pdc202xx_old.c 2008

[PATCH] pata_winbond: error return

2008-01-19 Thread Alan Cox
If no device is active return an error not zero. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc8-mm1/drivers/ata/pata_winbond.c linux-2.6.24-rc8-mm1/drivers/ata/pata_winbond.c --- linux.vanilla-2.6.24-r

[PATCH] pata_serverworks: Fix cable types and cosmetics

2008-01-19 Thread Alan Cox
Minor tidying up. Only real change is to return UNK not 80 wire when we don't know the cable type. This didn't use to matter but with Tejun's reworking of cable detection it may. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-

[PATCH] pata_mpc52xx: remove un-needed assignment

2008-01-19 Thread Alan Cox
ata_irq is always assigned so does not need to be initialised to zero. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc8-mm1/drivers/ata/pata_mpc52xx.c linux-2.6.24-rc8-mm1/drivers/ata/pata_mpc

pata_legacy: Merge winbond support

2008-01-19 Thread Alan Cox
This puts winbond VLB in with the other ISA/VLB support and means we can lose pata_winbond.c. With all the VLB/ISA probe in one space (and out of the core libata) this makes legacy probing work sanely. Also switch to devm_ for resource handling on the ports post probe Signed-off-by: Alan Cox

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-18 Thread Alan Cox
> >>+ /* udmatim Register */ > >>+ palm_bk3710_base->config.udmatim &= 0xFFF0; > >>+ palm_bk3710_base->config.udmatim |= level; > > > Direct memory access to I/O space - should be using read/write functions > > Sigh, I was anticipationg that somebody would say th

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-17 Thread Alan Cox
On Thu, 17 Jan 2008 21:50:56 +0300 Anton Salnikov <[EMAIL PROTECTED]> wrote: > This is Palmchip BK3710 IDE controller support for kernel version 2.6.24-rc8. > The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes. > Supports interface to compact Flash (CF) configured in True-IDE

Re: Delkin Cardbus IDE, a.k.a. ASKA "Ninja" chipset

2008-01-17 Thread Alan Cox
> I can confirm Mark's observation that the access speeds are slower - around > half the speed of the earlier Linux PIO driver, and a quarter the performance > of WinXP. Test CF card was a SanDisk UltraII as the target, with CB1410 > (Yenta compatible TI clone) as the host CB32 controller. > >

Re: [patch for 2.6.24? 1/1] libata: correct handling of TSS DVD

2008-01-15 Thread Alan Cox
On Tue, Jan 15, 2008 at 03:52:09PM -0500, Jeff Garzik wrote: > > { > >-if (ata_id_is_sata(dev_id)) > >-return 0; /* SATA */ > > if ((dev_id[93] & 0x2000) == 0x2000) > > return 0; /* 80 wire */ > > return 1; > > > Alan, is this .24 material? > > The

Re: ATA device reset, shoud I be concerned?

2008-01-15 Thread Alan Cox
> > [ 9031.028000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 > > frozen > > [ 9031.028000] ata1.00: cmd c8/00:08:90:ca:ce/00:00:00:00:00/e0 tag 0 cdb > > 0x0 > > data 4096 in > > [ 9031.028000] res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 > > (timeout) We got bore

Re: unable to use cdrom/dvd drive after some usage

2008-01-15 Thread Alan Cox
On Mon, 14 Jan 2008 20:46:08 -0800 Johnny Luong <[EMAIL PROTECTED]> wrote: > Hi, > > If possible, I would like to know if its worthwhile simply just to get another > SATA drive / different controller / cable rather than trying to figure out > this PATA drive on SATA/PATA controller... see attach

Re: Trouble with hdparm -d on Dell D610

2008-01-14 Thread Alan Cox
> In looking through my config file, I don't see "CONFIG_IDE_PIIX". > Below is a list of all the config entries that contain the patter > "PIIX": > CONFIG_BLK_DEV_PIIX=y > CONFIG_ATA_PIIX=y > CONFIG_PATA_MPIIX=y > CONFIG_PATA_OLDPIIX=y > > Any suggestions on how I may turn of the conflicting piix

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-13 Thread Alan Cox
> Yes, I concur for the short term. The other two possible courses of > action either involve long discussions (the different device one) or > you'll never quite be sure you got all the paths (the GFP_DMA32 one). > At least with this one, you know everything will work. The different device one is

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-13 Thread Alan Cox
> Other than that, I guess the solutions would be to just set a 32-bit > mask on the device if either port has an ATAPI device connected (which > is fairly ugly, considering that you could do things like hotplug an > ATAPI device when the other port was in use, for example), or do > something t

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-13 Thread Alan Cox
> $ hdparm --Istdin < hdparm.out > ATA device, with non-removable media > Model Number: Integrated Technology Express Inc > Serial Number: G! > Standards: > Likely used: 1 > Configuration: > Logical max current > cylinders 0

Re: Trouble with hdparm -d on Dell D610

2008-01-11 Thread Alan Cox
> I was talking to Kristin this morning about doing that. I was > concerned that there is not anybody certifying that each individual > disk drive model / firmware release is properly implementing the > Security Erase function. > > Are you aware of testing body, etc. that publishes a white-list o

Re: Trouble with hdparm -d on Dell D610

2008-01-11 Thread Alan Cox
> My concern with disabling the new drivers is as follows: I use this > linux kernel and config image to boot machines over PXE and call a > shred program on each of the harddrives. If I turn off CONFIG_ATA, > will this limit my ability to support various new IDE and SATA drives > for running shre

Re: Trouble with hdparm -d on Dell D610

2008-01-11 Thread Alan Cox
Thanks. You do indeed have both the old IDE and new IDE drivers trying to drive bits of the system. I don't see the CD-ROM in the dmesg at all however ? If you turn off CONFIG_ATA you should get just old IDE drivers and your disk back working sanely. Alan - To unsubscribe from this list: send the

Re: Trouble with hdparm -d on Dell D610

2008-01-11 Thread Alan Cox
On Fri, 11 Jan 2008 14:49:46 -0500 "Kristin Vadas Marsicano" <[EMAIL PROTECTED]> wrote: > Both laptops have IDE drives. The kernel image booted on the two > laptops are exactly the same. Please let me know if this doesn't > answer your question -- I'm new to this and not quite sure I > understan

Re: Trouble with hdparm -d on Dell D610

2008-01-11 Thread Alan Cox
> I have the same kernel and configuration on my Dell D600 (an older > version of the same laptop), and hdparm –d works just fine. We you using the IDE driver for PATA devices and the SATA driver for SATA devices ? If so the really nasty hacks for that were dropped as current libata PATA support i

Re: sata_nv does not function in kernel > 2.6.20.21

2008-01-11 Thread Alan Cox
> Error -16 is EBUSY, which causes the driver load to fail due to the > "Unable to reserve mem region" message. > > This means that the sata_nv driver needed to use PCI BAR 6, but was > unable to for some reason. Given that sata_nv uses devres like other > libata drivers, IMO the likely cause

Re: 40-wire cable detected when directly connected

2008-01-11 Thread Alan Cox
> I don't know very well about CF but does it even fill UDMA/33? What > does 'dd if=/dev/sdc of=/dev/null bs=1M count=16 iflag=direct' say? You > can increase count for more reliable result. Some CF hardware can manage UDMA33, almost no adapters and cable convertors can however. I don't know if

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Alan Cox
On Wed, 9 Jan 2008 17:16:35 + Alan Cox <[EMAIL PROTECTED]> wrote: > > trying to fix it for some time now && finally got a machine with > > pata_ali and non-working MWDMA2 ATAPI device on my desk a few weeks ago. > > Oh good. I've been through a pile of

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Alan Cox
> trying to fix it for some time now && finally got a machine with > pata_ali and non-working MWDMA2 ATAPI device on my desk a few weeks ago. Oh good. I've been through a pile of ones that just work. Which North and south does it have and what revision ? > I walked through IDE and libata codes a

Re: [PATCH #upstream-fixes] libata: implement libata.force_cbl parameter

2008-01-08 Thread Alan Cox
> > In which case we only need to be able to force UDMA33 or less ? > > Cable detection goes wrong and 40c is detected as 80c. However, we got In which case we only (see first question). I don't see why we need to force anything but "max speed UDMA 33" - To unsubscribe from this list: send the l

Re: [PATCH #upstream-fixes] libata: implement libata.force_cbl parameter

2008-01-08 Thread Alan Cox
> This only forces PATA controllers to certain cable type. It's a last > resort method for installation or live media - just enough to get things > going. In which case we only need to be able to force UDMA33 or less ? - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the

  1   2   3   4   5   6   7   8   9   10   >