PREEMPT bug? (was: Re: [PROBLEM]: hdparm strange behaviour for 2.6.21 and later)

2007-06-27 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 24 June 2007, Thanos Kyritsis wrote: On Saturday 23 June 2007, Bartlomiej Zolnierkiewicz wrote: Hi, Hello, thanks for answering :-D Also could you try running UP kernel without PREEMPT and see if it makes difference? Yes, it did make a difference. I've just tried

Re: [PATCH 5/6] ide: add ata_dev_has_iordy() helper

2007-06-27 Thread Bartlomiej Zolnierkiewicz
On Wednesday 27 June 2007, Sergei Shtylyov wrote: Set Transfer Mode subcode of the Set Features command, you're always selecting the flow control mode, i.e. using IORDY. So, the last condition in this if So, what actually would need fixing in *all* the drivers if one was aiming

[PATCH 4/6] ide: make ide_get_best_pio_mode() print info if overriding PIO mode

2007-06-23 Thread Bartlomiej Zolnierkiewicz
* Print info about overriding PIO mode in ide_get_best_pio_mode(). * Remove info about overriding PIO mode from cmd64{0,x} host drivers. * Remove no longer needed ide_pio_data_t.overridden field. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c| 10

[PATCH 2/6] atiixp: PIO mode setup fixes

2007-06-23 Thread Bartlomiej Zolnierkiewicz
doesn't get remapped to PIO0 - use atiixp_tuneproc() instead of atiixp_speedproc() * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/atiixp.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) Index: b

Re: [PATCH] ide: Stop mapping ROMs

2007-06-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 22 June 2007, Sergei Shtylyov wrote: Hello. Alan Cox wrote: Various old IDE drivers go mapping ROM devices for no apparent reason and without using the ROM mapping API we now have. They don't actually use Hm, do you mean the sysfs based aproach? I've tried that and

[PATCH 6/6] ide: add ide_pci_device_t.host_flags

2007-06-23 Thread Bartlomiej Zolnierkiewicz
ide_pci_device_t.channels field. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |5 - drivers/ide/pci/alim15x3.c |1 - drivers/ide/pci/amd74xx.c |2 -- drivers/ide/pci/atiixp.c |3 +-- drivers/ide/pci/cmd64x.c |4 drivers

Re: [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide

2007-06-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 22 June 2007, Alan Cox wrote: I think a /sys/ dma attribute (pick a name) might be most appropriate, or we just just implement HDIO_[GS]ET_DMA as a simpler/lazier mechanism. The problem is that libata lacks any locking needed for having this (and other useful) settings

Re: SATA RAID5 speed drop of 100 MB/s

2007-06-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 23 June 2007, Carlo Wood wrote: PS I'd like to do extensive testing with Bonnie++ to tune everything there is to tune. But bonnie likes to write/read files TWICE the amount of RAM I have. It therefore takes a LOT of time to run one test. Do you happen to know how I can limit

[PATCH 3/6] siimage: PIO mode setup fixes

2007-06-23 Thread Bartlomiej Zolnierkiewicz
of PIO4 (config_siimage_chipset_for_pio() used wrong arguments for ide_get_best_pio_mode() and as a results always tried to set PIO4). * Remove no longer needed siimage_taskfile_timing() and config_siimage_chipset_for_pio(). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH] ide: Fix a theoretical Ooops case

2007-06-23 Thread Bartlomiej Zolnierkiewicz
On Friday 22 June 2007, Alan Cox wrote: Found by a static analyser. It is in theory possible we dereference dev-id when it has become invalid. Re-order to avoid this. Not needed for new-ide as we no longer support the crazy exabyte nest stuff Signed-off-by: Alan Cox [EMAIL PROTECTED]

Re: [PATCH] ide: Stop mapping ROMs

2007-06-23 Thread Bartlomiej Zolnierkiewicz
On Friday 22 June 2007, Alan Cox wrote: Various old IDE drivers go mapping ROM devices for no apparent reason and without using the ROM mapping API we now have. They don't actually use the ROM they map and the new libata drivers are happy without it being mapped so rather than port them lets

[PATCH 1/6] qd65xx: fix PIO mode selection

2007-06-23 Thread Bartlomiej Zolnierkiewicz
PIO4 is a maximum PIO mode supported by a driver. Using 255 as a max_mode argument to ide_get_best_pio_mode() could result in wrong timings being used by a driver (for pio equal to 5) or OOPS (for pio values 5 255). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 5/6] ide: add ata_dev_has_iordy() helper

2007-06-23 Thread Bartlomiej Zolnierkiewicz
* Add ata_dev_has_iordy() helper. * Use it in sl82c105 host driver so it always gets the correct info (use_iordy was incorrectly set for pio != 255 cases). * Remove no longer needed ide_pio_data_t.use_iordy field. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

Re: [PROBLEM]: hdparm strange behaviour for 2.6.21 and later

2007-06-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 20 June 2007, Thanos Kyritsis wrote: On Monday 18 June 2007, Mark Lord wrote: Thanos Kyritsis wrote: [snip] /etc/rc.d/rc.local contains the following: /usr/sbin/hdparm -q -d1 -q -u1 -q -c1 -q -k1 /dev/hda /usr/sbin/hdparm -q -d1 -q -u1 -q -c1 -q -k1 /dev/hdb [snip]

Re: [PATCH 1/6] qd65xx: fix PIO mode selection

2007-06-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 23 June 2007, Alan Cox wrote: Possibly we should just drop support as I know of only one user and thats purely to test the code Fine with me, please send a patch. PS Added yours Reviewed-by: to this patch as I still need to push it (I have other patches in the queue depending on

Re: [PATCH 5/6] ide: add ata_dev_has_iordy() helper

2007-06-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 23 June 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: This one is actually arguable... * Add ata_dev_has_iordy() helper. I thought IDE subsys make use of only 'ide_' prefixes. :-) Nope, see ide-probe.c. ;-) * Use it in sl82c105 host driver so

Re: [PATCH 6/6] ide: add ide_pci_device_t.host_flags

2007-06-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 23 June 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename ide_pci_device_t.flags to ide_pci_device_t.host_flags and IDEPCI_FLAG_ISA_PORTS flag to IDE_HFLAG_ISA_PORTS. Erm, do you intend also adding device_flags field? :-O ;-) maybe 8) * Add

Re: [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide

2007-06-22 Thread Bartlomiej Zolnierkiewicz
On Friday 22 June 2007, Mark Lord wrote: Alan Cox wrote: On Fri, 22 Jun 2007 11:01:09 -0400 Mark Lord [EMAIL PROTECTED] wrote: Alan Cox wrote: Allow libata.pata_dma=0 to disable DMA (default is 1) SATA is unaffected as disabling DMA for SATA makes no sense at all.

Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible

2007-06-21 Thread Bartlomiej Zolnierkiewicz
Hi Sergei, On Thursday 21 June 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: use PIO/MMIO operations directly where possible This results in smaller/faster/simpler code and allows future optimizations. Also remove no longer needed ide[_mm]_{inl

Re: [PATCH 1/5] ide: add short cables support

2007-06-21 Thread Bartlomiej Zolnierkiewicz
On Sunday 17 June 2007, Sergei Shtylyov wrote: [ ... ] Index: b/drivers/ide/pci/alim15x3.c === --- a/drivers/ide/pci/alim15x3.c +++ b/drivers/ide/pci/alim15x3.c @@ -594,7 +594,7 @@ out: *FIXME: frobs bits that are

Re: [BUG] ide dma_timer_expiry, then hard lockup

2007-06-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 19 June 2007, Linas Vepstas wrote: On Tue, Jun 19, 2007 at 08:10:25PM +0400, Sergei Shtylyov wrote: I'm thinking that trying to debug libata is a better idea, rather than investing time in ide, right? Although at the moment, libata works even less; see other email.

Re: [PATCH] HPA Detect From Resume

2007-06-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 05 June 2007, Lee Trager wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 12 May 2007, Lee Trager wrote: Currently when system which have HPA require HPA to be detected and disabled upon resume from RAM or disk. The current IDE drivers do not do this nor

Re: [PATCH] ide: convert ide_find_best_mode() users to use ide_max_dma_mode()

2007-06-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 12 June 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Index: b/drivers/ide/mips/au1xxx-ide.c === --- a/drivers/ide/mips/au1xxx-ide.c +++ b/drivers/ide/mips/au1xxx-ide.c @@ -381,9 +381,7

Re: [PATCH 1/3] Make the IDE DMA timeout modifiable

2007-06-15 Thread Bartlomiej Zolnierkiewicz
On Tuesday 12 June 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: On Feb 20, 2007, at 5:44 PM, Bartlomiej Zolnierkiewicz wrote: On Wednesday 21 February 2007 02:19, Suleiman Souhlal wrote: It can be changed via /proc/ide/hd?/settings. Why do we need to change IDE DMA

Re: [-mm patch] drivers/ide/ide-dma.c: unexport ide_set_dma

2007-06-15 Thread Bartlomiej Zolnierkiewicz
On Friday 15 June 2007, Adrian Bunk wrote: ide_set_dma no longer has any modular user. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

[git patches] IDE fixes

2007-06-15 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide.c |9 ++--- drivers/scsi/ide-scsi.c |2 +- 2 files changed, 7 insertions(+), 4 deletions(-) Bartlomiej Zolnierkiewicz (1): ide-scsi: fix

[PATCH] pata_it821x: (partially) fix DMA in RAID mode

2007-06-11 Thread Bartlomiej Zolnierkiewicz
check completely. Thanks to Pavol Simo for the bugreport and testing the initial fix. This change unfortunately still doesn't fix DMA in RAID mode (which works fine with IDE it821x) but Alan is working on the missing pieces (pata_it821x vs libata EH issues). Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 1/5] ide: add short cables support

2007-06-10 Thread Bartlomiej Zolnierkiewicz
parameter. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c|2 +- drivers/ide/ide-iops.c |8 ++-- drivers/ide/ide.c |9 +++-- drivers/ide/pci/aec62xx.c |5 +++-- drivers/ide/pci/alim15x3.c |9

[PATCH 3/5] alim15x3: backport short cables support from pata_ali.c

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Backport short cables support from pata_ali.c and while at it cleanup existing cable detection code. This patch should allow UDMA 2 modes on HP Pavilion N5430 and Fujitsu P2000. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c | 73

[PATCH 4/5] sis5513: backport short cables support from pata_sis.c

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Backport short cables support from pata_sis.c. This patch should allow UDMA 2 modes on ASUS A6K. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sis5513.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci

[PATCH 5/5] via82cxxx: backport short cables support from pata_via.c

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Backport short cables support from pata_via.c. This patch should allow UDMA 2 modes on Acer Ferrari 3400. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/via82cxxx.c | 48 +--- 1 file changed, 41 insertions(+), 7

Re: [PATCH] pata_it821x: sync with IDE it821x driver

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Hi Alan! On Sunday 10 June 2007, Alan Cox wrote: @@ -258,8 +259,14 @@ static void it821x_passthru_set_piomode( static const u8 pio_want[]= { ATA_66, ATA_66, ATA_66, ATA_66, ATA_ANY }; struct it821x_dev *itdev = ap-private_data; + struct ata_device *pair =

[PATCH] pata_it821x: (partially) fix DMA in RAID mode

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ata/pata_it821x.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) Index: b/drivers/ata/pata_it821x.c === --- a/drivers

Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI

2007-06-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 June 2007, Alan Cox wrote: On Sun, 10 Jun 2007 14:52:36 +0900 Tejun Heo [EMAIL PROTECTED] wrote: IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if asked to configure itself to MWDMA0. Force PIO. This is only really a temporary fix. It appears to manage

Re: [2/3] 2.6.22-rc4: known regressions v2

2007-06-09 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 June 2007, Michal Piotrowski wrote: IDE Subject: libata and legacy ide pcmcia failure References : http://lkml.org/lkml/2007/5/17/305 Submitter : Robert de Rooy [EMAIL PROTECTED] Handled-By : Mark Lord [EMAIL PROTECTED] Status : problem is being debugged Not a

Re: [PATCH] pata_it821x: sync with IDE it821x driver

2007-06-09 Thread Bartlomiej Zolnierkiewicz
Hello, On Saturday 09 June 2007, Tejun Heo wrote: Hello, Bartlomiej Zolnierkiewicz wrote: * (partially) fix DMA in RAID mode Code intended to check DMA status was checking DMA command register. Moreover firmware seems to forget to set DMA capable bit for the slave device

[PATCH] ide: fix pre-EIDE SWDMA support

2007-06-09 Thread Bartlomiej Zolnierkiewicz
If the word 62 is not defined use the word 52 to get SWDMA mask in ide_get_mode_mask(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-dma.c

[PATCH] ide: convert ide_find_best_mode() users to use ide_max_dma_mode()

2007-06-09 Thread Bartlomiej Zolnierkiewicz
of ide_find_best_mode() There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-timing.h | 56 - drivers/ide/mips/au1xxx-ide.c |7 -- drivers/ide/pci/amd74xx.c | 118

[git patches] IDE fixes

2007-06-08 Thread Bartlomiej Zolnierkiewicz
|1 + include/linux/pci_ids.h |2 + 10 files changed, 115 insertions(+), 63 deletions(-) Bartlomiej Zolnierkiewicz (3): serverworks: remove crappy code serverworks: fix CSB6 tuning logic it821x: RAID mode fixes Jiri Slaby (1): ide: generic IDE PCI driver, add

Re: [PATCH pata-2.6 fix] hpt366: disallow Ultra133 for HPT374

2007-06-08 Thread Bartlomiej Zolnierkiewicz
On Wednesday 06 June 2007, Sergei Shtylyov wrote: Eliminate UltraATA/133 support for HPT374 -- the chip isn't capable of this mode according to the manual, and doesn't even seem to tolerate 66 MHz DPLL clock... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe

Re: [PATCH] Replace C code with call to ARRAY_SIZE() macro.

2007-06-08 Thread Bartlomiej Zolnierkiewicz
On Sunday 03 June 2007, Robert P. J. Day wrote: Delete the unnecessary macro ARY_LEN and use ARRAY_SIZE directly. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 3/2] serverworks: always tune CSB6

2007-06-08 Thread Bartlomiej Zolnierkiewicz
On Monday 04 June 2007, Alan Cox wrote: Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Looks good to me - and I can confirm no libata problem reports from us always setting modes ourselves. Thanks for review, added your ACK to the patch

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-08 Thread Bartlomiej Zolnierkiewicz
On Tuesday 05 June 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: The log of a typical IDE reset is available here: http://petra.hos.u-szeged.hu/~wildy/syslog.gz This was the worst case: the IDE bus was resetted during the system boot. Could you try

Re: [PATCH pata-2.6] hpt366: simplify UltraDMA filtering (take 3)

2007-06-08 Thread Bartlomiej Zolnierkiewicz
-off-by: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- This patch is against the top of the pata-2.6. I had to change it a bit due to a fixes going in ahead. Tested on HPT370, will try to test on HPT371N later... applied - To unsubscribe from

Re: [PATCH 1/1] ide: ide-generic, add another device exception

2007-06-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 08 June 2007, Jeff Garzik wrote: On Fri, Jun 08, 2007 at 02:18:55PM +0200, Bartlomiej Zolnierkiewicz wrote: On Monday 04 June 2007, Jiri Slaby wrote: ide-generic, add another device exception ide-generic is a generic ISA IDE driver, this one is drivers/ide/pci/generic

Re: [PATCH 1/1] ide: ide-generic, add another device exception

2007-06-08 Thread Bartlomiej Zolnierkiewicz
On Friday 08 June 2007, Alan Cox wrote: On Fri, 8 Jun 2007 14:18:55 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Monday 04 June 2007, Jiri Slaby wrote: ide-generic, add another device exception ide-generic is a generic ISA IDE driver, this one is drivers/ide/pci

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-04 Thread Bartlomiej Zolnierkiewicz
Hello, On Sunday 03 June 2007, Sergei Shtylyov wrote: Geller Sandor wrote: Hello. The log of a typical IDE reset is available here: http://petra.hos.u-szeged.hu/~wildy/syslog.gz This was the worst case: the IDE bus was resetted during the system boot. Could you try setting

[PATCH 3/2] serverworks: always tune CSB6

2007-06-03 Thread Bartlomiej Zolnierkiewicz
to read PIO/MWDMA timings now so don't do it. Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c | 77 +- 1 file changed, 2 insertions(+), 75 deletions(-) Index: b/drivers/ide/pci

[PATCH 2/2] serverworks: fix CSB6 tuning logic

2007-06-02 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) Index: b/drivers/ide/pci/serverworks.c

[PATCH 1/2] serverworks: remove crappy code

2007-06-02 Thread Bartlomiej Zolnierkiewicz
Remove crappy code noticed by Linus, see http://lkml.org/lkml/2007/5/23/476 for details. While at it simplify logic a bit. There should be no functionality changes caused by this patch. Cc: Linus Torvalds [EMAIL PROTECTED] Cc: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Bartlomiej

[PATCH] it821x: RAID mode fixes

2007-06-02 Thread Bartlomiej Zolnierkiewicz
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 12 ++-- drivers/ide/pci/it821x.c | 34 ++ 2 files changed, 24 insertions(+), 22 deletions(-) Index: b/drivers/ide/ide-probe.c

Re: [PATCH 3/3] Make ide dma blacklist handling a bit saner.

2007-05-30 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 29 May 2007, Junio C Hamano wrote: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] writes: The change itself looks good but IMO it is worth doing it before patch #2/3 (it would also make it possible for me to merge this patch immediately). Yes, I should have considered

Re: [PATCH 1/3] ide_in_drive_list(): accept NULL as the wildcard for firmware revision.

2007-05-30 Thread Bartlomiej Zolnierkiewicz
On Tuesday 29 May 2007, Junio C Hamano wrote: Earlier, the matching of (model,rev) in ide-dma black/white list handling was to consider ALL in the table to match any revision. This makes NULL to be also an accepted wildcard, and changes the entries of tables in ide-dma.c to use NULL. The

Re: [PATCH 2/3] mips au1xxx_ide.h: use NULL as firmware-revision wildcard.

2007-05-30 Thread Bartlomiej Zolnierkiewicz
On Tuesday 29 May 2007, Junio C Hamano wrote: This updates the DMA whitelist in MIPS specific au1xxx ide driver to use NULL instead of ALL as the wildcard. Signed-off-by: Junio C Hamano [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCH 3/3] ide_in_drive_list(): ALL is not a wildcard anymore.

2007-05-30 Thread Bartlomiej Zolnierkiewicz
On Tuesday 29 May 2007, Junio C Hamano wrote: This removes the support to treat ALL as a wildcard for firmware revision. This is made a separate patch, as it will break out-of-tree ide drivers that feed its own table that uses ALL as the wildcard to ide_in_drive_list(). Signed-off-by:

Re: Compact Flash performance...

2007-05-30 Thread Bartlomiej Zolnierkiewicz
Hi, Since you are using libata ata_piix driver and not IDE piix one Jeff and/or Alan are the right people to ask this question... Anyway... On Thursday 31 May 2007, Daniel J Blueman wrote: I have a SanDisk Extreme IV 4GB CF card, capable of 40MB/s read, but am seeing 30MB/s read [1],

Re: [PATCH 3/3] Make ide dma blacklist handling a bit saner.

2007-05-28 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 22 May 2007, Junio C Hamano wrote: Earlier, the matching of (model,rev) in ide-dma black/white list handling was to consider ALL in the table to match any revision. This changes the wildcard to NULL. This way, the DMA_BLACK_LIST macro used in the previous patch does not have

Re: [patch] Add the device IDs for AMD/ATI SB700

2007-05-28 Thread Bartlomiej Zolnierkiewicz
Hi, Sorry for the late reply and thanks to Jeff for stepping in. :) Since Jeff covered both status of your patches and administrative issues I would only like to add one small hint for people adding support for multi-function PCI chipsets (with multiple PCI device IDs): It makes sense to put

Re: [PATCH pata-2.6] aec62xx: kill speedproc() method wrapper (take 2)

2007-05-28 Thread Bartlomiej Zolnierkiewicz
On Thursday 24 May 2007, Sergei Shtylyov wrote: There's no reason to have the speedproc() method wrapper for the two quite different chip families, so just get rid of it. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Tthis version of the patch properly installs the speedproc()

Re: HPT366 not enabled by kernel 2.6.21.2

2007-05-24 Thread Bartlomiej Zolnierkiewicz
[ adding linux-ide ML and Sergei to cc: ] Hi, On Thursday 24 May 2007, Pascal Schmidt wrote: Hello! I recently upgraded my kernel to 2.6.21 (.1 and .2 with identical results) and my second IDE controller, a HPT366 on a PCI card, doesn't get enabled any more. The latest previous kernel I

Re: [PATCH pata-2.6 fix queue] aec62xx: kill speedproc() method wrapper

2007-05-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 16 May 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: There's no reason to have the speedproc() method wrapper for the two quite different chip families, so just get rid of it. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied I

Re: [PATCH] ide/pci/serverworks.c: Fix corruption/timeouts with MegaIDE in RAID mode

2007-05-23 Thread Bartlomiej Zolnierkiewicz
On Wednesday 16 May 2007, Alan Cox wrote: It turns out from customer reports to Red Hat and some PCI dumps that the MegaIDE in RAID mode doesn't provide the drive tuning data that the serverworks driver expects but sometimes does provide something that fools the code. For the RAID class

Re: 2.6.22-rc1-mm1: IDE compile error

2007-05-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 16 May 2007, Adrian Bunk wrote: On Tue, May 15, 2007 at 08:19:14PM -0700, Andrew Morton wrote: ... - Added an i386 early-startup development tree, as git-newsetup.patch (H. Peter Anvin [EMAIL PROTECTED]) ... Changes since 2.6.21-mm2: ... git-newsetup.patch ...

Re: [PATCH] Match DMA blacklist entries between ide-dma.c and libata-core.c

2007-05-23 Thread Bartlomiej Zolnierkiewicz
On Tuesday 22 May 2007, Junio C Hamano wrote: There are a few entries in ata_device_blacklist[] in libata-core.c marked with HORKAGE_NODMA but are missing from drive_blacklist[] in ide-dma.c. This patch makes the lists in sync. Also remove a duplicated entry for SanDisk SDP3B-64.

Re: Add Seagate STT20000A to DMA blacklist.

2007-05-23 Thread Bartlomiej Zolnierkiewicz
On Monday 21 May 2007, Dave Jones wrote: http://bugzilla.kernel.org/show_bug.cgi?id=1044 has been open for _four_ years with a patch available. Here's a rediffed version of the same. Signed-off-by: Dave Jones [EMAIL PROTECTED] Uh, it seems that this fix got stuck in the kernel black hole

Re: [PATCH] Add two missing chipsets to drivers/ide/ide-proc.c

2007-05-23 Thread Bartlomiej Zolnierkiewicz
On Friday 18 May 2007, Mika Kukkonen wrote: Compiling with '-Wswitch-enum' I noticed following: CC drivers/ide/ide-proc.o drivers/ide/ide-proc.c: In function ‘proc_ide_read_imodel’: drivers/ide/ide-proc.c:54: warning: enumeration value ‘ide_etrax100’ not handled in switch

[git patches] IDE fixes

2007-05-23 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide-dma.c |4 +++- drivers/ide/ide-proc.c|2 ++ drivers/ide/pci/atiixp.c |1 + drivers/ide/pci/serverworks.c | 14 ++

Re: IT821x: no DMA since 2.6.21

2007-05-16 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 16 May 2007, Thomas Kuther wrote: On Mi, 16.05.07 02:58 Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday 15 May 2007, Alan Cox wrote: On Tue, 15 May 2007 12:53:08 +0200 Thomas Kuther [EMAIL PROTECTED] wrote: Hi! Since 2.6.21 I have a problem

Re: [git patches] IDE updates/fixes

2007-05-16 Thread Bartlomiej Zolnierkiewicz
On Wednesday 16 May 2007, Linus Torvalds wrote: On Wed, 16 May 2007, Bartlomiej Zolnierkiewicz wrote: * host driver fixes: - pdc202xx_old: mode programming rewrite (a lot of bugs fixed) - serverworks/sis5513: PIO mode setup fixes - sl82c105: MWDMA0/1 support by Sergei

Re: [PATCH pata-2.6 fix queue] cmd64x: init. code cleanup

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Thursday 10 May 2007, Sergei Shtylyov wrote: Fix two minor issues with PCI0646 chip reporting in the init_chipset() method: IRQ workaround enabled message printed out not only for revision 0x01 and CMD646: chipset revision printed twice (by IDE core and the driver itself). Also, remove

Re: [patch 1/2] sl82c105: Switch to ref counting API

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, [EMAIL PROTECTED] wrote: From: Alan Cox [EMAIL PROTECTED] Not sure how this one got missed in the great purge some time ago but it did. Signed-off-by: Alan Cox [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED]

Re: [patch 2/2] Use menuconfig objects: IDE

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, [EMAIL PROTECTED] wrote: From: Jan Engelhardt [EMAIL PROTECTED] Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] Cc: Bartlomiej Zolnierkiewicz [EMAIL

Re: [PATCH pata-2.6 fix queue] aec62xx: rework init_setup_aec6x80()

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, Sergei Shtylyov wrote: Rework init_setup_aec6x80() so that it won't rewrite the constant name strings anymore -- in order to do this: - in aec62xx_init_one(), pass a local copy of 'struct pci_device_id' down the call chain; - change the names for in

Re: [PATCH pata-2.6 fix queue] aec62xx: kill speedproc() method wrapper

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, Sergei Shtylyov wrote: There's no reason to have the speedproc() method wrapper for the two quite different chip families, so just get rid of it. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/5] Use mutex instead of semaphore in IDE driver

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Monday 14 May 2007, Matthias Kaehlcke wrote: The IDE driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] applied Since I already had a patch from you with identical patch summary/description (but for

Re: [PATCH]add the IDE device ID for ATI SB700

2007-05-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 14 May 2007, gmail_ati wrote: From: [EMAIL PROTECTED] add the IDE device ids to atiixp_pci_tbl struct in atiixp.c for ATI SB700. Signed-off-by: Luugi Marsan [EMAIL PROTECTED] This patch is somehow missing the chunk adding PCI_DEVICE_ID_ATI_IXP700_IDE define to linux/pci_ids.h

[git patches] IDE updates/fixes

2007-05-15 Thread Bartlomiej Zolnierkiewicz
. - * * Copyright (C) 2000 Mark Lord [EMAIL PROTECTED] + * Copyright (C) 2007 Bartlomiej Zolnierkiewicz + * * May be copied or modified under the terms of the GNU General Public License * * Development of this chipset driver was funded @@ -62,6 +62,14 @@ static

Re: IT821x: no DMA since 2.6.21

2007-05-15 Thread Bartlomiej Zolnierkiewicz
, but the problem persists. I've had multiple reports of this. I would recommend you use the libata driver. IT821x hasn't changed over the past few releases so its someting commit 0e9b4e535fec7e2a189952670937adfbe2826b63 Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Date: Sat May 5 22:03:50 2007

[git patches] IDE update

2007-05-09 Thread Bartlomiej Zolnierkiewicz
/scsi/ide-scsi.c| 30 ++- include/linux/ide.h| 93 + 63 files changed, 1107 insertions(+), 1464 deletions(-) Bartlomiej Zolnierkiewicz (11): ide: fix UDMA/MWDMA/SWDMA masks (v3) ide: rework the code for selecting the best DMA transfer mode (v3) ide

Re: [PATCH pata-2.6] hpt366: simplify UltraDMA filtering (take 2)

2007-05-07 Thread Bartlomiej Zolnierkiewicz
On Sunday 06 May 2007, Sergei Shtylyov wrote: Hello, I wrote: Simplify UltraDMA mode filtering in the driver: - make use of the newly introduced 'udma_mask' field of 'ide_pci_device_t' to set the correct hwif-ultra_mask, modifying init_setup_hpt366() to select the correct mask

Re: [PATCH 1/2 pata-2.6] ide: make void and rename ide_dma_lostirq() method

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Tuesday 24 April 2007, Sergei Shtylyov wrote: Since ide_dma_lostirq() method's result is discarded, make it return 'void'. While at it, rename the method to dma_lost_irq(), drop the '__' prefix from the default method's name, and do some cleanups in this method driver-wise: - in

Re: [PATCH 2/2 pata-2.6] ide: make void and rename ide_dma_timeout() method

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Tuesday 24 April 2007, Sergei Shtylyov wrote: Since ide_dma_timeout() method's result is discarded, make it return 'void'. While at it, drop 'ide_' from the method's name, drop the '__' prefix from the default method's name, and do some cleanups in this method driver-wise: - in

Re: [PATCH] use mutex instead of semaphore in IDE driver

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Thursday 26 April 2007, Matthias Kaehlcke wrote: the IDE driver uses a semaphore as mutex. use the mutex API instead of the (binary) semaphore Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: [PATCH pata-2.6] hpt366: simplify UltraDMA filtering

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Monday 30 April 2007, Sergei Shtylyov wrote: Simplify UltraDMA mode filtering in the driver: - make use of the newly introduced 'udma_mask' field of 'ide_pci_device_t' to set the correct hwif-ultra_mask, modifying init_setup_hpt366() to select the correct mask based on the chip

Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Friday 04 May 2007, Sergei Shtylyov wrote: HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

[git patches] IDE updates

2007-05-05 Thread Bartlomiej Zolnierkiewicz
/sl82c105.c | 247 --- include/linux/ide.h|1 - 11 files changed, 459 insertions(+), 513 deletions(-) Bartlomiej Zolnierkiewicz (5): alim15x3: PIO fallback fix pdc202xx_new: enable DMA for all ATAPI devices it821x: PIO mode setup fixes siimage

Re: [PATCH pata-2.6] hpt366: simplify UltraDMA filtering (take 2)

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Saturday 05 May 2007, Sergei Shtylyov wrote: Simplify UltraDMA mode filtering in the driver: - make use of the newly introduced 'udma_mask' field of 'ide_pci_device_t' to set the correct hwif-ultra_mask, modifying init_setup_hpt366() to select the correct mask based on the chip

Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Saturday 05 May 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied I'm getting 403 Forbidden

Re: 2.6.20 libata cdrom

2007-05-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 01 May 2007, William Thompson wrote: On Tue, May 01, 2007 at 09:04:46AM -0400, Mark Lord wrote: William Thompson wrote: +scsi2 : ata_piix +ata_port_schedule_eh: port EH scheduled +ata_scsi_error: ENTER +ata_port_flush_task: ENTER +ata_port_flush_task: flush #1

[git patch] IDE fix for 2.6.21-final (Revert adjust legacy IDE resource setting (v2))

2007-04-23 Thread Bartlomiej Zolnierkiewicz
Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Date: Mon Apr 23 23:19:36 2007 +0200 Revert adjust legacy IDE resource setting (v2) This reverts commit ed8ccee0918ad063a4741c0656fda783e02df627. It causes hang on boot for some users and we don't yet know why: http

Re: [PATCH pata-2.6] cmd64x: interrupt status fixes (take 2)

2007-04-23 Thread Bartlomiej Zolnierkiewicz
bits are not coupled to DMA. In addition, wrong interrupt bit was tested/cleared for the primary channel -- it's bit 2 in all the chip specs and the driver used bit 1... :-/ Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

Re: [PATCH pata-2.6] cmd64x: add/fix enablebits (take 2)

2007-04-23 Thread Bartlomiej Zolnierkiewicz
/disabled -- so, add 'enablebits' initializers to each 'ide_pci_device_t' structure, handling the original PCI0646 via adding the init_setup() method and clearing the 'reg' field there if necessary... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH pata-2.6] cmd64x: procfs code fixes/cleanups (take 2)

2007-04-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 April 2007, Sergei Shtylyov wrote: Fix several issues with the driver's procfs output: - when testing if channel is enabled, the code looks at the simplex bits, not at the real enable bits -- add #define for the primary channel enable bit; - UltraDMA modes 0, 1, 3 for

Re: [PATCH pata-2.6] cmd64x: use interrupt status from MRDMODE register (take 2)

2007-04-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 April 2007, Sergei Shtylyov wrote: Fold the parts of the ide_dma_end() methods identical to __ide_dma_end() into a mere call to it. Start using faster versions of the ide_dma_end() and ide_dma_test_irq() methods for the PCI0646U and newer chips that have the duplicate

Re: [PATCH pata-2.6 fix queue] aec62xx: fix PIO/DMA setup issues

2007-04-23 Thread Bartlomiej Zolnierkiewicz
On Sunday 22 April 2007, Sergei Shtylyov wrote: Teach the driver's tuneproc() method to do PIO auto-runing properly since it treated 5 instead of 255 as auto-tune request, and also passed the mode limit of PIO5 to ide_get_best_pio_mode() despite supporting up to PIO4 only. While at it, also:

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 20 April 2007, Sergei Shtylyov wrote: Hello, I wrote: Index: b/drivers/ide/pci/hpt366.c === --- a/drivers/ide/pci/hpt366.c +++ b/drivers/ide/pci/hpt366.c @@ -513,43 +513,31 @@ static int

Re: [PATCHSET] libata: improve ATA ACPI support

2007-04-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 24 April 2007, Mark Lord wrote: Tejun Heo wrote: of the time. I think HDIO_GET_IDENTITY's meaning is something like give me IDENTIFY page of the device as seen by the driver and doesn't really matter as long as it can be used to get general idea about the device.

Re: PATCH: ide/pci/delkin_cb.c add new PCI ID

2007-04-20 Thread Bartlomiej Zolnierkiewicz
On Sunday 15 April 2007, Mark Lord wrote: Add PCI ID for a newer variant of cardbus CF/IDE adapter card. Patch is against 2.6.21-rc*. Signed-off-by: Mark Lord [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH pata-2.6 fix queue] hpt366: fix kernel oops with HPT302N

2007-04-20 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 April 2007, Sergei Shtylyov wrote: The driver crashes the kernel on HPT302N chips due to the missing initializer for 'hpt302n.settings' having been unfortunately overlooked so far. :- Much thanks to Mike Mattie for pin-pointing the reason of crash. Signed-off-by: Sergei

[git patches] IDE fixes

2007-04-20 Thread Bartlomiej Zolnierkiewicz
insertions(+), 2 deletions(-) Bartlomiej Zolnierkiewicz (1): ide/Kconfig: add missing range check for IDE_MAX_HWIFS Mark Lord (1): ide/pci/delkin_cb.c: add new PCI ID Sergei Shtylyov (1): hpt366: fix kernel oops with HPT302N diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig

<    6   7   8   9   10   11   12   13   14   >