[PATCH 45/63] ide-cd: remove BUG_ON() from cdrom_newpc_intr()

2007-12-19 Thread Bartlomiej Zolnierkiewicz
There is no need for it anylonger and ide_set_handler() complains if -handler is not NULL anyway. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 43/63] ide-cd: rename cdrom_* functions to ide_cd_*

2007-12-19 Thread Bartlomiej Zolnierkiewicz
-cd.c. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 83 +++ 1 file changed, 44 insertions(+), 39 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

2007-12-19 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c

[PATCH 42/63] ide-cd: coding style fixes for cdrom_get_toc_entry()

2007-12-19 Thread Bartlomiej Zolnierkiewicz
This is a preparation to move code handling cdrom.c IOCTLs out of ide-cd.c. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 41/63] ide-cd: move lba_to_msf() and msf_to_lba() to linux/cdrom.h

2007-12-19 Thread Bartlomiej Zolnierkiewicz
* Move lba_to_msf() and msf_to_lba() to linux/cdrom.h (use 'u8' type instead of 'byte' while at it). * Remove msf_to_lba() copy from drivers/cdrom/cdrom.c. Cc: Jens Axboe [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/cdrom/cdrom.c |6

[PATCH 40/63] ide-cd: merge cdrom_select_speed() into ide_cdrom_select_speed()

2007-12-19 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -13 bytes drivers/ide/ide-cd.c | 66 ++- 1 file changed, 29 insertions(+), 37 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 37/63] ide-cd: factor out ioctl handlers from ide_cdrom_audio_ioctl()

2007-12-19 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 142 ++- 1 file changed, 75 insertions(+), 67 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 35/63] ide-cd: coding style fixes for VERBOSE_IDE_CD_ERRORS code

2007-12-19 Thread Bartlomiej Zolnierkiewicz
* Coding style fixes for VERBOSE_IDE_CD_ERRORS code. * Add KERN_{ERR,CONT} printk() levels where needed. This is a preparation for moving this code out of ide-cd.[c,h]. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 65

[PATCH 32/63] ide-cd: use BCD2BIN()/BIN2BCD() macros from linux/bcd.h

2007-12-19 Thread Bartlomiej Zolnierkiewicz
Use BCD2BIN()/BIN2BCD() macros from linux/bcd.h and remove the local bcd2bin()/bin2bcd() inlines. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +15 bytes :( drivers/ide/ide-cd.c | 34 +++--- 1 file changed, 11 insertions(+), 23 deletions(-) Index

[PATCH 07/63] ide-cd: add error message for DMA error to cdrom_read_intr()

2007-12-19 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide

[PATCH 29/63] ide-cd: remove struct ide_cd_{config,state}_flags

2007-12-19 Thread Bartlomiej Zolnierkiewicz
' to struct cdrom_info and use -cd_flags instead of -{config,state}_flags. * Remove no longer needed struct ide_cd_{config,state}_flags. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -45 bytes drivers/ide/ide-cd.c | 106

[PATCH 06/63] ide-cd: fix error messages in cdrom_write_intr()

2007-12-19 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers

[PATCH 26/63] ide-cd: kill CDROM_CONFIG_FLAGS() macro

2007-12-19 Thread Bartlomiej Zolnierkiewicz
While at it rename 'info' variable to 'cd' in ide_cdrom_probe_capabilities() and ide_cdrom_setup(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -47 bytes drivers/ide/ide-cd.c | 96 ++- drivers/ide/ide-cd.h |2 - 2 files

[PATCH 24/63] ide-cd: add IDE_CD_CAPABILITIES define

2007-12-19 Thread Bartlomiej Zolnierkiewicz
While at it remove stale/incorrect comment. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-cd.c

Re: [PATCH] Fix build break caused by ide: remove ideprobe_init()

2007-12-17 Thread Bartlomiej Zolnierkiewicz
[EMAIL PROTECTED] applied but... --- On Sun, Nov 18, 2007 at 11:25:09PM +0100, Bartlomiej Zolnierkiewicz wrote: * Rename ide_device_add() to ide_device_add_all() and make it accept 'u8 idx[MAX_HWIFS]' instead of 'u8 idx[4]' as an argument. * Add ide_device_add() wrapper

Re: [PATCH] drivers/ide/: Spelling fixes

2007-12-17 Thread Bartlomiej Zolnierkiewicz
On Monday 17 December 2007, Joe Perches wrote: Signed-off-by: Joe Perches [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH pata-2.6] hpt366: merge set_dma_mode() methods

2007-12-17 Thread Bartlomiej Zolnierkiewicz
On Friday 14 December 2007, Sergei Shtylyov wrote: Group the array of pointers to the timing tables with the timing register masks which allows us to merge HPT36x/HPT37x set_dma_mode() methods into one. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this

Re: [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()

2007-12-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 13 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename init_hwif_data() to ide_init_port_data() and export it. * For all users of ide_register_hw() with 'initializing' argument set hwif-present and hwif-hold are always zero so convert

Re: [PATCH 14/20] ide: convert empty REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE

2007-12-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 13 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Based on the previous work by Tejun Heo. There should be no functionality changes caused by this patch. I didn't get the point. Why do you consider them empty? These requests don't have command

Re: [PATCH 15/20] ide: don't enable local IRQs for PIO-in in driver_cmd_intr()

2007-12-12 Thread Bartlomiej Zolnierkiewicz
On Monday 10 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Don't enable local IRQs for PIO-in protocol in driver_cmd_intr(). While at it: * Remove redundant rq-cmd_type check. * Read status register after enabling local IRQs for no-data protocol

Re: [PATCH 12/20] ide: use wait_drive_not_busy() in drive_cmd_intr()

2007-12-12 Thread Bartlomiej Zolnierkiewicz
On Monday 10 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-taskfile.c

Re: [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()

2007-12-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 11 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename init_hwif_data() to ide_init_port_data() and export it. * For all users of ide_register_hw() with 'initializing' argument set hwif-present and hwif-hold are always zero so convert these host

Re: [PATCH 19/30] blk_end_request: changing ide-scsi (take 4)

2007-12-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 11 December 2007, Kiyoshi Ueda wrote: This patch converts ide-scsi to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi

Re: [PATCH 20/21] ide: fix host drivers depending on ide_generic to probe for interfaces

2007-12-12 Thread Bartlomiej Zolnierkiewicz
On Wednesday 12 December 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Add mpc8xx_ide_probe() to mpc8xx.c and call it from probe_for_hwifs(). * Convert ide_arm, ide-cris, ide-h8300, ide-pnp, buddha, falconide, gayle, macide, q40ide, cmd640 and mpc8xx host

[git patches] IDE fixes

2007-12-12 Thread Bartlomiej Zolnierkiewicz
+ drivers/scsi/ide-scsi.c| 17 + include/linux/ide.h|6 ++-- 14 files changed, 191 insertions(+), 189 deletions(-) Bartlomiej Zolnierkiewicz (13): ide-scsi: add ide_scsi_hex_dump() helper ide: add missing checks for control register existence ide

Re: Peculiar out-of-sync boot log lines

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 07 December 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: DMA reporting and validity checking fixes (take 2) * ide_xfer_verbose() fixups: - beautify returned mode names - fix PIO5 reporting - make it return 'const char

Re: [PATCH] hpt366: fix HPT37x PIO mode timings (take 2)

2007-12-09 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 December 2007, Sergei Shtylyov wrote: After looking into the HPT370 manual (now that I have it) and re-checking all the timing tables, here's what I have discovered: - at 33 MHz clock, PIO mode 0 timings turned to be overclocked, and all other PIO modes underclocked; - at

[PATCH] pdc202xx_new: fix Promise TX4 support

2007-12-09 Thread Bartlomiej Zolnierkiewicz
In case of Promise TX4 the first PCI device is located at slot 1 and the second one is at slot 2 so the offset used by pci_get_slot() should be +1 and not +2. Thanks goes out to Markus Dietz for bugreport and testing this patch. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej

Re: [PATCH pata-2.6] hpt366: change timing register masks

2007-12-09 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 December 2007, Sergei Shtylyov wrote: Since PIO autotuning is now done always, there's no need anymore to program the taskfile timings also on DMA modes, so chenge the IDE timing register masks accordingly, inverting the polarity of the masks while at it... Signed-off-by:

Re: [PATCH pata-2.6] hpt366: kill set_dma_mode() method wrapper

2007-12-09 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 December 2007, Sergei Shtylyov wrote: There's no reason to keep the set_dma_mode() method wrapper for two different chip families, so get rid of it... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied, thanks! - To unsubscribe from this list: send the line unsubscribe

[PATCH 1/20] ide: fix -io_32bit race in set_io_32bit()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
set_io_32bit() (ide_procset_t function) can race against running PIO transfers. Fix it by using ide_spin_wait_hwgroup(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |6 ++ 1 file changed, 6 insertions(+) Index: b/drivers/ide/ide.c

[PATCH 2/20] ide: fix -io_32bit race in ide_taskfile_ioctl()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
by ide_taskfile_ioctl(). This patch adds IDE_TFLAG_IO_16BIT flag to indicate to ide_pio_datablock() that 16-bit I/O is needed regardless of drive-io_32bit settting. Bart: - ported it over recent IDE changes Signed-off-by: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 3/20] dtc2278: -io_32bit setting don't have to be identical for master/slave

2007-12-09 Thread Bartlomiej Zolnierkiewicz
drive-io_32bit is used per PIO transfer so there is no reason to require it to be identical for master/slave. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c|4 drivers/ide/legacy/dtc2278.c |7 +-- 2 files changed, 1 insertion(+), 10

[PATCH 4/20] ide: clear HOB bit for REQ_TYPE_ATA_CMD requests in ide_end_drive_cmd()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
ide_dump_status() may set HOB bit before ide_end_drive_cmd() is called. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/ide-io.c

[PATCH 5/20] ide: fix final status check in task_in_intr()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Check for DRQ bit being cleared on the final status check. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-taskfile.c

[PATCH 6/20] ide-tape: fix handling of non-special requests in -end_request method

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |5 + 1 file changed, 5 insertions(+) Index: b/drivers/ide/ide-tape.c === --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c

[PATCH 7/20] ide: set IDE_TFLAG_IN_* flags before queuing/executing command

2007-12-09 Thread Bartlomiej Zolnierkiewicz
* Add IDE_TFLAG_{HOB,TF,DEVICE} defines. * Set IDE_TFLAG_IN_* flags in {do_rw,ide_no_data,ide_raw}_taskfile() users. * Remove no longer needed -tf_flags setup from ide_end_drive_cmd(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 8/20] ide: remove needless -cursg clearing from task_end_request()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c +++ b/drivers/ide/ide

[PATCH 9/20] ide: use rq-nr_sectors in task_end_request()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c +++ b

[PATCH 10/20] ide: task_end_request() fix

2007-12-09 Thread Bartlomiej Zolnierkiewicz
completion. Bart: - ported it over recent IDE changes Signed-off-by: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |8 +--- drivers/ide/ide-taskfile.c | 11 --- include/linux/ide.h|2 ++ 3 files

[PATCH 11/20] ide: kill DATA_READY define

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c |4 ++-- include/linux/ide.h|1 - 2 files changed, 2 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-taskfile.c

[PATCH 12/20] ide: use wait_drive_not_busy() in drive_cmd_intr()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |4 +--- drivers/ide/ide-taskfile.c |2 +- include/linux/ide.h|2 ++ 3 files changed, 4 insertions(+), 4 deletions(-) Index: b/drivers/ide/ide-io.c

[PATCH 13/20] ide: initialize rq-cmd_type in ide_init_drive_cmd() callers

2007-12-09 Thread Bartlomiej Zolnierkiewicz
* Initialize rq-cmd_type in ide_wait_cmd(), ide_cmd_ioctl() and set_pio_mode() (other callers were aleady over-riding rq-cmd_type). * Remove no longer needed rq-cmd_type setup from ide_init_drive_cmd(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c

[PATCH 15/20] ide: don't enable local IRQs for PIO-in in driver_cmd_intr()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Don't enable local IRQs for PIO-in protocol in driver_cmd_intr(). While at it: * Remove redundant rq-cmd_type check. * Read status register after enabling local IRQs for no-data protocol. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 11

[PATCH 14/20] ide: convert empty REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Based on the previous work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |4 +++- drivers/ide/ide-taskfile.c |2 +- drivers/ide/ide.c

[PATCH 16/20] ide: check BUSY and ERROR status bits before reading data in drive_cmd_intr()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |7 +++ 1 file changed, 7 insertions(+) Index: b/drivers/ide/ide-io.c === --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c @@ -643,6

[PATCH 17/20] ide: fix final status check in drive_cmd_intr()

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Don't check for READY_STAT bit being set for PIO-in protocol (makes the final status check in drive_cmd_intr() match the one in task_in_intr()). Also fix function name reported by ide_error() call while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c

[PATCH 18/20] ide: switch set_xfer_rate() to use REQ_TYPE_ATA_TASKFILE requests

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. Switch set_xfer_rate() to use REQ_TYPE_ATA_TASKFILE requests and make ide_wait_cmd() static. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 19/20] ide: switch ide_cmd_ioctl() to use REQ_TYPE_ATA_TASKFILE requests

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |4 +- drivers/ide/ide-taskfile.c | 63

[PATCH 20/20] ide: remove REQ_TYPE_ATA_CMD

2007-12-09 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. All users are gone so we can finally remove it. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 98 ++--- drivers/ide/ide-lib.c | 25

Re: [PATCH 3/20] dtc2278: -io_32bit setting don't have to be identical for master/slave

2007-12-09 Thread Bartlomiej Zolnierkiewicz
On Sunday 09 December 2007, Alan Cox wrote: drive-io_32bit is used per PIO transfer so there is no reason to require it to be identical for master/slave. Sure about that ? The driver has always gone to great pains to ensure that occurs and that suggests the author had a good reason for

Re: [PATCH 3/20] dtc2278: -io_32bit setting don't have to be identical for master/slave

2007-12-09 Thread Bartlomiej Zolnierkiewicz
On Monday 10 December 2007, Alan Cox wrote: There is absolutely no hardware setup done by IDE subsystem or dtc2278 host driver when -io_32bit setting is changed and since -io_32bit setting So ? The original author went to great trouble to specifically enforce the behaviour in question

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-04 Thread Bartlomiej Zolnierkiewicz
-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] Looks good, thanks! Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-12-04 Thread Bartlomiej Zolnierkiewicz
On Tuesday 04 December 2007, Kiyoshi Ueda wrote: Hi Bartlomiej, On Sat, 1 Dec 2007 23:53:05 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Saturday 01 December 2007, Kiyoshi Ueda wrote: This patch converts normal parts of ide to use blk_end_request(). Signed-off

Re: [PATCH 20/28] blk_end_request: changing ide-scsi (take 3)

2007-12-04 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 December 2007, Kiyoshi Ueda wrote: This patch converts ide-scsi to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send

Re: [PATCH 4/6] ide: add ide_busy_sleep() helper

2007-12-04 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 04 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Add ide_busy_sleep() helper and use it in do_probe(), enable_nest() and probe_hwif(). As a nice side-effect this fixes a minor bug in enable_nest() (the code was reading status register without

Re: [PATCH 6/6] cmd64x: remove /proc/ide/cmd64x

2007-12-04 Thread Bartlomiej Zolnierkiewicz
On Tuesday 04 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: This belongs to user-space (and only if really needed). Sigh, and why only I spent time fixing this code? :-) textdata bss dec hex filename 3874 180 284082

[PATCH 2/6] ide: remove stale changelog from ide-disk.c

2007-12-03 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 26 -- 1 file changed, 26 deletions(-) Index: b/drivers/ide/ide-disk.c === --- a/drivers/ide/ide-disk.c +++ b/drivers

[PATCH 3/6] ide: remove stale changelog from ide-probe.c

2007-12-03 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) Index: b/drivers/ide/ide-probe.c === --- a/drivers/ide/ide-probe.c

[PATCH 4/6] ide: add ide_busy_sleep() helper

2007-12-03 Thread Bartlomiej Zolnierkiewicz
Add ide_busy_sleep() helper and use it in do_probe(), enable_nest() and probe_hwif(). As a nice side-effect this fixes a minor bug in enable_nest() (the code was reading status register without any delay). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c

[PATCH 5/6] ide: remove broken disk byte-swapping support

2007-12-03 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide.txt |4 drivers/ide/ide-disk.c |1 - drivers/ide/ide-taskfile.c | 32 ++-- drivers/ide/ide.c |6 +- include/linux/ide.h|1 - 5 files changed, 3 insertions

[PATCH 6/6] cmd64x: remove /proc/ide/cmd64x

2007-12-03 Thread Bartlomiej Zolnierkiewicz
two bugs: - incorrect UDMA modes were reported for reserved values of UDIDETCR0/1 regs - MRDMODE_BLK_CH0/1 bits are not defined on CMD643 and early CMD646 revisions Also while at it remove unused CNTRL_DIS_RA0/1 defines. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz

Re: Peculiar out-of-sync boot log lines

2007-12-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 02 December 2007, Randy Dunlap wrote: On Sat, 1 Dec 2007 22:59:35 +0100 Bartlomiej Zolnierkiewicz wrote: Thanks for reporting/debugging it guys! Something in there needs to insert a '\n' before the skipping word message. Since it doesn't do that right now

Re: Peculiar out-of-sync boot log lines

2007-12-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 02 December 2007, Nick Warne wrote: On Sat, 1 Dec 2007 22:59:35 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Thanks for reporting/debugging it guys! Something in there needs to insert a '\n' before the skipping word message. Since it doesn't do that right

Re: Peculiar out-of-sync boot log lines

2007-12-01 Thread Bartlomiej Zolnierkiewicz
is always reported by IDE core code. Cc: Nick Warne [EMAIL PROTECTED] Cc: Mark Lord [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |7 -- drivers/ide/ide-disk.c |5 drivers/ide/ide-dma.c | 57

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-01 Thread Bartlomiej Zolnierkiewicz
). This was uncovered thanks to the blk_end_request: full I/O completion handler (take 3) patch series from Kiyoshi Ueda. Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Cc: Kiyoshi Ueda [EMAIL PROTECTED] Cc: Jun'ichi Nomura [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej

Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-12-01 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 December 2007, Kiyoshi Ueda wrote: This patch converts normal parts of ide to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |6 +++--- drivers/ide/ide-io.c | 17

Re: [PATCH 1/6] au1xxx-ide: au_ide_probe() fixes

2007-11-28 Thread Bartlomiej Zolnierkiewicz
On Wednesday 28 November 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * hwif-hold is always set in au_ide_probe() (few lines earlier), no need to set it again * hwif-{channel,select_data,config_data} should be always zero * autotune PIO also

[PATCH 1/8] ide: add missing checks for control register existence

2007-11-28 Thread Bartlomiej Zolnierkiewicz
Add missing checks for control register existence (some legacy m68k specific IDE controllers don't have it). Also use drive-ctl while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c|3 ++- drivers/ide/ide-probe.c |3 ++- 2 files changed, 4

[PATCH 2/8] ide: add ide_set_irq() inline helper

2007-11-28 Thread Bartlomiej Zolnierkiewicz
There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |9 +++-- drivers/ide/ide-iops.c | 10 -- drivers/ide/ide-probe.c| 12 drivers/ide/ide-taskfile.c

[PATCH 4/8] ide: deprecate CONFIG_BLK_DEV_OFFBOARD

2007-11-28 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Index: b/drivers/ide/Kconfig === --- a/drivers/ide/Kconfig +++ b/drivers/ide/Kconfig

[PATCH 3/8] ide: print banner message once per controller in m68k host drivers

2007-11-28 Thread Bartlomiej Zolnierkiewicz
[EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/buddha.c| 19 +-- drivers/ide/legacy/falconide.c |4 ++-- drivers/ide/legacy/gayle.c | 18 +++--- drivers/ide/legacy/macide.c| 14

[PATCH 5/8] ide: fix ide_scan_pcibus() error message

2007-11-28 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: b/drivers/ide/setup-pci.c === --- a/drivers/ide/setup-pci.c +++ b/drivers

[PATCH 6/8] ide: coding style fixes for drivers/ide/setup-pci.c

2007-11-28 Thread Bartlomiej Zolnierkiewicz
* remove trailing whitespaces * 'if()' - 'if ()' * remove extra new-line before EXPORT_SYMBOL_GPL() * add extra new-line after 'id' definition * respect 80-columns limit There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 7/8] ide: move CONFIG_IDEPCI_PCIBUS_ORDER code to ide-scan-pci.c

2007-11-28 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-scan-pci.c | 110 + drivers/ide/setup-pci.c| 103 -- 2 files changed, 110 insertions(+), 103 deletions(-) Index: b/drivers/ide

[PATCH 8/8] ide: make CONFIG_IDEPCI_PCIBUS_ORDER visible and deprecate it

2007-11-28 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) Index: b/drivers/ide/Kconfig === --- a/drivers/ide/Kconfig +++ b/drivers/ide

Re: [PATCH 2/2] ide-scsi: use print_hex_dump from linux/kernel.h

2007-11-27 Thread Bartlomiej Zolnierkiewicz
On Tuesday 27 November 2007, Andrew Morton wrote: On Mon, 26 Nov 2007 15:16:13 +0800 Denis Cheng [EMAIL PROTECTED] wrote: these utilities implemented in lib/hexdump.c are more handy, please use this. ... --- a/drivers/scsi/ide-scsi.c +++ b/drivers/scsi/ide-scsi.c @@ -242,16

[git patches] IDE fixes

2007-11-27 Thread Bartlomiej Zolnierkiewicz
(-) Aleksandar Radovanovic (1): aec62xx: Fix kernel oops in driver's probe function Andrew Morton (1): amd74xx: arm hack Bartlomiej Zolnierkiewicz (11): macide/q40ide: add missing __init tag to {macide,q40ide}_init() ide/Kconfig: fix mpc8xx host driver dependencies

Re: [PATCH 2/2] ide-scsi: use print_hex_dump from linux/kernel.h

2007-11-27 Thread Bartlomiej Zolnierkiewicz
On Tuesday 27 November 2007, Bartlomiej Zolnierkiewicz wrote: On Tuesday 27 November 2007, Andrew Morton wrote: On Mon, 26 Nov 2007 15:16:13 +0800 Denis Cheng [EMAIL PROTECTED] wrote: these utilities implemented in lib/hexdump.c are more handy, please use

[PATCH 1/6] au1xxx-ide: au_ide_probe() fixes

2007-11-27 Thread Bartlomiej Zolnierkiewicz
* hwif-hold is always set in au_ide_probe() (few lines earlier), no need to set it again * hwif-{channel,select_data,config_data} should be always zero * autotune PIO also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_BDMA is not defined Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 2/6] au1xxx-ide: use ide_init_port_hw()

2007-11-27 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: b/drivers/ide/mips/au1xxx-ide.c === --- a/drivers/ide/mips/au1xxx

[PATCH 3/6] ide: always use ide_std_init_ports() in setup-pci.c

2007-11-27 Thread Bartlomiej Zolnierkiewicz
[IDE_DATA_OFFSET] is also non-zero always clear hwif-noprobe. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) Index: b/drivers/ide/setup-pci.c

[PATCH 5/6] rapide: remove write-only hwif-hwif_data

2007-11-27 Thread Bartlomiej Zolnierkiewicz
Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/rapide.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/arm/rapide.c === --- a/drivers/ide/arm

[PATCH 4/6] ide: use ide_init_port_hw() in setup-pci.c

2007-11-27 Thread Bartlomiej Zolnierkiewicz
* Move setting hwif-gendev.parent from ide_pci_setup_ports() to ide_hwif_configure(). * Always set hwif-io_ports in ide_hwif_configure(). * Use ide_init_port_hw() in ide_hwif_configure(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c | 33

[PATCH 6/6] ide-pmac: use custom hwif-sg_max_nents only if DMA support is enabled

2007-11-27 Thread Bartlomiej Zolnierkiewicz
Move setting hwif-sg_max_nents from pmac_ide_setup_device() to pmac_ide_setup_dma(). Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers

Re: kernel bugzilla is FPOS (was: Re: buggy cmd640 message followed by soft lockup)

2007-11-25 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 25 November 2007, Rafael J. Wysocki wrote: On Sunday, 25 of November 2007, Bartlomiej Zolnierkiewicz wrote: [ I removed Frans from cc: since it is off-topic to the original bugreport ] On Saturday 24 November 2007, Rafael J. Wysocki wrote: On Saturday, 24 of November

kernel bugzilla is FPOS (was: Re: buggy cmd640 message followed by soft lockup)

2007-11-24 Thread Bartlomiej Zolnierkiewicz
[ I removed Frans from cc: since it is off-topic to the original bugreport ] On Saturday 24 November 2007, Rafael J. Wysocki wrote: On Saturday, 24 of November 2007, Bartlomiej Zolnierkiewicz wrote: [--snip--] Rafael, I see that you've filled a bug for this bugreport into kernel bugzilla

Re: Lost interrupt with cmd 64x

2007-11-23 Thread Bartlomiej Zolnierkiewicz
On Friday 23 November 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: This problem should have been already fixed by: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6183289cd4356b790c5eaa619020fb887ec0fa44 which was merged

Re: [PATCH 17/59] drivers/ide: Add missing space

2007-11-22 Thread Bartlomiej Zolnierkiewicz
On Tuesday 20 November 2007, Joe Perches wrote: Signed-off-by: Joe Perches [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] ide: add TORiSAN model: CD-ROM CDR_U200 fw: 1.09 to DMA blacklist

2007-11-22 Thread Bartlomiej Zolnierkiewicz
Based on the report from [EMAIL PROTECTED] Should fix kernel bugzilla bug #9195. Cc: [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/ide-dma.c

[PATCH] alim15x3: add Mitac 8317 and derivatives to ali_cable_override()

2007-11-22 Thread Bartlomiej Zolnierkiewicz
Port of Alan's patch for pata_ali.c. Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c |5 + 1 file changed, 5 insertions(+) Index: b/drivers/ide/pci/alim15x3.c

[PATCH] trm290: remove bogus init_hwif_trm290() comment

2007-11-22 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/trm290.c |3 --- 1 file changed, 3 deletions(-) Index: b/drivers/ide/pci/trm290.c === --- a/drivers/ide/pci/trm290.c +++ b/drivers/ide/pci/trm290.c

[PATCH] piix: add HP compaq laptop to short cable list

2007-11-22 Thread Bartlomiej Zolnierkiewicz
Port of Jeff's libata commit 54174db300ee1bac632d62e4ac37fe02e47d1f18 ([libata] ata_piix: add HP compaq laptop to short cable list). Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/piix.c |1 + 1 file changed, 1 insertion

Re: Problem with PCMCIA IDE

2007-11-22 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 18 November 2007, Akkana Peck wrote: I've been having problems getting PCMCIA IDE to work on my Vaio laptop on recent kernels (I've been working most with 2.6.23.1 and .8). I've been hesitant to report it as a kernel bug because it may very well be a problem with my .config

[PATCH] ali14xx: constify __initdata

2007-11-22 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ali14xx.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: b/drivers/ide/legacy/ali14xx.c === --- a/drivers/ide/legacy

Re: [PATCH 6/21] ide: move CONFIG_IDE_ETRAX to drivers/ide/Kconfig

2007-11-20 Thread Bartlomiej Zolnierkiewicz
On Monday 19 November 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Move ETRAX_IDE and friends from arch/cris/arch-{v10,v32}/drivers/Kconfig to drivers/ide/Kconfig. * Don't force selecting ide-disk and ide-cd device drivers (please handle this through defconfig

Re: [PATCH] drivers/ide/ide-probe.c Skip ide_wait_not_busy on noprobe-disks. was: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1

2007-11-18 Thread Bartlomiej Zolnierkiewicz
On Friday 16 November 2007, Jonas Stare wrote: There is a problem in some hardware where the kernel will stall for 35 seconds waiting for disks that dont exist. This patch will skip waiting for the BSY-bit on ide-drives to go away if you set hdx=noprobe as a kernel option and the disk is not

Re: [PATCH 2.6.24-rc3] aec62xx: Fix kernel oops in driver's probe function

2007-11-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 17 November 2007, Aleksandar Radovanovic wrote: From: Aleksandar Radovanovic [EMAIL PROTECTED] Add pci_enable_device() to aec62xx probe function before doing any I/O. Original probe function tries to read from device's PCI region 4 before calling ide_setup_pci_device(). Since

[PATCH 1/21] ide: dump taskfile HOB registers in ide_tf_load() (if DEBUG is defined)

2007-11-18 Thread Bartlomiej Zolnierkiewicz
* Dump taskfile HOB registers in ide_tf_load() (if DEBUG is defined). * Remove no longer needed DEBUG code from __ide_do_rw_disk(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |7 +-- drivers/ide/ide-taskfile.c |4 2 files changed

[PATCH 2/21] ide: merge -fixup and -quirkproc methods

2007-11-18 Thread Bartlomiej Zolnierkiewicz
'quirkproc' argument instead of 'fixup' one. * Remove no longer needed -fixup method. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c| 20 ++-- drivers/ide/ide.c |8 +++- drivers/ide/pci/hpt366.c | 11

<    1   2   3   4   5   6   7   8   9   10   >