Re: [PATCH] removed static prototypes from include/asm-mips/mach-au1x00/au1xxx_ide.h

2007-03-15 Thread Bartlomiej Zolnierkiewicz
On Thursday 15 March 2007, Daniel Mack wrote: > Hi, > > This patch removes the static prototypes from the au1xxx_ide.h, some of > them were not even implemented. Also, they caused build breakage since > they differed from the functions actually implemented in > drivers/ide/mips/au1xxx-ide.c. > >

Re: [PATCH pata-2.6 fix queue] cmd64x: fix recovery time calculation (take 3)

2007-03-15 Thread Bartlomiej Zolnierkiewicz
yway, > the new code gives the same or longer recovery times than the old one... > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > > --- > This patch has been changed in accordance to the pending

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 March 2007, Mark Lord wrote: > Jeff Garzik wrote: > > Alan Cox wrote: > >>> I think it only requires the *host* to drop to PIO0 timings. In > >>> which case it should be achievable w/o libata modification -- if the > >>> driver has to "snoop" command and turn off prefetch, why

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 March 2007, Mark Lord wrote: > Bartlomiej Zolnierkiewicz wrote: > > On Friday 16 March 2007, Mark Lord wrote: > .. > >> I've tested ATA1 and newer PATA drives, and various SATA drives > >> with these commands without bothering to drop to PIO

[PATCH 1/2] ide: don't allow DMA to be enabled if CONFIG_IDEDMA_{ICS,PCI}_AUTO=n

2007-03-15 Thread Bartlomiej Zolnierkiewicz
orn for reporting the issue, narrowing it down to the specific commit and testing the fix. Also thanks to Sergei Shtylyov for help in debugging the problem. Cc: Patrick Horn <[EMAIL PROTECTED]> Cc: Sergei Shtylyov <[EMAIL PROTECTED]> Cc: Russell King <[EMAIL PROTECTED]> Signed-off-

[PATCH 2/2] ide: remove CONFIG_IDEDMA_{ICS,PCI}_AUTO config options

2007-03-15 Thread Bartlomiej Zolnierkiewicz
ONFIG_IDEDMA_{ICS,PCI}_AUTO=n" patch. There is no functionality loss because "ide=nodma" kernel option is still available. Cc: Patrick Horn <[EMAIL PROTECTED]> Cc: Sergei Shtylyov <[EMAIL PROTECTED]> Cc: Russell King <[EMAIL PROTECTED]> Signed-off-by:

Re: [PATCH 10/13] sl82c105: add ->speedproc support

2007-03-15 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 March 2007, Sergei Shtylyov wrote: > Hello, I wrote: > > >>> Bartlomiej Zolnierkiewicz wrote: > > >>>> [PATCH] sl82c105: add ->speedproc support > > >>>> * add sl82c105_tunepio() wrapper for sl82c105_tune_driv

Re: libata: CD and dvd devices not recognized

2007-03-17 Thread Bartlomiej Zolnierkiewicz
Hi, Any news about this test? ide-cd driver is much more forgiving for quirky hardware than libata+sr so please give it a try... Bart On Friday 16 March 2007, YUP wrote: > Hi Albert, > I'll do it today and send you results. > > Yarema > > > > > Could you please check whether the IDE driver

Re: libata: CD and dvd devices not recognized

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 17 March 2007, Albert Lee wrote: > Bartlomiej Zolnierkiewicz wrote: > > Hi, > > > > Any news about this test? ide-cd driver is much more forgiving for > > quirky hardware than libata+sr so please give it a try... > > > > Hi Bart, > Yarema

Re: libata: CD and dvd devices not recognized

2007-03-17 Thread Bartlomiej Zolnierkiewicz
02) Yes. However you have the "problematic" drive on the on-board Intel controller so please disable ata_piix libata driver, enable piix IDE driver and retest. :-) Thanks, Bart > 02:05.0 Ethernet controller: ADMtek NC100 Network Everywhere Fast > Ethernet 10/100 (rev 11) &

Re: libata: CD and dvd devices not recognized

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 17 March 2007, YUP wrote: > Just to check up can you recheck my config? Looks fine but please set CONFIG_ATA_PIIX to "n" (just in case). Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at h

Re: [PATCH] jmicron: make ide jmicron driver play nice with libata ones

2007-03-17 Thread Bartlomiej Zolnierkiewicz
atch makes jmicron match PCI class code such that it doesn't > attach itself to the SATA part preventing the proper ahci driver from > attaching. > > This change is suggested by Bartlomiej. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > Cc: Bartlomiej Zolnie

Re: [PATCH] jmicron: make ide jmicron driver play nice with libata ones

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 17 March 2007, Alan Cox wrote: > > > PATA ports live in separate functions with different programming > > > interfaces. pata_jmicron and ide jmicron drivers can drive only the > > > PATA part. > > This isn't actually true. The IDE jmicron driver can drive both the PATA > and the SATA

Re: [PATCH 1/2] scc_pata: dependency fix

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Friday 16 March 2007, Akira Iguchi wrote: > This patch fixes: > * the dependency of scc_pata on BLK_DEV_IDEDMA_PCI > * incorrect link to ide-core > * move scc_pata from ide/ppc to ide/pci > > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> > Signed-off-by: Akira Iguchi <[EMAIL PROTECTED]> I a

Re: [git patches] IDE fixes

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Sunday 18 March 2007, Linus Torvalds wrote: > > On Sat, 17 Mar 2007, Bartlomiej Zolnierkiewicz wrote: > > > > to receive the following updates: > > > > b/drivers/ide/Kconfig | 48 - > > b/drivers/ide/Makefile

Re: libata: CD and dvd devices not recognized

2007-03-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 18 March 2007, YUP wrote: > Please ignore previous message, I sent wrong file. Here is right dmesg > output with disabled ata_piix. [ 40.145204] PDC20269: IDE controller at PCI slot :02:01.0 [ 40.145244] PDC20269: chipset revision 2 [ 40.145249] PDC20269: ROM enabled at

Re: libata: CD and dvd devices not recognized

2007-03-18 Thread Bartlomiej Zolnierkiewicz
On Sunday 18 March 2007, YUP wrote: > Hello Bartek, > > > > > Thanks, does reading from CD/DVD media also work fine now? > > Yes, drives can read all media cd and dvd I have. OK, thanks for testing. The conclusion here is that the problem experienced by Yarema is clearly some libata regressi

[PATCH] ide: revert "ide: fix drive side 80c cable check, take 2" for now

2007-03-20 Thread Bartlomiej Zolnierkiewicz
[ Please also see libata commit f31f0cc2f0b7527072d94d02da332d9bb8d7d94c. ] Thanks goes out to Fernando Mitio Yamada for reporting the problem and patiently testing patches. Cc: Tejun Heo <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <

[PATCH] ide: fix locking for manual DMA enable/disable ("hdparm -d")

2007-03-21 Thread Bartlomiej Zolnierkiewicz
ting for a drive is changed (so it won't race against I/O commands in fly). I audited briefly all ->ide_dma_check/->ide_dma_on/->tuneproc/->speedproc implementations and they all look OK wrt to this change. Cc: Sergei Shtylyov <[EMAIL PROTECTED]> Cc: Alan Cox <

Re: libata: CD and dvd devices not recognized

2007-03-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 19 March 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > > It seems that the drive works just fine in PIO mode with pdc202xx_new > > IDE driver (it doesn't support ATAPI DMA at the moment) > > There used to be

Re: request_queue_t depends on CONFIG_BLOCK

2007-03-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 23 March 2007, Olaf Hering wrote: > On Thu, Mar 22, Christoph Hellwig wrote: > > > On Thu, Mar 22, 2007 at 10:52:34PM +0100, Olaf Hering wrote: > > > How can this compile error be fixed properly? > > > request_queue_t is inside CONFIG_BLOCK, > > > ide_drive_s (and likely others) us

Re: request_queue_t depends on CONFIG_BLOCK

2007-03-23 Thread Bartlomiej Zolnierkiewicz
On Friday 23 March 2007, Olaf Hering wrote: > On Fri, Mar 23, Bartlomiej Zolnierkiewicz wrote: > > > > Because it is needed in a few places. > > > > Is there really any PPC64 specific code which needs > > (ppc_ide_md is used only by PPC32)? I suspect that

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 08 March 2007, Suleiman Souhlal wrote: > > On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: > > Please respin the patch so I could merge it. > > Ok. Since I think that it's worth to have it in 2.6.21-final and respin didn't happen I did

[git patches] IDE fixes for 2.6.21-rc5

2007-03-26 Thread Bartlomiej Zolnierkiewicz
/ide/ide.c | 37 ++--- drivers/ide/pci/pdc202xx_new.c |3 ++- include/linux/ide.h|1 + 6 files changed, 67 insertions(+), 23 deletions(-) Albert Lee (1): pdc202xx_new: Enable ATAPI DMA Bartlomiej Zolnierkiewicz (2): ide

Re: [PATCH 0/4] libata: Workaround/fixes for ATAPI devices (revised)

2007-03-31 Thread Bartlomiej Zolnierkiewicz
only for TORiSAN DVD drives > > > > (patch 2/4 revised per Tejun's advice.) > > > > All four look good to me. Thanks a lot for tracking this down. Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Special thanks for fixing implicit libata vs drivers/ide regressi

Re: [PATCH] add correct interrupt property for pegasos ide

2007-04-04 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 04 April 2007, Olaf Hering wrote: > > The firmware assigns irq 20/21 to the VIA IDE device on Pegasos. > But the required interrupt is 14/15. > Maybe someone confused decimal vs. hexadecimal values. Good to see Pegasos platform being fixed to do the quirk in the proper way. Ho

Re: [PATCH] add correct interrupt property for pegasos ide

2007-04-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 April 2007, Olaf Hering wrote: > On Wed, Apr 04, Bartlomiej Zolnierkiewicz wrote: > > > ? > > You are right, I did not test the ide driver again. pata_via works with > the change. > I will test the ide driver tomorrow. Thanks. There might be also the

Re: [PATCH pata-2.6] sl82c105: rework PIO support (take 2)

2007-04-04 Thread Bartlomiej Zolnierkiewicz
timings() and get > rid of the code in it clamping cycle counts to 32 which was both incorrect and > never executed anyway... > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> applied - To unsubsc

Re: [PATCH pata-2.6] sl82c105: DMA support code cleanup (take 4)

2007-04-04 Thread Bartlomiej Zolnierkiewicz
lso use more proper hwif->dma_command, fix printk() and comment in the latter > one as well. While at it, cleanup style in several places. > > --- > This patch has also been actually tested at last. :-) > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> > Signed-off-by:

Re: [PATCH pata-2.6] sl82c105: add speedproc() method and MWDMA0/1 support

2007-04-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 28 March 2007, Sergei Shtylyov wrote: > Add the speedproc() method for setting transfer modes, modify config_for_dma() > to call it and use ide_max_dma_mode() to select the best DMA mode. > Add support for the multiword DMA modes 0 and 1, using the upper half of the > 'drive_data' fie

Re: [PATCH pata-2.6] sl82c105: rework PIO support (take 2)

2007-04-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 28 March 2007, Sergei Shtylyov wrote: > Hello, I wrote: > > > Index: linux-2.6/include/linux/ide.h > > === > > --- linux-2.6.orig/include/linux/ide.h > > +++ linux-2.6/include/linux/ide.h > > @@ -613,7 +613,6 @@ typedef

Re: Linux tape drivers

2007-04-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 April 2007, Andrew Morton wrote: > On Wed, 4 Apr 2007 12:22:35 -0700 > "Willem Riede" <[EMAIL PROTECTED]> wrote: > > > On 4/4/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Wed, 4 Apr 2007 16:26:14 +0200 Kern Sibbald <[EMAIL PROTECTED]> wrote: > > > > > > > I'm all in favor

Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Bartlomiej Zolnierkiewicz
On Friday 06 April 2007, Suleiman Souhlal wrote: > It is possible for the timer expiry function to run even though the > request has already been handled: ide_timer_expiry() only checks that > the handler is not NULL, but it is possible that we have handled a > request (thus clearing the handler)

Re: [PATCH] ugly messages trying to open CD drive with no media present

2007-04-06 Thread Bartlomiej Zolnierkiewicz
On Monday 02 April 2007, [EMAIL PROTECTED] wrote: > > I get the following error messages when trying to open a CD device > (specifically, the Teac CD-ROM CD-224E) that has no media present: > > hda: packet command error: status=0x51 { DriveReady SeekComplete Error } > hda: packet command error: e

Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Bartlomiej Zolnierkiewicz
On Friday 06 April 2007, Sergei Shtylyov wrote: > Hello. > > Suleiman Souhlal wrote: > > The reason the timer could have been active at that point, before applying > > this patch, is that we try to dispatch a new request after handling one. > > The new request will then have its own expiry timer

[git patches] IDE fixes

2007-04-10 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide-cd.c |9 + drivers/ide/ide-io.c |6 +- drivers/ide/ide-iops.c |2 ++ drivers/ide/ide.c |2 ++ include/linux/ide.h|2 ++

Re: Loud "pop" coming from hard drive on reboot

2007-04-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 12 April 2007, Chuck Ebbert wrote: > Jan Engelhardt wrote: > > On Apr 11 2007 17:35, Chuck Ebbert wrote: > >> Jan Engelhardt wrote: > >>> On Apr 11 2007 17:07, Chuck Ebbert wrote: > When I reboot my notebook, it powers off and powers back on. > On poweroff a loud snapping nois

Re: Loud "pop" coming from hard drive on reboot

2007-04-13 Thread Bartlomiej Zolnierkiewicz
On 4/13/07, Chuck Ebbert <[EMAIL PROTECTED]> wrote: Bartlomiej Zolnierkiewicz wrote: >> Now we're getting somewhere. There is some other OS on here because >> it's required for doing BIOS updates. I booted it and shut down. >> The power cycle count increased b

Re: Loud "pop" coming from hard drive on reboot

2007-04-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 April 2007, Chuck Ebbert wrote: > Mark Lord wrote: > > Mark Lord wrote: > >> > >> With the patch applied, I don't see *any* new activity in those > >> S.M.A.R.T. > >> attributes over multiple hibernates (Linux "suspend-to-disk"). > > > > Scratch that -- operator failure. ;) > > T

Re: Loud "pop" coming from hard drive on reboot

2007-04-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 April 2007, Tejun Heo wrote: > Mark Lord wrote: > > Chuck Ebbert wrote: > >> Mark Lord wrote: > >>> I'll patch it locally on my own machines, but what about the tens > >>> of thousands of other Seagate notebook drive owners out there? > >>> > >> > >> This is a problem with Seagate

Re: PATCH: ide/pci/delkin_cb.c add new PCI ID

2007-04-20 Thread Bartlomiej Zolnierkiewicz
On Sunday 15 April 2007, Mark Lord wrote: > Add PCI ID for a newer variant of cardbus CF/IDE adapter card. > Patch is against 2.6.21-rc*. > > Signed-off-by: Mark Lord <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [E

Re: [PATCH pata-2.6 fix queue] hpt366: fix kernel oops with HPT302N

2007-04-20 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 April 2007, Sergei Shtylyov wrote: > The driver crashes the kernel on HPT302N chips due to the missing initializer > for 'hpt302n.settings' having been unfortunately overlooked so far. :-< > > Much thanks to Mike Mattie for pin-pointing the reason of crash. > > Signed-off-by: Serg

[git patches] IDE fixes

2007-04-20 Thread Bartlomiej Zolnierkiewicz
insertions(+), 2 deletions(-) Bartlomiej Zolnierkiewicz (1): ide/Kconfig: add missing range check for IDE_MAX_HWIFS Mark Lord (1): ide/pci/delkin_cb.c: add new PCI ID Sergei Shtylyov (1): hpt366: fix kernel oops with HPT302N diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig

Re: Kernel 2.6.18 and above

2007-04-20 Thread Bartlomiej Zolnierkiewicz
On Friday 20 April 2007, Benjamin Herrenschmidt wrote: > I'm CC'ing linux-ide... looks like the disk which you say is 20GB is > misdetected by the IDE layer as being 2GB. > > Ok, so we have: > > > >> Probing IDE interface ide0... > > >> hda: WDC WD800JB-00FMA0, ATA DISK drive > > >> hdb: IC35L020

[git patch] IDE fix for 2.6.21-final (Revert "adjust legacy IDE resource setting (v2)")

2007-04-23 Thread Bartlomiej Zolnierkiewicz
Author: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Date: Mon Apr 23 23:19:36 2007 +0200 Revert "adjust legacy IDE resource setting (v2)" This reverts commit ed8ccee0918ad063a4741c0656fda783e02df627. It causes hang on boot for some users and we do

Re: [PATCH pata-2.6] cmd64x: fix multiword and remove single-word DMA support

2007-04-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 April 2007, Sergei Shtylyov wrote: > Fix the multiword DMA and drop the single-word DMA support (which nobody will > miss, I think). In order to do it, a number of changes was necessary: > > - rename program_drive_counts() to program_cycle_times(), pass to it cycle's > total/acti

Re: [PATCH pata-2.6] cmd64x: interrupt status fixes (take 2)

2007-04-23 Thread Bartlomiej Zolnierkiewicz
o irq_stat as the interrupt > status bits are not coupled to DMA. > In addition, wrong interrupt bit was tested/cleared for the primary channel -- > it's bit 2 in all the chip specs and the driver used bit 1... :-/ > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]&g

Re: [PATCH pata-2.6] cmd64x: add/fix enablebits (take 2)

2007-04-23 Thread Bartlomiej Zolnierkiewicz
o be enabled/disabled > -- > so, add 'enablebits' initializers to each 'ide_pci_device_t' structure, > handling > the original PCI0646 via adding the init_setup() method and clearing the 'reg' > field there if necessary... > > Signed-off-by:

Re: [PATCH pata-2.6] cmd64x: procfs code fixes/cleanups (take 2)

2007-04-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 April 2007, Sergei Shtylyov wrote: > Fix several issues with the driver's procfs output: > > - when testing if channel is enabled, the code looks at the "simplex" bits, > not > at the real enable bits -- add #define for the primary channel enable bit; > > - UltraDMA modes 0, 1,

Re: [PATCH pata-2.6] cmd64x: use interrupt status from MRDMODE register (take 2)

2007-04-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 April 2007, Sergei Shtylyov wrote: > Fold the parts of the ide_dma_end() methods identical to __ide_dma_end() into > a > mere call to it. > Start using faster versions of the ide_dma_end() and ide_dma_test_irq() > methods > for the PCI0646U and newer chips that have the duplicate i

Re: [PATCH pata-2.6 fix queue] aec62xx: fix PIO/DMA setup issues

2007-04-23 Thread Bartlomiej Zolnierkiewicz
On Sunday 22 April 2007, Sergei Shtylyov wrote: > Teach the driver's tuneproc() method to do PIO auto-runing properly since it > treated 5 instead of 255 as auto-tune request, and also passed the mode limit > of PIO5 to ide_get_best_pio_mode() despite supporting up to PIO4 only. > > While at it, a

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 20 April 2007, Sergei Shtylyov wrote: > Hello, I wrote: > > Index: b/drivers/ide/pci/hpt366.c > === > --- a/drivers/ide/pci/hpt366.c > +++ b/drivers/ide/pci/hpt366.c > @@ -513,43 +513,31 @@ sta

Re: [PATCHSET] libata: improve ATA ACPI support

2007-04-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 24 April 2007, Mark Lord wrote: > Tejun Heo wrote: > > > > of the time. I think HDIO_GET_IDENTITY's meaning is something like > > "give me IDENTIFY page of the device as seen by the driver" and doesn't > > really matter as long as it can be used to get general idea about the > >

Re: 2.6.20 libata cdrom

2007-05-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 01 May 2007, William Thompson wrote: > On Tue, May 01, 2007 at 09:04:46AM -0400, Mark Lord wrote: > > William Thompson wrote: > > > > > >+scsi2 : ata_piix > > >+ata_port_schedule_eh: port EH scheduled > > >+ata_scsi_error: ENTER > > >+ata_port_flush_task: ENTER > > >+ata_port_flush

Re: [PATCH 1/2 pata-2.6] ide: make void and rename ide_dma_lostirq() method

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Tuesday 24 April 2007, Sergei Shtylyov wrote: > Since ide_dma_lostirq() method's result is discarded, make it return 'void'. > While at it, rename the method to dma_lost_irq(), drop the '__' prefix from > the > default method's name, and do some cleanups in this method driver-wise: > > - in a

Re: [PATCH 2/2 pata-2.6] ide: make void and rename ide_dma_timeout() method

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Tuesday 24 April 2007, Sergei Shtylyov wrote: > Since ide_dma_timeout() method's result is discarded, make it return 'void'. > While at it, drop 'ide_' from the method's name, drop the '__' prefix from > the default method's name, and do some cleanups in this method driver-wise: > > - in ide-d

Re: [PATCH] use mutex instead of semaphore in IDE driver

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Thursday 26 April 2007, Matthias Kaehlcke wrote: > the IDE driver uses a semaphore as mutex. use the mutex API instead of > the (binary) semaphore > > Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the bod

Re: [PATCH pata-2.6] hpt366: simplify UltraDMA filtering

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Monday 30 April 2007, Sergei Shtylyov wrote: > Simplify UltraDMA mode filtering in the driver: > > - make use of the newly introduced 'udma_mask' field of 'ide_pci_device_t' to > set the correct hwif->ultra_mask, modifying init_setup_hpt366() to select > the correct mask based on the chip

Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Friday 04 May 2007, Sergei Shtylyov wrote: > HPT36x chip don't seem to have the channel enable bits, so prevent the IDE > core > from checking them... > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the b

[git patches] IDE updates

2007-05-05 Thread Bartlomiej Zolnierkiewicz
/sl82c105.c | 247 --- include/linux/ide.h|1 - 11 files changed, 459 insertions(+), 513 deletions(-) Bartlomiej Zolnierkiewicz (5): alim15x3: PIO fallback fix pdc202xx_new: enable DMA for all ATAPI devices it821x: PIO mode setup fixes siimage

Re: [PATCH pata-2.6] hpt366: simplify UltraDMA filtering (take 2)

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Saturday 05 May 2007, Sergei Shtylyov wrote: > Simplify UltraDMA mode filtering in the driver: > > - make use of the newly introduced 'udma_mask' field of 'ide_pci_device_t' to > set the correct hwif->ultra_mask, modifying init_setup_hpt366() to select > the correct mask based on the chip r

Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

2007-05-05 Thread Bartlomiej Zolnierkiewicz
On Saturday 05 May 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > >>HPT36x chip don't seem to have the channel enable bits, so prevent the IDE > >>core > >>from checking them... > > >>Signed-off-by: Sergei

Re: [PATCH pata-2.6] hpt366: simplify UltraDMA filtering (take 2)

2007-05-07 Thread Bartlomiej Zolnierkiewicz
On Sunday 06 May 2007, Sergei Shtylyov wrote: > Hello, I wrote: > > Simplify UltraDMA mode filtering in the driver: > > > - make use of the newly introduced 'udma_mask' field of 'ide_pci_device_t' > > to > > set the correct hwif->ultra_mask, modifying init_setup_hpt366() to select > > the cor

[git patches] IDE update

2007-05-09 Thread Bartlomiej Zolnierkiewicz
drivers/scsi/ide-scsi.c| 30 ++- include/linux/ide.h| 93 + 63 files changed, 1107 insertions(+), 1464 deletions(-) Bartlomiej Zolnierkiewicz (11): ide: fix UDMA/MWDMA/SWDMA masks (v3) ide: rework the code for selecting the best DMA transfer mode (v3)

Re: [PATCH pata-2.6 fix queue] cmd64x: init. code cleanup

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Thursday 10 May 2007, Sergei Shtylyov wrote: > Fix two minor issues with PCI0646 chip reporting in the init_chipset() method: > "IRQ workaround enabled" message printed out not only for revision 0x01 and > "CMD646: chipset revision" printed twice (by IDE core and the driver itself). > Also, remo

Re: [patch 1/2] sl82c105: Switch to ref counting API

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, [EMAIL PROTECTED] wrote: > From: Alan Cox <[EMAIL PROTECTED]> > > Not sure how this one got missed in the great purge some time ago but it > did. > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > Cc: Sergei Shtylyov <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL

Re: [patch 2/2] Use menuconfig objects: IDE

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, [EMAIL PROTECTED] wrote: > From: Jan Engelhardt <[EMAIL PROTECTED]> > > Use menuconfigs instead of menus, so the whole menu can be disabled at once > instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> &

Re: [PATCH pata-2.6 fix queue] aec62xx: rework init_setup_aec6x80()

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, Sergei Shtylyov wrote: > Rework init_setup_aec6x80() so that it won't rewrite the constant name strings > anymore -- in order to do this: > > - in aec62xx_init_one(), pass a local copy of 'struct pci_device_id' down the > call chain; > > - change the names for in aec62xx_

Re: [PATCH pata-2.6 fix queue] aec62xx: remove init_dma() method

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, Sergei Shtylyov wrote: > Get rid of the init_dma() method (which had no particular reason to exist) by > folding it into the init_hwif() method. While at it, also perform some cleanup > in the latter method: > > - get rid of the useless clearing of hwif->autodma; > > - fold

Re: [PATCH pata-2.6 fix queue] aec62xx: kill speedproc() method wrapper

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, Sergei Shtylyov wrote: > There's no reason to have the speedproc() method wrapper for the two quite > different chip families, so just get rid of it. > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH 2/5] Use mutex instead of semaphore in IDE driver

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Monday 14 May 2007, Matthias Kaehlcke wrote: > The IDE driver uses a semaphore as mutex. Use the mutex API instead of > the (binary) semaphore. > > Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> applied Since I already had a patch from you with identical patch summary/description (but f

Re: [PATCH]add the IDE device ID for ATI SB700

2007-05-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 14 May 2007, gmail_ati wrote: > From: [EMAIL PROTECTED] > add the IDE device ids to atiixp_pci_tbl struct in atiixp.c for ATI SB700. > Signed-off-by: Luugi Marsan <[EMAIL PROTECTED]> This patch is somehow missing the chunk adding PCI_DEVICE_ID_ATI_IXP700_IDE define to and thus mak

[git patches] IDE updates/fixes

2007-05-15 Thread Bartlomiej Zolnierkiewicz
- if (ide_use_dma(drive) && config_chipset_for_dma(drive)) + if (ide_tune_dma(drive)) return 0; if (ide_use_fast_pio(drive)) diff --git a/drivers/ide/pci/cs5530.c b/drivers/ide/pci/cs5530.c index b2d7c13..1eec1f3 100644 --- a/drivers/ide/pci/cs5530.c ++

Re: IT821x: no DMA since 2.6.21

2007-05-15 Thread Bartlomiej Zolnierkiewicz
dates to it821x in 2.6.22-rc1 and gave that a try, but > > the problem persists. > > I've had multiple reports of this. I would recommend you use the libata > driver. IT821x hasn't changed over the past few releases so its someting commit 0e9b4e535fec7e2a189952670937adfbe282

Re: IT821x: no DMA since 2.6.21

2007-05-16 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 16 May 2007, Thomas Kuther wrote: > On Mi, 16.05.07 02:58 Bartlomiej Zolnierkiewicz wrote: > > > > > Hi, > > > > On Tuesday 15 May 2007, Alan Cox wrote: > > > On Tue, 15 May 2007 12:53:08 +0200 > > > Thomas Kut

Re: [git patches] IDE updates/fixes

2007-05-16 Thread Bartlomiej Zolnierkiewicz
On Wednesday 16 May 2007, Linus Torvalds wrote: > > On Wed, 16 May 2007, Bartlomiej Zolnierkiewicz wrote: > > > > * host driver fixes: > > - pdc202xx_old: mode programming rewrite (a lot of bugs fixed) > > - serverworks/sis5513: PIO mode setup fixes > &g

Re: [PATCH pata-2.6 fix queue] aec62xx: kill speedproc() method wrapper

2007-05-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 16 May 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > >>There's no reason to have the speedproc() method wrapper for the two quite > >>different chip families, so just get rid of it. > > >>S

Re: [PATCH] ide/pci/serverworks.c: Fix corruption/timeouts with MegaIDE in RAID mode

2007-05-23 Thread Bartlomiej Zolnierkiewicz
On Wednesday 16 May 2007, Alan Cox wrote: > It turns out from customer reports to Red Hat and some PCI dumps that the > MegaIDE in RAID mode doesn't provide the drive tuning data that the > serverworks driver expects but sometimes does provide something that > fools the code. > > For the RAID clas

Re: 2.6.22-rc1-mm1: IDE compile error

2007-05-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 16 May 2007, Adrian Bunk wrote: > On Tue, May 15, 2007 at 08:19:14PM -0700, Andrew Morton wrote: > >... > > - Added an i386 early-startup development tree, as git-newsetup.patch ("H. > > Peter Anvin" <[EMAIL PROTECTED]>) > >... > > Changes since 2.6.21-mm2: > >... > > git-new

Re: [PATCH] Match DMA blacklist entries between ide-dma.c and libata-core.c

2007-05-23 Thread Bartlomiej Zolnierkiewicz
On Tuesday 22 May 2007, Junio C Hamano wrote: > There are a few entries in ata_device_blacklist[] in libata-core.c > marked with HORKAGE_NODMA but are missing from drive_blacklist[] > in ide-dma.c. This patch makes the lists in sync. > > Also remove a duplicated entry for "SanDisk SDP3B-64". > >

Re: Add Seagate STT20000A to DMA blacklist.

2007-05-23 Thread Bartlomiej Zolnierkiewicz
On Monday 21 May 2007, Dave Jones wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=1044 > has been open for _four_ years with a patch available. > Here's a rediffed version of the same. > > Signed-off-by: Dave Jones <[EMAIL PROTECTED]> Uh, it seems that this fix got stuck in the kernel "black

Re: [PATCH] Add two missing chipsets to drivers/ide/ide-proc.c

2007-05-23 Thread Bartlomiej Zolnierkiewicz
On Friday 18 May 2007, Mika Kukkonen wrote: > Compiling with '-Wswitch-enum' I noticed following: > > CC drivers/ide/ide-proc.o > drivers/ide/ide-proc.c: In function ‘proc_ide_read_imodel’: > drivers/ide/ide-proc.c:54: warning: enumeration value ‘ide_etrax100’ not > handled in switch > dri

[git patches] IDE fixes

2007-05-23 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide-dma.c |4 +++- drivers/ide/ide-proc.c|2 ++ drivers/ide/pci/atiixp.c |1 + drivers/ide/pci/serverworks.c | 14 ++ inc

Re: IT821x: no DMA since 2.6.21

2007-05-24 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 18 May 2007, Thomas Kuther wrote: > On Mi, 16.05.07 11:46 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > wrote: > > > > Shall I test it without "noraid=1" too? > > > > Please do, the main goal of the patch was to fix "RAID mode

Re: HPT366 not enabled by kernel 2.6.21.2

2007-05-24 Thread Bartlomiej Zolnierkiewicz
[ adding linux-ide ML and Sergei to cc: ] Hi, On Thursday 24 May 2007, Pascal Schmidt wrote: > > Hello! > > I recently upgraded my kernel to 2.6.21 (.1 and .2 with identical > results) and my second IDE controller, a HPT366 on a PCI card, > doesn't get enabled any more. The latest previous ker

Re: [PATCH 3/3] Make ide dma blacklist handling a bit saner.

2007-05-28 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 22 May 2007, Junio C Hamano wrote: > Earlier, the matching of (model,rev) in ide-dma black/white list > handling was to consider "ALL" in the table to match any > revision. This changes the wildcard to NULL. This way, the > DMA_BLACK_LIST macro used in the previous patch does not

Re: [patch] Add the device IDs for AMD/ATI SB700

2007-05-28 Thread Bartlomiej Zolnierkiewicz
Hi, Sorry for the late reply and thanks to Jeff for stepping in. :) Since Jeff covered both status of your patches and administrative issues I would only like to add one small hint for people adding support for multi-function PCI chipsets (with multiple PCI device IDs): It makes sense to put ad

Re: [PATCH pata-2.6] aec62xx: kill speedproc() method wrapper (take 2)

2007-05-28 Thread Bartlomiej Zolnierkiewicz
On Thursday 24 May 2007, Sergei Shtylyov wrote: > There's no reason to have the speedproc() method wrapper for the two quite > different chip families, so just get rid of it. > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> > > --- > Tthis version of the patch properly installs the speedpro

Re: [PATCH 3/3] Make ide dma blacklist handling a bit saner.

2007-05-30 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 29 May 2007, Junio C Hamano wrote: > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> writes: > > > The change itself looks good but IMO it is worth doing it before patch #2/3 > > (it would also make it possible for me to merge this patch immediately).

Re: [PATCH 1/3] ide_in_drive_list(): accept NULL as the wildcard for firmware revision.

2007-05-30 Thread Bartlomiej Zolnierkiewicz
On Tuesday 29 May 2007, Junio C Hamano wrote: > Earlier, the matching of (model,rev) in ide-dma black/white list > handling was to consider "ALL" in the table to match any > revision. This makes NULL to be also an accepted wildcard, and > changes the entries of tables in ide-dma.c to use NULL. >

Re: [PATCH 2/3] mips au1xxx_ide.h: use NULL as firmware-revision wildcard.

2007-05-30 Thread Bartlomiej Zolnierkiewicz
On Tuesday 29 May 2007, Junio C Hamano wrote: > This updates the DMA whitelist in MIPS specific au1xxx ide > driver to use NULL instead of "ALL" as the wildcard. > > Signed-off-by: Junio C Hamano <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in

Re: [PATCH 3/3] ide_in_drive_list(): "ALL" is not a wildcard anymore.

2007-05-30 Thread Bartlomiej Zolnierkiewicz
On Tuesday 29 May 2007, Junio C Hamano wrote: > This removes the support to treat "ALL" as a wildcard for > firmware revision. This is made a separate patch, as it will > break out-of-tree ide drivers that feed its own table that uses > "ALL" as the wildcard to ide_in_drive_list(). > > Signed-off

Re: Compact Flash performance...

2007-05-30 Thread Bartlomiej Zolnierkiewicz
Hi, Since you are using libata ata_piix driver and not IDE piix one Jeff and/or Alan are the right people to ask this question... Anyway... On Thursday 31 May 2007, Daniel J Blueman wrote: > I have a SanDisk Extreme IV 4GB CF card, capable of 40MB/s read, but > am seeing 30MB/s read [1], connec

[PATCH 2/2] serverworks: fix CSB6 tuning logic

2007-06-02 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/serverworks.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) Index: b/drivers/ide/pci/serverworks.c =

[PATCH 1/2] serverworks: remove crappy code

2007-06-02 Thread Bartlomiej Zolnierkiewicz
igned-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/serverworks.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) Index: b/drivers/ide/pci/serverworks.c === --- a/drivers/ide/pci/s

[PATCH] it821x: RAID mode fixes

2007-06-02 Thread Bartlomiej Zolnierkiewicz
[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> Cc: Jens Axboe <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c | 12 ++-- drivers/ide/pci/it821x.c | 34 ++---

Re: IT821x: no DMA since 2.6.21

2007-06-02 Thread Bartlomiej Zolnierkiewicz
On Thursday 31 May 2007, Thomas Kuther wrote: > On Do, 24.05.07 11:46 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > wrote: > > > > > Hi, > > > > [...] > > > > Improved patch - this time the issue should be fixed for good (I was > > l

Re: [PATCH] HPA Detect From Resume

2007-06-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 12 May 2007, Lee Trager wrote: > Currently when system which have HPA require HPA to be detected and > disabled upon resume from RAM or disk. The current IDE drivers do not do > this nor does libata(obviously it since it doesn't support HPA yet). I > have implemented this into the

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 02 June 2007, Geller Sandor wrote: > On Sat, 2 Jun 2007, Sergei Shtylyov wrote: > > >> The log of a typical IDE reset is available here: > > > >> http://petra.hos.u-szeged.hu/~wildy/syslog.gz > > > >> This was the worst case: the IDE bus was resetted during the system boot. > > >

Re: [PATCH] libata: always use polling SETXFER

2007-06-03 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 03 June 2007, Jeff Garzik wrote: > Tejun Heo wrote: > > Several people have reported LITE-ON LTR-48246S detection failed > > because SETXFER fails. It seems the device raises IRQ too early after > > SETXFER. This is controller independent. The same problem has been > > reported f

<    5   6   7   8   9   10   11   >