pata_marvell, use ioread* for iomap-ped memory
read* on pci_iomapped memory is incorrect, fix it
Signed-off-by: Jiri Slaby [EMAIL PROTECTED]
Cc: Alan Cox [EMAIL PROTECTED]
---
commit 5a28a23f3c53993aaf6e7ef6c392e5f4c20d4a3b
tree 4b3387d330556da54d61d989f2dc75d5258af4ea
parent
imagine a proper fix?
- move to ioreadX/iowriteX
or
- move back to ioremap (unlikely for the most)
or?
thanks,
--
Jiri Slaby ([EMAIL PROTECTED])
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED
Jeff Garzik napsal(a):
If the driver knows its MMIO, using readX/writeX after pci_iomap() is
just fine, for all current implementations, and it makes sense that way.
Hmm, that's what I'm claiming.
--
Jiri Slaby ([EMAIL PROTECTED])
Faculty of Informatics, Masaryk University
-
To unsubscribe
-
Disallow generic driver to grab it by adding next condition. Also
consolidate exceptions to one bigger 'switch (dev-vendor)'.
Cc: Ingo Korb [EMAIL PROTECTED]
Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Signed-off-by: Jiri Slaby [EMAIL PROTECTED]
---
commit
Sergei Shtylyov napsal(a):
Hello.
Jiri Slaby wrote:
diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/generic.c
index f2c5a14..0d51a11 100644
--- a/drivers/ide/pci/generic.c
+++ b/drivers/ide/pci/generic.c
@@ -198,32 +198,41 @@ static ide_pci_device_t generic_chipsets
Sergei Shtylyov napsal(a):
Hello.
Hi.
Sorry -- I thought it was a part of kernel style, but it appeared to
be my aesthetical preference only. :-)
Ok, anyway thanks for reviewing,
--
http://www.fi.muni.cz/~xslaby/Jiri Slaby
faculty of informatics, masaryk university, brno, cz
qc-err_mask |= ac_err_mask;
pdc_reset_port(ap);
+
+ ata_port_abort(ap);
}
static inline unsigned int pdc_host_intr( struct ata_port *ap,
Yes, no freezing anymore.
thanks,
--
http://www.fi.muni.cz/~xslaby/Jiri Slaby
faculty of informatics, masaryk university
PROTECTED]
Cc: Mikael Pettersson [EMAIL PROTECTED]
Signed-off-by: Jiri Slaby [EMAIL PROTECTED]
---
commit a38d21f4b5d5029b0b083fe2651e78c7657fda3b
tree 0a2019a34227906bc5fb0e60d90cc7f4759ee934
parent b5c1fc64195b18d3919bfa7dddfb76e9f2a05786
author Jiri Slaby [EMAIL PROTECTED] Sat, 05 May 2007 16:43:22
Jiri Slaby napsal(a):
Cc: Mikael Pettersson [EMAIL PROTECTED]
Cc: linux-ide@vger.kernel.org
Cc: Jeff Garzik [EMAIL PROTECTED]
Jiri Slaby napsal(a):
Cc: [EMAIL PROTECTED]
Jiri Slaby napsal(a):
Hi,
I have a problem with higher disk loads (e.g. running git-log or yum
update).
Many
00 50 02 fb
20: 00 00 00 fb 00 00 00 00 00 00 00 00 5a 10 73 3d
30: 00 00 00 00 60 00 00 00 00 00 00 00 0a 01 04 12
2.6.19-rc6-mm2 is OK (2.6.19-mm1 untested and won't be)
regards,
--
http://www.fi.muni.cz/~xslaby/Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail
mv_pci_driver = {
+ .name = DRV_NAME,
+ .id_table = mv_pci_tbl,
+ .probe = mv_init_one,
+ .remove = ata_pci_remove_one,
+};
[snip]
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ [EMAIL PROTECTED
11 matches
Mail list logo