Re: PATA driver for Atmel AVR32

2007-07-20 Thread Kristoffer Nyborg Gregertsen
ct ata_host *host = platform_get_drvdata(pdev); struct at32_ide_info *info; if (!host) return 0; info = host->private_data; ata_host_detach(host); if (!info) return 0; pata_at32_hard_reset(&pdev->dev, i

PATA driver for Atmel AVR32

2007-07-20 Thread Kristoffer Nyborg Gregertsen
Can a random signal fault generate this kind of failure? Or is it my driver code that is to blame? Any advice where to look for faults would be appriciated :) -- Kristoffer Nyborg Gregertsen MSc. student / Summer intern Atmel Norway -sh-3.2# modprobe pata_at32 libata version 2.21 loaded. at32_ide at32_i

Re: PATA driver for Atmel AVR32

2007-07-20 Thread Kristoffer Nyborg Gregertsen
On Friday 20 July 2007 11:08:19 Kristoffer Nyborg Gregertsen wrote: > There might be problems with the signals from the AVR32s External Bus > Interface to the ATA device, although it seems fine when looking with the > logic analyzer. Can a random signal fault generate this kind of fa

Re: PATA driver for Atmel AVR32

2007-07-20 Thread Kristoffer Nyborg Gregertsen
; That is wrong. Any mode for PIO2+ will use IORDY. Modes below may require > it sometimes (and its a good signal check). See ata_pio_need_iordy(atadev) Woops, my bad. I'll fix it so that NWAIT is used at all times :) -- Kristoffer Nyborg Gregertsen MSc. student / Summer intern Atmel Norway - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/1] AVR32 PATA driver

2007-08-07 Thread Kristoffer Nyborg Gregertsen
ct? If so, what shall I do when activating the host to not get "irq 65: nobody cared" ... "Disabling IRQ #65". Should I give an negative irq number? Any help and reviews of my code would be appriciate :) -- Kristoffer Nyborg Gregertsen MSc. student / Summer intern Atmel Norwa

[PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Kristoffer Nyborg Gregertsen
This patch adds support for PATA devices on the AVR32 using the CompactFlash controller in 'True IDE mode'. DMA is currently not supported due to lack of DMACK pins on the current AP7000 series. Tested on AP7000 / STK1000. Signed-off-by: Kristoffer Nyborg Gregertsen <[EMAIL PROTECT

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Kristoffer Nyborg Gregertsen
I'm not 100% sure. I now see that things can get messed up. I can alter the hardware so that a seperate SMC memory space for data and register transfer can be used, each with their respective timing set at all times. This will cost one extra chip select pin and an AND port on the adaptor, b

Re: [PATCH 0/1] AVR32 PATA driver

2007-08-07 Thread Kristoffer Nyborg Gregertsen
do in the resetting phases even > with nIEN in use. > > OTOH if you get one or two per command then someone must have nIEN wrong > on command issue. Either way you need to clear down IRQs that occur - > some hardware doesn't get nIEN right and interrupts anyway in some cases. I

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Kristoffer Nyborg Gregertsen
that's not needed by the end users. -- With kind regards Kristoffer Nyborg Gregertsen Student, Department of Engineering Cybernetics Norwegian University of Science and Technology Trondheim, Norway - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the b

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-08 Thread Kristoffer Nyborg Gregertsen
ays at 2.5 volts and generates a lot of interrupts due to ripple / noise. What to do? Signed-off-by: Kristoffer Nyborg Gregertsen <[EMAIL PROTECTED]> --- diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 4ad8675..f6b8dd2 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @

[PATCH 1/1] AVR32 PATA driver

2007-08-13 Thread Kristoffer Nyborg Gregertsen
This patch adds support for PATA devices on the AVR32 using the CompactFlash controller in 'True IDE mode'. DMA is currently not supported due to lack of DMACK pins on the current AP7000 series. Tested on AP7000 / STK1000. Signed-off-by: Kristoffer Nyborg Gregertsen <[EMAIL PROTECT

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-13 Thread Kristoffer Nyborg Gregertsen
... 65: 62025176 eic at32_ide Would I be better off using polling mode? -- Kristoffer Nyborg Gregertsen MSc. student / Summer intern Atmel Norway - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-15 Thread Kristoffer Nyborg Gregertsen
Forget about what I said about using polling, I was just fooled by the benchmark tool. Could the last patch I've sent you be accepted? - Kristoffer Nyborg Gregertsen - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL

[PATCH 1/1] Several fixes for the AVR32 PATA driver

2007-11-29 Thread Kristoffer Nyborg Gregertsen
* Improved some comments. Signed-off-by: Kristoffer Nyborg Gregertsen <[EMAIL PROTECTED]> --- diff --git a/drivers/ata/pata_at32.c b/drivers/ata/pata_at32.c index bb250a4..67e574d 100644 --- a/drivers/ata/pata_at32.c +++ b/drivers/ata/pata_at32.c @@ -28,7 +28,7 @@ #include #define DRV