On Mon, 25 Feb 2008, Jeff Garzik wrote:
> > ...
> >
> > Saeed: isn't this what your SOC patches already implemented for us?
> > As near as I can tell, sata_mv now already has support for the 60x1C0.
>
> Saeed's stuff didn't support PCI though,
this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/sata_mv.c |6 ++
1 files changed, 2 insertions(+),
vm_ioremap and it looks fine. I'll
send the new patch in different email.
saeed
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
iomem still shows that sata_mv uses io mempry after
the rrmod, but when I re-load the driver, I can see it reuses the same
io address range. so it doesn't waste io mem resources.
saeed
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message
this fixes crash bug as the iomap table is not valid for integrated controllers.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 0
this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/sata_mv.c |3 ---
1 files changed, 0 insertions(+),
]
> table.
> sata_mv only ever uses iomap[MV_PRIMARY_BAR=0], so the above patch should
> work around it just fine.
Jeff, do the libata upper drivers use the other BARs? if not, then we can use
pci_iomap to map BAR0, this way we can remove the iomap[] table and use one
iomem pointer for pci
t() while calling dma_pool_alloc(), the patch to fix this is
>> at the end of this email.
> ..
>
> Ouch. I'd say this is proof-positive that Saeed did not even test his
> latest patches. Your fix below looks straightforward and correct.
you're right, the fix
ure that the new patch will not bypass this one? is
there anything git got to do with this?
saeed
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Saeed Bishara <[EMAIL PROTECTED]>
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. This patch extends the libATA sata_mv
driver to support those controllers.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/
From: Saeed Bishara <[EMAIL PROTECTED]>
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/Kconfig |
Hi Jeff,
I've the two patches ready and rebased on the version that you have
in the master branch, specifically on the commit "libata: convert to
chained sg".
Do you prefer to get those rebased patches?
Saeed
-
To unsubscribe from this list: send the line "unsubscribe linux-i
From: Saeed Bishara <[EMAIL PROTECTED]>
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/Kconfig |
more forgiving than git-am)
ok, I'll send the patch as [PATCH v2] in separate email with git-send-email.
saeed
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
case I need to wait till you ack the later ones.
right?
saeed
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 1/16/08, Mark Lord <[EMAIL PROTECTED]> wrote:
> saeed bishara wrote:
> >
> > I attached the new patch
> ..
>
> Try again, please.
> This time, post the patch *inline* in the body of the email,
> so that it can more easily be seen, read, and commented on.
&
On 1/16/08, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> saeed bishara wrote:
> > - if (unlikely(irq_stat & PCI_ERR)) {
> > + if (unlikely(irq_stat & PCI_ERR) && HAS_PCI(host)) {
> > mv_pci_error(host, mmio);
> > handled = 1
> Here is the updated patch according your comments:
> From af124a0fd4984db4fbc8638e0af4e6a41561588d Mon Sep 17 00:00:00 2001
> From: Saeed Bishara <[EMAIL PROTECTED]>
> Date: Sun, 2 Dec 2007 10:43:10 +0200
> Subject: [PATCH] sata_mv: Remove PCI dependency
>
> The in
>
>
Here is the updated patch according your comments:
>From af124a0fd4984db4fbc8638e0af4e6a41561588d Mon Sep 17 00:00:00 2001
From: Saeed Bishara <[EMAIL PROTECTED]>
Date: Sun, 2 Dec 2007 10:43:10 +0200
Subject: [PATCH] sata_mv: Remove PCI dependency
The integrated SATA controll
The mv5_sht and mv6_sht structures are identical. This patch removes one of
those structures and renames the other to mv_sht.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/sata_mv.c | 22 ++
1 files changed, 2 insertions(+), 20 deletions(-)
diff -
>
> I really think that a lot of the new variable/macro/enum names are overly
> long,
> making the code a bit harder to read.
> The patch is all about "System On Chip (SOC)" support,
> yet the names all say "INTEGRATED".
well, many socs have SATA or Ethernet controllers as pci controller,
but in t
On 12/2/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> From: Saeed Bishara <[EMAIL PROTECTED]>
>
> The integrated SATA controller is connected directly to the SoC's
> internal bus, not via PCI interface. this patch removes the dependency
> on the PCI interface.
On 12/2/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>
rebased the patch with the latest updates:
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed B
On 12/3/07, saeed bishara <[EMAIL PROTECTED]> wrote:
> >
> > This patch won't apply, because sata_mv.c was just recently updated
> > to fix 7042 PCIe support. You'll have to rebase this patch against that.
> ok. I'll check that.
Here is the rebased
>
> This patch won't apply, because sata_mv.c was just recently updated
> to fix 7042 PCIe support. You'll have to rebase this patch against that.
ok. I'll check that.
>
> Also, I'm not sure I understand why there's a need for the new sata_mv.h file
> ?
This file contains the definition of the da
From: Saeed Bishara <[EMAIL PROTECTED]>
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/Kconfig |
From: Saeed Bishara <[EMAIL PROTECTED]>
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. The integrated SATA unit is connected
directly to the internal bus of the Orion SoC, and not via PCI.
This patch extends the libATA sata_mv d
From: Saeed Bishara <[EMAIL PROTECTED]>
This patch series adds support for the integrated SATA controller that can be
found in some of Marvell's SoC's. This controller is based on the 88SX7042, but
it connected directly to the internal bus of the SoC and not via PCI.
-
To unsub
From: Saeed Bishara <[EMAIL PROTECTED]>
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. The integrated SATA unit is connected
directly to the internal bus of the Orion SoC, and not via PCI.
This patch extends the libATA sata_mv d
From: Saeed Bishara <[EMAIL PROTECTED]>
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/Kconfig |
From: Saeed Bishara <[EMAIL PROTECTED]>
This patch series adds support for the integrated SATA controller that can be
found in some of Marvell's SoC's. This controller is based on the 88SX7042, but
it connected directly to the internal bus of the SoC and not via PCI.
-
To unsub
From: Saeed Bishara <[EMAIL PROTECTED]>
use sstatus instead status.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index a43f64d..97
From: Saeed Bishara <[EMAIL PROTECTED]>
use sstatus instead status.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index a43f64d..97
33 matches
Mail list logo
