Re: [PATCH] ide: don't set PIO mode on pre-EIDE drives

2007-11-16 Thread Sergei Shtylyov
Alan Cox wrote: Fix handling of the PIO modes for the pre-EIDE drives that did not support the PIO Flow Control Transfer Mode value (1 nnn) of the Set Transfer Mode feature by skipping the actual mode programming. You also need to cater for CF 1.1 compliant devices which do not have

Re: [PATCH] ide: don't set PIO mode on pre-EIDE drives

2007-11-16 Thread Alan Cox
On Fri, 16 Nov 2007 19:45:54 +0300 Sergei Shtylyov [EMAIL PROTECTED] wrote: Alan Cox wrote: Fix handling of the PIO modes for the pre-EIDE drives that did not support the PIO Flow Control Transfer Mode value (1 nnn) of the Set Transfer Mode feature by skipping the actual mode

Re: [PATCH] ide: don't set PIO mode on pre-EIDE drives

2007-11-16 Thread Alan Cox
That's something at least. I hope they also don't set bit 11 -- otherwise, bad luck. Or am I supposed to also check the CF signature? :-) Libata issues the command but ignores an ABRT if the device is CFA or has no iordy flag and PIO = 2 or MWDMA0 is used and the device thinks its in

Re: [PATCH] ide: don't set PIO mode on pre-EIDE drives

2007-11-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 November 2007, Sergei Shtylyov wrote: Fix handling of the PIO modes for the pre-EIDE drives that did not support the PIO Flow Control Transfer Mode value (1 nnn) of the Set Transfer Mode feature by skipping the actual mode programming. Signed-off-by: Sergei Shtylyov [EMAIL