Re: [PATCH] libata: cosmetic clean up in ata_eh_reset()

2007-10-25 Thread Jeff Garzik
Tejun Heo wrote: Local variable @action usage in ata_eh_reset() is a bit confusing. It's used only to cache ehc-i.action to test reset masks after clearing it; however, due to the generic name action, it's easy to misinterpret the local variable as containing the selected reset method later.

[PATCH] libata: cosmetic clean up in ata_eh_reset()

2007-10-24 Thread Tejun Heo
Local variable @action usage in ata_eh_reset() is a bit confusing. It's used only to cache ehc-i.action to test reset masks after clearing it; however, due to the generic name action, it's easy to misinterpret the local variable as containing the selected reset method later. Also, the reason for