Re: [PATCH 1/1] AVR32 PATA driver

2007-08-31 Thread Jeff Garzik
Kristoffer Nyborg Gregertsen wrote: Updated and simplified driver. Use only register transfer timing for both data and register transfers. This gives poorer performance in PIO1 and 2, but should not be a problem in PIO3 and 4, correct me if I'm wrong :) The driver works very we'll but I still

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-15 Thread Kristoffer Nyborg Gregertsen
Forget about what I said about using polling, I was just fooled by the benchmark tool. Could the last patch I've sent you be accepted? - Kristoffer Nyborg Gregertsen - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

[PATCH 1/1] AVR32 PATA driver

2007-08-14 Thread Kristoffer Nyborg Gregertsen
This patch adds support for PATA devices on the AVR32 using the CompactFlash controller in 'True IDE mode'. DMA is currently not supported due to lack of DMACK pins on the current AP7000 series. Tested on AP7000 / STK1000. Signed-off-by: Kristoffer Nyborg Gregertsen [EMAIL PROTECTED] --- diff

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-14 Thread Kristoffer Nyborg Gregertsen
Hi again everybody, The driver is now working very nicely. The sporadic errors I reported earlier were mostly due to the state of the EBI to ATA adaptor prototype card. I have also added some time before R/W strobe to make sure signals are stable. The only thing that bothers me is the huge

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-08 Thread Kristoffer Nyborg Gregertsen
Updated and simplified driver. Use only register transfer timing for both data and register transfers. This gives poorer performance in PIO1 and 2, but should not be a problem in PIO3 and 4, correct me if I'm wrong :) The driver works very we'll but I still wonder about the interrupts. I have an

[PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Kristoffer Nyborg Gregertsen
This patch adds support for PATA devices on the AVR32 using the CompactFlash controller in 'True IDE mode'. DMA is currently not supported due to lack of DMACK pins on the current AP7000 series. Tested on AP7000 / STK1000. Signed-off-by: Kristoffer Nyborg Gregertsen [EMAIL PROTECTED] --- diff

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Alan Cox
+static int pata_at32_get_pio_mask(void) +{ + switch (max_pio) { + case 0: + return 0x01; + case 1: + return 0x03; + case 2: + return 0x07; + case 3: + return 0x0f; + case 4: + return 0x1f; +

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Kristoffer Nyborg Gregertsen
On Tuesday 07 August 2007 17:54:09 Alan Cox wrote: +static int pata_at32_get_pio_mask(void) +{ + switch (max_pio) { + case 0: + return 0x01; + case 1: + return 0x03; + case 2: + return 0x07; + case 3: + return 0x0f; +

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Jeff Garzik
Kristoffer Nyborg Gregertsen wrote: On Tuesday 07 August 2007 17:54:09 Alan Cox wrote: +static int pata_at32_get_pio_mask(void) +{ + switch (max_pio) { + case 0: + return 0x01; + case 1: + return 0x03; + case 2: + return 0x07;

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Kristoffer Nyborg Gregertsen
On Tuesday 07 August 2007 20:14:27 Jeff Garzik wrote: Well, a higher level issue, you should not have a max_pio module parameter at all. Other drivers do not have such a thing. OK, I'll remove it then. It was very convenient during automated testing of all PIO modes, but I guess that's not