On Saturday 14 July 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
[PATCH] icside: fix -speedproc to return on unsupported modes (take 3)
* All other implementations of -speedproc return zero on success
and non-zero on failure. Currently it doesn't matter for icside
Bartlomiej Zolnierkiewicz wrote:
[PATCH] icside: fix -speedproc to return on unsupported modes (take 3)
* All other implementations of -speedproc return zero on success
and non-zero on failure. Currently it doesn't matter for icside host
driver and isn't a bug per se since:
-
On Fri, Jul 13, 2007 at 11:02:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
wee, take 3
I'm probably going to drop this driver as soon as the PATA people get
their finger(s) out and respond to the issues I raised when merging
the pata_icside driver.
v3:
* Remove no longer needed
On Friday 13 July 2007, Russell King wrote:
On Fri, Jul 13, 2007 at 11:02:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
wee, take 3
I'm probably going to drop this driver as soon as the PATA people get
their finger(s) out and respond to the issues I raised when merging
the pata_icside
On Fri, 13 Jul 2007 22:39:48 +0100
Russell King [EMAIL PROTECTED] wrote:
On Fri, Jul 13, 2007 at 11:02:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
wee, take 3
I'm probably going to drop this driver as soon as the PATA people get
their finger(s) out and respond to the issues I raised
Hello.
Bartlomiej Zolnierkiewicz wrote:
Moreover, I think the patch is quite broken. If an invalid DMA mode
is passed, currently the driver sets the cycle time to 480ns (stored
in drive_data) since both cycle_time and use_dma_info will be zero.
Moreover, 'on' will be zero, causing
Hello.
Bartlomiej Zolnierkiewicz wrote:
icside_set_speed() happily accepts unsupported transfer modes which
results in drive-drive_data being set to the maximum value (480)
and drive-current_speed being set to the unsupported transfer mode.
Fix it.
Signed-off-by: Bartlomiej
Hello.
Russell King wrote:
icside_set_speed() happily accepts unsupported transfer modes which
results in drive-drive_data being set to the maximum value (480)
and drive-current_speed being set to the unsupported transfer mode.
Fix it.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL
icside_set_speed() happily accepts unsupported transfer modes which
results in drive-drive_data being set to the maximum value (480)
and drive-current_speed being set to the unsupported transfer mode.
Fix it.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Cc: Russell King [EMAIL
