RE: ide-cd question

2005-03-24 Thread Stuart_Hayes
Bartlomiej Zolnierkiewicz wrote: On Thu, 17 Mar 2005 10:17:58 -0600, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Fri, Mar 04 2005, [EMAIL PROTECTED] wrote: There's still a problem here, you are not initializing nsectors for non-pc requests. And your comments wrap :)

Re: ide-cd question

2005-03-03 Thread Stuart Hayes
I sent in this patch a few weeks ago, and never saw a response... I was wondering if there was a problem with it, or if I need to supply more info...? This patch is against 2.6.11-rc3. It makes sure that when ide_atapi_error() tries to end a failing ATAPI request after 2 reset attempts by

Re: ide-cd question

2005-03-03 Thread Jens Axboe
On Thu, Mar 03 2005, Stuart Hayes wrote: I sent in this patch a few weeks ago, and never saw a response... I was wondering if there was a problem with it, or if I need to supply more info...? This patch is against 2.6.11-rc3. It makes sure that when ide_atapi_error() tries to end a

Re: ide-cd question

2005-02-12 Thread Stuart Hayes
Sorry--this patch is against 2.6.11-rc3. Also sorry for the mangled patch--I'll resend it from another email address shortly. Thanks Stuart OK, here's that patch again--hopefully not mangled this time. Thanks, Stuart --- ide-io.c.orig 2005-02-10 15:23:52.0 -0500 +++ ide-io.c.new 2005-02-10

Re: ide-cd question

2005-02-12 Thread Stuart Hayes
Sorry--this patch is against 2.6.11-rc3. Also sorry for the mangled patch--I'll resend it from another email address shortly. Thanks Stuart OK, here's that patch again--hopefully not mangled this time. Thanks, Stuart This is frustrating. Here it is again: --- ide-io.c.orig 2005-02-10

RE: ide-cd question

2005-02-10 Thread Stuart_Hayes
I'd recommend applying this patch if nobody sees any problems with it. --- ide-cd.c.orig 2005-02-07 10:56:42.0 -0500 +++ ide-cd.c 2005-02-07 10:57:06.0 -0500 @@ -3301,6 +3301,7 @@ static ide_driver_t ide_cdrom_driver = { .supports_dsc_overlap = 1,

RE: ide-cd question

2005-02-10 Thread Stuart_Hayes
Hayes, Stuart wrote: I'd recommend applying this patch if nobody sees any problems with it. --- ide-cd.c.orig2005-02-07 10:56:42.0 -0500 +++ ide-cd.c 2005-02-07 10:57:06.0 -0500 @@ -3301,6 +3301,7 @@ static ide_driver_t ide_cdrom_driver = {

RE: ide-cd question

2005-02-07 Thread Stuart_Hayes
If there is a bug, it is in ide_cdrom_driver declaration. .end_request is not set to ide_cdrom_error. I wondered about that. I'll give that a try. OK, 2.6.11-rc3 has the same issue. The function ide_atapi_error() is calling drive-driver-end_request() when rq-errors exceeds ERROR_MAX,