Tejun Heo wrote:
This patch cleans up libata-acpi such that it looks similar to other
libata files. This patch doesn't introuce any behavior changes.
* make libata-acpi functions take ata_device instead of ata_port +
device index
* s/atadev/adev/
* de-indent local variable declarations
I
Tejun Heo wrote:
This patch cleans up ata_acpi_exec_tfs() and its friends.
* Rename taskfile_array to ata_acpi_gtf and make it __packed as it's
used as argument to ACPI method, and use pointer to ata_acpi_gtf and
number of taskfiles to represent _GTF taskfiles instead of a pointer
casted
Tejun Heo wrote:
* Add missing LOCKING: and RETURNS: to function comment.
* Don't conditionalize warning messages with ata_msg_probe(). Print
directly with KERN_WARNING.
* Drop duplicate debug messages.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-acpi.c | 51
) are active and only prints the CPBs for those commands. That
way it won't spew at inappropriate times like suspend/resume.
[EMAIL PROTECTED]: cleanup]
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Signed-off-by: Andrew Morton
From: Alan Cox [EMAIL PROTECTED]
Yes its no longer 3x2n but 3xxn, I can rename it if you want Jeff
Choose whatever you feel is the best long term name; I have no
preference here.
If you do rename, please follow this slightly special procedure:
* add a MODULE_ALIAS() for the old name
* send
/libata-core.c:1003: warning: format '%lld' expects type 'long long
int', but argument 4 has type 'u64'
Also fix various 80-col bustage.
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send
[EMAIL PROTECTED] wrote:
From: Alan Cox [EMAIL PROTECTED]
Further HPT37x changes
- No 66MHz 370/370A
- Remove dead special case check now we use the DPLL (as per the IDE driver)
Pointed out by Sergei
Signed-off-by: Alan Cox [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
[EMAIL PROTECTED] wrote:
From: Andrew Morton [EMAIL PROTECTED]
This is grubby, but all the ata drivers do it this way.
Would it not be better to do
#define ata_scsi_device_resume NULL
in libata.h, remove all those ifdefs?
(updated version, ug, ug)
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Alan
Mark Lord wrote:
Tejun,
While working on the new hdparm (version 7.0, released today),
I ran into trouble when a buggy SG_IO/ATA_16 packet caused
the libata EH to get confused.
I triggered this by accident, issuing an IDENTIFY command
which incorrectly specified ATA_PROT_NODATA. My error, for
Mark Lord wrote:
Actually, I'm not so sure that this problem hasn't *already* been
posted to this very mailing list.
http://lkml.org/lkml/2006/10/1/264
http://www.mail-archive.com/linux-ide@vger.kernel.org/msg05078.html
...
What Tejun said at the end of that thread :)
That one is a phy-level
Alan Cox wrote:
I am reluctant to do anything about this.
This one does need dealing with. It happens in the real world and the old
IDE paths for this do get triggered and used now and then (we know this
because bugs in them were found). All it takes is a device and a
controller disagreeing
Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
This patch cleans up libata-acpi such that it looks similar to other
libata files. This patch doesn't introuce any behavior changes.
* make libata-acpi functions take ata_device instead of ata_port +
device index
* s/atadev/adev/
* de
Tejun Heo wrote:
ATA_PROT_ATAPI_NODATA is used for PACKET command without CDB. ACPI _GTF
never contains PACKET command. It's always ATA commands.
Ah yes. Thanks for the reminder about the code I wrote :)
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
Tejun Heo wrote:
and thus clear DRQ, right? Stuck DRQ after SRST seems odd to me.
Unfortunately not odd on ata_piix, which can get stuck DRQ-on somewhere
deep inside its IDE emulation engine. And neither draining the FIFO nor
SRST nor a couple other tricks ever helped. The only thing that
: printk warning fixes
drivers/ata/pata_cmd640.c: fix build with CONFIG_PM=n
Conke Hu (1):
ahci.c: remove non-existing SB600 raid id (re-send)
Dmitriy Monakhov (1):
libata: handle ata_pci_device_do_resume() failure while resuming
Jeff Garzik (8):
[libata] sata_mv: remove
Chuck Ebbert wrote:
Jeff Garzik wrote:
Jeff Garzik (8):
libata/IDE: remove combined mode quirk
You can't just remove the combined_mode= kernel parameter or
every Linux user who uses that will get an unbootable kernel
with no good way of diagnosing the problem. It should still
Stephen Clark wrote:
Yeah the kernel will boot but the hd performance is sh*t on my laptop. I
am running FC6 with
kernel 2.6.21 and without the combined_mode setting my disk performance
goes down to a
whopping 1.25mb/sec from 44mb/sec when I boot with combined_mode=libata.
It make my
system
Chuck Ebbert wrote:
Jeff Garzik wrote:
Chuck Ebbert wrote:
Jeff Garzik wrote:
Jeff Garzik (8):
libata/IDE: remove combined mode quirk
You can't just remove the combined_mode= kernel parameter or
every Linux user who uses that will get an unbootable kernel
with no good way of diagnosing
Mark Lord wrote:
Gee... Two crazy screwed up devices today. What's going on?
libata is finally seeing use by non-kernel developers.
Amusing but factually incorrect. libata has been shipping in major
distros for years, with bazoodles of active users.
Jeff
-
To unsubscribe from
Mark Lord wrote:
Jeff?
This has been pending for a very long time now.
This patch brings libata up to similar standards as Linux IDE
with support for things like hdparm -I (identify) and -C (check power)
among others on ATAPI drives.
Andrew, can you pick this up for -mm ??
???
My reluctance
[EMAIL PROTECTED] wrote:
2.6.21 breaks HPT366 - back to 2.6.20
I thought Bart/Sergei had fixed this. Are you using libata or old-IDE
driver?
2.6.20 breaks ZIP - back to 2.6.19
What does this mean? How is it broken?
Jeff
-
To unsubscribe from this list: send the line
+++-
32 files changed, 321 insertions(+), 212 deletions(-)
Jeff Garzik (1):
[libata reset-seq] build and merge fixes
Tejun Heo (4):
libata: add deadline support to prereset and reset methods
libata: improve 0xff status handling
libata: improve ata_std_prereset
Tejun Heo wrote:
Albert, if Jeff agrees with pushing HSM or data transfer to workqueue,
are you interested in doing that? The HSM is your baby after all. :-)
It's always been my desire to do PIO from a workqueue if possible, since
it is so slow.
Jeff
-
To unsubscribe from this
Henry Su wrote:
From: [EMAIL PROTECTED]
Adding the device ID for AMD/ATI SB700.
Signed-off-by:henry su [EMAIL PROTECTED]
Time to train new people...
You need to split up your patches:
* send I2C and PCI quirk patches to GregKH
* send drivers/ide/* stuff to Bart
* send drivers/ata/* patches to
Chuck Ebbert wrote:
Tejun Heo wrote:
FWIW several distros have turned off MSI by default and added
a pci=msi option to enable it.
Yeah, it seem to cause a lot of problems on certain chips but I think
the correct path is to add PCI quirks for those. Most MSI problems I've
seen are on these ATI
Bartlomiej Zolnierkiewicz wrote:
Bartlomiej Zolnierkiewicz (11):
ide: fix UDMA/MWDMA/SWDMA masks (v3)
ide: rework the code for selecting the best DMA transfer mode (v3)
ide: add ide_tune_dma() helper
ide: make /proc/ide/ optional
ide: split off ioctl handling from
Bartlomiej Zolnierkiewicz wrote:
* the code for selecting and programming the best DMA transfer mode
has been reworked to be cleaner, more generic and more libata-like,
( 500 LOCs gone and this change allows the change described below)
Bartlomiej Zolnierkiewicz (11):
ide: rework the
Andrew Morton wrote:
Jeff Garzik [EMAIL PROTECTED] wrote:
Has this seen testing/exposure in -mm tree?
argh. If this was in a file called
ide-rework-the-code-for-selecting-the-best-DMA-transfer-mode.patch then it
would be so easy.
logs into hera
greps
ah, it's hidden in ide-max-dma-mode
Bartlomiej Zolnierkiewicz wrote:
On Thursday 10 May 2007, Jeff Garzik wrote:
The limit was raised to 400K IIRC.
That's (good) news to me, here goes the actual 150K patch:
Thanks. I did in fact receive copies from vger, so it went through.
Jeff
-
To unsubscribe from this list
Tejun Heo wrote:
It seems the world isn't as frank as we thought and some devices lie
about who they are. Fallback to the other IDENTIFY if IDENTIFY fails
with device error. As this is the strategy used by IDE for a long
time, it shouldn't cause too much problem.
Signed-off-by: Tejun Heo
Mikael Pettersson wrote:
The sata_promise error decode update changed pdc_host_intr()
to return and not complete the qc after detecting an error.
Unfortunately not completing the qc:s causes them to always
time out on error, which is wrong and has nasty side-effects.
This patch updates
Richard Kennedy wrote:
update pata_pcmcia to add card ident for JVC MP-CDX1 cdrom drive
card info:
PRODID_1=KME
PRODID_2=KXLC005
PRODID_3=00
MANFID=0032,2904
Signed-off-by: Richard Kennedy [EMAIL PROTECTED]
---
patch against 2.6.21.1
applied
-
To unsubscribe from this list: send the line
Tejun Heo wrote:
For some reason, sata_via is missing PM hooks. Add them. Spotted by
Jeroen Janssen [EMAIL PROTECTED].
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Jeroen Janssen [EMAIL PROTECTED]
---
I have no idea how we missed this. This is for both libata-dev
-stable. Thanks.
Alexey Dobriyan wrote:
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/ata/pata_scc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More
Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Warning(linux-2.6.21-git4//drivers/ata/libata-core.c:904): No description found
for parameter 'new_sectors'
Warning(linux-2.6.21-git4//drivers/ata/libata-core.c:941): No description found
for parameter 'new_sectors'
Signed-off-by:
Jesse Barnes wrote:
On Sunday, April 29, 2007 9:15 am Jeff Garzik wrote:
Noteworthy changes:
* remove combined mode PCI quirk. IDE driver selection (libata or
old-IDE) is now determined purely by module load order.
* new driver API, that is far more like other kernel APIs:
alloc...register
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
Documentation/kernel-parameters.txt |8 ---
drivers/ata/libata-acpi.c |3 +-
drivers/ata/libata-core.c |
Mark Lord wrote:
Same here, but I would like to see it in there under a CONFIG_DEBUG_LIBATA
kernel build option or something. Kind of like the FANCY_STATUS_DUMPS
flag
that drivers/ide used to have for this kind of stuff.
The long term goal is to enable verbose output with a module option
Mark Lord wrote:
If we're compiling the messages into the kernel regardless,
then it doesn't really make much sense to NOT show all of them
on the error paths.
Not true. Uncontrolled message spewage inevitably results in critical
information scrolling off the screen, before a user can take
Robert Hancock wrote:
I don't think this is as big of a deal here as in other cases, like oops
output. With libata errors, if they're at the console (which they'd have
to be to see these messages), unless something has actually caused a
panic the scrollback buffer should still be functional
Tomasz Chmielewski wrote:
I'm a little confused about sata_mv hotplug status.
According to http://linux-ata.org/driver-status.html#marvell, the driver
has full SATA control including hotplug.
A bit down on that same page, the matrix
http://linux-ata.org/driver-status.html#matrix says
Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Reimplement suspend/resume support using sdev-manage_start_stop.
* Device suspend/resume is now SCSI layer's responsibility and the
code is simplified a lot.
* DPM is dropped. This also simplifies code a lot. Suspend/resume
status
Tejun Heo wrote:
libata enables SCSI host during ATA host activation which happens
after IRQ handler is registered and IRQ is enabled. All ATA ports are
in frozen state when IRQ is enabled but frozen ports may raise limited
number of IRQs after being frozen - IOW, -freeze() is not responsible
Tejun Heo wrote:
It seems the world isn't as frank as we thought and some devices lie
about who they are. Fallback to the other IDENTIFY if IDENTIFY is
aborted by the device. As this is the strategy used by IDE for a long
time, it shouldn't cause too much problem.
Signed-off-by: Tejun Heo
Tejun Heo wrote:
+ if (class == ATA_DEV_ATA)
+ class = ATA_DEV_ATAPI;
+ else
+ class = ATA_DEV_ATA;
the 'else' branch is obviously redundant
-
To unsubscribe from this list: send the line
Tejun Heo wrote:
ACPI applies to both SATA and PATA. Drop the 'S' from the config
variable.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/Kconfig| 26 +-
drivers/ata/Makefile |2 +-
drivers/ata/libata.h |2 +-
include/linux/libata.h |
[EMAIL PROTECTED] wrote:
From: Oleg Nesterov [EMAIL PROTECTED]
We should not use cancel_work_sync(delayed_work-work). This works, but not
good. We can use cancel_rearming_delayed_work(), this also simplifies the
code.
Signed-off-by: Oleg Nesterov [EMAIL PROTECTED]
Signed-off-by: Andrew Morton
[EMAIL PROTECTED] wrote:
From: Andrew Morton [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
drivers/ata/sata_via.c |4
1 file changed, 4 deletions(-)
applied
-
To unsubscribe from this list
[EMAIL PROTECTED] wrote:
From: Aeschbacher, Fabrice [EMAIL PROTECTED]
Allow the pata_pcmcia driver to automatically detect 2GB CompactFlash cards
from Transcend.
Signed-off-by: Fabrice Aeschbacher [EMAIL PROTECTED]
Cc: Peter Stuge [EMAIL PROTECTED]
Acked-by: Alan Cox [EMAIL PROTECTED]
Cc:
for Linux since the
kernel has supported AHCI.
Signed-off-by: Luugi Marsan [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
drivers/pci/quirks.c|1 +
include/linux/pci_ids.h |1 +
2 files changed, 2
[EMAIL PROTECTED] wrote:
From: Henry Su [EMAIL PROTECTED]
Add the device ID to AHCI pci table for ATI SB700 SATA controller, the
subsequent chipset of SB600.
Signed-off-by: henry su[EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Signed-off-by: Andrew Morton
[EMAIL PROTECTED] wrote:
From: Jan Engelhardt [EMAIL PROTECTED]
Use menuconfigs instead of menus, so the whole menu can be disabled at once
instead of going through all options.
Signed-off-by: Jan Engelhardt [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton
Olof Johansson wrote:
Hi,
I have a system where I have a simple IDE controller that sits on a
local bus without bus master dma capability, and thus no dma_mapping
ops defined for the device/bus.
pata_platform works great for me, with the exception of using the generic
ata_port_start which
Robert Hancock wrote:
The ATA ones are more of a pain in that regard than SCSI though - SCSI
has all distinct error codes for different errors, whereas ATA has
bitmasks for everything..
That should not affect implementation. Either way, a table-driven
approach can easily work.
I favor
Peer Chen wrote:
For sata_nv driver in kernel 2.6.21 onward, Inside nv_init_one(),use
'hpriv = devm_kzalloc(pdev-dev, sizeof(*hpriv), GFP_KERNEL);' but
using the kfree(hpriv) to free that data struction in nv_remove_one(),
which will cause system hang when removing the sata_nv module.
Change
Tejun Heo wrote:
Unlocking ap-lock and ssleeping don't work because SCSI commands can
be issued from completion path without context. Reimplement delayed
completion by allowing translation functions to override
qc-scsidone(), storing the original completion function to
scmd-scsi_done() and
Tejun Heo wrote:
Our assumption that most distros issue STANDBYNOW seems wrong. The
upstream sysvinit and thus many distros including gentoo and opensuse
don't take any action for libata disks on spindown. We can skip
compat handling for these distros so that they don't need to update
anything
All bug fixes. The two things that do not seem like bugfixes (separate
out... and add ATA_FLAG_ACPI_SATA) are not as they seem. The former
is a prep patch for a fix, and the latter fixes what ACPI considers a
legacy IDE interface.
Please pull from 'upstream-linus' branch of
[EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
drivers/ata/sata_nv.c |6 --
1 file changed, 6 deletions(-)
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Tejun Heo wrote:
As with all other drivers, sata_nv's hpriv is allocated with
devm_kzalloc() and there's no need to free it explicitly. Kill
nv_remove_one() which incorrectly used kfree() instead of devm_kfree()
and use ata_pci_remove_one() directly.
Original fix is from Peer Chen.
Tejun Heo wrote:
With STANDBYDOWN tracking added, libata.spindown_compat isn't
necessary anymore. If userspace shutdown(8) issues STANDBYNOW, libata
warns. If userspace shutdown(8) doesn't issue STANDBYNOW, libata does
the right thing. Userspace can tell whether kernel supports spindown
by
Tejun Heo wrote:
pcim_iomap_regions() conversion missed BAR5. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Sorry, dunno how I missed that during testing. :-( Please verify this
fixes your problem.
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index d105d2c..ac4f43c
Benjamin Herrenschmidt wrote:
This patch adds MMIO support to the pata_sil680 for taskfile IOs,
based on what the old siimage does.
I haven't bothered changing the chip setup stuff from PCI config
cycles to MMIO though (siimage does it), I don't think it matters,
I've only adapted it to use
);
-MODULE_PARM_DESC(spindown_compat, Enable backward compatible spindown
-behavior. Will be removed. More info can be found in
-Documentation/feature-removal-schedule.txt\n);
-
MODULE_AUTHOR(Jeff Garzik);
MODULE_DESCRIPTION(Library module for ATA devices);
MODULE_LICENSE(GPL
b2a4d29570403f611689e786372e8a4afbdf8891
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Dec 1 22:58:31 2006 -0500
[libata sata_sil] Greatly improve DMA handling
311x hardware includes a vendor-specific scatter/gather format which
eliminates the traditional 64k boundary limit found in PCI IDE DMA
Below is a refresh of my on-going effort to convert sata_mv to the new
exception handling framework. sata_mv is one of the last hold-outs, and
its old-EH implementation blocks new features like hotplug and NCQ.
It works for me on the one 50xx and one 60xx card I tested it on, but
other testers
This is the work-in-progress for supporting the newer Marvell PATA/SATA
chips like the 6145.
SATA support works, but PATA support is not implemented at all.
There is some temporary code that makes sure the PATA port is disabled,
if enabled.
This can be found in the 'mv-ahci' branch of
Robert Hancock wrote:
Jeff Garzik wrote:
Since Alan expressed a desire to see Large Block Transfer (LBT) support
in pata_sil680, I though I would re-post my patch for adding LBT support
to sata_sil.
Silicon Image's Large Block Transfer (LBT) support is a vendor-specific
DMA scatter/gather
Jeff Garzik wrote:
rotfl. Boy am I dumb. I -thought- my patch, written months ago,
included that bit. But obviously it does not. Let's add that...
Or not. It just gets rid of the 64k boundary -and- allows for larger
scatter/gather entries. LBT does not add 64-bit DMA support
Indan Zupancic wrote:
This patch seems to work with my SiI 3512, though I don't notice any
difference, neither a speedup, nor a slowdown. Hdparm gives the same
speeds (-tT), and cp -a'ing kernel sources is abysmal slow in both cases,
(need to look into that one) so I didn't really test it that
Stupid BIOS crap like that is largely the reason why I am reluctant to
merge pata_acpi. There is a lot of knowledge like this yet to be
discovered.
I would feel far more comfortable disassembling the AML like you are
doing...
Jeff
-
To unsubscribe from this list: send the line
Jens Axboe wrote:
ahci has always had clustering disabled, perhaps Jeff can expand on why?
Just historical reasons. libata had clustering disabled by default in
the beginning, for all drivers. Then we enabled it globally by changing
the value of ATA_SHT_USE_CLUSTERING... but apparently
Tejun Heo wrote:
SB600 claims it can do 64bit DMA but it can't. Disable it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Jeff, this one is for #upstream-fixes.
ahci.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
applied
-
To unsubscribe from this list: send the
Tejun Heo wrote:
Recent mmio change broke compilation if PM is turned on. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
---
pata_sil680.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
applied
-
To unsubscribe from this list:
Dave Jones wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=1044 points out an
additional hard disk that doesn't handle DMA transfers correctly.
This patch is the libata variant of the earlier patch to drivers/ide/
Signed-off-by: Dave Jones [EMAIL PROTECTED]
applied
-
To unsubscribe from
Alan Cox wrote:
Various people had problems with both old and new IDE when hpt366 enable
bits started getting honoured. It turns out they are not reliable so
don't rely on them
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe
Alan Cox wrote:
With cable methods in place we don't need a custom error handler for SATA
so get rid of it
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Alan Cox wrote:
As of the -mm tree we don't have post_set_mode users any more.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
):
libata: Add Seagate STT2A to DMA blacklist.
Jeff Garzik (2):
libata: Trim trailing whitespace
libata: bump versions
Tejun Heo (1):
ahci: disable 64bit dma on sb600
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index ad1f59c..b4a8d60 100644
--- a/drivers/ata
Andrew Paprocki wrote:
I have a Gigabyte GA-965P-DQ6 motherboard which has onboard Intel ICH8
raid as well as a Gigabyte (rebranded JMicron) chipset for 2
separate SATA ports. When I boot the machine, it completely
sporadically fails to initialize the JMB361 chipset which it detects,
claiming
George T. Joseph (development) wrote:
Hi Jeff,
Two issues with the patch...
msi has to be disabled for the Marvell or the driver load will throw a
nobody cared message and eventually hang before discovering all the
drives.
Light I/O works fine but heavy I/O generates
exception Emask 0x0 Sact
Wakko Warner wrote:
In kernel 2.6.20, this driver is marked as experimental. How well does this
driver work? I was concidering a supermicro 8 port sata controller and it
appears to use this driver. I really do not wish to use anything that is
experimental.
It's still beta. It needs error
MMIO has always been like this (libata-core.c):
/* software reset. causes dev0 to be selected */
iowrite8(ap-ctl, ioaddr-ctl_addr);
udelay(20); /* FIXME: flush */
iowrite8(ap-ctl | ATA_SRST, ioaddr-ctl_addr);
udelay(20); /* FIXME: flush */
Uwe Koziolek wrote:
The sata_sis driver supports SATA and PATA ports. The broken support
of both types in one controller is fixed.
the pata133 sis controllers does not support a drive present status
in the pci configspace like the older sis controllers, check removed.
Signed-off-by: Uwe
Alan Cox wrote:
Currently libata does the 400ns thingy in the inline ata_pause() which
unconditionally does ata_altstatus(); ndelay(400); (and thus does it on
PIO, MMIO, anything ...).
It might actually improve performance for PATA if we did as we'll get rid
of an excess (expensive) PCI read
Art Haas wrote:
On Tue, May 01, 2007 at 05:02:22AM +0200, Tejun Heo wrote:
Hello, Art Haas.
Art Haas wrote:
Hi.
Back in the beginning of February I was sent a patch to test during the
time the CD-ROM identification bug was affecting my computer. The
first posting of the patch appeared on
Alan Cox wrote:
On Thu, 24 May 2007 06:52:13 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Alan Cox wrote:
Currently libata does the 400ns thingy in the inline ata_pause() which
unconditionally does ata_altstatus(); ndelay(400); (and thus does it on
PIO, MMIO, anything ...).
It might actually
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ata_piix.c |1 +
drivers/ata/libata-core.c |4 +-
drivers/ata/pata_hpt3x2n.c |4 +-
Alan Cox wrote:
#define DELAY400NS { pio_inbyte( CB_ASTAT ); pio_inbyte( CB_ASTAT ); \
pio_inbyte( CB_ASTAT ); pio_inbyte( CB_ASTAT ); }
Totally unrelated. Hal is using the cycle time of the four I/O reads to
do the 400nS delay. Its a neat way to do the delay on
Tejun Heo wrote:
* Add acpi_handle to ata_host and ata_port. Rename
ata_device-obj_handle to -acpi_handle and move it above such that
it doesn't get cleared on reconfiguration.
* Replace ACPI node association which ata_acpi_associate() which is
called once during host initialization.
Tejun Heo wrote:
ap-cbl == ATA_CBL_SATA indicates SATA cable while ap-flags
ATA_FLAG_SATA indicates SATA host port. Till now they always gave the
same result but SATA/PATA bridge handling will change that. Switch to
ATA_FLAG_SATA test if we're testing for host port type.
Signed-off-by: Tejun
Jens Axboe wrote:
On Mon, May 21 2007, Jeff Garzik wrote:
Jens Axboe wrote:
ahci has always had clustering disabled, perhaps Jeff can expand on why?
Just historical reasons. libata had clustering disabled by default in
the beginning, for all drivers. Then we enabled it globally
Kristen Carlson Accardi wrote:
Hi Jeff,
Here are the AN patches again, they have not changed with the exception
of patch #1, which does set the host flag in board_ahci and board_ahci_pi
now (thanks Tejun).
This patch series implements Asynchronous Notification (AN) for SATA
ATAPI devices as
Kristen Carlson Accardi wrote:
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
---
Andrew, I cleaned up the function header to properly comply with kernel
doc requirements. Other than that, this
Simon Griph wrote:
With NCQ enabled, this drive always hangs when under load and remains
hung until the next cold boot.
Very similar to: http://thread.gmane.org/gmane.linux.ide/17640
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 0abd72d..17e27e9 100644
---
Daniel Beichl wrote:
+static int sil_check_atapi_dma(struct ata_queued_cmd *qc)
+{
+ /* limit atapi commands less than 60bytes to pio as certain sil */
+ /* chips seem to have trouble to perform dma for these commands */
+ if ( (qc-scsicmd != NULL)
+
Henry Su wrote:
--- linux-2.6.21.1.orig/drivers/ata/pata_atiixp.c 2007-05-10
06:30:14.0 폍
linux-2.6.21.1/drivers/ata/pata_atiixp.c 2007-05-10 07:17:07.0 폍
@@ -283,6 ,7 @@ static const struct pci_device_id atiixp
{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP300_IDE),
) controller. Now respun as a single patch, and the function name
shortened as requested.
Signed-off-by: Tony Vroon [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 21
I moved the sil680 MMIO changes from 'upstream' (queued for 2.6.23) to a
side branch 'sil680-mmio'.
To be clear, I am still quite interested in the patch (w/ the reset
fix), but I did not want to delay other unrelated stuff that was about
to be queued into #upstream.
The patch will still
Benjamin Herrenschmidt wrote:
On Thu, 2007-05-24 at 23:33 -0400, Jeff Garzik wrote:
I moved the sil680 MMIO changes from 'upstream' (queued for 2.6.23) to
a
side branch 'sil680-mmio'.
To be clear, I am still quite interested in the patch (w/ the reset
fix), but I did not want to delay other
601 - 700 of 1579 matches
Mail list logo
