Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
On 7/21/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: #try 4: Ive changed the error handling so it only should release stuff it actually had aquired. Looks good, thank you. Can I please get a "signed-off-by:" form you so I can apply it to the input tree? -- Dmitry

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Kristoffer Ericson
#try 4: Ive changed the error handling so it only should release stuff it actually had aquired. Best wishes Kristoffer diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index c97d5eb..4a77c87 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kc

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
Hi Kristoffer, On 7/18/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: Try #2 Thanks for feedback, Ive tried a different approach to get it better handled. Thank you for making the changes I requested, however there is still an issue: + + ret = request_irq(IRQ_GPIO0, +

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Fri, Jul 20, 2007 at 02:51:02PM -0400, Dmitry Torokhov wrote: > On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: >> On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: >> > Hi Geert, >> > >> > On 7/20/07, Geert Uytterhoeven <[EM

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
On 7/21/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: Greetings, Ive added it to free IRQ as you said, a minor change is also that jornada720.h defines are set in CAPS (just changed that for Russell). Ive also added the Kconfig and Makefile. Btw, do you keep patchtracker (like Russell) or

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Kristoffer Ericson
Greetings, Ive added it to free IRQ as you said, a minor change is also that jornada720.h defines are set in CAPS (just changed that for Russell). Ive also added the Kconfig and Makefile. Btw, do you keep patchtracker (like Russell) or drag from mail (like Paul)? Best wishes Kristoffer diff

Re: [PATCH] USB: driver for CM109 chipset

2007-07-20 Thread Dmitry Torokhov
On 7/12/07, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: On Thu, Jul 12, 2007 at 12:22:10PM -0400, Dmitry Torokhov wrote: > >> Hmm, they use KEY_0 through KEY_9 now. > > > >Which results in the phone sending 'é+ěščřžýáí' instead of > >'0123456789' > >on a Czech keyboard, which is definitely not wha

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 02:51:02PM -0400, Dmitry Torokhov wrote: > On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: >> On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: >> > Hi Geert, >> > >> > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> >> From: Geert Uytterhoeven

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > Hi Geert, > > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> From: Geert Uytterhoeven <[EMAIL PROTECTED]> >> >> m68k/mac: Make mac_hid_mouse_emulate_buttons() declar

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > Hi Geert, > > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> From: Geert Uytterhoeven <[EMAIL PROTECTED]> >> >> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible >> >> drivers/char/keyboard.c: In funct

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
Hi Geert, On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: From: Geert Uytterhoeven <[EMAIL PROTECTED]> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of f

[patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons' The forward declaration of ma