Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-08-17 Thread Marvin Raaijmakers
Ah this is the part that checks for a change in key state: !!test_bit(usage->code, input->key) != value Well, in that case: yes, this is the functionality I was looking for. - Marvin On Fri, 2007-08-17 at 16:42 +0200, Jiri Kosina wrote: > On Fri, 17 Aug 2007, Marvin Raaijmakers wrote: > > > Thi

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-08-17 Thread Jiri Kosina
On Fri, 17 Aug 2007, Marvin Raaijmakers wrote: > This code doesn't filter out the "status events" right? So that still > needs to be done(?). Hi Marvin, I am not sure what you mean by that -- this patch is supposed to issue input_event(EV_MSC, MSC_SCAN) if and only if it would mean the change i

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-08-17 Thread Marvin Raaijmakers
This code doesn't filter out the "status events" right? So that still needs to be done(?). - Marvin On Fri, 2007-08-17 at 12:22 +0200, Jiri Kosina wrote: > (CCs trimmed a little bit) > > On Fri, 17 Aug 2007, Marvin Raaijmakers wrote: > > > What's the current state of this patch? > > Hi Marvin,

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-08-17 Thread Jiri Kosina
(CCs trimmed a little bit) On Fri, 17 Aug 2007, Marvin Raaijmakers wrote: > What's the current state of this patch? Hi Marvin, does the patch below establish the functionality you are looking for? Please note that we do the reporting only for such usages that have the type of EV_KEY. diff -

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-08-17 Thread Marvin Raaijmakers
What's the current state of this patch? - Marvin Raaijmakers On Thu, 2007-08-02 at 23:27 +0200, Vojtech Pavlik wrote: > On Mon, Jul 30, 2007 at 04:09:04PM +0200, Jiri Kosina wrote: > > ** > > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c > > index 7f81789..c604a1d 100644 > > ---

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-08-02 Thread Vojtech Pavlik
On Mon, Jul 30, 2007 at 04:09:04PM +0200, Jiri Kosina wrote: > ** > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c > index 7f81789..c604a1d 100644 > --- a/drivers/hid/hid-input.c > +++ b/drivers/hid/hid-input.c > @@ -818,6 +818,11 @@ static void hidinput_configure_usage(struct hid_i

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-30 Thread Jiri Kosina
On Fri, 20 Jul 2007, federico ferri wrote: > oh, great! finally I got to remap F13 to SysRq (which was keycode 99). > would be nice to have some informations in the manpage about how to > find/dump those raw scancodes, cause with showkey/evtest I only see > translated keycodes. [I added keyfuzz

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-19 Thread federico ferri
Dmitry Torokhov ha scritto: do you see some solution? perhaps can you supply an example of re-mapping F13 to SysRq? KEY_F13 is normally assigned to usage 0x00070068. Since you want your F13 to be used as SysRq you need map that usage to KEY_SYSRQ. Please try doing: echo "458856 84" | keyfuzz

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-19 Thread Dmitry Torokhov
On 7/19/07, federico ferri <[EMAIL PROTECTED]> wrote: Dmitry Torokhov ha scritto: >> # echo "84 183" | keyfuzz -s -d/dev/input/event1 >> EVIOCGKEYCODE: Invalid argument >> >> # echo "84 183" | keyfuzz -s -d/dev/input/event2 >> EVIOCGKEYCODE: Invalid argument >> >> # echo "0x05d 0x0b7" | keyfuzz -

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-19 Thread federico ferri
Dmitry Torokhov ha scritto: # echo "84 183" | keyfuzz -s -d/dev/input/event1 EVIOCGKEYCODE: Invalid argument # echo "84 183" | keyfuzz -s -d/dev/input/event2 EVIOCGKEYCODE: Invalid argument # echo "0x05d 0x0b7" | keyfuzz -s -d/dev/input/event2 EVIOCGKEYCODE: Invalid argument What is 84? For SU

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-19 Thread Dmitry Torokhov
On 7/19/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: On 7/18/07, federico ferri <[EMAIL PROTECTED]> wrote: > Dmitry Torokhov ha scritto: > > EVIOCSKEYCODE support for HID (USB) went in in 2.6.22-rc1. > > > > There is keyfuzz utility you can use to play with keymaps for a > > particular device:

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-19 Thread Dmitry Torokhov
On 7/18/07, federico ferri <[EMAIL PROTECTED]> wrote: Dmitry Torokhov ha scritto: > EVIOCSKEYCODE support for HID (USB) went in in 2.6.22-rc1. > > There is keyfuzz utility you can use to play with keymaps for a > particular device: > > http://0pointer.de/lennart/projects/keyfuzz/ hi Dmitry,

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-18 Thread federico ferri
Dmitry Torokhov ha scritto: EVIOCSKEYCODE support for HID (USB) went in in 2.6.22-rc1. There is keyfuzz utility you can use to play with keymaps for a particular device: http://0pointer.de/lennart/projects/keyfuzz/ hi Dmitry, I tried keyfuzz, but I'm not able to change sysrq key (I get a

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-17 Thread Dmitry Torokhov
On 7/17/07, federico ferri <[EMAIL PROTECTED]> wrote: Dmitry Torokhov ha scritto: >> Dmitry? Any reason not to do this? >> > > Recent kernels have the ability to remap keymap for USB keyboards via > EVIOCSKEYCODE ioctl (we allowed 0adjusting keymaps on PS/2 keyboards > for a long time). So instea

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread federico ferri
Dmitry Torokhov ha scritto: Dmitry? Any reason not to do this? Recent kernels have the ability to remap keymap for USB keyboards via EVIOCSKEYCODE ioctl (we allowed 0adjusting keymaps on PS/2 keyboards for a long time). So instead of having the new parameter redefining SysRq keycode Frederico

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread Dmitry Torokhov
Hi Linus, On 7/15/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: On Mon, 16 Jul 2007, federico ferri wrote: > Linus Torvalds ha scritto: > > Well, this is totally untested, and I won't guarantee that this works > > at all, but this is how to generally do these kinds of things.. > > YAY! it wor

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread federico ferri
Linus Torvalds ha scritto: > On Sun, 15 Jul 2007, federico ferri wrote: > >> this patch adds an entry in Kconfig after 'config MAGIC_SYSRQ' which >> asks for a different keycode (replacing also KEY_SYSRQ with >> CONFIG_MAGIC_SYSRQ_KEYCODE in char/keyboard.c) >> > > Quite frankly, I think th

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread federico ferri
Linus Torvalds ha scritto: > Well, this is totally untested, and I won't guarantee that this works at > all, but this is how to generally do these kinds of things.. > YAY! it works great. tried with: # echo 183 > /sys/module/keyboard/parameters/sysrq_key but also keyboard.sys_rq=183 on the comm

[PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread federico ferri
this patch adds an entry in Kconfig after 'config MAGIC_SYSRQ' which asks for a different keycode (replacing also KEY_SYSRQ with CONFIG_MAGIC_SYSRQ_KEYCODE in char/keyboard.c) it was tested on some USB keyboards (Microsoft and Apple USB keyboards, and it works) I sumbitted this patch two years ag

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread Linus Torvalds
On Mon, 16 Jul 2007, federico ferri wrote: > Linus Torvalds ha scritto: > > Well, this is totally untested, and I won't guarantee that this works > > at all, but this is how to generally do these kinds of things.. > > YAY! it works great. > tried with: > # echo 183 > /sys/module/keyboard/par

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread Linus Torvalds
On Sun, 15 Jul 2007, federico ferri wrote: >> > (I can imagine it could be done via a /proc/sysrq-keycode virtual file, > but that's just one possibility) > > So, this should turn into a feature request... > would you accept feature requests? ( : Well, this is totally untested, and I won't gu

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread Linus Torvalds
On Sun, 15 Jul 2007, federico ferri wrote: > > this patch adds an entry in Kconfig after 'config MAGIC_SYSRQ' which > asks for a different keycode (replacing also KEY_SYSRQ with > CONFIG_MAGIC_SYSRQ_KEYCODE in char/keyboard.c) Quite frankly, I think that if we want to make something like this c