Re: [PATCH v3 1/1] cap11xx: add runtime PM support

2015-08-20 Thread Matt Ranostay
On Thu, Aug 20, 2015 at 5:37 PM, Dmitry Torokhov wrote: > Hi Matt, > > On Tue, Aug 18, 2015 at 06:21:29PM -0700, Matt Ranostay wrote: >> >> +static int cap11xx_i2c_remove(struct i2c_client *i2c_client) >> +{ >> + struct cap11xx_priv *priv = i2c_get_clientdata(i2c_client); >> + >> + cap11xx

Re: [PATCH] joystick/zhenhua: remove zhenhua_bitreverse()

2015-08-20 Thread Dmitry Torokhov
On Tue, Aug 11, 2015 at 01:49:34PM +0800, yalin wang wrote: > This change remove zhenhua_bitreverse() function, use generic > bitrev8() function instead. > > Signed-off-by: yalin wang Applied, thank you. > --- > drivers/input/joystick/zhenhua.c | 13 ++--- > 1 file changed, 2 insertion

Re: [PATCH v3 1/1] cap11xx: add runtime PM support

2015-08-20 Thread Dmitry Torokhov
Hi Matt, On Tue, Aug 18, 2015 at 06:21:29PM -0700, Matt Ranostay wrote: > > +static int cap11xx_i2c_remove(struct i2c_client *i2c_client) > +{ > + struct cap11xx_priv *priv = i2c_get_clientdata(i2c_client); > + > + cap11xx_set_sleep(priv, true); > + pm_runtime_disable(&i2c_client->de

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Dmitry Torokhov
Hi Gabor, On Thu, Aug 20, 2015 at 4:35 PM, Gabor Balla wrote: > Hi Dmitry, > >> How about this one? > > It looks fine for me, I've also tested it and it works. Thanks for trying it out! > Still, can we do something about synaptics_set_disable_gesture() function too? > Not sure what it does, but

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Gabor Balla
Hi Dmitry, > How about this one? It looks fine for me, I've also tested it and it works. Still, can we do something about synaptics_set_disable_gesture() function too? Not sure what it does, but it certainly looks like it could break EWmode. I've included a possible solution. Regards, Gabor dif

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Dmitry Torokhov
On Thu, Aug 20, 2015 at 04:08:40PM -0700, Dmitry Torokhov wrote: > Hi Gabor, > > On Fri, Aug 21, 2015 at 01:05:46AM +0200, Gabor Balla wrote: > > Hi Dmitry, > > > > On Fri, Aug 21, 2015 at 1:01 AM, Dmitry Torokhov > > wrote: > > > On Thu, Aug 20, 2015 at 3:56 PM, Dmitry Torokhov > > > wrote: >

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Dmitry Torokhov
Hi Gabor, On Fri, Aug 21, 2015 at 01:05:46AM +0200, Gabor Balla wrote: > Hi Dmitry, > > On Fri, Aug 21, 2015 at 1:01 AM, Dmitry Torokhov > wrote: > > On Thu, Aug 20, 2015 at 3:56 PM, Dmitry Torokhov > > wrote: > >> On Fri, Aug 21, 2015 at 12:24:59AM +0200, Gabor Balla wrote: > >>> Hi Dmitry, >

[PATCH 1/2] HID: wacom: Set button bits based on a new numbered_buttons

2015-08-20 Thread Aaron Skomra
Prior to this commit, numbered button bit setting was done separately for each device type in wacom_setup_pad_capabilities(). Here we add a numbered_buttons property to the wacom_features struct and extract the repeated bit setting code to a new function: wacom_settup_numbered_buttons(). Signed-of

[PATCH 2/2] HID: wacom: Add support for Express Key Remote.

2015-08-20 Thread Aaron Skomra
This device is pad (buttons) only, there is no stylus or touch. Up to five remotes can pair with the device's associated USB dongle. Signed-off-by: Aaron Skomra Reviewed-by: Jason Gerecke --- Documentation/ABI/testing/sysfs-driver-wacom | 19 +++ drivers/hid/wacom.h |

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Gabor Balla
Hi Dmitry, On Fri, Aug 21, 2015 at 1:01 AM, Dmitry Torokhov wrote: > On Thu, Aug 20, 2015 at 3:56 PM, Dmitry Torokhov > wrote: >> On Fri, Aug 21, 2015 at 12:24:59AM +0200, Gabor Balla wrote: >>> Hi Dmitry, >>> >>> On Thu, Aug 20, 2015 at 11:35 PM, Dmitry Torokhov >>> wrote: >>> > On Thu, Aug 20

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Dmitry Torokhov
On Thu, Aug 20, 2015 at 3:56 PM, Dmitry Torokhov wrote: > On Fri, Aug 21, 2015 at 12:24:59AM +0200, Gabor Balla wrote: >> Hi Dmitry, >> >> On Thu, Aug 20, 2015 at 11:35 PM, Dmitry Torokhov >> wrote: >> > On Thu, Aug 20, 2015 at 10:50:27PM +0200, Gabor Balla wrote: >> [...] >> >> At some point a n

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Dmitry Torokhov
On Fri, Aug 21, 2015 at 12:24:59AM +0200, Gabor Balla wrote: > Hi Dmitry, > > On Thu, Aug 20, 2015 at 11:35 PM, Dmitry Torokhov > wrote: > > On Thu, Aug 20, 2015 at 10:50:27PM +0200, Gabor Balla wrote: > [...] > >> At some point a new PS/2 mode was introduced by Synaptics, called EWmode. > >> Th

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Gabor Balla
Hi Dmitry, I've prepared another possible fix, that checks the current mode for Wmode bit. Regards, Gabor diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 6025eb4..7ec72a6 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -5

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Gabor Balla
Hi Dmitry, On Thu, Aug 20, 2015 at 11:35 PM, Dmitry Torokhov wrote: > On Thu, Aug 20, 2015 at 10:50:27PM +0200, Gabor Balla wrote: [...] >> At some point a new PS/2 mode was introduced by Synaptics, called EWmode. >> This >> can be enabled by setting bit 2 of the mode byte. But previously this b

Re: [PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-20 Thread Michael Welling
On Thu, Aug 20, 2015 at 05:41:30PM +0530, Vignesh R wrote: > > > On 08/19/2015 11:38 PM, Michael Welling wrote: > > On Wed, Aug 12, 2015 at 01:44:22PM -0500, Michael Welling wrote: > >> On Wed, Aug 12, 2015 at 11:56:36AM +0530, Vignesh R wrote: > >>> Hi Michael, > >>> > >>> + Dmitry > >>> > >>> O

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Dmitry Torokhov
Hi Gabor, On Thu, Aug 20, 2015 at 10:50:27PM +0200, Gabor Balla wrote: > Hi, > > I could also reproduce this issue using a T450s, but have probably found the > issue behind it. > > At some point a new PS/2 mode was introduced by Synaptics, called EWmode. This > can be enabled by setting bit 2 of

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-20 Thread Gabor Balla
Hi, I could also reproduce this issue using a T450s, but have probably found the issue behind it. At some point a new PS/2 mode was introduced by Synaptics, called EWmode. This can be enabled by setting bit 2 of the mode byte. But previously this bit was used for 'Disable Gesture', whatever that

Re: input: gpio_keys_polled: Request GPIO pin as input.

2015-08-20 Thread Dmitry Torokhov
On Thu, Aug 20, 2015 at 07:50:00PM +0200, Vincent Pelletier wrote: > GPIOF_IN flag was lost in: > Commit 633a21d80b4a("input: gpio_keys_polled: Add support for GPIO > descriptors"). > > Without this flag, legacy code path (for non-descriptor GPIO declarations) > would configure GPIO as output (0 m

[Try 2] input: gpio_keys_polled: Request GPIO pin as input.

2015-08-20 Thread Vincent Pelletier
Changes since try 1: - Added Reviewed-By Mika - Made commit log more verbose (I'm very bad at this suggestions very welcome) Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo

input: gpio_keys_polled: Request GPIO pin as input.

2015-08-20 Thread Vincent Pelletier
GPIOF_IN flag was lost in: Commit 633a21d80b4a("input: gpio_keys_polled: Add support for GPIO descriptors"). Without this flag, legacy code path (for non-descriptor GPIO declarations) would configure GPIO as output (0 meaning GPIOF_DIR_OUT | GPIOF_INIT_LOW). Signed-off-by: Vincent Pelletier Revi

Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()

2015-08-20 Thread Alexander Kuleshov
Hello Jiri, On 08-19-15, Jiri Kosina wrote: > On Wed, 19 Aug 2015, Alexander Kuleshov wrote: > > > > > - hid_debug_init(); > > + if (hid_debug) > > + hid_debug_init(); > > How is this change related to the rest of the patch? > > It's wrong anyway, because hid_debug is independen

[PATCH v3] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()

2015-08-20 Thread Alexander Kuleshov
The debugfs_create_dir() and debugfs_create_file() functions may return -errno if an error occurs. This patch adds a couple of checks of the result of the debufs_create_dir() and debugfs_create_file() functions execution in the hid_debug_register() and othre places. Changelog: v3: * do not che

Re: [PATCH] ALSA: ac97: Switch to dev_pm_ops

2015-08-20 Thread Mark Brown
On Thu, Aug 20, 2015 at 06:35:24PM +0200, Lars-Peter Clausen wrote: > On 08/20/2015 06:33 PM, Mark Brown wrote: > > Just discussed this in person with Dmitry: I'll apply the patch just now > > for v4.3 and we can incrementally improve the ifdef handling after. > Great, thanks. I was about to send

Re: [PATCH] ALSA: ac97: Switch to dev_pm_ops

2015-08-20 Thread Lars-Peter Clausen
On 08/20/2015 06:33 PM, Mark Brown wrote: > On Fri, Aug 07, 2015 at 09:32:13AM -0700, Dmitry Torokhov wrote: >> On Fri, Aug 07, 2015 at 10:13:48AM +0200, Lars-Peter Clausen wrote: > >>> We know that it is used when CONFIG_PM_SLEEP is defined and we know that it >>> is unused CONFIG_PM_SLEEP is not

Re: [PATCH] ALSA: ac97: Switch to dev_pm_ops

2015-08-20 Thread Mark Brown
On Fri, Aug 07, 2015 at 09:32:13AM -0700, Dmitry Torokhov wrote: > On Fri, Aug 07, 2015 at 10:13:48AM +0200, Lars-Peter Clausen wrote: > > We know that it is used when CONFIG_PM_SLEEP is defined and we know that it > > is unused CONFIG_PM_SLEEP is not defined. Marking the function as > > __maybe_u

Re: [PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-20 Thread Vignesh R
On 08/19/2015 11:38 PM, Michael Welling wrote: > On Wed, Aug 12, 2015 at 01:44:22PM -0500, Michael Welling wrote: >> On Wed, Aug 12, 2015 at 11:56:36AM +0530, Vignesh R wrote: >>> Hi Michael, >>> >>> + Dmitry >>> >>> On 08/12/2015 12:15 AM, Michael Welling wrote: Adds a device tree parameter

Re: [PATCH v5] input: Add ROHM BU21023/24 Dual touch support resistive touchscreens

2015-08-20 Thread Yuasa Yoichi
Hi Dmitry, I updated the driver according to your comments. Do you have any comments? Thanks, Yoichi 2015-08-07 18:06 GMT+09:00 Yoichi Yuasa : > v5 Changes: > - contact count variables move to array > - remove unneeded u16 casts in #define > - remove module parameters > - handle "no fingers" as