The critical section protected by usbhid->lock in hid_ctrl() is too
big and because of this it causes a recursive deadlock. "Too big" means
the case statement and the call to hid_input_report() do not need to be
protected by the spinlock (no URB operations are done inside them).
The deadlock happe
On Thu, 19 Nov 2015 22:34:18 +0100 (CET)
Jiri Kosina wrote:
> Could you please reformulate the changelog in this respect and resubmit?
Yes, of course, I tried to reformulate the problem and solution as clear and
succint as I could in v2, which I'll send shortly.
Thank you very much for your pati
On 11/20/2015 04:32 PM, Javier Martinez Canillas wrote:
[snip]
>
> But is not complete because the .driver_data in i2c_device_id is an
> kernel_ulong_t while the .data in of_device_id is a const void * so
> some casting will be needed to add an OF table in some drivers that
Some casting in the
Hello Dmitry,
On 11/20/2015 04:15 PM, Dmitry Torokhov wrote:
> On Fri, Nov 20, 2015 at 04:09:42PM -0300, Javier Martinez Canillas wrote:
>> The Atmel maxtouch DT binding documents that the compatible string for
>> the device is "atmel,maxtouch" and the I2C core always reports a module
>> alias of
On Fri, Nov 20, 2015 at 08:19:52PM +0100, Hans de Goede wrote:
> Hi,
>
> On 20-11-15 19:54, Dmitry Torokhov wrote:
> >On Fri, Nov 20, 2015 at 02:24:49PM +0100, Hans de Goede wrote:
> >>From: Sander Vermin
> >>
> >>On some devices the wake and enable pins of the pixcir touchscreen
> >>controller a
Hi,
On 20-11-15 19:54, Dmitry Torokhov wrote:
On Fri, Nov 20, 2015 at 02:24:49PM +0100, Hans de Goede wrote:
From: Sander Vermin
On some devices the wake and enable pins of the pixcir touchscreen
controller are connected to gpios and these must be controlled by the
driver for the device to op
On Fri, Nov 20, 2015 at 04:09:42PM -0300, Javier Martinez Canillas wrote:
> The Atmel maxtouch DT binding documents that the compatible string for
> the device is "atmel,maxtouch" and the I2C core always reports a module
> alias of the form i2c:alias where alias is the compatible string model:
>
>
The Atmel maxtouch DT binding documents that the compatible string for
the device is "atmel,maxtouch" and the I2C core always reports a module
alias of the form i2c:alias where alias is the compatible string model:
$ grep MODALIAS /sys/devices/platform/12e0.i2c/i2c-8/8-004b/uevent
MODALIAS=i2c
The Atmel maxtouch DT binding documents that the compatible string for
the device is "atmel,maxtouch" but the I2C core always reports a module
alias of the form i2c:alias where alias is the compatible string model:
MODALIAS=i2c:maxtouch
But there isn't maxtouch entry in the I2C device ID table so
On Fri, Nov 20, 2015 at 02:24:49PM +0100, Hans de Goede wrote:
> From: Sander Vermin
>
> On some devices the wake and enable pins of the pixcir touchscreen
> controller are connected to gpios and these must be controlled by the
> driver for the device to operate properly.
>
> Signed-off-by: Sand
Hi,
On 20-11-15 18:27, Dmitry Torokhov wrote:
On Fri, Nov 20, 2015 at 12:17:10PM +0100, Hans de Goede wrote:
From: Sander Vermin
On some devices the wake and enable pins of the pixcir touchscreen
controller are connected to gpios and these must be controlled by the
driver for the device to op
On Fri, Nov 20, 2015 at 09:52:14AM +0100, Benjamin Tissoires wrote:
> Hi Duson,
>
> A user reported a non working touchpad on his Asus Zenbook UX305CA.
> The touchpad is the ELAN1000 which has been added to v4.3:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1281990
>
> In the logs, I see:
>
On Fri, Nov 20, 2015 at 12:17:10PM +0100, Hans de Goede wrote:
> From: Sander Vermin
>
> On some devices the wake and enable pins of the pixcir touchscreen
> controller are connected to gpios and these must be controlled by the
> driver for the device to operate properly.
>
> Signed-off-by: Sand
On Fri, Nov 20, 2015 at 7:44 AM, Rob Herring wrote:
> On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote:
>> Add ESD (Electrostatic Discharge) protection mechanism.
>
> [...]
>
>> This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
>> driver gt9xx.c for Android (publicl
On Thu, Nov 19, 2015 at 02:26:35PM +0200, Irina Tirdea wrote:
> After power on, it is recommended that the driver resets the device.
> The reset procedure timing is described in the datasheet and is used
> at device init (before writing device configuration) and
> for power management. It is a sequ
On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote:
> Add ESD (Electrostatic Discharge) protection mechanism.
[...]
> This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
> driver gt9xx.c for Android (publicly available in Android kernel
> trees for various devices).
>
On Fri, Nov 20, 2015 at 12:17:10PM +0100, Hans de Goede wrote:
> From: Sander Vermin
>
> On some devices the wake and enable pins of the pixcir touchscreen
> controller are connected to gpios and these must be controlled by the
> driver for the device to operate properly.
>
> Signed-off-by: Sand
Hi,
On Tuesday 17 November 2015 10:17:20 Dmitry Torokhov wrote:
> On Mon, Nov 16, 2015 at 01:01:07PM +0100, Markus Pargmann wrote:
> > This is a driver for the imx25 ADC/TSC module. It controls the
> > touchscreen conversion queue and creates a touchscreen input device.
> > The driver currently on
Use the touchscreen_parse_properties and touchscreen_apply_prop_to_x_y
functions, instead of DIY code, this results in a nice cleanup.
Signed-off-by: Hans de Goede
---
Changes in v2:
-Call input_set_capability() before calling touchscreen_parse_properties()
---
drivers/input/touchscreen/chipone_
Add a node describing the touchscreen found on the pov protab2-ips9
tablet.
Signed-off-by: Hans de Goede
---
arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 23 +++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts
b/arch/arm/
From: Sander Vermin
On some devices the wake and enable pins of the pixcir touchscreen
controller are connected to gpios and these must be controlled by the
driver for the device to operate properly.
Signed-off-by: Sander Vermin
Signed-off-by: Hans de Goede
---
Changes in v2 (Hans de Goede):
-
Add support for axis inversion / swapping using the new
touchscreen_parse_properties and touchscreen_apply_prop_to_x_y
functionality.
Signed-off-by: Hans de Goede
---
Changes in v2:
-Add a fix which actually makes this patch compile, which accidentally ended
up in a later commit in my tree
---
Add a node describing the touchscreen controller used on the iNet1 tablet.
Signed-off-by: Hans de Goede
---
arch/arm/boot/dts/sun4i-a10-inet1.dts | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10-inet1.dts
b/arch/arm/boot/dts/sun4i-a10-inet1.d
Add support for axis inversion / swapping using the new
touchscreen_parse_properties and touchscreen_apply_prop_to_x_y
functionality.
Signed-off-by: Hans de Goede
---
drivers/input/touchscreen/edt-ft5x06.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/input/t
Hi Dimtry and Maxime,
Brown paper-bag release of this series fixing 2 issues which I missed
during initial testing. First the original coverletter again:
This patch-set extends the of_touchscreen.c helpers to (optionally) also
deal with axis inversion / swapping, and patches a bunch of drivers to
Extend touchscreen_parse_properties() with support for the
touchscreen-inverted-x/y and touchscreen-swapped-x-y properties and
add a touchscreen_apply_prop_to_x_y() helper function for adjusting
x and y coordinates to take these properties into account.
This commit also modifies the existing calle
> -Original Message-
> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> Sent: 19 November, 2015 20:21
> To: Tirdea, Irina
> Cc: Bastien Nocera; Aleksei Mamlin; Karsten Merker;
> linux-input@vger.kernel.org; Mark Rutland; Rob Herring; Purdila, Octavian;
> linux-
> ker...@vger.k
Hi,
On 20-11-15 12:22, Russell King - ARM Linux wrote:
On Fri, Nov 20, 2015 at 12:17:06PM +0100, Hans de Goede wrote:
This patch-set extends the of_touchscreen.c helpers to (optionally) also
deal with axis inversion / swapping, and patches a bunch of drivers to use
this new functionality.
Wha
On Fri, Nov 20, 2015 at 12:17:06PM +0100, Hans de Goede wrote:
> This patch-set extends the of_touchscreen.c helpers to (optionally) also
> deal with axis inversion / swapping, and patches a bunch of drivers to use
> this new functionality.
What's wrong with using tslib? tslib supports axis trans
Add a node describing the touchscreen controller used on the iNet1 tablet.
Signed-off-by: Hans de Goede
---
arch/arm/boot/dts/sun4i-a10-inet1.dts | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10-inet1.dts
b/arch/arm/boot/dts/sun4i-a10-inet1.d
Use the touchscreen_parse_properties and touchscreen_apply_prop_to_x_y
functions, instead of DIY code, this results in a nice cleanup.
Signed-off-by: Hans de Goede
---
drivers/input/touchscreen/chipone_icn8318.c | 56 +++--
1 file changed, 12 insertions(+), 44 deletions(-
From: Sander Vermin
On some devices the wake and enable pins of the pixcir touchscreen
controller are connected to gpios and these must be controlled by the
driver for the device to operate properly.
Signed-off-by: Sander Vermin
Signed-off-by: Hans de Goede
---
Changes in v2 (Hans de Goede):
-
Add a node describing the touchscreen found on the pov protab2-ips9
tablet.
Signed-off-by: Hans de Goede
---
arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 23 +++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts
b/arch/arm/
Add support for axis inversion / swapping using the new
touchscreen_parse_properties and touchscreen_apply_prop_to_x_y
functionality.
Signed-off-by: Hans de Goede
---
drivers/input/touchscreen/edt-ft5x06.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/input/t
Add support for axis inversion / swapping using the new
touchscreen_parse_properties and touchscreen_apply_prop_to_x_y
functionality.
Signed-off-by: Hans de Goede
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/in
Extend touchscreen_parse_properties() with support for the
touchscreen-inverted-x/y and touchscreen-swapped-x-y properties and
add a touchscreen_apply_prop_to_x_y() helper function for adjusting
x and y coordinates to take these properties into account.
This commit also modifies the existing calle
Hi Dimtry and Maxime,
This patch-set extends the of_touchscreen.c helpers to (optionally) also
deal with axis inversion / swapping, and patches a bunch of drivers to use
this new functionality.
One of the modified drivers is the pixcir_i2c_ts driver. Sander Vermin
has been helping me with getting
Following Launchpad bug 1513914 status being changed to Triaged; as requested I
have prepared the Kernel.org format information which is listed below.
Martyn Berry (new to Linux, hope this information is being sent to the correct
persons)
[1.]
Dell E7440 touchpad jumps position.
[2.]
Dell E744
The usage Confidence is mandary to Windows Precision Touchpad devices. The
appearance of this usage is checked in hidinput_connect but the quirk
MT_QUIRK_VALID_IS_CONFIDENCE is not applied to device accordingly.
Apply this quirk and also remove quirk MT_QUIRK_ALWAYS_VALID to enable palm
rejection f
On Thu, 5 Nov 2015, Oliver Neukum wrote:
> If an event is discarded the device stays idle.
> Just reverse the order of check and marking busy.
>
> Signed-off-by: Oliver Neukum
Hi Oliver,
thanks for the fix. This is a real bug, so I am wondering whether you have
seen causing it real problems (
On Sat, 14 Nov 2015, Rasmus Villemoes wrote:
> scnprintf() exists to provide these semantics, so we might as well use
> it.
>
> Signed-off-by: Rasmus Villemoes
Applied to hid.git#for-4.5/core. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux
On Thu, 19 Nov 2015, Simon Wood wrote:
> Patch-V3 tweaked as per Benjamin's and Dmitry's requests.
>
> This series of patches provide input support for the Logitech G920 gaming
> wheel.
This is now in hid.git#for-4.5/logitech.
Dmitry -- I've put the first patch into
hid.git#for-dmitry
On Fri, 20 Nov 2015, Jimmy Berry wrote:
> Without quirk keyboard repeats '6' until volume control is used since it
> indicates the key is pressed without ever releasing.
>
> Signed-off-by: Jimmy Berry
Applied to for-4.4/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
From: Jiri Kosina
Benjamin has been helping a lot over time with reviewing patches flowing
into HID subsystem. Let's make it official.
Acked-by: Benjamin Tissoires
Signed-off-by: Jiri Kosina
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Hi Duson,
A user reported a non working touchpad on his Asus Zenbook UX305CA.
The touchpad is the ELAN1000 which has been added to v4.3:
https://bugzilla.redhat.com/show_bug.cgi?id=1281990
In the logs, I see:
[ 16.636101] i2c_designware i2c_designware.0:
i2c_dw_handle_tx_abort: lost arbitrati
On Tue, Nov 17, 2015 at 10:00:52AM -0800, Dmitry Torokhov wrote:
> On Tue, Nov 17, 2015 at 07:10:15PM +0530, Sudip Mukherjee wrote:
> > db9_parport_cb is a local uninitialized structure and the member
> > function pointers will be pointing to arbitrary locations unless they
> > are cleared.
> >
>
Hi Simon,
On Nov 19 2015 or thereabouts, Simon Wood wrote:
> Patch-V3 tweaked as per Benjamin's and Dmitry's requests.
>
If you just amended with my comments and Dmitry's, you can keep the
previous Rev-by while resending the series (as a general rule).
The series is still rev-by me.
Cheers,
Be
47 matches
Mail list logo
