[PATCH] Input: rohm_bu21023 - fix handling of retrying firmware update

2016-01-06 Thread Dmitry Torokhov
Because of the wrong condition we'd never retry firmware update. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/touchscreen/rohm_bu21023.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/rohm_bu21023.c b/drivers

Re: [PATCH] Input: ALPS - Report v3 pinnacle trackstick device only if is present

2016-01-06 Thread Dmitry Torokhov
On Tue, Jan 05, 2016 at 05:54:19PM +0100, Pali Rohár wrote: > On Monday 23 March 2015 12:42:25 Hans de Goede wrote: > > Hi, > > > > On 22-03-15 14:47, Pali Rohár wrote: > > >This patch move v3 pinnacle code for trackstick detection from > > >alps_hw_init_v3() > > >to alps_set_protocol() so

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-06 Thread Dmitry Torokhov
On Wed, Jan 06, 2016 at 03:36:57PM +0100, Jiri Kosina wrote: > On Mon, 4 Jan 2016, Benjamin Tissoires wrote: > > > Jiri, I *think* this commit still is in your next pull request for > > Linus. We might want to drop it before it hits Linus' tree. > > What exactly would be the reasoning for

Re: [PATCH v11 0/8] Goodix touchscreen enhancements

2016-01-05 Thread Dmitry Torokhov
Hi Karsten, On Tue, Jan 5, 2016 at 12:03 PM, Karsten Merker <mer...@debian.org> wrote: > On Thu, Dec 17, 2015 at 05:13:18PM -0800, Dmitry Torokhov wrote: >> On Thu, Nov 19, 2015 at 02:26:33PM +0200, Irina Tirdea wrote: >> > This patchset depends on Dmitry's patch that fixe

Re: [PATCH] Input: xpad - use LED API when identifying wireless controllers

2016-01-04 Thread Dmitry Torokhov
On Thu, Dec 24, 2015 at 07:11:22PM +0100, Pavel Rojtberg wrote: > > for me this one did the trick. The correct LED lights up after resume. > > Integrated it here (master): > https://github.com/paroj/xpad Pavel, I refreshed my xpad branch on kernel.org folding the reset_resume and anchor changes

Re: [PATCH 2/2] Input: elants_i2c: fixed wake-on-touch issue

2016-01-04 Thread Dmitry Torokhov
Hi James, On Mon, Jan 04, 2016 at 02:57:50PM +0800, james.chen wrote: > From: "james.chen" > > Fix function of wake-on-touch on suspend/resume. > The function of device_may_wakeup will return true if > the device supports wake-on-touch (for example, kitty and buddy). >

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-04 Thread Dmitry Torokhov
Hi Simon, On Mon, Jan 04, 2016 at 01:05:35PM -0700, Simon Wood wrote: > > On Mon, 4 Jan 2016 02:55:24 -0700, Benjamin Tissoires wrote: > your next pull request for > > Linus. We might want to drop it before it hits Linus' tree. > > > > We can still keep the HID work in place even if the device

Re: [PATCH] input: gpio_keys: Fix check for disabling unsupported key

2016-01-04 Thread Dmitry Torokhov
On Sun, Jan 03, 2016 at 11:21:16PM +0200, Ivaylo Dimitrov wrote: > Commit 4ea14a53d8f881034fa9e186653821c4e3d9a8fb ("Input: gpio-keys - > report error when disabling unsupported key") tried to prevent an > unsupported key to disabled. Unfortunately it effectively broke the driver > in a way so no

Re: [PATCH] Input: i8042 add Fujitsu Lifebook U745 to the nomux list

2016-01-02 Thread Dmitry Torokhov
On Wed, Dec 30, 2015 at 01:14:23AM +0100, Aurélien Francillon wrote: > Without i8042.nomux=1 the Elantech touch pad is not working at all on > a Fujitsu Lifebook U745. This patch does not seem necessary for all > U745 (maybe because of different BIOS versions?). However, it was > verified that the

Re: [PATCH] Input: bma150 - constify bma150_cfg structure

2016-01-02 Thread Dmitry Torokhov
On Wed, Dec 30, 2015 at 12:11:19PM +0100, Julia Lawall wrote: > The bma150_cfg structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied, thank you. > > --- > drivers/input/misc/bma150.c |2 +-

Re: [PATCH 3/7] input: touchscreen: use to_delayed_work

2016-01-02 Thread Dmitry Torokhov
On Fri, Jan 01, 2016 at 10:59:08PM +0800, Geliang Tang wrote: > Use to_delayed_work() instead of open-coding it. > > Signed-off-by: Geliang Tang Applied, thank you. > --- > drivers/input/touchscreen/pcap_ts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] Input: evdev - drop partial events after emptying the buffer

2016-01-02 Thread Dmitry Torokhov
On Thu, Dec 31, 2015 at 03:36:47AM +0530, Aniroop Mathur wrote: > This patch introduces concept to drop partial events in evdev handler > itself after emptying the buffer which are dropped by all evdev > clients in userspace after SYN_DROPPED occurs. > This in turn saves space of partial events in

Re: [PATCH] Input: byd - add BYD PS/2 touchpad driver

2016-01-02 Thread Dmitry Torokhov
Hi Chris, On Mon, Dec 28, 2015 at 03:15:36AM +, ch...@diamand.org wrote: > From: Chris Diamand > > Driver for the BYD BTP10463 touchpad. This patch sends the magic > command sequence to enable gesture recognition, and interprets the > resulting intellimouse-style packets.

Re: [PATCH] input:touchscreen:Properly check touchscreen information is read in ads7846_probe

2015-12-22 Thread Dmitry Torokhov
On Tue, Dec 22, 2015 at 9:58 AM, Nicholas Krause wrote: > This properly checks if touchscreen information is read before > allocating a sysfs_group of files for this device's device > structure's kobject(s) and if we fail to read the information > successfully then we must

Re: [PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-21 Thread Dmitry Torokhov
On Sun, Dec 20, 2015 at 01:49:25PM +0100, Pavel Rojtberg wrote: > 2015-12-20 8:55 GMT+01:00 Dmitry Torokhov <dmitry.torok...@gmail.com>: > > On Sat, Dec 19, 2015 at 10:17:09PM +0100, Clement Calmels wrote: > >> On Wed, 16 Dec 2015 14:44:08 -0800 > >> Dmitry To

Re: [patch] Input: egalax: potential NULL dereference on error

2015-12-19 Thread Dmitry Torokhov
Hi Dan, On Sat, Dec 19, 2015 at 01:58:24PM +0300, Dan Carpenter wrote: > We didn't check input_allocate_device() for failures so it could lead to > a NULL deref. > > Fixes: 6b0f8f9c52ef ('Input: add eGalaxTouch serial touchscreen driver') > Signed-off-by: Dan Carpenter

Re: [PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-19 Thread Dmitry Torokhov
On Sat, Dec 19, 2015 at 10:17:09PM +0100, Clement Calmels wrote: > On Wed, 16 Dec 2015 14:44:08 -0800 > Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > > > When lighting up the segment identifying wireless controller, Instead > > of sending command directly to the

Re: [PATCH] CHROMIUM: Input: elants_i2c: fixed wake-on-touch issue

2015-12-18 Thread Dmitry Torokhov
Hi James, On Fri, Dec 18, 2015 at 10:48:48AM +0800, james.chen wrote: > From: "james.chen" > > Something wrong in suspend/resume of kernel v3.14 for the function of > wake-on-touch. The function of device_may_wakeup will return true if > the device supports wake-on-touch

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-12-18 Thread Dmitry Torokhov
On Wed, Oct 28, 2015 at 11:10:06AM -0400, Benjamin Tissoires wrote: > Hi, > > On Oct 25 2015 or thereabouts, David Herrmann wrote: > > Hi > > > > On Sun, Oct 25, 2015 at 12:53 AM, Dmitry Torokhov > > <dmitry.torok...@gmail.com> wrote: > > > Hi Ben

Re: [PATCH v2 2/2] Input: uinput: Sanity check on ff_effects_max and EV_FF

2015-12-18 Thread Dmitry Torokhov
On Sun, Nov 08, 2015 at 06:37:34PM +0100, Elias Vanderstuyft wrote: > Currently the user can set ff_effects_max to zero with the EV_FF bit > (and the FF_GAIN and/or FF_AUTOCENTER bits) set, > in this case the uninitialized methods > ff->set_gain and/or ff->set_autocenter can be dereferenced, >

[git pull] Input updates for 4.4-rc5

2015-12-18 Thread Dmitry Torokhov
Charlie Mooney (1): Input: elan_i2c - set input device's vendor and product IDs Dmitry Torokhov (1): Input: atmel_mxt_ts - add generic platform data for Chromebooks James Chen (1): Input: elants_i2c - fix wake-on-touch Javier Martinez Canillas (1): Input: atmel_mxt_ts - add

Re: [PATCH V4 0/3] Input: goodix - add axis swapping and axis inversion support

2015-12-17 Thread Dmitry Torokhov
On Sat, Nov 21, 2015 at 02:30:19PM +0100, Karsten Merker wrote: > Hello, > > this is v4 of my "Input: goodix - add axis swapping and axis inversion > support" patchset. > > The goodix touchscreen driver has gained device-tree support in kernel > 4.1, but doesn't currently support the

Re: [PATCH v11 0/8] Goodix touchscreen enhancements

2015-12-17 Thread Dmitry Torokhov
On Thu, Nov 19, 2015 at 02:26:33PM +0200, Irina Tirdea wrote: > This patchset depends on Dmitry's patch that fixes the > GPIO ACPI API[1], so devm_gpiod_get_optional can be properly > used in the code. > > [1] https://lkml.org/lkml/2015/11/11/465 Applied 1 through 5 (see my goodix branch),

Re: [PATCH] Add eGalaxTouch serial touchscreen driver v3

2015-12-16 Thread Dmitry Torokhov
On Wed, Dec 16, 2015 at 01:54:01PM +0100, Boszormenyi Zoltan wrote: > 2015-12-16 13:43 keltezéssel, Zoltán Böszörményi írta: > > Signed-off-by: B�sz�rm�nyi Zolt�n > > this > > > + * Copyright (c) 2015 Zolt�n B�sz�rm�nyi > > this > > > +MODULE_AUTHOR("Zolt�n

[PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-16 Thread Dmitry Torokhov
-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- I do not have the hardware so please try this out. drivers/input/joystick/xpad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 36328b3..00a766b

Re: [PATCH 2/2] Input: add touchscreen support for TS-4800

2015-12-16 Thread Dmitry Torokhov
Hi Damien, On Thu, Dec 10, 2015 at 11:11:12AM -0500, Damien Riegel wrote: > On this board, the touchscreen, an ads7843, is not handled directly by > Linux but by a companion FPGA. This FPGA is memory-mapped and the IP > design is very similar to the mk712. > > This commit adds the support for

Re: [PATCH 4/5] Input: xpad: workaround dead irq_out after suspend/ resume

2015-12-16 Thread Dmitry Torokhov
On Wed, Dec 09, 2015 at 10:41:31PM -0800, Dmitry Torokhov wrote: > On Sun, Nov 01, 2015 at 04:31:38PM +0100, Pavel Rojtberg wrote: > > From: Pavel Rojtberg <rojtb...@gmail.com> ... > > + > > +static int xpad_resume(struct usb_interface *intf) > > +{ > > +

Re: [PATCH] input: Report vendor and product IDs for elan_i2c

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 11:11:12AM -0800, Charlie Mooney wrote: > Previously the "vendor" and "product" IDs for the elan_i2c > driver simply reported . This patch modifies the elan_i2c > driver to include the Elan vendor ID and the touchpad's product > id under input/input*/{vendor,product}.

Re: [PATCH] input/touchscreen: New EETI eGalaxTouch serial touchscreen driver

2015-12-15 Thread Dmitry Torokhov
_get_drvdata(serio); > + > + input_get_device(pegalax->dev); > + input_unregister_device(pegalax->dev); > + serio_close(serio); > + serio_set_drvdata(serio, NULL); > + input_put_device(pegalax->dev); > + kfree(pegalax); This is needlessly complicated

Re: [PATCH] Input: don't push static constants on stack for %*ph

2015-12-14 Thread Dmitry Torokhov
On Thu, Dec 10, 2015 at 5:46 AM, Andy Shevchenko wrote: > On Wed, 2013-09-04 at 13:41 +0300, Andy Shevchenko wrote: >> There is no need to pass constants via stack. The width may be >> explicitly >> specified in the format. > > Dmitry, any comments on this? My

Re: [PATCH 000/182] Rid struct gpio_chip from container_of() usage

2015-12-14 Thread Dmitry Torokhov
On Mon, Dec 14, 2015 at 1:18 AM, Linus Walleij <linus.wall...@linaro.org> wrote: > On Wed, Dec 9, 2015 at 8:30 PM, Dmitry Torokhov > <dmitry.torok...@gmail.com> wrote: >> On Wed, Dec 09, 2015 at 02:08:35PM +0100, Linus Walleij wrote: >>> This removes the use of

Re: [PATCH 1/5] Input: xpad: handle "present" and "gone" correctly

2015-12-14 Thread Dmitry Torokhov
On Wed, Dec 09, 2015 at 11:02:39PM -0800, Dmitry Torokhov wrote: > On Sun, Nov 01, 2015 at 04:31:35PM +0100, Pavel Rojtberg wrote: > > From: "Pierre-Loup A. Griffais" <pgriff...@valvesoftware.com> > > > > Handle the "a new device is present" message

Re: [PATCH] HID: enable all buttons on the TiVo Slide Pro remote

2015-12-13 Thread Dmitry Torokhov
On Fri, Dec 11, 2015 at 11:18 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > On Sun, Mar 15, 2015 at 7:05 AM, Jiri Kosina <jkos...@suse.cz> wrote: >> On Thu, 12 Mar 2015, Forest Wilkinson wrote: >> >>> The linux kernel has supported the TiV

Re: [PATCH 2/2] Input: add touchscreen support for TS-4800

2015-12-12 Thread Dmitry Torokhov
Hi Damien, On Thu, Dec 10, 2015 at 11:11:12AM -0500, Damien Riegel wrote: > On this board, the touchscreen, an ads7843, is not handled directly by > Linux but by a companion FPGA. This FPGA is memory-mapped and the IP > design is very similar to the mk712. ... > + > + poll_dev =

Re: touchscreen: edt-ft5x06: Prevent DMA driver from mapping an area on stack

2015-12-12 Thread Dmitry Torokhov
On Sat, Dec 12, 2015 at 06:13:55PM +0100, Wolfram Sang wrote: > > > Frankly speaking I do not know where the fix should actually be. I2C IMX > > driver somehow taking care of this or the users of I2C, touchscreen drivers > > in this case. In my opinion, the fix should be with the touchscreen

Re: [PATCH v2] Input: xpad - remove spurious events of wireless xpad 360 controller

2015-12-12 Thread Dmitry Torokhov
On Sun, Nov 22, 2015 at 05:35:39PM +0100, clement.calm...@free.fr wrote: > From: Clement Calmels > > When powering up a wireless xbox 360 controller, some wrong joystick > events are generated. It is annoying because, for example, it makes > unwanted moves in Steam big

Re: [PATCH] Input: sunxi LRADC-keys: allwinner,sun4i-a10-lradc-keys binding: typo fix

2015-12-12 Thread Dmitry Torokhov
On Sat, Dec 12, 2015 at 03:47:55PM +0100, Karsten Merker wrote: > Trivial typo fix ("mut" -> "must") in the sunxi LRADC-keys binding > documentation. > > Signed-off-by: Karsten Merker > Acked-by: Rob Herring > Acked-by: Chen-Yu Tsai > --- >

Re: [PATCH v2] Input: atmel_mxt_ts - Add maxtouch to I2C table for module autoload

2015-12-11 Thread Dmitry Torokhov
Hi Javier, On Thu, Dec 10, 2015 at 08:07:47PM -0300, Javier Martinez Canillas wrote: > Hello Dmitry, > > On 11/20/2015 04:15 PM, Dmitry Torokhov wrote: > > On Fri, Nov 20, 2015 at 04:09:42PM -0300, Javier Martinez Canillas wrote: > >> The Atmel maxtouch DT binding docum

Re: [PATCH] HID: enable all buttons on the TiVo Slide Pro remote

2015-12-11 Thread Dmitry Torokhov
On Sun, Mar 15, 2015 at 7:05 AM, Jiri Kosina wrote: > On Thu, 12 Mar 2015, Forest Wilkinson wrote: > >> The linux kernel has supported the TiVo Slide remote control for some time, >> but does not recognize the USB ID of the newer Slide Pro. This patch adds >> the missing data

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-12-10 Thread Dmitry Torokhov
On Thu, Dec 10, 2015 at 9:08 AM, Benjamin Tissoires <benjamin.tissoi...@redhat.com> wrote: > On Dec 09 2015 or thereabouts, Dmitry Torokhov wrote: >> On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov >> <dmitry.torok...@gmail.com> wrote: >> > On Thu, Nov 1

Re: [PATCH 000/182] Rid struct gpio_chip from container_of() usage

2015-12-09 Thread Dmitry Torokhov
On Wed, Dec 09, 2015 at 02:08:35PM +0100, Linus Walleij wrote: > This removes the use of container_of() constructions from *all* > GPIO drivers in the kernel. It is done by instead adding an > optional void *data pointer to the struct gpio_chip and an > accessor function, gpiochip_get_data() to

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-12-09 Thread Dmitry Torokhov
On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov > <dmitry.torok...@gmail.com> wrote: >> On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: >>> On Thu, 12 Nov 2015,

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-12-09 Thread Dmitry Torokhov
On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: >> On Thu, 12 Nov 2015, Simon Wood wrote: >> >> > When plugged in the Logitech G920 wheel starts with USBID 046d:c261

Re: [PATCH 3/5] Input: xpad: re-submit pending ff and led requests

2015-12-09 Thread Dmitry Torokhov
o process next request. Alternate serving LED vs FF requests to make sure one does not starve another. See [1] for discussion. Inspired by patch of Sarah Bessmer [2]. [1]: http://www.spinics.net/lists/linux-input/msg40708.html [2]: http://www.spinics.net/lists/linux-input/msg31450.html Signed-of

Re: [PATCH 4/5] Input: xpad: workaround dead irq_out after suspend/ resume

2015-12-09 Thread Dmitry Torokhov
On Sun, Nov 01, 2015 at 04:31:38PM +0100, Pavel Rojtberg wrote: > From: Pavel Rojtberg > > the irq_out urb is dead after suspend/ resume on my x360 wr pad. (also > reproduced by Zachary Lund [0]) Work around this by resetting the usb > device on resume. Added suspend/ resume

Re: [PATCHv3] Input: xpad - Fix double URB submission races

2015-12-09 Thread Dmitry Torokhov
Hi Laura, On Mon, Nov 16, 2015 at 02:47:13PM -0800, Laura Abbott wrote: > +static int __xpad_submit_urb(struct usb_xpad *xpad, > + unsigned char odata[XPAD_PKT_LEN], int transfer_length, > + int type, bool safe_submit) > +{ > + int ret; > + > + if

Re: [PATCH] Input: xpad - fix input from Covert Forces Xbox One controller

2015-12-09 Thread Dmitry Torokhov
Hi Cameron, On Sun, Dec 06, 2015 at 12:02:31AM -0800, Cameron Gutman wrote: > The Covert Forces edition of the Xbox One controller requires the full 5 > byte initialization packet to work at all. The 5 byte packet was known to > be needed for proper rumble support, but it looks like it's needed

Re: [PATCH 1/5] Input: xpad: handle "present" and "gone" correctly

2015-12-09 Thread Dmitry Torokhov
On Sun, Nov 01, 2015 at 04:31:35PM +0100, Pavel Rojtberg wrote: > From: "Pierre-Loup A. Griffais" > > Handle the "a new device is present" message properly by dynamically > creating the input device at this point in time. This means we now do > not "preallocate" all

Re: [PATCH V1] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press

2015-12-09 Thread Dmitry Torokhov
On Tue, Dec 08, 2015 at 05:55:05PM +, Steve Twiss wrote: > From: Steve Twiss > > Stop reporting KEY_SLEEP for a short key-press and report KEY_POWER instead > This change applied to both DA9063 and DA9062 ONKEY drivers. You need to explain why this change is

Re: hid-sony patch to add rumble and led support for nyko core controllers

2015-12-08 Thread Dmitry Torokhov
Hi Scott, On Tue, Dec 08, 2015 at 03:05:54AM -0700, Scott Moreau wrote: > Hi Dimtry, > > I managed to get rumble and led's sorted out for the nyko core controller > with this patch. The code probably isn't the greatest but do you think you > might be able to help me get it cleaned up and

[PATCH] Input: psmouse - clean up Cypress probe

2015-12-03 Thread Dmitry Torokhov
vices only have issue with Sentelic probes probing Imtellimouse should be safe. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/mouse/psmouse-base.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/input/mouse/p

Re: [PATCH v2 5/5] Input: wacom_w8001 - split the touch and pen devices into two devices

2015-12-03 Thread Dmitry Torokhov
On Wed, Dec 2, 2015 at 8:22 PM, Peter Hutterer wrote: > These devices have a pen device and a touch device through the same serial > protocol, split it up into two separate devices like we do for USB Wacom > tablets too. > > Userspace already matches on the device name

Re: [PATCH] Input: sparcspkr - Use platform_register/unregister_drivers()

2015-12-02 Thread Dmitry Torokhov
On Wed, Dec 02, 2015 at 05:25:19PM +0100, Thierry Reding wrote: > From: Thierry Reding > > These new helpers simplify implementing multi-driver modules and > properly handle failure to register one driver by unregistering all > previously registered drivers. > >

Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros

2015-12-02 Thread Dmitry Torokhov
wrote: > > > > Hi, > > > > > > > > On Tue, Dec 01, 2015 at 02:45:27PM -0800, Dmitry Torokhov wrote: > > > > > On Tue, Dec 1, 2015 at 2:32 PM, Sinclair Yeh <s...@vmware.com> wrote: > > > > > > Hi, > > > > > > >

[PATCH v2] Input: psmouse - rename ps2pp_init() to ps2pp_detect()

2015-12-02 Thread Dmitry Torokhov
This makes Logitech PS2++ protocol implementation consistent with the naming in other protocols. Also mark the stub as "static inline" Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- V2: add forgotten drivers/input/mouse/logips2pp.c file. drivers/input/mouse/lo

Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros

2015-12-02 Thread Dmitry Torokhov
On Wed, Dec 02, 2015 at 10:45:28AM -0800, Greg Kroah-Hartman wrote: > On Wed, Dec 02, 2015 at 09:26:34AM -0800, Dmitry Torokhov wrote: > > On Wed, Dec 02, 2015 at 07:31:24AM -0800, Greg Kroah-Hartman wrote: > > > On Tue, Dec 01, 2015 at 06:21:06PM -0800, Sinclair Yeh wrote: >

[PATCH] Input: psmouse - rename ps2pp_init() to ps2pp_detect()

2015-12-02 Thread Dmitry Torokhov
This makes Logitech PS2++ protocol implementation consistent with the naming in other protocols. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/mouse/logips2pp.h| 4 ++-- drivers/input/mouse/psmouse-base.c | 2 +- 2 files changed, 3 insertions(+), 3 del

Re: [PATCH 5/6] Input: psmouse - factor out common protocol probing code

2015-12-02 Thread Dmitry Torokhov
Hi Hans, On Wed, Dec 02, 2015 at 04:20:48PM +0100, Hans de Goede wrote: > Hi, > > Thanks for splitting out the series, patches 1 - 4 look good to me and are: > > Reviewed-by: Hans de Goede > > I've some comments inline for this one. Thanks for spending time on reviewing

Re: [PATCH] Input: psmouse - rename ps2pp_init() to ps2pp_detect()

2015-12-02 Thread Dmitry Torokhov
On Wed, Dec 02, 2015 at 11:20:44AM -0800, Dmitry Torokhov wrote: > This makes Logitech PS2++ protocol implementation consistent with > the naming in other protocols. > > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Well, if I did not forget to add drivers/input

Re: [PATCH] Input: arizona-haptic: Correct disable of haptics device

2015-12-02 Thread Dmitry Torokhov
On Mon, Nov 30, 2015 at 06:02:20PM +, Charles Keepax wrote: > A small copy and paste error was preventing the haptics device being > disabled. This patch corrects the value written on disable. > > Signed-off-by: Charles Keepax Applied, thank you. > ---

Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros

2015-12-01 Thread Dmitry Torokhov
ned-off-by: Sinclair Yeh <s...@vmware.com> > Reviewed-by: Thomas Hellstrom <thellst...@vmware.com> > Reviewed-by: Alok N Kataria <akata...@vmware.com> > Cc: pv-driv...@vmware.com > Cc: linux-graphics-maintai...@vmware.com > Cc: Dmitry Torokhov <dmitry.torok...@

Re: support for some types of Asus+Elantech touchpads

2015-12-01 Thread Dmitry Torokhov
Hi Wladimir, On Tue, Dec 01, 2015 at 09:59:28PM +0200, Wladimir Mutel wrote: > Dear Dmitry & linux-input members, > > some new Asus (and probably non-Asus) laptops are shipped with a new > kind of Elantech (not sure if only Elantech) touchpads which are not > adequately handled by Linux kernel

Re: [PATCH v3] touchscreen: pixcir_i2c: Add support for wake and enable gpios

2015-12-01 Thread Dmitry Torokhov
On Sun, Nov 22, 2015 at 04:19:50PM -0600, Rob Herring wrote: > On Sun, Nov 22, 2015 at 04:57:33PM +0100, Hans de Goede wrote: > > From: Sander Vermin > > > > On some devices the wake and enable pins of the pixcir touchscreen > > controller are connected to gpios and these must

Re: [PATCH 3/5] Input: wacom_w8001 - handle touch error case correctly

2015-12-01 Thread Dmitry Torokhov
On Mon, Nov 30, 2015 at 01:38:14PM +1000, Peter Hutterer wrote: > If a device failed at the pen setup and gets a zero reply from the touch > device, we need to return an error. Otherwise we have a device with > nothing but a name and the EV_KEY and EV_ABS bits. But if device does not fail pen

Re: [PATCH] Input: atmel_mxt_ts - add generic platform data for Chromebooks

2015-12-01 Thread Dmitry Torokhov
Hi Javier, On Tue, Nov 24, 2015 at 04:18:05PM -0300, Javier Martinez Canillas wrote: > Hello Dmitry, > > On 11/24/2015 03:58 PM, Dmitry Torokhov wrote: > > Apparently people are installing generic Linux distributions not only on > > Pixels but also on other Chromebooks.

Re: [PATCH 5/5] Input: wacom_w8001 - split the touch and pen devices into two devices

2015-12-01 Thread Dmitry Torokhov
On Mon, Nov 30, 2015 at 01:38:16PM +1000, Peter Hutterer wrote: > These devices have a pen device and a touch device through the same serial > protocol, split it up into two separate devices like we do for USB Wacom > tablets too. > > Userspace already matches on the device name so we can't drop

Re: [PATCH] Input: aiptek: fix crash on detecting device without endpoints

2015-12-01 Thread Dmitry Torokhov
Hi Vladis, On Wed, Nov 25, 2015 at 04:58:08PM +0100, Vladis Dronov wrote: > The aiptek driver crashes in aiptek_probe() when a specially crafted usb > device > without endpoints is detected. This fix adds a check that the device has > proper > configuration expected by the driver. Also an error

Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros

2015-12-01 Thread Dmitry Torokhov
On Tue, Dec 1, 2015 at 2:54 PM, Sinclair Yeh <s...@vmware.com> wrote: > Hi, > > On Tue, Dec 01, 2015 at 02:45:27PM -0800, Dmitry Torokhov wrote: >> On Tue, Dec 1, 2015 at 2:32 PM, Sinclair Yeh <s...@vmware.com> wrote: >> > Hi, >> > > > > &g

Re: [PATCH] Input: aiptek: fix crash on detecting device without endpoints

2015-11-30 Thread Dmitry Torokhov
On Mon, Nov 30, 2015 at 03:38:20PM -0500, Alan Stern wrote: > On Mon, 30 Nov 2015, Dmitry Torokhov wrote: > > > How about we do something like below? > > It looks okay to me. If you want to propose it on the linux-usb > mailing list, you can add: > &g

Re: [PATCH] Input: aiptek: fix crash on detecting device without endpoints

2015-11-30 Thread Dmitry Torokhov
> > > > btw, indeed, this is not the only driver with this problem, I've met 2 > > > > more. > > > > > > In fact, there's no way to check whether endpoint 0 exists. Where > > > would you look to find out? There isn't any endpoint descriptor for i

[PATCH 5/6] Input: psmouse - factor out common protocol probing code

2015-11-28 Thread Dmitry Torokhov
that this removes option of forcing Lifebook protocol on devices that are not recognized by lifebook_detect() as having the hardware, but I do not recall anyone using this option. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/mouse/psmouse-base.c

[PATCH 1/6] Input: psmouse - use switch statement in psmouse_process_byte()

2015-11-28 Thread Dmitry Torokhov
Instead of a series mostly exclusive "if" statements testing protocol type of the mouse let's use "switch" statement. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/mouse/psmouse-base.c | 65 ++ 1 f

[PATCH 2/6] Input: psmouse - fix comment style

2015-11-28 Thread Dmitry Torokhov
The module was using non-standard comment style with comment blocks often starting at the very beginning of a line instead of being aligned with the code. Let's switch to standard formatting. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/mouse/psmouse-base.c

[PATCH 6/6] Input: psmouse - limit protocols that we try on passthrough ports

2015-11-28 Thread Dmitry Torokhov
on pass-through ports, so let's limit protocols that we probe there to Trackpoint, IntelliMouse Explorer, IntelliMouse, and bare PS/2 protocol, and avoid other extended protocols, such as Synaptics, ALPS, etc. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/mouse/p

[PATCH 3/6] Input: psmouse - rearrange Focaltech init code

2015-11-28 Thread Dmitry Torokhov
, replace focaltech_init() with a stub now that it is only called when protocol is enabled. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- I know I originally requested doing reset in focaltech_init() even when focaltech support is disabled, but as I was working with the code I

[PATCH 4/6] Input: psmouse - move protocol descriptions around

2015-11-28 Thread Dmitry Torokhov
We move protocol descriptions and psmouse_find_by_type() and pmouse_find_by_name() so that we can use them without forward declarations in the subsequent patches. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/mouse/psmouse-base.c

[PATCH 0/6] Only probe select protocols on pass through PS/2 prots

2015-11-28 Thread Dmitry Torokhov
This series limits protocols that we probe on pass-through PS/2 ports to IBM Trackpoint, Intellimouse, Intellimouse Explorer and basic PS/2, since we have not seen anything else and probing all possible protocols takes too long. Input: psmouse - use switch statement in psmouse_process_byte()

Re: X-Box one controller causes Xpad to crash [NEW INFO]

2015-11-27 Thread Dmitry Torokhov
Hi Jonathan, On Fri, Nov 27, 2015 at 05:48:56PM +0100, Jonathan Beilharz wrote: > Still haven't got it on the mailing list... Also can't find any info > on how to add new stuff. I already had sent an email sometime ago > but since then I found out more. Hmm, not sure why your email do not reach

Re: [PATCH v11 6/8] Input: goodix - add support for ESD

2015-11-27 Thread Dmitry Torokhov
On Fri, Nov 27, 2015 at 05:24:21PM +, Tirdea, Irina wrote: > > > > -Original Message- > > From: Rob Herring [mailto:r...@kernel.org] > > Sent: 20 November, 2015 17:45 > > To: Tirdea, Irina > > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Maml

Re: [PATCH] Input: aiptek: fix crash on detecting device without endpoints

2015-11-26 Thread Dmitry Torokhov
Hi Vladis, On Wed, Nov 25, 2015 at 04:58:08PM +0100, Vladis Dronov wrote: > The aiptek driver crashes in aiptek_probe() when a specially crafted usb > device > without endpoints is detected. This fix adds a check that the device has > proper > configuration expected by the driver. Also an error

Re: [PATCH] serio: delay resume error handling til PM complete

2015-11-25 Thread Dmitry Torokhov
On Wed, Nov 25, 2015 at 09:25:59AM -0800, Todd E Brandt wrote: > On Tue, Nov 24, 2015 at 05:26:15PM -0800, Dmitry Torokhov wrote: > > On Tue, Nov 24, 2015 at 4:58 PM, Todd Brandt > > <todd.e.bra...@linux.intel.com> wrote: > > > Delay the error rescan for serio device

Re: [PATCH] serio: delay resume error handling til PM complete

2015-11-25 Thread Dmitry Torokhov
On Wed, Nov 25, 2015 at 10:24:07AM -0500, Alan Stern wrote: > On Tue, 24 Nov 2015, Dmitry Torokhov wrote: > > > On Tue, Nov 24, 2015 at 4:58 PM, Todd Brandt > > <todd.e.bra...@linux.intel.com> wrote: > > > Delay the error rescan for serio devices until the PM &

Re: [PATCH] serio: delay resume error handling til PM complete

2015-11-24 Thread Dmitry Torokhov
On Tue, Nov 24, 2015 at 4:58 PM, Todd Brandt wrote: > Delay the error rescan for serio devices until the PM > complete phase. PM complete requires locking each device > before checking for and executing the complete callbacks. > Serio rescan also locks the

[PATCH] Input: psmouse - limit protocols that we try on passthrough ports

2015-11-24 Thread Dmitry Torokhov
on pass-through ports, so let's limit protocols that we probe there to Trackpoint, IntelliMouse Explorer, IntelliMouse, and bare PS/2 protocol, and avoid other extended protocols, such as Synaptics, ALPS, etc. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input

[PATCH] Input: atmel_mxt_ts - add generic platform data for Chromebooks

2015-11-24 Thread Dmitry Torokhov
). Tested-by: Rich K <rgki...@gmail.com> Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/input/touchscreen/atmel_mxt_ts.c | 33 1 file changed, 33 insertions(+) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input

Re: [PATCH v11 6/8] Input: goodix - add support for ESD

2015-11-20 Thread Dmitry Torokhov
On Fri, Nov 20, 2015 at 7:44 AM, Rob Herring wrote: > On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote: >> Add ESD (Electrostatic Discharge) protection mechanism. > > [...] > >> This is based on Goodix datasheets for GT911 and GT9271 and on Goodix >> driver gt9xx.c

Re: [PATCH 4/7] touchscreen: pixcir_i2c: Add support for wake and enable gpios

2015-11-20 Thread Dmitry Torokhov
On Fri, Nov 20, 2015 at 12:17:10PM +0100, Hans de Goede wrote: > From: Sander Vermin > > On some devices the wake and enable pins of the pixcir touchscreen > controller are connected to gpios and these must be controlled by the > driver for the device to operate properly. > >

Re: [PATCH v2] Input: atmel_mxt_ts - Add maxtouch to I2C table for module autoload

2015-11-20 Thread Dmitry Torokhov
On Fri, Nov 20, 2015 at 04:09:42PM -0300, Javier Martinez Canillas wrote: > The Atmel maxtouch DT binding documents that the compatible string for > the device is "atmel,maxtouch" and the I2C core always reports a module > alias of the form i2c:alias where alias is the compatible string model: >

Re: [PATCH v2 4/7] touchscreen: pixcir_i2c: Add support for wake and enable gpios

2015-11-20 Thread Dmitry Torokhov
On Fri, Nov 20, 2015 at 02:24:49PM +0100, Hans de Goede wrote: > From: Sander Vermin > > On some devices the wake and enable pins of the pixcir touchscreen > controller are connected to gpios and these must be controlled by the > driver for the device to operate properly. > >

Re: [PATCH v2 4/7] touchscreen: pixcir_i2c: Add support for wake and enable gpios

2015-11-20 Thread Dmitry Torokhov
On Fri, Nov 20, 2015 at 08:19:52PM +0100, Hans de Goede wrote: > Hi, > > On 20-11-15 19:54, Dmitry Torokhov wrote: > >On Fri, Nov 20, 2015 at 02:24:49PM +0100, Hans de Goede wrote: > >>From: Sander Vermin <san...@vermin.nl> > >> > >>On som

Re: [PATCH v11 4/8] Input: goodix - add power management support

2015-11-19 Thread Dmitry Torokhov
On Thu, Nov 19, 2015 at 02:26:37PM +0200, Irina Tirdea wrote: > Implement suspend/resume for goodix driver. > > The suspend and resume process uses the gpio pins. > If the device ACPI/DT information does not declare gpio pins, > suspend/resume will not be available for these devices. > > This is

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-11-19 Thread Dmitry Torokhov
xpad - switch Logitech G920 Wheel into HID mode" Otherwise: Acked-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 3/8] Input: goodix - write configuration data to device

2015-11-19 Thread Dmitry Torokhov
On Thu, Nov 19, 2015 at 02:26:36PM +0200, Irina Tirdea wrote: > + if (ts->gpiod_int && ts->gpiod_rst) { > + /* update device config */ > + ts->cfg_name = kasprintf(GFP_KERNEL, "goodix_%d_cfg.bin", > + ts->id); devm_kasprintf maybe

Re: [PATCH v11 4/8] Input: goodix - add power management support

2015-11-19 Thread Dmitry Torokhov
On Thu, Nov 19, 2015 at 2:18 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: > Hi, > > On Thu, Nov 19, 2015 at 7:24 PM, Dmitry Torokhov > <dmitry.torok...@gmail.com> wrote: >> On Thu, Nov 19, 2015 at 02:26:37PM +0200, Irina Tirdea wrote: >>> Imp

Re: Chromebook touchpad not responsive on latest kernel

2015-11-18 Thread Dmitry Torokhov
Hi Rich, On Wed, Nov 18, 2015 at 11:44:03AM -0500, Rich K wrote: > Dear Dmitry Torokhov, > > I have filed a bug report on launchpad and gathered the information from > wiki.ubuntu.com/Bugs/Upstream/kernel. I believe that you are the correct > person to email with this conc

Re: [PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate

2015-11-17 Thread Dmitry Torokhov
On Mon, Nov 16, 2015 at 09:56:28AM +0100, Boris Brezillon wrote: > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. > Doing that will ease adaptation of the PWM framework to support atomic > update. > > Signed-off-by: Boris Brezillon

Re: [PATCH v8 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller

2015-11-17 Thread Dmitry Torokhov
On Mon, Nov 16, 2015 at 08:16:09AM -0600, Rob Herring wrote: > On Mon, Nov 16, 2015 at 01:01:04PM +0100, Markus Pargmann wrote: > > This is the touchscreen conversion queue binding documentation. It uses > > the shared imx25 ADC. > > > > Signed-off-by: Markus Pargmann > >

Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-17 Thread Dmitry Torokhov
On Mon, Nov 16, 2015 at 01:01:07PM +0100, Markus Pargmann wrote: > This is a driver for the imx25 ADC/TSC module. It controls the > touchscreen conversion queue and creates a touchscreen input device. > The driver currently only supports 4 wire touchscreens. The driver uses > a simple conversion

Re: [PATCH] input: st1232.c: Add devicetree attributes

2015-11-17 Thread Dmitry Torokhov
Hi Sander, On Sun, Nov 15, 2015 at 05:20:47PM +0100, Sander Vermin wrote: > -static int __maybe_unused st1232_ts_suspend(struct device *dev) > +#ifdef CONFIG_PM_SLEEP Why? > +static int st1232_ts_suspend(struct device *dev) > { > struct i2c_client *client = to_i2c_client(dev); > -

Re: [PATCH] Input: pixcir_i2c_ts: add wake and enable gpios

2015-11-17 Thread Dmitry Torokhov
On Mon, Nov 16, 2015 at 09:39:06AM -0600, Rob Herring wrote: > On Sun, Nov 15, 2015 at 04:56:43PM +0100, Sander Vermin wrote: > > This patch improves the pixcir_i2c_ts touchscreen controller which is used > > by the POV PROTAB2 tablet. > > > > On POV PROTAB2 tablet the WAKE and ENABLE gpios are

  1   2   3   4   5   6   7   8   9   10   >