Re: [PATCH v2 0/2] hid: sony: Clear and restore controller state on suspend and resume

2015-11-19 Thread Antonio Ospite
On Thu, 19 Nov 2015 11:39:55 +0100 Antonio Ospite <a...@ao2.it> wrote: > On Tue, 17 Nov 2015 08:57:05 -0500 > Frank Praznik <frank.praz...@gmail.com> wrote: > > > > On Nov 15, 2015, at 10:30, Antonio Ospite <a...@ao2.it> wrote: > [...] > > &g

Re: [PATCH v2 0/2] hid: sony: Clear and restore controller state on suspend and resume

2015-11-19 Thread Antonio Ospite
On Tue, 17 Nov 2015 08:57:05 -0500 Frank Praznik <frank.praz...@gmail.com> wrote: > > On Nov 15, 2015, at 10:30, Antonio Ospite <a...@ao2.it> wrote: [...] > > > > Hi Frank, the changes are basically OK, but there are warnings and > > errors from scripts/c

Re: [PATCH v2 0/2] hid: sony: Clear and restore controller state on suspend and resume

2015-11-15 Thread Antonio Ospite
e force-feedback. > Hi Frank, the changes are basically OK, but there are warnings and errors from scripts/checkpatch.pl Would you care to send a v3 which fixes those? Thanks a lot, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text.

Re: [PATCH 2/2] hid: sony: Save and restore controller state on suspend and resume

2015-11-09 Thread Antonio Ospite
Force-feedback is stopped on suspend but > automatically restored on resume until a new event is received to avoid > potentially damaging hardware. > > Signed-off-by: Frank Praznik <frank.praz...@gmail.com> Acked-by: Antonio Ospite <a.

Re: [PATCH 1/2] hid: sony: Refactor output report sending functions

2015-11-09 Thread Antonio Ospite
t; /* > @@ -2336,9 +2349,9 @@ static int sony_probe(struct hid_device *hdev, const > struct hid_device_id *id) > } > } > > - sony_init_work(sc, dualshock4_state_worker); > + sony_init_work(sc); >

Re: [RFC_v2 0/4] HID: hid-sony: Add IIO Suport for Motion Controllers

2015-06-24 Thread Antonio Ospite
On Tue, 23 Jun 2015 18:30:26 -0600 Simon Wood si...@mungewell.org wrote: [...] The SixAxis contains accelerometers, the DS4 contains accelerometers and gyros. Hi Simon, the SixAxis also have a gyroscope, I don't know how useful/reliable it is, but it's there. Ciao, Antonio -- Antonio

Re: [PATCH 2/9] input: goodix: fix variable length array warning

2015-06-03 Thread Antonio Ospite
On Wed, 3 Jun 2015 10:26:47 + Tirdea, Irina irina.tir...@intel.com wrote: -Original Message- From: Antonio Ospite [mailto:a...@ao2.it] Sent: 28 May, 2015 18:58 To: Tirdea, Irina Cc: Dmitry Torokhov; Bastien Nocera; linux-input@vger.kernel.org; devicet...@vger.kernel.org

Re: [PATCH 2/9] input: goodix: fix variable length array warning

2015-05-28 Thread Antonio Ospite
; -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally

Re: [PATCH] Add driver for mouse logitech M560

2015-04-29 Thread Antonio Ospite
devices, the two quirks fit on the same line. { HID_DEVICE(BUS_USB, HID_GROUP_LOGITECH_DJ_DEVICE, USB_VENDOR_ID_LOGITECH, HID_ANY_ID)}, -- 2.1.4 -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http

[PATCH 01/12] trivial: HID: Makefile: fix alignment of objs-* entries

2015-04-28 Thread Antonio Ospite
Most of the entries are aligned with TABs, fix those which are not. Signed-off-by: Antonio Ospite a...@ao2.it Cc: Jiri Kosina jkos...@suse.cz Cc: linux-input@vger.kernel.org --- drivers/hid/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/Makefile b

Re: [Patch V2] Driver for Logitech M560

2015-04-14 Thread Antonio Ospite
when we (me or Dario, in CC) actually test the code. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list

Re: Driver for Logitech M560

2015-04-13 Thread Antonio Ospite
package for this driver I am interested to integrate Hi Goffredo, I should be able to do some tests later this week. I'll let you know. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki

Re: Driver for Logitech M560

2015-04-09 Thread Antonio Ospite
Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: input_polldev interval (was Re: [sur40] Debugging a race condition)?

2015-03-26 Thread Antonio Ospite
— on a more complex system. Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v3] input: goodix: Add device tree support

2015-03-06 Thread Antonio Ospite
at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line

Re: [PATCH] input: goodix: Use max touch number from device config

2015-03-06 Thread Antonio Ospite
On Thu, 5 Mar 2015 20:32:24 +0300 Aleksei Mamlin mamli...@gmail.com wrote: Use max number of touches from device config instead of hardcoding. Signed-off-by: Aleksei Mamlin mamli...@gmail.com Tested-by: Antonio Ospite a...@ao2.it Some minor comments below, but no need to resend IMHO

Re: [PATCH 1/2] input: goodix: Add device tree support

2015-03-04 Thread Antonio Ospite
info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] input: goodix: Add device tree support for 5-finger chips

2015-03-04 Thread Antonio Ospite
in register 0x804C. Have you tried if this is true on your 5-finger devices too? If so, please use this mechanism to populate ts-max_touch_num to avoid passing hardcoded data. Thanks, Antonio [1] http://www.wpgholdings.com/uploads/bu/bu_3/MID_20141112/GT9271_Datasheet_20130904.pdf -- Antonio

Re: [PATCH 3/3] HID: i2c-hid: Add support for ACPI GPIO interrupts

2015-02-24 Thread Antonio Ospite
requested by someone. Is that correct? Thanks, Antonio [...] -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line

Re: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-16 Thread Antonio Ospite
On Mon, 16 Feb 2015 15:06:59 +0200 Lauri Kasanen c...@gmx.com wrote: Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines

[PATCH 3/5] HID: sony: Don't use magic numbers in sixaxis_set_operational_usb()

2015-02-16 Thread Antonio Ospite
Remove the magic numbers used in sixaxis_set_operational_usb(): - use the already defined SIXAXIS_REPORT_0xF2_SIZE; - define and use SIXAXIS_REPORT_0xF5_SIZE; - set the dummy buffer size to accommodate any report that is going to be requested. Signed-off-by: Antonio Ospite a...@ao2

[PATCH 4/5] HID: sony: Use __u8 * for the buffer in sixaxis_set_operational_usb()

2015-02-16 Thread Antonio Ospite
Use the same type declared in the prototypes of functions that are going to accept the buffer as parameter. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c

[PATCH 5/5] HID: sony: Coding style cleanups in sixaxis_set_operational_usb()

2015-02-16 Thread Antonio Ospite
Don't mix declaration and allocation, remove some useless newlines between calling a function and checking its return value. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-sony.c b

[PATCH 0/5] HID: sony: misc fixes and cleanups

2015-02-16 Thread Antonio Ospite
Hi, here are a few cleanups for hid-sony. Changes are meant to follow the patch titled: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers Frank, hi, I'd like to have your explicit ack at least for patch 1 and 2. Thanks, Antonio Antonio Ospite (5): HID: sony: Fix a WARNING

[PATCH 2/5] HID: sony: Use the minimum accepted size for feature report 0xf2

2015-02-16 Thread Antonio Ospite
Sixaxis devices accept feature report 0xf2 when size is = 17, not 18. Use the minimum accepted size. The change is mainly for documentation purposes, the code worked fine even before this change. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 2 +- 1 file changed, 1

[PATCH 1/5] HID: sony: Fix a WARNING shown when rmmod-ing the driver

2015-02-16 Thread Antonio Ospite
bc794b3d22c30ede ]--- Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index f3d44e5..137d1ee 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c

Re: [PATCH 0/5] HID: sony: misc fixes and cleanups

2015-02-16 Thread Antonio Ospite
On Mon, 16 Feb 2015 16:48:53 -0500 Frank Praznik frank.praz...@gmail.com wrote: On 2/16/2015 12:12, Antonio Ospite wrote: Hi, here are a few cleanups for hid-sony. Changes are meant to follow the patch titled: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers Frank

Re: [PATCHv3] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-15 Thread Antonio Ospite
On Tue, 10 Feb 2015 14:52:52 +0200 Lauri Kasanen c...@gmx.com wrote: Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-10 Thread Antonio Ospite
Hi Lauri, On Sun, 8 Feb 2015 11:11:38 +0200 Lauri Kasanen c...@gmx.com wrote: Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. v2: - edited error messages - use

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Antonio Ospite
on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines andrewd...@aol.com Signed-off-by: Lauri Kasanen c...@gmx.com --- drivers/hid/hid-sony.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) Antonio's original

Re: About Goodix-TS on Bay Trail, and ACPI and interrupts

2015-02-06 Thread Antonio Ospite
On Tue, 27 Jan 2015 15:45:59 +0100 Antonio Ospite a...@ao2.it wrote: On Wed, 21 Jan 2015 12:16:54 +0200 Mika Westerberg mika.westerb...@intel.com wrote: On Tue, Jan 20, 2015 at 05:56:45PM +0100, Antonio Ospite wrote: [...] [9.056300] gpiochip_get_desc: hwnum: 68 chip-ngpio: 44

Re: About Goodix-TS on Bay Trail, and ACPI and interrupts

2015-01-27 Thread Antonio Ospite
On Wed, 21 Jan 2015 12:16:54 +0200 Mika Westerberg mika.westerb...@intel.com wrote: On Tue, Jan 20, 2015 at 05:56:45PM +0100, Antonio Ospite wrote: Hi Mika, I tested the patch but I still can't get the IRQ. The new code in i2c-hid does more or less what I was trying to do in the goodix

Re: About Goodix-TS on Bay Trail, and ACPI and interrupts

2015-01-20 Thread Antonio Ospite
in the pinctrl-baytrail driver? Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/3] input: goodix: Add device tree support

2015-01-18 Thread Antonio Ospite
with no enabled mechanism to pass platform data to it? Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send

Re: [PATCH 8/9] Fixed indentation violation in switch statement : Aligned the switch and its subordinate case labels in the same column instead of double-intending the case labels.

2015-01-17 Thread Antonio Ospite
this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http

About Goodix-TS on Bay Trail, and ACPI and interrupts

2015-01-16 Thread Antonio Ospite
-- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH 001/001] hid-sony.c: add sysfs provisioning

2014-11-18 Thread Antonio Ospite
, so I'm happy either way. I'll comment on that in the other mail when you talk about the shell solution. Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top

Re: [PATCH 001/001] hid-sony.c: add sysfs provisioning

2014-11-18 Thread Antonio Ospite
On Mon, 17 Nov 2014 21:01:44 -0500 bri b...@abrij.org wrote: On Mon, Nov 17, 2014 at 01:35:18PM +0100, Antonio Ospite wrote: I had tried doing something similar in the past (the parsing was just a sscanf): http://thread.gmane.org/gmane.linux.bluez.kernel/5261 but then we deliberately

Re: [PATCH 001/001] hid-sony.c: add sysfs provisioning

2014-11-17 Thread Antonio Ospite
); hid_unregister_driver(sony_driver); } module_init(sony_init); -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2

Re: [PATCH v2] hid: sony: Use kernel allocated buffers for HID reports

2014-11-12 Thread Antonio Ospite
. That'll be a little easier on the eyes in code like the one below. [...] + ret = hid_hw_raw_request(sc-hdev, 0x81, buf, + DS4_REPORT_129_SIZE, HID_FEATURE_REPORT, + HID_REQ_GET_REPORT); [...] Thanks, Antonio -- Antonio

Re: Perixx reprogrammable mouse

2014-10-05 Thread Antonio Ospite
need soon to have some support for this gamers-equipment. I hope you'll give me some hints. Ciao ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting

Re: [PATCH v5 1/4] HID: lenovo: Rename hid-lenovo-tpkbd to hid-lenovo

2014-07-25 Thread Antonio Ospite
...@lentin.co.uk Reviewed-by: Antonio Ospite a...@ao2.it --- ...er-hid-lenovo-tpkbd = sysfs-driver-hid-lenovo} | 0 drivers/hid/Kconfig| 14 +- drivers/hid/Makefile | 2 +- drivers/hid/hid-core.c

Re: [PATCH v5 2/4] HID: lenovo: Prepare support for adding other devices

2014-07-25 Thread Antonio Ospite
extra postfixed functions. Signed-off-by: Jamie Lentin j...@lentin.co.uk Reviewed-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-lenovo.c | 53 1 file changed, 45 insertions(+), 8 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b

Re: [PATCH v5 3/4] HID: lenovo: Style fixes

2014-07-25 Thread Antonio Ospite
), -- 2.0.0 -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH v5 4/4] HID: lenovo: Add support for Compact (BT|USB) keyboard

2014-07-25 Thread Antonio Ospite
-by: Antonio Ospite a...@ao2.it --- Documentation/ABI/testing/sysfs-driver-hid-lenovo | 12 ++ drivers/hid/Kconfig | 2 + drivers/hid/hid-core.c| 2 + drivers/hid/hid-ids.h | 2 + drivers/hid/hid

Re: [PATCH v5 0/4] HID: lenovo: Add support for Lenovo Compact Keyboard

2014-07-25 Thread Antonio Ospite
not show as a USB HID device when plugged in, can you confirm that? Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe

Re: [PATCH v4 1/4] Rename hid-lenovo-tpkbd to hid-lenovo

2014-07-21 Thread Antonio Ospite
On Fri, 18 Jul 2014 10:35:35 +0100 (BST) Jamie Lentin j...@lentin.co.uk wrote: On Mon, 14 Jul 2014, Antonio Ospite wrote: On Sun, 13 Jul 2014 08:24:19 +0100 Jamie Lentin j...@lentin.co.uk wrote: Rename module and all functions within so we can add support for other keyboards

Re: [PATCH v4 1/4] Rename hid-lenovo-tpkbd to hid-lenovo

2014-07-14 Thread Antonio Ospite
...@lentin.co.uk Reviewed-by: Antonio Ospite a...@ao2.it Patch looks good to me, easier to validate now :) A few ideas below for some possible _future_ cleanups, but no reason to hold this one any longer IMHO. Ciao, Antonio --- ...er-hid-lenovo-tpkbd = sysfs-driver-hid-lenovo} | 0

Re: [PATCH v4 2/4] Make all base functions switch depending on product ID

2014-07-14 Thread Antonio Ospite
, + .input_mapping = lenovo_input_mapping, .probe = lenovo_probe, .remove = lenovo_remove, }; -- 2.0.0 -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting

Re: [PATCH v4 4/4] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-07-14 Thread Antonio Ospite
HID_UP_CUSTOM0x00ff #define HID_UP_LOGIVENDOR0xffbc +#define HID_UP_LNVENDOR 0xffa0 #define HID_UP_SENSOR0x0020 #define HID_USAGE0x -- 2.0.0 -- Antonio Ospite http://ao2.it A: Because it messes up

Re: [PATCH v4 0/4] Add support for Lenovo Compact Keyboard

2014-07-14 Thread Antonio Ospite
rename Bluetooth to BT if this becomes too long with the prefix. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from

[PATCH 2/4] HID: sony: Always override the Sixaxis descriptor

2014-06-24 Thread Antonio Ospite
is not strictly necessary for now, but it simplifies the code and in the future the report descriptor will be patched further and keys will be remapped, so it's handy to have only one place to patch. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 31 ++- 1

[PATCH 1/4] HID: sony: Use the SIXAXIS_CONTROLLER constant when possible

2014-06-24 Thread Antonio Ospite
Instead of checking for SIXAXIS_CONTROLLER_USB and SIXAXIS_CONTROLLER_BT separately, a check on SIXAXIS_CONTROLLER can be used when setting connect_mask. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 4/4] HID: sony: Remove an old and redundant comment

2014-06-24 Thread Antonio Ospite
present in the body of the function. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index 22ba5dd..bb1e969 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -875,8

[PATCH 3/4] HID: sony: Format and comment sixaxis_rdesc

2014-06-24 Thread Antonio Ospite
with the help of hidrd-convert: https://github.com/DIGImend/hidrd Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 93 +++--- 1 file changed, 74 insertions(+), 19 deletions(-) diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index

[PATCH 0/4] HID: sony: Some cleanups

2014-06-24 Thread Antonio Ospite
Hi, here are some cleanups for hid-sony. The changes in patches 2 and 3 will prove useful if someday David Hermann's ABS2 changes make it to mainline. Ciao, Antonio Antonio Ospite (4): HID: sony: Use the SIXAXIS_CONTROLLER constant when possible HID: sony: Always override the Sixaxis

Re: [PATCH v3 1/2] Rename hid-lenovo-tpkbd to hid-lenovo, so we can add other keyboards

2014-06-16 Thread Antonio Ospite
(tpkbd_driver); +module_hid_driver(lenovo_driver); MODULE_LICENSE(GPL); -- 2.0.0.rc2 -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing

Re: [PATCH v3 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-16 Thread Antonio Ospite
0xff00 #define HID_UP_CUSTOM0x00ff #define HID_UP_LOGIVENDOR0xffbc +#define HID_UP_LNVENDOR 0xffa0 #define HID_UP_SENSOR0x0020 #define HID_USAGE0x -- 2.0.0.rc2 -- Antonio Ospite

Re: [PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-13 Thread Antonio Ospite
On Thu, 12 Jun 2014 09:56:41 +0100 (BST) Jamie Lentin j...@lentin.co.uk wrote: On Wed, 11 Jun 2014, Antonio Ospite wrote: [...] +static int tpcompactkbd_input_mapping(struct hid_device *hdev, Maybe name these functions like tpkbd_input_mapping_compact()? This way the namespace

Re: [PATCH v2 1/2] Loosen seams to allow support of other keyboards

2014-06-11 Thread Antonio Ospite
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Ciao Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing

Re: [PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-11 Thread Antonio Ospite
, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH] input: pcap2: avoid calling mutex_lock() in irq handler

2014-05-21 Thread Antonio Ospite
specifying IRQCHIP_ONESHOT_SAFE so I do not think request_threaded_irq() without IRQF_ONESHOT would succeed. Can someone test the change to be sure? Tested-by: Antonio Ospite a...@ao2.it I confirm the keys still work fine with the patch applied on a 3.2 kernel. I cannot test on a newer

Re: [PATCH] input: pcap2: avoid calling mutex_lock() in irq handler

2014-05-13 Thread Antonio Ospite
On Mon, 12 May 2014 19:14:56 -0700 Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Sun, Apr 06, 2014 at 11:37:44PM +0200, Antonio Ospite wrote: On Sun, 6 Apr 2014 13:24:36 -0700 Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Sun, Apr 06, 2014 at 12:54:50AM +0400, Alexey

Re: [PATCH v3 01/24] input: Add ff-memless-next module

2014-04-26 Thread Antonio Ospite
-- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe

Re: [PATCH v3 16/24] hid: Port hid-sony to ff-memless-next

2014-04-26 Thread Antonio Ospite
); -- 1.9.2 -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people

Re: [PATCH] input: pcap2: avoid calling mutex_lock() in irq handler

2014-04-06 Thread Antonio Ospite
specifying IRQCHIP_ONESHOT_SAFE so I do not think request_threaded_irq() without IRQF_ONESHOT would succeed. Can someone test the change to be sure? I can try to test it in a couple of weeks, I don't have the hardware at hand right now. Ciao, Antonio -- Antonio Ospite http://ao2

Re: [PATCH v3 3/4] HID: sony: do not rely on hid_output_raw_report

2014-03-10 Thread Antonio Ospite
in USB mode. Reviewed-by: David Herrmann dh.herrm...@gmail.com Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com I confirm that using hidraw via USB works again now, thanks, so the patch is OK: Tested-by: Antonio Ospite a...@ao2.it However I still get the failure with hidraw via

Re: [PATCH v3 3/4] HID: sony: do not rely on hid_output_raw_report

2014-03-10 Thread Antonio Ospite
On Mon, 10 Mar 2014 12:32:53 +0100 Antonio Ospite a...@ao2.it wrote: On Sat, 8 Mar 2014 22:52:42 -0500 Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: hid_out_raw_report is going to be obsoleted as it is not part of the unified HID low level transport documentation

Re: [PATCH v2 6/8] HID: sony: Add an IDA allocator to assign unique device ids

2014-03-10 Thread Antonio Ospite
(sony_init); +module_exit(sony_exit); MODULE_LICENSE(GPL); -- 1.8.5.3 -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite

Re: [PATCH v2 7/8] HID: sony: Initialize the controller LEDs with the device ID value

2014-03-10 Thread Antonio Ospite
-- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text

Re: [PATCH 0/6] HID: sony: More Sony controller fixes and improvements.

2014-03-04 Thread Antonio Ospite
On Sun, 02 Mar 2014 11:26:14 -0500 Frank Praznik frank.praz...@oh.rr.com wrote: On 3/1/2014 08:53, Antonio Ospite wrote: [...] Patch #6 initializes the LEDs to a default value of LED 1 on the Sixaxis and blue on the DualShock 4 so there is some indication that the controller

Re: [PATCH 3/4] HID: sony: do not rely on hid_output_raw_report

2014-03-01 Thread Antonio Ospite
to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing

Re: [PATCH 4/6] HID: sony: Add blink support to the LEDs

2014-03-01 Thread Antonio Ospite
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from

Re: [PATCH 5/6] HID: sony: Add an led trigger to report controller battery status.

2014-03-01 Thread Antonio Ospite
-- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH 6/6] HID: sony: Turn on the LEDs by default.

2014-03-01 Thread Antonio Ospite
; led-brightness_set = sony_led_set_brightness; -- 1.8.5.3 -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2

Re: [PATCH 0/4] HID: sony: Additional fixes and improvements for the Dualshock 4

2014-01-17 Thread Antonio Ospite
to the cover letter and we have them grouped together. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list

Re: [PATCH 4/4] HID: sony: Map gyroscopes and accelerometers to axes

2014-01-17 Thread Antonio Ospite
majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send

Re: [PATCH 1/2] HID: sony: Add force feedback for the Dualshock 4

2014-01-09 Thread Antonio Ospite
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list

Re: [PATCH 2/2] HID: sony: Add LED controls for Dualshock 4

2014-01-09 Thread Antonio Ospite
at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2] Add ff-memless-next module

2013-12-26 Thread Antonio Ospite
this is the best place to put annotations and patch commentary. See git-format-patch and git-am man pages for the details. Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q

[PATCH] Input: gamepad - use independent axes for analog D-Pad buttons

2013-12-23 Thread Antonio Ospite
Model this part of the API after the Sony PlayStation 3 Controller which exposes independent analog values for each one of the D-Pad buttons. The PS3 programming API psl1ght also maps the analog D-Pad buttons individually. Cc: David Herrmann dh.herrm...@gmail.com Signed-off-by: Antonio Ospite

Re: [PATCH 2/4] Input: introduce ABS_MAX2/CNT2 and friends

2013-12-18 Thread Antonio Ospite
for values = ABS_MAX. IIUC this is true only for compatibility with older kernels right? If a program decides to support only newer kernels it can check the protocol version and use only the new ioctls, right? Maybe you can be more explicit about that in the comment? Thanks, Antonio -- Antonio

Re: [PATCH 4/4] Input: add motion-tracking ABS_* bits and docs

2013-12-18 Thread Antonio Ospite
, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH 2/4] Input: introduce ABS_MAX2/CNT2 and friends

2013-12-18 Thread Antonio Ospite
On Wed, 18 Dec 2013 15:44:48 +0100 David Herrmann dh.herrm...@gmail.com wrote: Hi On Wed, Dec 18, 2013 at 3:27 PM, Antonio Ospite osp...@studenti.unina.it wrote: Hi David, thanks for the update. On Tue, 17 Dec 2013 16:48:52 +0100 David Herrmann dh.herrm...@gmail.com wrote

[PATCH 2/2] Input: joystick - use sizeof(VARIABLE) in documentation

2013-12-16 Thread Antonio Ospite
. Signed-off-by: Antonio Ospite osp...@studenti.unina.it --- Documentation/input/joystick-api.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/input/joystick-api.txt b/Documentation/input/joystick-api.txt index f95f648..47e60a5 100644

[PATCH 1/2] Input: joystick - refer to /dev/input/js0 in documentation

2013-12-16 Thread Antonio Ospite
Nowadays the joystick device nodes are created under /dev/input, reflect this in the documentation in order to make copy and paste easier for users. Signed-off-by: Antonio Ospite osp...@studenti.unina.it --- Documentation/input/joystick-api.txt | 2 +- Documentation/input/joystick.txt | 8

Re: [PATCH 2/2] Input: joystick - use sizeof(VARIABLE) in documentation

2013-12-16 Thread Antonio Ospite
On Mon, 16 Dec 2013 01:51:41 -0800 Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Antonio, On Mon, Dec 16, 2013 at 09:57:15AM +0100, Antonio Ospite wrote: @@ -181,7 +181,7 @@ at a time using the typical read(2) functionality. For that, you would replace the read above

Re: [PATCH] Input: fix typos in Documentation/input/gamepad.txt

2013-12-16 Thread Antonio Ospite
On Mon, 16 Dec 2013 14:03:43 +0100 David Herrmann dh.herrm...@gmail.com wrote: Hi CCing linux-input which I forgot. On Mon, Dec 16, 2013 at 1:34 PM, Antonio Ospite osp...@studenti.unina.it wrote: Fix some typos and while at it also use PS as the name for the central HOME button on Sony

Re: [PATCH 1/3] Only process ABS_MT_SLOT where there are slots available

2013-11-21 Thread Antonio Ospite
On Wed, 20 Nov 2013 20:56:21 -0800 Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Benjamin, Antonio, On Wed, Nov 20, 2013 at 04:32:19PM -0500, Benjamin Tissoires wrote: From: Antonio Ospite osp...@studenti.unina.it This fixes the case when a non-multitouch device happens to have

Re: [PATCH] HID: sony: Add force feedback support for Dualshock3 USB

2013-11-18 Thread Antonio Ospite
' (such as a serial number) would be better, but most controllers don't report these. Any suggestions? The bluez plugin uses libudev, so it knows how to address the right device when setting the LED. Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people

Re: [PATCH] HID: sony: Add force feedback support for Dualshock3 USB

2013-11-18 Thread Antonio Ospite
On Mon, 18 Nov 2013 00:12:14 +0100 Sven Eckelmann s...@narfation.org wrote: On Sunday 17 November 2013 23:25:59 Antonio Ospite wrote: Sven, if you are going to resubmit another patch for this functionality (I've seen your v2 just before hitting Send), wouldn't it be better to advertise

Re: About the PS3 Sixaxis linux driver

2013-11-18 Thread Antonio Ospite
push this too hard. - I have discussed this with the Xinput maintainer, and he also would like to get the information from the kernel when the ABS_MT axis are used as ABS_MT or ABS_MISC, so I'll also add a property in this way. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because

Re: [PATCH] HID: sony: Add force feedback support for Dualshock3 USB

2013-11-17 Thread Antonio Ospite
Jiri had already picked it up. Thanks, Antonio [1] http://ao2.it/tmp/playstation-peripheral-pugin-v5.x-2013-11-13.patch -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting

Re: About the PS3 Sixaxis linux driver

2013-11-16 Thread Antonio Ospite
not merged yet, I'll send an RFC as soon as this becomes more easily testable. Regards, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing

Re: [PATCH 04/13] Input: add motion-tracking ABS_* bits and docs

2013-11-16 Thread Antonio Ospite
On Fri, 15 Nov 2013 11:17:31 +0100 David Herrmann dh.herrm...@gmail.com wrote: Hi Antonio On Fri, Nov 15, 2013 at 11:11 AM, Antonio Ospite osp...@studenti.unina.it wrote: On Fri, 1 Nov 2013 21:16:15 +0100 David Herrmann dh.herrm...@gmail.com wrote: Motion sensors are getting quite

Re: [PATCH 04/13] Input: add motion-tracking ABS_* bits and docs

2013-11-15 Thread Antonio Ospite
, David maybe you have another repository I can pull from? Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from

Re: [PATCH] Input: clarify gamepad API ABS values

2013-11-14 Thread Antonio Ospite
as positive values) What about analog Action-Pad buttons? Do you suggest any mapping for them? Menu-Pad: Menu buttons are always digital and are mapped according to their location Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read

Re: [PATCH] Input: clarify gamepad API ABS values

2013-11-14 Thread Antonio Ospite
On Thu, 14 Nov 2013 18:22:28 +0100 David Herrmann dh.herrm...@gmail.com wrote: On Thu, Nov 14, 2013 at 6:07 PM, Antonio Ospite osp...@studenti.unina.it wrote: [...] I know it is not really relevant and you won't fix the kernel interface anyway, but I was just curios: is there any known

Re: About the PS3 Sixaxis linux driver

2013-11-04 Thread Antonio Ospite
, and again, sorry if you're not the right person to write to. Regards, -- Marc Planard -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio

Re: Game Controllers

2013-05-02 Thread Antonio Ospite
them would be even better ;) Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line

  1   2   >