On Thu, 19 Nov 2015 11:39:55 +0100
Antonio Ospite wrote:
> On Tue, 17 Nov 2015 08:57:05 -0500
> Frank Praznik wrote:
>
> > > On Nov 15, 2015, at 10:30, Antonio Ospite wrote:
> [...]
> > >
> > > Hi Frank, the changes are basically OK, but there are
On Tue, 17 Nov 2015 08:57:05 -0500
Frank Praznik wrote:
> > On Nov 15, 2015, at 10:30, Antonio Ospite wrote:
[...]
> >
> > Hi Frank, the changes are basically OK, but there are warnings and
> > errors from scripts/checkpatch.pl
> >
> > Would you
the changes are basically OK, but there are warnings and
errors from scripts/checkpatch.pl
Would you care to send a v3 which fixes those?
Thanks a lot,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/
dev);
> - sony_init_work(sc, sixaxis_state_worker);
> + sony_init_work(sc);
> } else if (sc->quirks & DUALSHOCK4_CONTROLLER) {
> if (sc->quirks & DUALSHOCK4_CONTROLLER_BT) {
> /*
> @@ -2336,9 +2349,9 @@
d but
> automatically restored on resume until a new event is received to avoid
> potentially damaging hardware.
>
> Signed-off-by: Frank Praznik
Acked-by: Antonio Ospite
> ---
> drivers/hid/hid-sony.c | 51
> +-
>
+ (IS_MODULE(CONFIG_IIO) && IS_MODULE(CONFIG_HID_SONY))
> + if (sc->quirks & SONY_IIO_SUPPORT)
> + sony_iio_remove(sc);
> +#endif
> sony_cancel_work_sync(sc);
> kfree(sc->output_report_dmabuf);
> sony_remove_dev_list(sc);
> @@ -210
On Tue, 23 Jun 2015 18:30:26 -0600
Simon Wood wrote:
[...]
> The SixAxis contains accelerometers, the DS4 contains accelerometers and
> gyros.
>
Hi Simon,
the SixAxis also have a gyroscope, I don't know how useful/reliable it
is, but it's there.
Ciao,
Antonio
--
On Wed, 3 Jun 2015 10:26:47 +
"Tirdea, Irina" wrote:
> > -Original Message-
> > From: Antonio Ospite [mailto:a...@ao2.it]
> > Sent: 28 May, 2015 18:58
> > To: Tirdea, Irina
> > Cc: Dmitry Torokhov; Bastien Nocera; linux-input@vger.kernel.org
ry.
Thanks,
Antonio
> int touch_num;
> int i;
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.or
llocate(hdev, id);
> if (ret)
> - goto wtp_allocate_fail;
> + goto allocate_fail;
> + }
> + if (hidpp->quirks & HIDPP_QUIRK_CLASS_M560) {
else if here too please, this way it's super clear that the two allocate
calls a
Most of the entries are aligned with TABs, fix those which are not.
Signed-off-by: Antonio Ospite
Cc: Jiri Kosina
Cc: linux-input@vger.kernel.org
---
drivers/hid/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
index
ic hint than anything else, this
also gives less ambiguity to the 'allocate_fail' label.
> + ret = m560_allocate(hdev);
> + if (ret)
> + goto allocate_fail;
> }
>
> INIT_WORK(&hidpp->work, delayed_work_c
ke a dkms package for this driver I am interested to
> integrate
>
Hi Goffredo, I should be able to do some tests later this week.
I'll let you know.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
the latest version of your dkms-enabled external
module?
https://github.com/kreijack/hid-logitech-dj/tree/m560-dkms
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is
oader (i.e. before lading another linux
instance) and then scrape the dump to look for the kernel messages, but
AFAIK this is not going to be reliable —or even possible— on a more
complex system.
Ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people no
{ }
> +};
> +MODULE_DEVICE_TABLE(of, goodix_of_match);
> +#endif
>
> static struct i2c_driver goodix_ts_driver = {
> .probe = goodix_ts_probe,
> @@ -387,7 +405,8 @@ static struct i2c_driver goodix_ts_driver = {
> .driver = {
> .name = "Goodix-T
On Thu, 5 Mar 2015 20:32:24 +0300
Aleksei Mamlin wrote:
> Use max number of touches from device config instead of hardcoding.
>
> Signed-off-by: Aleksei Mamlin
Tested-by: Antonio Ospite
Some minor comments below, but no need to resend IMHO.
> ---
> drivers/input/touchscree
escription to add the newly supported devices to
> the list?
>
> Cheers
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo
0x804C.
Have you tried if this is true on your 5-finger devices too?
If so, please use this mechanism to populate ts->max_touch_num to avoid
passing hardcoded data.
Thanks,
Antonio
[1]
http://www.wpgholdings.com/uploads/bu/bu_3/MID_20141112/GT9271_Datasheet_20130904.pdf
--
Antonio Ospite
h
rupt */
> + struct gpio_desc*desc;
Just curious: can't the gpio_desc be local in the probe function?
I take that the gpio descriptor needs to be alive even after the irq
number has been derived from it in order for the gpio chip to remember
that the gpio has been requested by som
On Mon, 16 Feb 2015 16:48:53 -0500
Frank Praznik wrote:
> On 2/16/2015 12:12, Antonio Ospite wrote:
> > Hi,
> >
> > here are a few cleanups for hid-sony.
> >
> > Changes are meant to follow the patch titled:
> > [PATCHv4] HID: sony: Enable Gasia third-party
ete_module+0x1bf/0x270
[] ? do_notify_resume+0x69/0xa0
[] ? system_call_fastpath+0x16/0x1b
---[ end trace bc794b3d22c30ede ]---
Signed-off-by: Antonio Ospite
---
drivers/hid/hid-sony.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-so
Sixaxis devices accept feature report 0xf2 when size is >= 17, not 18.
Use the minimum accepted size.
The change is mainly for documentation purposes, the code worked fine
even before this change.
Signed-off-by: Antonio Ospite
---
drivers/hid/hid-sony.c | 2 +-
1 file changed, 1 insert
Don't mix declaration and allocation, remove some useless newlines
between calling a function and checking its return value.
Signed-off-by: Antonio Ospite
---
drivers/hid/hid-sony.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/driver
Hi,
here are a few cleanups for hid-sony.
Changes are meant to follow the patch titled:
[PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers
Frank, hi, I'd like to have your explicit ack at least for patch 1 and
2.
Thanks,
Antonio
Antonio Ospite (5):
HID: sony: Fix a WA
Remove the magic numbers used in sixaxis_set_operational_usb():
- use the already defined SIXAXIS_REPORT_0xF2_SIZE;
- define and use SIXAXIS_REPORT_0xF5_SIZE;
- set the dummy buffer size to accommodate any report that is going to
be requested.
Signed-off-by: Antonio Ospite
---
drivers
Use the same type declared in the prototypes of functions that are going
to accept the buffer as parameter.
Signed-off-by: Antonio Ospite
---
drivers/hid/hid-sony.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index a419868
On Mon, 16 Feb 2015 15:06:59 +0200
Lauri Kasanen wrote:
> Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send
> any events. Now everything works including the leds.
>
> Based on work by Andrew Haines and Antonio Ospite.
>
> cc: Antonio Ospite
> cc:
On Tue, 10 Feb 2015 14:52:52 +0200
Lauri Kasanen wrote:
> Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send
> any events. Now everything works including the leds.
>
> Based on work by Andrew Haines and Antonio Ospite.
>
> cc: Antonio Ospite
> cc:
Hi Lauri,
On Sun, 8 Feb 2015 11:11:38 +0200
Lauri Kasanen wrote:
> Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send
> any events. Now everything works including the leds.
>
> Based on work by Andrew Haines and Antonio Ospite.
>
> v2:
>
gt; > Based on work by Andrew Haines and Antonio Ospite.
> >
> > cc: Antonio Ospite
> > cc: Andrew Haines
> > Signed-off-by: Lauri Kasanen
> > ---
> > drivers/hid/hid-sony.c | 26 --
> > 1 file changed, 24 insertions(+), 2 d
On Tue, 27 Jan 2015 15:45:59 +0100
Antonio Ospite wrote:
> On Wed, 21 Jan 2015 12:16:54 +0200
> Mika Westerberg wrote:
>
> > On Tue, Jan 20, 2015 at 05:56:45PM +0100, Antonio Ospite wrote:
[...]
> > > [9.056300] gpiochip_get_desc: hwnum: 68 chip->ng
On Wed, 21 Jan 2015 12:16:54 +0200
Mika Westerberg wrote:
> On Tue, Jan 20, 2015 at 05:56:45PM +0100, Antonio Ospite wrote:
> > Hi Mika, I tested the patch but I still can't get the IRQ.
> >
> > The new code in i2c-hid does more or less what I was trying to do in
>
On Tue, 20 Jan 2015 12:05:48 +0200
Mika Westerberg wrote:
> On Mon, Jan 19, 2015 at 10:37:58AM -0500, Benjamin Tissoires wrote:
> > Hi Antonio,
> >
> > [adding Mika in CC, he implemented most of the ACPI and GPIO for
> > i2c-hid]
> >
> > On Jan 17 20
allow selecting a driver even with no
enabled mechanism to pass platform data to it?
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thin
BTN_SIDE:
> + index = 3; break;
>
> case BTN_4:
> - case BTN_EXTRA: index = 4; break;
> + case BTN_EXTRA:
> + index = 4; break;
>
> - default: return;
> + default:
> + return;
>
#x27;d notice that the pin number is 0x44 (hex)
on GPO2 (the third bank), but GPO2 has max 44 (decimal) pins, so it would
be still invalid.
Obviously I am still missing something.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
On Mon, 17 Nov 2014 21:01:44 -0500
bri wrote:
> On Mon, Nov 17, 2014 at 01:35:18PM +0100, Antonio Ospite wrote:
> > I had tried doing something similar in the past (the parsing was just a
> > sscanf): http://thread.gmane.org/gmane.linux.bluez.kernel/5261 but then
> > we
stronger voice in the decisions.
If you ask me, wrt. usefulness and necessity the two functionality
are more or less on the same level but the code which is already there
will more likely stay in.
> But whatever. I made this for my own use, and offered it up, and if the
> community does
failed to create master_bdaddr sysfs file\n");
> + goto err_nosysfs1;
> }
>
> if (sc->quirks & SIXAXIS_CONTROLLER_USB) {
> @@ -1932,13 +2120,17 @@ static int sony_probe(struct hid_device
> err_close:
> hid_hw_close(hdev);
> err
#define SIXAXIS_REPORT_0xF2_SIZE 18
either with or without the 0x prefix is fine by me.
That'll be a little easier on the eyes in code like the one below.
[...]
> + ret = hid_hw_raw_request(sc->hdev, 0x81, buf,
> + DS4_REPORT_129_SIZE, HID_FEA
re games will be ported to Linux, the more we'll need soon
> to have some support for this gamers-equipment.
>
> I hope you'll give me some hints.
>
Ciao ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
for charging
and it does not show as a USB HID device when plugged in, can you
confirm that?
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad
On Wed, 23 Jul 2014 23:30:48 +0100
Jamie Lentin wrote:
> Add support for both ThinkPad Compact Bluetooth Keyboard with
> TrackPoint and ThinkPad Compact USB Keyboard with TrackPoint.
>
> Signed-off-by: Jamie Lentin
I think this version is OK, thanks.
Reviewed-by: An
;);
> - }
>
> data_pointer = devm_kzalloc(&hdev->dev,
> sizeof(struct lenovo_drvdata_tpkbd),
> --
> 2.0.0
>
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.
ra postfixed functions.
>
> Signed-off-by: Jamie Lentin
>
Reviewed-by: Antonio Ospite
> ---
> drivers/hid/hid-lenovo.c | 53
>
> 1 file changed, 45 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hid/hid-leno
n
Reviewed-by: Antonio Ospite
> ---
> ...er-hid-lenovo-tpkbd => sysfs-driver-hid-lenovo} | 0
> drivers/hid/Kconfig| 14 +-
> drivers/hid/Makefile | 2 +-
> drivers/hid/hid-core.c |
On Fri, 18 Jul 2014 10:35:35 +0100 (BST)
Jamie Lentin wrote:
> On Mon, 14 Jul 2014, Antonio Ospite wrote:
>
> > On Sun, 13 Jul 2014 08:24:19 +0100
> > Jamie Lentin wrote:
> >
> >> Rename module and all functions within so we can add support for other
> >&
th Trackpoint
Maybe rename Bluetooth to BT if this becomes too long with the prefix.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
ENOVO_TPKBD:
> lenovo_remove_tpkbd(hdev);
> break;
> + case USB_DEVICE_ID_LENOVO_CUSBKBD:
> + case USB_DEVICE_ID_LENOVO_CBTKBD:
> + lenovo_remove_cptkbd(hdev);
> + break;
> }
>
> hid_hw_stop(hdev);
&g
On Sun, 13 Jul 2014 08:24:21 +0100
Jamie Lentin wrote:
> Signed-off-by: Jamie Lentin
Reviewed-by: Antonio Ospite
> ---
> drivers/hid/hid-lenovo.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hi
> - if (hid_get_drvdata(hdev))
> + switch (hdev->product) {
> + case USB_DEVICE_ID_LENOVO_TPKBD:
> lenovo_remove_tpkbd(hdev);
> + break;
> + }
>
> hid_hw_stop(hdev);
> }
> @@ -454,7 +485,7 @@ MODULE_DEVICE_TABLE(hid, lenovo_devic
n
Reviewed-by: Antonio Ospite
Patch looks good to me, easier to validate now :)
A few ideas below for some possible _future_ cleanups, but no reason to
hold this one any longer IMHO.
Ciao,
Antonio
> ---
> ...er-hid-lenovo-tpkbd => sysfs-driver-hid-lenovo} |
help of hidrd-convert:
https://github.com/DIGImend/hidrd
Signed-off-by: Antonio Ospite
---
drivers/hid/hid-sony.c | 93 +++---
1 file changed, 74 insertions(+), 19 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 11026b5
Hi,
here are some cleanups for hid-sony.
The changes in patches 2 and 3 will prove useful if someday David
Hermann's ABS2 changes make it to mainline.
Ciao,
Antonio
Antonio Ospite (4):
HID: sony: Use the SIXAXIS_CONTROLLER constant when possible
HID: sony: Always override the Si
s not
strictly necessary for now, but it simplifies the code and in the future
the report descriptor will be patched further and keys will be remapped,
so it's handy to have only one place to patch.
Signed-off-by: Antonio Ospite
---
drivers/hid/hid-sony.c | 31 ++---
Instead of checking for SIXAXIS_CONTROLLER_USB and SIXAXIS_CONTROLLER_BT
separately, a check on SIXAXIS_CONTROLLER can be used when setting
connect_mask.
Signed-off-by: Antonio Ospite
---
drivers/hid/hid-sony.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hid
present in the body of the function.
Signed-off-by: Antonio Ospite
---
drivers/hid/hid-sony.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 22ba5dd..bb1e969 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -875,8 +875,6
novo_remove_cptkbd(hdev);
> + break;
> }
>
> hid_hw_stop(hdev);
> @@ -478,6 +677,8 @@ static void lenovo_remove(struct hid_device *hdev)
>
> static const struct hid_device_id lenovo_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEV
gt; + if (ret)
> + goto err_hid;
>
This hunk would also go in the preparatory patch.
> return 0;
> err_hid:
> @@ -422,12 +449,15 @@ err:
> return ret;
> }
>
> -static void tpkbd_remove_tp(struct hid_device *hdev)
> +static void lenovo_r
On Thu, 12 Jun 2014 09:56:41 +0100 (BST)
Jamie Lentin wrote:
> On Wed, 11 Jun 2014, Antonio Ospite wrote:
>
[...]
> >> +static int tpcompactkbd_input_mapping(struct hid_device *hdev,
> >
> > Maybe name these functions like tpkbd_input_mapping_compact()?
> >
&
id tpkbd_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_TPKBD) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_CUSBKBD) },
> + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LENOVO,
> USB_DEVICE_ID_LENOVO_CBTKBD) },
> { }
&g
in tpkbd_remove() like
you are doing as hid_hw_stop() must be always called.
> + if (hdev->product == USB_DEVICE_ID_LENOVO_TPKBD)
> tpkbd_remove_tp(hdev);
>
> hid_hw_stop(hdev);
> --
> 2.0.0.rc2
>
> --
> To unsubscribe from this li
request_threaded_irq(pcap_to_irq(pcap_keys->pcap, PCAP_IRQ_MIC),
> > + NULL, pcap_keys_handler, 0,
> > + "Headphone button", pcap_keys);
>
> So I guess we do need threaded IRQ here, but I do not see the pcap&#
On Mon, 12 May 2014 19:14:56 -0700
Dmitry Torokhov wrote:
> On Sun, Apr 06, 2014 at 11:37:44PM +0200, Antonio Ospite wrote:
> > On Sun, 6 Apr 2014 13:24:36 -0700
> > Dmitry Torokhov wrote:
> >
> > > On Sun, Apr 06, 2014 at 12:54:50AM +0400, Alexey Khoroshilov wr
evices[] = {
> .driver_data = DUALSHOCK4_CONTROLLER_USB },
> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY,
> USB_DEVICE_ID_SONY_PS4_CONTROLLER),
> .driver_data = DUALSHOCK4_CONTROLLER_BT },
> +
Extra blank line here.
> { }
> };
> MODULE_DE
On Sat, 26 Apr 2014 13:57:38 +0200
Michal Malý wrote:
> Add ff-memless-next module
>
Hi Michal, what about adding the notes from 0/24 to this commit
message? This is the one which will actually get into the project
history. And perhaps hint briefly about the improvements also in the
commit messa
pcap's
> irqchip specifying IRQCHIP_ONESHOT_SAFE so I do not think
> request_threaded_irq() without IRQF_ONESHOT would succeed.
>
> Can someone test the change to be sure?
>
I can try to test it in a couple of weeks, I don't have the hardware
at hand right now.
Ciao,
Anton
> if (ret) {
> hid_err(hdev, "Failed to register LED %d\n", n);
> + sc->leds[n] = NULL;
> kfree(led);
> goto error_leds;
> }
> -
> - sc->leds[n] = l
gt; -module_hid_driver(sony_driver);
> +
> +static int __init sony_init(void)
> +{
> + dbg_hid("Sony:%s\n", __func__);
> +
> + return hid_register_driver(&sony_driver);
> +}
> +
> +static void __exit sony_exit(void)
> +{
> + dbg_hid("Sony:%s\n&qu
On Mon, 10 Mar 2014 12:32:53 +0100
Antonio Ospite wrote:
> On Sat, 8 Mar 2014 22:52:42 -0500
> Benjamin Tissoires wrote:
>
> > hid_out_raw_report is going to be obsoleted as it is not part of the
> > unified HID low level transport documentation
> > (Document
ith the PS3 SixAxis
> controllers in USB mode.
>
> Reviewed-by: David Herrmann
> Signed-off-by: Benjamin Tissoires
>
I confirm that using hidraw via USB works again now, thanks, so the
patch is OK:
Tested-by: Antonio Ospite
However I still get the failure with hidraw via BT,
On Sun, 02 Mar 2014 11:26:14 -0500
Frank Praznik wrote:
> On 3/1/2014 08:53, Antonio Ospite wrote:
[...]
> >
> >> Patch #6 initializes the LEDs to a default value of LED 1 on the Sixaxis
> >> and
> >> blue on the DualShock 4 so there is some indication that t
> + led->brightness = initial_values[n];
> led->max_brightness = max_brightness;
> led->brightness_get = sony_led_get_brightness;
> led->brightness_set = sony_led_set_brightness;
> --
> 1.8.5.3
>
> --
> T
< 0)
> + goto err_stop;
> + }
> +
> if (sc->quirks & SONY_FF_SUPPORT) {
> ret = sony_init_ff(sc);
> if (ret < 0)
> @@ -1817,8 +1968,10 @@ err_close:
> err_stop:
> if (sc->quirks & SONY_LED
}
> + }
> +
> if (sc->quirks & SIXAXIS_CONTROLLER_USB)
> hid_output_raw_report(sc->hdev, buf, sizeof(buf),
> HID_OUTPUT_REPORT);
> else
> @@ -1338,6 +1416,9 @@ static void dualshock4_state_worker(struct work_struct
> *work)
mble values could override the
LED settings done via hidraw, because the LEDs state is not tracked in
the latter case.
Ciao,
Antonio
[1]
http://git.kernel.org/cgit/bluetooth/bluez.git/tree/plugins/sixaxis.c
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people nor
hid.h
> index 5eb282e..2baf834 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -287,6 +287,8 @@ struct hid_item {
> #define HID_QUIRK_NO_EMPTY_INPUT 0x0100
> #define HID_QUIRK_NO_INIT_INPUT_REPORTS 0x0200
> #define HID_QUI
sizeof(dualshock4_usb_rdesc);
> + }
> +
> /* The HID descriptor exposed over BT has a trailing zero byte */
> if sc->quirks & SIXAXIS_CONTROLLER_USB) && *rsize == 148) ||
> ((sc->quirks & SIXAXIS_CONTROLLER_BT) &am
he cover letter and we
have them grouped together.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
--
To unsubscribe from this
is_state_worker(struct work_struct
> *work)
> buf[5] = sc->left;
> #endif
>
> - buf[10] |= (sc->led_state & 0xf) << 1;
> + buf[10] |= sc->led_state[0] << 1;
> + buf[10] |= sc->led_state[1] << 2;
> + buf[10] |= sc->led
USB_DEVICE_ID_LOGITECH_HARMONY_PS3),
> .driver_data = PS3REMOTE },
> + /* Sony Dualshock 4 controllers for PS4 */
> + { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER),
> + .driver_data = DUALSHOCK4_CONTROLLER },
> + { HID_BLUETOOTH_DEV
On Sun, 29 Dec 2013 16:52:09 -0800
Dmitry Torokhov wrote:
> Hi Antonio,
>
> On Mon, Dec 23, 2013 at 05:17:43PM +0100, Antonio Ospite wrote:
> > Model this part of the API after the Sony PlayStation 3 Controller which
> > exposes independent analog values for each one
t;diff"
blocks, so this is the best place to put annotations and patch
commentary.
See git-format-patch and git-am man pages for the details.
Ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia
Model this part of the API after the Sony PlayStation 3 Controller which
exposes independent analog values for each one of the D-Pad buttons.
The PS3 programming API psl1ght also maps the analog D-Pad buttons
individually.
Cc: David Herrmann
Signed-off-by: Antonio Ospite
---
Hi,
as David
On Wed, 18 Dec 2013 15:44:48 +0100
David Herrmann wrote:
> Hi
>
> On Wed, Dec 18, 2013 at 3:27 PM, Antonio Ospite
> wrote:
> > Hi David,
> >
> > thanks for the update.
> >
> > On Tue, 17 Dec 2013 16:48:52 +0100
> > David Herrmann wrote:
> &
9,19 @@ struct input_keymap_entry {
> #define ABS_MAX 0x3f
> #define ABS_CNT (ABS_MAX+1)
>
> +#define ABS_ACCEL_X 0x40/* Accelerometer X axis */
> +#define ABS_ACCEL_Y 0x41/* Accelerometer Y axis */
> +#define AB
rnels right?
If a program decides to support only newer kernels it can check the
protocol version and use only the new ioctls, right?
Maybe you can be more explicit about that in the comment?
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people
Signed-off-by: Antonio Ospite
---
I also noticed that BTN_GEAR_DOWN is named "WheelBtn", should this be fixed?
Thanks,
Antonio
drivers/hid/hid-debug.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
ind
Fix some typos and while at it also use "PS" as the name for the central
"HOME" button on Sony controllers, this is how Sony itself calls it.
Reviewed-by: David Herrmann
Signed-off-by: Antonio Ospite
---
Changes since v1:
- Fix one of the fixes: use "advise" (ve
On Mon, 16 Dec 2013 14:03:43 +0100
David Herrmann wrote:
> Hi
>
CCing linux-input which I forgot.
> On Mon, Dec 16, 2013 at 1:34 PM, Antonio Ospite
> wrote:
> > Fix some typos and while at it also use "PS" as the name for the central
> > "HOME"
On Mon, 16 Dec 2013 01:51:41 -0800
Dmitry Torokhov wrote:
> Hi Antonio,
>
> On Mon, Dec 16, 2013 at 09:57:15AM +0100, Antonio Ospite wrote:
> > @@ -181,7 +181,7 @@ at a time using the typical read(2) functionality. For
> > that, you would
> > replace the rea
Hi,
here are a couple of fixes for the joystick API documentation.
Ciao,
Antonio
Antonio Ospite (2):
Input: joystick - refer to /dev/input/js0 in documentation
Input: joystick - use sizeof(VARIABLE) in documentation
Documentation/input/joystick-api.txt | 12 ++--
Documentation
Nowadays the joystick device nodes are created under /dev/input, reflect
this in the documentation in order to make copy and paste easier for
users.
Signed-off-by: Antonio Ospite
---
Documentation/input/joystick-api.txt | 2 +-
Documentation/input/joystick.txt | 8
2 files changed
t mean
anything.
Signed-off-by: Antonio Ospite
---
Documentation/input/joystick-api.txt | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/input/joystick-api.txt
b/Documentation/input/joystick-api.txt
index f95f648..47e60a5 100644
--- a/Documentation
On Wed, 20 Nov 2013 20:56:21 -0800
Dmitry Torokhov wrote:
> Hi Benjamin, Antonio,
>
> On Wed, Nov 20, 2013 at 04:32:19PM -0500, Benjamin Tissoires wrote:
> > From: Antonio Ospite
> >
> > This fixes the case when a non-multitouch device happens to have a HID
> >
king API, but I won't push
this too hard.
> - I have discussed this with the Xinput maintainer, and he also would
> like to get the information from the kernel when the ABS_MT axis are
> used as ABS_MT or ABS_MISC, so I'll also add a property in this way.
>
Thanks,
Antonio
On Mon, 18 Nov 2013 00:12:14 +0100
Sven Eckelmann wrote:
> On Sunday 17 November 2013 23:25:59 Antonio Ospite wrote:
> > Sven, if you are going to resubmit another patch for this functionality
> > (I've seen your v2 just before hitting "Send"), wouldn't
x27;fixed UID' (such as a serial number) would be
> better, but most controllers don't report these. Any suggestions?
>
The bluez plugin uses libudev, so it knows how to address the right
device when setting the LED.
Ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it
HID_SONY_FF instead of CONFIG_SONY_FF? Not a big deal of course,
just a suggestion.
Sorry for the late comments but I got to see the patch only after Jiri
had already picked it up.
Thanks,
Antonio
[1] http://ao2.it/tmp/playstation-peripheral-pugin-v5.x-2013-11-13.patch
--
Antonio Ospite
http:
1 - 100 of 120 matches
Mail list logo
