Re: [PATCH] Input: cap1106 - allow changing key mapping from userspace

2014-08-06 Thread Daniel Mack
Hi Dmitry, On 08/07/2014 08:20 AM, Dmitry Torokhov wrote: > On Sun, Jul 20, 2014 at 06:20:49PM -0700, Dmitry Torokhov wrote: >> Wire up support for EVIOC{G|S}KEYCODE to allow users change key mappings >> from userspace. >> >> Signed-off-by: Dmitry Torokhov >> --- >> >> Just compiled, not tested.

Re: [PATCH] Input: cap1106 - allow changing key mapping from userspace

2014-08-08 Thread Daniel Mack
On 08/08/2014 08:50 AM, Dmitry Torokhov wrote: > On Thu, Aug 07, 2014 at 08:50:24AM +0200, Daniel Mack wrote: >> Hi Dmitry, >> >> On 08/07/2014 08:20 AM, Dmitry Torokhov wrote: >>> On Sun, Jul 20, 2014 at 06:20:49PM -0700, Dmitry Torokhov wrote: >>>> Wire

Re: [PATCH] Input: cap1106 - fix register definition

2014-09-02 Thread Daniel Mack
make use of them? Acked-by: Daniel Mack Thanks, Daniel > --- > drivers/input/keyboard/cap1106.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/cap1106.c > b/drivers/input/keyboard/cap1106.c > index 180b184..d70

Re: [PATCH 1/3] cap1106: Add support for various cap11xx devices

2014-09-21 Thread Daniel Mack
Hi, On 09/21/2014 05:01 AM, Matt Ranostay wrote: > Several other variants of the cap11xx device exists with a varying > number of capacitance detection channels. Add support for creating > the channels dynamically. Thanks for the patches! > > Signed-off-by: Matt Ranostay > --- > drivers/input

Re: [PATCH 2/3] cap1106: support for active-high interrupt option

2014-09-21 Thread Daniel Mack
On 09/21/2014 05:01 AM, Matt Ranostay wrote: > Some applications need to use the active-high push-pull interrupt > option. This allows it be enabled in the device tree child node. > > Signed-off-by: Matt Ranostay > --- > drivers/input/keyboard/cap1106.c | 6 ++ > 1 file changed, 6 insertions

Re: [PATCH 1/3] cap1106: Add support for various cap11xx devices

2014-09-21 Thread Daniel Mack
Hi, On 09/21/2014 05:01 AM, Matt Ranostay wrote: > priv->regmap = devm_regmap_init_i2c(i2c_client, &cap1106_regmap_config); > if (IS_ERR(priv->regmap)) > return PTR_ERR(priv->regmap); > > - error = regmap_read(priv->regmap, CAP1106_REG_PRODUCT_ID, &val); > - if

Re: [PATCH 1/3] cap1106: Add support for various cap11xx devices

2014-09-22 Thread Daniel Mack
On 09/22/2014 12:46 AM, Matt Ranostay wrote: > On Sun, Sep 21, 2014 at 2:58 AM, Daniel Mack wrote: >> On 09/21/2014 05:01 AM, Matt Ranostay wrote: >>> @@ -313,12 +307,16 @@ static int cap1106_i2c_probe(struct i2c_client >>> *i2c_client, >>> >>> st

Re: [PATCH 2/3] cap1106: support for active-high interrupt option

2014-09-22 Thread Daniel Mack
On 09/22/2014 07:56 AM, Dmitry Torokhov wrote: > On Sun, Sep 21, 2014 at 12:06:30PM +0200, Daniel Mack wrote: >> On 09/21/2014 05:01 AM, Matt Ranostay wrote: >>> Some applications need to use the active-high push-pull interrupt >>> option. This allows it be enabled in

Re: [PATCH v2 1/2] cap1106: Add support for various cap11xx devices

2014-09-22 Thread Daniel Mack
On 09/23/2014 06:04 AM, Matt Ranostay wrote: > diff --git a/drivers/input/keyboard/cap1106.c > b/drivers/input/keyboard/cap1106.c > index d70b65a..07f9e88 100644 > --- a/drivers/input/keyboard/cap1106.c > +++ b/drivers/input/keyboard/cap1106.c > @@ -55,8 +55,6 @@ > #define CAP1106_REG_MANUFACTURE

Re: [PATCH v3 1/3] cap11xx: make driver generic for variant support

2014-09-27 Thread Daniel Mack
e. I can't test it, however, as I don't have access to the hardware anymore. Reviewed-by: Daniel Mack Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] driver: input: touchscreen: add Raydium i2c touchscreen driver

2014-11-19 Thread Daniel Mack
On 11/19/2014 04:30 PM, jeffrey.lin wrote: > From: "jeffrey.lin" > > this patch is porting Raydium I2C touch driver. Developer can enable > raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM_TS". > > BUG: None > TEST: built and test with peppy > > Signed-off-by: jeffrey@rad-ic.

[PATCH] Input: Add driver for Microchip's CAP1106

2014-07-11 Thread Daniel Mack
ata driven boards, but fully depends on CONFIG_OF. Power management functions are also left for volounteers with the ability to actually test them. Signed-off-by: Daniel Mack --- .../devicetree/bindings/input/cap1106.txt | 63 drivers/input/keyboard/Kconfig | 10

[PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-11 Thread Daniel Mack
ata driven boards, but fully depends on CONFIG_OF. Power management functions are also left for volounteers with the ability to actually test them. Signed-off-by: Daniel Mack --- v2: * Fix potential deadlocks pointed out by David. .../devicetree/bindings/input/cap1106.txt | 63 dri

Re: [PATCH] Input: Add driver for Microchip's CAP1106

2014-07-11 Thread Daniel Mack
On 07/11/2014 07:33 PM, Dmitry Torokhov wrote: > On Fri, Jul 11, 2014 at 11:48:48AM +0200, Daniel Mack wrote: >> On 07/11/2014 11:43 AM, David Herrmann wrote: >>>> +static void cap1106_work(struct work_struct *w) >>>>> +{ >>>>> +

[PATCH v3] Input: Add driver for Microchip's CAP1106

2014-07-11 Thread Daniel Mack
ata driven boards, but fully depends on CONFIG_OF. Power management functions are also left for volounteers with the ability to actually test them. Signed-off-by: Daniel Mack --- v2: * Fix potential deadlocks pointed ou

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-14 Thread Daniel Mack
Hi Mark, thanks a lot for your feedback! Much appreciated. On 07/14/2014 11:52 AM, Mark Rutland wrote: > On Fri, Jul 11, 2014 at 11:06:33AM +0100, Daniel Mack wrote: >> +++ b/Documentation/devicetree/bindings/input/cap1106.txt >> @@ -0,0 +1,63 @@ >> +Device tree bindings

[PATCH v4] Input: Add driver for Microchip's CAP1106

2014-07-14 Thread Daniel Mack
ata driven boards, but fully depends on CONFIG_OF. Power management functions are also left for volounteers with the ability to actually test them. Signed-off-by: Daniel Mack --- v2: * Fix potential deadlocks pointed ou

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Daniel Mack
On 07/15/2014 10:51 AM, Mark Rutland wrote: > On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: >> Hmm, I thought about that, but there are - in theory - more details that >> could be specified per channel. I left those functions out for the first >> version, as

[PATCH v5] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Daniel Mack
ata driven boards, but fully depends on CONFIG_OF. Power management functions are also left for volounteers with the ability to actually test them. Signed-off-by: Daniel Mack --- v2: * Fix potential deadlocks pointed ou

Re: [PATCH v4] Input: Add driver for Microchip's CAP1106

2014-07-17 Thread Daniel Mack
On 07/14/2014 08:46 PM, Dmitry Torokhov wrote: > On Mon, Jul 14, 2014 at 04:28:02PM +0200, Daniel Mack wrote: >> + >> +static int cap1106_i2c_remove(struct i2c_client *i2c_client) >> +{ >> +struct cap1106_priv *priv = i2c_get_clientdata(i2c_client); >> + >

[PATCH 1/2] Input: touchscreen: ads7846: copy info from pdata to private struct

2013-04-25 Thread Daniel Mack
In preparation for DT bindings, we have to store all runtime information inside struct ads7846. Add more variable to struct ads7846 and refactor some code so the probe-time supplied pdata is not used from any other function than the probe() callback. Signed-off-by: Daniel Mack --- drivers/input

[PATCH 2/2] Input: touchscreen: ads7846: add device tree bindings

2013-04-25 Thread Daniel Mack
This patch adds device tree bindings to the ads7846 driver, and documents the required and optional binding properties. Successfully tested on an OMAP3 board. Signed-off-by: Daniel Mack --- .../devicetree/bindings/input/ads7846.txt | 86 ++ drivers/input/touchscreen/ads7846.c

Re: [PATCH 1/2] Input: touchscreen: ads7846: copy info from pdata to private struct

2013-05-06 Thread Daniel Mack
Hi Dmitry, On 06.05.2013 05:24, Dmitry Torokhov wrote: > On Thu, Apr 25, 2013 at 01:33:52PM +0200, Daniel Mack wrote: >> In preparation for DT bindings, we have to store all runtime information >> inside struct ads7846. Add more variable to struct ads7846 and refactor >> s

Re: [PATCH 9/9] Input: rotary_encoder - Remove redundant platform_set_drvdata()

2013-05-06 Thread Daniel Mack
On 04.05.2013 16:51, Sachin Kamat wrote: > Commit 0998d06310 (device-core: Ensure drvdata = NULL when no > driver is bound) removes the need to set driver data field to > NULL. > > Signed-off-by: Sachin Kamat > Cc: Daniel Mack Acked-by: Daniel Mack > ---

Re: [PATCH 1/2] Input: touchscreen: ads7846: copy info from pdata to private struct

2013-05-06 Thread Daniel Mack
On 06.05.2013 12:25, Mark Brown wrote: > On Sun, May 05, 2013 at 08:24:44PM -0700, Dmitry Torokhov wrote: >> On Thu, Apr 25, 2013 at 01:33:52PM +0200, Daniel Mack wrote: > >>> In preparation for DT bindings, we have to store all runtime information >>> inside struct

[PATCH v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct

2013-05-12 Thread Daniel Mack
Allocate a copy of the pdata, and keep a pointer to it in the private struct ads7846. Also, kill some members that used to be in both structs. This is needed for the upcoming DT support. Signed-off-by: Daniel Mack --- Hi Dmitry, this is the alternative approach, as described eariler in our

[PATCH v2 2/2] Input: touchscreen: ads7846: add device tree bindings

2013-05-12 Thread Daniel Mack
Signed-off-by: Daniel Mack --- .../devicetree/bindings/input/ads7846.txt | 86 drivers/input/touchscreen/ads7846.c| 109 - 2 files changed, 194 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/input

[PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct

2013-05-22 Thread Daniel Mack
Allocate a copy of the pdata, and keep a pointer to it in the private struct ads7846. Also, kill some members that used to be in both structs. This is needed for the upcoming DT support. Signed-off-by: Daniel Mack --- Hi Dmitry, this is the alternative approach, as described eariler in our

[PATCH RESEND v2 2/2] Input: touchscreen: ads7846: add device tree bindings

2013-05-22 Thread Daniel Mack
Signed-off-by: Daniel Mack --- .../devicetree/bindings/input/ads7846.txt | 86 drivers/input/touchscreen/ads7846.c| 109 - 2 files changed, 194 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/input

Re: [PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct

2013-06-23 Thread Daniel Mack
Hi Dmitry, I believe these two patches were simply forgotten. Could you review them again please? I don't have access to the hardware any more, but I'd still like to have the patches mainline. Thanks, Daniel On 22.05.2013 19:57, Daniel Mack wrote: > Allocate a copy of the pdat

[PATCH RESEND v2 2/2] Input: touchscreen: ads7846: add device tree bindings

2013-06-30 Thread Daniel Mack
Signed-off-by: Daniel Mack --- .../devicetree/bindings/input/ads7846.txt | 86 drivers/input/touchscreen/ads7846.c| 109 - 2 files changed, 194 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/input

[PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct

2013-06-30 Thread Daniel Mack
Allocate a copy of the pdata, and keep a pointer to it in the private struct ads7846. Also, kill some members that used to be in both structs. This is needed for the upcoming DT support. Signed-off-by: Daniel Mack --- Hi Dmitry, my apologies if I'm annyoning you by resending this patc

Re: [PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct

2013-06-30 Thread Daniel Mack
Hi Dmitry, On 01.07.2013 03:33, Dmitry Torokhov wrote: > On Sun, Jun 30, 2013 at 11:09:14PM +0200, Daniel Mack wrote: >> + >> +if (!pdata->model) >> +pdata->model = 7846; >> + >> +if (!pdata->vref_delay_usecs) >> +

Re: [PATCH RESEND v2 2/2] Input: touchscreen: ads7846: add device tree bindings

2013-06-30 Thread Daniel Mack
Hi Dmirty, On 01.07.2013 03:35, Dmitry Torokhov wrote: > On Sun, Jun 30, 2013 at 11:09:15PM +0200, Daniel Mack wrote: >> +static struct ads7846_platform_data *ads7846_probe_dt(struct device *dev) >> +{ >> +struct ads7846_platform_data *pdata = NULL; >> +const

Re: [PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct

2013-07-01 Thread Daniel Mack
On 01.07.2013 09:09, Dmitry Torokhov wrote: > Hi Daniel, > > On Mon, Jul 01, 2013 at 08:48:50AM +0200, Daniel Mack wrote: >> Hi Dmitry, >> >> On 01.07.2013 03:33, Dmitry Torokhov wrote: >>> On Sun, Jun 30, 2013 at 11:09:14PM +0200, Daniel Mack wro

Re: [PATCH 44/50] sound: usb: caiaq: spin_lock in complete() cleanup

2013-07-11 Thread Daniel Mack
On 11.07.2013 11:06, Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Daniel Mack > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: alsa-de...@alsa-project.org > Signed-off-by: Ming Lei Sound right to me, thanks

Re: [PATCH 1/1] Input: rotary-encoder: Add 'stepped' irq handler

2013-09-29 Thread Daniel Mack
Hi Ezequiel, On 28.09.2013 20:26, Ezequiel Garcia wrote: > Some rotary-encoder devices (such as those with detents) are capable > of producing a stable event on each step. This commit adds support > for this case, by implementing a new interruption handler. > > The handler needs only detect the d

Re: [PATCH 1/1] Input: rotary-encoder: Add 'stepped' irq handler

2013-09-29 Thread Daniel Mack
On 29.09.2013 19:29, Ezequiel García wrote: > On 29 September 2013 07:40, Daniel Mack wrote: >> On 28.09.2013 20:26, Ezequiel Garcia wrote: >>> + sum = (encoder->last_stable << 2) + state; >>> + switch (sum) { >>> + case 0b1101:

Re: [PATCH v2 1/2] Input: rotary-encoder: Add 'stepped' irq handler

2013-10-04 Thread Daniel Mack
he direction of the turn and generate > an event according to this detection. I think you can squash patch 2/2 into this one. It doesn't make much sense to have a one-liner patch to just update the documenation separately. Other than that, the code looks fine to me. Acked-by: Daniel

Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN

2012-07-15 Thread Daniel Mack
On 13.07.2012 09:01, Dmitry Torokhov wrote: > On Wed, May 02, 2012 at 09:36:51PM -0700, Dmitry Torokhov wrote: >> Hi Sven, >> >> On Sat, Apr 07, 2012 at 08:38:33PM +0200, Sven Neumann wrote: >>> Hi, >>> >>> On 07.04.12 09:02, Dmitry Torokhov wrote: On Fri, Apr 06, 2012 at 10:40:07PM -0700, Olo

Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN

2012-07-17 Thread Daniel Mack
On 13.07.2012 09:01, Dmitry Torokhov wrote: > On Wed, May 02, 2012 at 09:36:51PM -0700, Dmitry Torokhov wrote: >> Hi Sven, >> >> On Sat, Apr 07, 2012 at 08:38:33PM +0200, Sven Neumann wrote: >>> Hi, >>> >>> On 07.04.12 09:02, Dmitry Torokhov wrote: On Fri, Apr 06, 2012 at 10:40:07PM -0700, Olo

Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN

2012-07-19 Thread Daniel Mack
On 17.07.2012 14:59, Daniel Mack wrote: > On 13.07.2012 09:01, Dmitry Torokhov wrote: >> On Wed, May 02, 2012 at 09:36:51PM -0700, Dmitry Torokhov wrote: >>> Hi Sven, >>> >>> On Sat, Apr 07, 2012 at 08:38:33PM +0200, Sven Neumann wrote: >>>> Hi, &g

Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN

2012-07-23 Thread Daniel Mack
On 23.07.2012 18:51, Dmitry Torokhov wrote: > On Thu, Jul 19, 2012 at 05:36:12PM +0200, Daniel Mack wrote: >> Ok, finally I found some time. In general, the patch works fine. The >> only detail I had to amend was the irqflags, which were changed from >> IRQF_TRIGGER_RISING/IR

[PATCH 2/2] input: rotary-encoder: defer calls gpio_to_irq()

2012-07-24 Thread Daniel Mack
Don't call gpio_to_irq() on GPIOs before gpio_request() succeeded on them. This avoids Ooopses with incorrect DT bindings. Signed-off-by: Daniel Mack --- drivers/input/misc/rotary_encoder.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input

[PATCH 1/2] input: rotary-encoder: add DT bindings

2012-07-24 Thread Daniel Mack
This adds devicetree bindings to the rotary encoder driver and some documenation about how to use them. Tested on a PXA3xx platform. Signed-off-by: Daniel Mack --- .../devicetree/bindings/input/rotary-encoder.txt | 37 drivers/input/misc/rotary_encoder.c| 63

Emulating level IRQs (was: Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN)

2012-07-24 Thread Daniel Mack
On 23.07.2012 18:51, Dmitry Torokhov wrote: > On Thu, Jul 19, 2012 at 05:36:12PM +0200, Daniel Mack wrote: >> Ok, finally I found some time. In general, the patch works fine. The >> only detail I had to amend was the irqflags, which were changed from >> IRQF_TRIGGER_RISING/IR

Re: [PATCH 2/2] input: rotary-encoder: defer calls gpio_to_irq()

2012-07-25 Thread Daniel Mack
On 24.07.2012 21:45, H Hartley Sweeten wrote: > On Tuesday, July 24, 2012 10:38 AM, Daniel Mack wrote: >> Don't call gpio_to_irq() on GPIOs before gpio_request() succeeded on >> them. This avoids Ooopses with incorrect DT bindings. >> >> Signed-off-by: Daniel Mac

[PATCH v2 2/2] input: rotary-encoder: add DT bindings

2012-07-25 Thread Daniel Mack
This adds devicetree bindings to the rotary encoder driver and some documenation about how to use them. Tested on a PXA3xx platform. Signed-off-by: Daniel Mack --- .../devicetree/bindings/input/rotary-encoder.txt | 37 drivers/input/misc/rotary_encoder.c| 63

[PATCH v2 1/2] input: rotary-encoder: switch to devm_* allocation of GPIOs and IRQs

2012-07-25 Thread Daniel Mack
This simplifies the error unwind pathes. Also, don't call gpio_to_irq() on GPIOs before dev_gpio_request_one() succeeded on them. This avoids Ooopses with incorrect DT bindings. Signed-off-by: Daniel Mack --- drivers/input/misc/rotary_encoder.c | 67 +++--

Re: [PATCH v2 1/2] input: rotary-encoder: switch to devm_* allocation of GPIOs and IRQs

2012-07-25 Thread Daniel Mack
On 25.07.2012 18:05, Dmitry Torokhov wrote: > On Wed, Jul 25, 2012 at 09:43:47AM +0200, Daniel Mack wrote: >> @@ -263,12 +243,7 @@ exit_free_mem: >> static int __devexit rotary_encoder_remove(struct platform_device *pdev) >> { >> struct rotary_encoder *encoder

Re: [PATCH v2 1/2] input: rotary-encoder: switch to devm_* allocation of GPIOs and IRQs

2012-07-25 Thread Daniel Mack
On 25.07.2012 18:29, Dmitry Torokhov wrote: > On Wed, Jul 25, 2012 at 06:07:24PM +0200, Daniel Mack wrote: >> On 25.07.2012 18:05, Dmitry Torokhov wrote: >>> On Wed, Jul 25, 2012 at 09:43:47AM +0200, Daniel Mack wrote: >>>> @@ -263,12 +243,7 @@ exit_free_m

[PATCH v3 2/3] input: rotary-encoder: use gpio_request_one()

2012-07-25 Thread Daniel Mack
Use gpio_request_one() instead of separate calls to gpio_request() and gpio_direction_input() to simplify the code. Signed-off-by: Daniel Mack --- drivers/input/misc/rotary_encoder.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH v3 1/3] input: rotary-encoder: defer calls gpio_to_irq()

2012-07-25 Thread Daniel Mack
Don't call gpio_to_irq() on GPIOs before gpio_request() succeeded on them. This avoids Ooopses with incorrect DT bindings. Signed-off-by: Daniel Mack --- drivers/input/misc/rotary_encoder.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input

[PATCH v3 3/3] input: rotary-encoder: add DT bindings

2012-07-25 Thread Daniel Mack
ept privately in struct rotary_encoder. Signed-off-by: Daniel Mack --- .../devicetree/bindings/input/rotary-encoder.txt | 37 +++ drivers/input/misc/rotary_encoder.c| 101 2 files changed, 120 insertions(+), 18 deletions(-) create mode 100644 Documentat

Re: [PATCH v3 1/3] input: rotary-encoder: defer calls gpio_to_irq()

2012-07-30 Thread Daniel Mack
Hi Dmitry and Hartley, does that new approach look better to you? Daniel On 25.07.2012 20:25, Daniel Mack wrote: > Don't call gpio_to_irq() on GPIOs before gpio_request() succeeded on > them. This avoids Ooopses with incorrect DT bindings. > > Signed-off-by: Daniel Mack

Re: [PATCH v3 3/3] input: rotary-encoder: add DT bindings

2012-07-31 Thread Daniel Mack
On 31.07.2012 08:12, Dmitry Torokhov wrote: > Still, I do not line the copying of pdata over, maybe we coudl have > something like the patch below? [...] > diff --git a/drivers/input/misc/rotary_encoder.c > b/drivers/input/misc/rotary_encoder.c > index ea51265..0f9d746 100644 > --- a/drivers/inp

Re: [PATCH v3 3/3] input: rotary-encoder: add DT bindings

2012-08-02 Thread Daniel Mack
On 31.07.2012 15:56, Daniel Mack wrote: > On 31.07.2012 08:12, Dmitry Torokhov wrote: >> Still, I do not line the copying of pdata over, maybe we coudl have >> something like the patch below? Was that merged yet? Sorry, just want to forget about it :) > > [...] >

Re: Emulating level IRQs

2012-08-05 Thread Daniel Mack
On 24.07.2012 20:01, Daniel Mack wrote: > On 23.07.2012 18:51, Dmitry Torokhov wrote: >> On Thu, Jul 19, 2012 at 05:36:12PM +0200, Daniel Mack wrote: > >>> Ok, finally I found some time. In general, the patch works fine. The >>> only detail I had to amend was the irq

Re: Emulating level IRQs

2012-08-05 Thread Daniel Mack
On 05.08.2012 18:56, Haojian Zhuang wrote: > On Mon, Aug 6, 2012 at 12:22 AM, Daniel Mack wrote: >> On 24.07.2012 20:01, Daniel Mack wrote: >>> On 23.07.2012 18:51, Dmitry Torokhov wrote: >>>> On Thu, Jul 19, 2012 at 05:36:12PM +0200, Daniel Mack wrote: >>>

Re: Emulating level IRQs

2012-08-07 Thread Daniel Mack
or me. Dmitry, are you fine with that patch? Many thanks for the input, everyone! Daniel >From bfb14c1a0417435ebcf5bdebbb94ae6812cb4aee Mon Sep 17 00:00:00 2001 From: Daniel Mack Date: Tue, 7 Aug 2012 17:02:59 +0200 Subject: [PATCH] Input: eeti_ts: pass gpio value instead of IRQ The EET

Re: [PATCH 2/6] ARM: pxa remove irq_to_gpio from eeti_ts driver

2012-08-08 Thread Daniel Mack
On 08.08.2012 16:19, Arnd Bergmann wrote: > On Wednesday 08 August 2012, Daniel Mack wrote: >> On 08.08.2012 14:54, Arnd Bergmann wrote: >>> The irq_to_gpio function was removed from the pxa platform >>> in linux-3.2, and this driver has been broken since. >>&

Re: [PATCH v3 3/3] input: rotary-encoder: add DT bindings

2012-08-21 Thread Daniel Mack
Dmitry, can we merge this series? Your approach with a fix of that trivial syntax error I pointed out above is fine for me. Many thanks, Daniel On 31.07.2012 15:56, Daniel Mack wrote: > On 31.07.2012 08:12, Dmitry Torokhov wrote: >> Still, I do not line the copying of pdata over,

[PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Daniel Mack
This allows DT driven boards to allocate and configure the pinmux once the driver is probed. Signed-off-by: Daniel Mack Cc: Linus Walleij Cc: Dmitry Torokhov --- drivers/input/keyboard/gpio_keys.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/input/keyboard/gpio_keys.c b

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Daniel Mack
On 12.10.2012 23:26, Linus Walleij wrote: > On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack wrote: > >> This allows DT driven boards to allocate and configure the pinmux once >> the driver is probed. >> >> Signed-off-by: Daniel Mack >> Cc: L

[PATCH v2] Input: gpio_keys: allocate pins

2012-10-12 Thread Daniel Mack
This allows DT driven boards to allocate and configure the pinmux once the driver is probed. Signed-off-by: Daniel Mack Cc: Linus Walleij Cc: Dmitry Torokhov --- drivers/input/keyboard/gpio_keys.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/input/keyboard/gpio_keys.c b

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Daniel Mack
On 12.10.2012 23:37, Linus Walleij wrote: > On Fri, Oct 12, 2012 at 11:27 PM, Daniel Mack wrote: >> On 12.10.2012 23:26, Linus Walleij wrote: >>> On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack wrote: >>> >>>> This allows DT driven boards to allocate and confi

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-25 Thread Daniel Mack
On 25.10.2012 10:08, Linus Walleij wrote: > On Thu, Oct 25, 2012 at 9:58 AM, Lee Jones wrote: >> On Fri, 12 Oct 2012, Linus Walleij wrote: > (...) >>> Is biasing what you need to do? > (...) >>> All I really want is that platforms have a clear idea about >>> how and where the pins will be handled,

Re: [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias

2015-01-31 Thread Daniel Mack
On 01/31/2015 05:38 AM, Axel Lin wrote: > This is a I2C driver, so it's wrong to use platform prefix for the modalias. > We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, > so remove the wrong and unneeded cap11xx modalias. > > Signed-off-by: Axel Lin A

Re: [PATCH] cap11xx: add LED support

2015-06-08 Thread Daniel Mack
Hi Matt, On 06/09/2015 05:46 AM, Matt Ranostay wrote: > Several cap11xx variants have LEDs that be can be controlled, this > patchset implements this functionality. > > Signed-off-by: Matt Ranostay > --- > drivers/input/keyboard/cap11xx.c | 102 > +-- > 1 fi

Re: [PATCH] cap11xx: add LED support

2015-06-08 Thread Daniel Mack
On 06/09/2015 05:46 AM, Matt Ranostay wrote: > Several cap11xx variants have LEDs that be can be controlled, this > patchset implements this functionality. > > Signed-off-by: Matt Ranostay > --- > drivers/input/keyboard/cap11xx.c | 102 > +-- > 1 file changed

Re: [PATCH] cap11xx: add LED support

2015-06-09 Thread Daniel Mack
On 06/09/2015 07:12 PM, Dmitry Torokhov wrote: > On Tue, Jun 09, 2015 at 07:25:42AM +0200, Daniel Mack wrote: >> Use the .brightness_set_sync callback, so you don't have to dance around >> with the workers at all. > > Umm, how will it help? You still can

Re: [PATCH v3 2/2] cap11xx: add LED support

2015-06-15 Thread Daniel Mack
On 06/15/2015 10:56 AM, Matt Ranostay wrote: > On Mon, Jun 15, 2015 at 1:15 AM, Jacek Anaszewski > wrote: >>> + error = devm_led_classdev_register(dev, &led->cdev); >>> + if (error < 0) >>> + return -EINVAL; >>> + INIT_WORK(&led->wor

Re: [PATCH v4 2/2] cap11xx: add LED support

2015-06-16 Thread Daniel Mack
On 06/16/2015 04:39 PM, Matt Ranostay wrote: > On Tue, Jun 16, 2015 at 12:54 AM, Jacek Anaszewski > wrote: >> On 06/16/2015 04:46 AM, Matt Ranostay wrote: >>> + for_each_child_of_node(node, child) { >>> + led->cdev.name = >>> + of_get_property(child, "lab

Re: [PATCH v4 2/2] cap11xx: add LED support

2015-06-17 Thread Daniel Mack
On 06/17/2015 08:49 AM, Matt Ranostay wrote: > Actually after further reading of the datasheet and testing with > i2ctools it seems cap11xx_input_close() isn't putting the device in > DEEP SLEEP mode. > > Any thoughts why? No, sorry. IIRC, the board I wrote the driver for didn't give me the abili

Re: [PATCH 07/18] Input: cap11xx - simplify function return logic

2015-10-02 Thread Daniel Mack
oard/cap11xx.c:475:1-6: WARNING: end returns can be > simplified > > Signed-off-by: Javier Martinez Canillas Acked-by: Daniel Mack > --- > > drivers/input/keyboard/cap11xx.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/driver

Re: [PATCH RESEND v4] cap11xx: add runtime PM support

2015-10-02 Thread Daniel Mack
On 10/02/2015 07:19 AM, Matt Ranostay wrote: > Puts device into DEEP SLEEP when no LEDs are in in the on-state, and no > input_handlers are in use. Also uses *_autosuspend to prevent a LED > trigger from constantly suspending and resuming device. > > Signed-off-by: Matt Ranostay > --- > drivers/

Re: [PATCH RFC 0/3] input: rotary_encoder: use more than two gpios as input

2015-12-05 Thread Daniel Mack
On 12/03/2015 02:01 PM, Rojhalat Ibrahim wrote: > On Wednesday 02 December 2015 19:59:20 Uwe Kleine-König wrote: >> I have a real rotary encoder with 4 input lines and so 16 >> distinguishable positions. It would be described as: >> >> compatible = "rotary-encoder"; >> gpios = <&gpio4 12