o take over the xpad.c
heavylifting, but before that work gets done, this can stay, can't it?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info
tput reports while the device is being
> reset by adding a mutex which is held during that time.
Thanks Mika. Applied to for-4.4/upstream-fixes.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.
On Sun, 27 Dec 2015, Geliang Tang wrote:
> to_hid_device() macro is defined in both hid-lg4ff.c and
> hid-logitech-hidpp.c. So I move it to include/linux/hid.h.
>
> Signed-off-by: Geliang Tang
I've applied the whole series to hid.git#for-4.5/container-of-cleanups
--
Jiri
ch adds
> rumble
> and led support in the hid-sony driver.
Scott,
the patch is missing your Signoff; as such, it unfortunately can't be
merged. Please see Documentation/SubmittingPatches for details.
Antonio, Frank, I'd like to have your Ack for this one as well is
possible.
T
struct usb_device, dev)
> + to_usb_device(hid_dev->dev.parent->parent)
Applied to hid.git#for-4.5/upstream.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
driver(&corsair_driver);
> -}
> -
> -static void corsair_exit(void)
> -{
> - hid_unregister_driver(&corsair_driver);
> -}
> -
> -module_init(corsair_init);
> -module_exit(corsair_exit);
> +module_hid_driver(corsair_driver);
>
> MODULE_LICENSE("GPL&
On Fri, 18 Dec 2015, Srinivas Pandruvada wrote:
> This needs same quirk as applied to other YOGA sensor hubs.
> Refer to
> 47eeca8a48 (" HID: sensor-hub: Add in quirk for Lenovo Yogas with ITE")
Which tree is this SHA from?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
udan
I got a bit lost here ... what's the status of this patch? Nishanth later
reported that the patch actually doesn't fix the issue for him, so?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a mes
On Mon, 14 Dec 2015, Alexander E. Patrakov wrote:
> This mouse, when asked about the battery, ceases to report movements and
> clicks. So just don't ask.
>
> Signed-off-by: Alexander E. Patrakov
Applied to for-4.5/core branch, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsu
I've applied the series to for-4.5/wacom.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
viewed-by: Jason Gerecke
Queued in for-4.5/wacom, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
wacom: Slim down wacom_intuos_pad processing')
> Signed-off-by: Dan Carpenter
Jason, could you please provide your Ack for this one?
It's obviously a Correct Thing To Do(TM), but I assume you've tested on
your devices with this patch, so some other changes might potentially b
+ struct hid_usage *usage, unsigned long **bit, int *max)
> +{
> + return -1;
> +}
Why do you need this at all?
[ ... snip ... ]
> --
> Legal Disclaimer:
> The information contained in this message may be privileged and
> confidential. It is intended to be rea
> + } while (tries-- > 0 && ret);
> +
> if (ret)
> return ret;
As a possible alternative, please test the patch above on top of for-next
branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
It contains 64bebefcf3 ("HI
On Wed, 9 Dec 2015, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: Jiri Kosina
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Linus Wal
e absence of this quirk does not significantly impact usability, but
> is a correctness issue nonetheless.
>
> Signed-off-by: Jason Gerecke
Applied to for-4.5/wacom.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the
vice *hid_allocate_device(void)
> device_initialize(&hdev->dev);
> hdev->dev.release = hid_device_release;
> hdev->dev.bus = &hid_bus_type;
> + device_enable_async_suspend(&hdev->dev);
Applied to for-4.5/async-suspend branch.
--
Jiri Kosina
t, thanks. I have applied
it to for-4.5/wacom branch.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2 Dec 2015, Jiri Kosina wrote:
> I know that this code (and other instances of similar spaghetti) has been
> there before already and you are just moving it around, but isn't this the
> proper time to clean it up a bit?
>
> Like change it to a for-loop that'd u
TN_9, (data[8] & 0x02));
> + input_report_key(input, BTN_A, (data[8] & 0x04));
> + input_report_key(input, BTN_B, (data[8] & 0x08));
> + input_report_key(input, BTN_C, (data[8] & 0x10));
> + input_report_key(input, BTN_X, (dat
for the input mode and
> are
> thus not affected by this change.
Thanks for detailed assessment. After considering the alternatives, I've
now applied it to for-4.5/multitouch. If it later proves itself to be
regression-free, we might well backport it to -stable.
Ok?
Thanks,
--
> ---
>
> Hi Jiri,
>
> as reported in #108121, this is 4.4-rc material. At least 2 people already
> started complaining about it on the mailing list, so it should definitively
> be fixed before 4.4 is out.
Applied to for-4.4/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs
ien Vergé
Reviewed-by: Benjamin Tissoires
Reviewed-by: Jiri Kosina
Greg, I guess it makes sense to take both 1/2 and 2/2 together as a whole.
Would you mind adding the tags above and taking it through usb git tree?
Alternatively I can take it through my tree if you Ack the usb part.
Thanks
id state, calling hid_input_report()
> with the spinlock unlocked, allowing the device driver to grab the
> lock first, finish and then grab the lock afterwards in hid_ctrl().
>
> This patch implements the 2nd solution.
>
> Signed-off-by: Ioan-Adrian Ratiu
Applied to for
ad
> buf[i] anyway, so testing it is almost free) and the latter by
> changing i to unsigned. This cuts 29% (69 bytes) of the size of the
> function.
>
> Signed-off-by: Rasmus Villemoes
Agreed, this is much better. Applied to for-4.5/core, thanks Rasmus.
--
Jiri Kosina
SUSE Labs
--
it'd be nice if I could get your Tested-by: / Reviewed-by: for
this.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
remove quirk MT_QUIRK_ALWAYS_VALID to enable palm
> rejection for the WIN 8 touchpad devices which have implemented usage
> Confidence in its input reports.
>
> Tested on Dell XPS 13 laptop.
>
> Signed-off-by: Allen Hung
Applied to for-4.5/multitouch. Thanks,
--
Jiri Kosin
device number 42 using xhci_hcd
> [ 2891.783438] usb 1-5: unable to read config index 0 descriptor/start: -71
> [ 2891.783443] usb 1-5: can't read configurations, error -71
The drivers/hid part is
Acked-by: Jiri Kosina
Makes one wonder however whether we shouldn't be appl
On Thu, 5 Nov 2015, Oliver Neukum wrote:
> If an event is discarded the device stays idle.
> Just reverse the order of check and marking busy.
>
> Signed-off-by: Oliver Neukum
Applied to for-4.5/core. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: s
eal problems (and hence it should be merged for 4.4), or
if you found it just by code inspection (and therefore it should be fine
to merge it for 4.5).
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body
On Sat, 14 Nov 2015, Rasmus Villemoes wrote:
> scnprintf() exists to provide these semantics, so we might as well use
> it.
>
> Signed-off-by: Rasmus Villemoes
Applied to hid.git#for-4.5/core. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
Linus first.
Do you want me to send you a "proper" pull request? :)
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 20 Nov 2015, Jimmy Berry wrote:
> Without quirk keyboard repeats '6' until volume control is used since it
> indicates the key is pressed without ever releasing.
>
> Signed-off-by: Jimmy Berry
Applied to for-4.4/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
From: Jiri Kosina
Benjamin has been helping a lot over time with reviewing patches flowing
into HID subsystem. Let's make it official.
Acked-by: Benjamin Tissoires
Signed-off-by: Jiri Kosina
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTA
Andy Lutomirski
Agreed, that's generally useful; applied to for-4.5/core branch.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
If you have already done the full analysis that shows that usbhid->lock is
indeed not needed, this absolutely needs to go into changelog as proper
justification.
Could you please reformulate the changelog in this respect and resubmit?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubsc
detected by using the Coccinelle software.
Applied to for-4.5/wacom.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 19 Nov 2015, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski
> Acked-by: Benjamin Tissoires
Applied to for-4.5/i2c-hid. Thanks,
--
Jiri Kosina
SUSE Labs
--
To u
> The module is completely replacing the descriptor instead of patching it, so
> the
> size check isn't really necessary anyways.
>
> Signed-off-by: Frank Praznik
Applied to for-4.5/sony, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "u
;
> Signed-off-by: Simon Wood
Adding Dmitry to CC.
Dmitry, I am planning to take this through my tree together with the rest
of the actual HID support for that device if you Ack this.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-i
resume.
>
> Force-feedback is cleared on suspend but the state is not restored on resume
> since it can potentially result in hardware damage if the device is unattended
> when the system wakes. A new event will be required to resume force-feedback.
Applied to for-4.5/sony. Thank
On Thu, 12 Nov 2015, Simon Wood wrote:
> Patch-V2 tweaked as per Benjamin's requests.
Looking at the patches, I am happy with them, but still would like to have
Benjamin's Ack/Reviewed-by before merging them.
Benjamin ... ?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe f
> I'll continue to research this more in depth, but progress is slow
> because I don't have much time, I'm doing this in my spare time because
> it's my girlfriend's tablet.
Oh, now I understand the level of severity of this bug! :-)
Thanks,
--
Jiri Ko
;d better first understand the problem rather than papering it over
with more or less random fixes.
First, have you tried to run your usecase on your system with lockdep
enabled?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the lock
> after the hid_input_report() call and the deadlock dissapears.
I think the proper fix actually is to spin_lock_irqsave() in hid_ctrl(),
isn't it?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a me
Yup, I have already comitted fix with David's Reported-by:, just wanted to
make you aware of this.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
BAMBOO_PT)
Good catch, that code is obviously crappy.
Adding Ping, Aaron and Jason to CC.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
aised at
http://lkml.kernel.org/r/alpine.lnx.2.00.1509251404130.30...@pobox.suse.cz
has ever been answered or at least discussed ... ?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kern
_DTU_OFFSET, WACOM_DTU_OFFSET };
> static const struct wacom_features wacom_features_0x57 =
> { "Wacom DTK2241", 95640, 54060, 2047, 63,
> DTK, WACOM_INTUOS3_RES, WACOM_INTUOS3_RES, 6,
Applied to for-4.4/upstream-fixes.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe f
On Mon, 2 Nov 2015, Simon Wood wrote:
> Simplfy how hid-logitech driver detects the native mode of the wheel,
> done by looking at the USB-ID revision and comparing bit mask.
>
> Signed-off-by: Simon Wood
I've applied both patches to for-4.4/logitech. Thanks,
--
Jiri Kosina
Jiri,
>
> Ping clued me in to the fact that 'wacom_query_tablet_data' hasn't always
> been in this problematic location. The offending commit mentioned in the
> revised commit summary is queued for 4.4, so this only needs to get into
> the next RC rather than be targ
nother option would be to create a joint merge tree that'd contain both
branches merged together and proceed further from that, but I don't think
it's worth the hassle for simple case like this.
Works for you?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: sen
set.
This is really late in the game (the merge window is already open), but
given the nature of the patches (we'll be sending them as -rc bugfixes
later anyway), I've just picked those up to for-4.4/wacom.
1/1 I am sure you two will have some more discussion about :) so I am
i
ported-by: Dale Brewe
> Tested-by: Dale Brewe
> Signed-off-by: Ping Cheng
Applied to hid.git#for-4.4/wacom.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majo
gt; please resend with that fixed?
> >
>
> Have you guys noticed the patch [1] to support Surface Book along with
> Surface Pro 3?
Not really. A quick scan through my mailbox tells me that it has actually
never submitted to me for inclusion into the kernel.
> [1] https://github
On Tue, 27 Oct 2015, savoca wrote:
> Adding support for device 0x07e8 (SP4 Type Cover)
>
> Signed-off-by: savoca
Thanks for the patch.
The authorship and signoffs should same real names though. Could you
please resend with that fixed?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe
[ Benjamin added to CC ]
Benjamin, before I proceed with this series, I'd like you to have review
the HID++ bits at least, if possible. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@v
On Thu, 22 Oct 2015, Jiri Kosina wrote:
> > Add HID driver for Google Fiber TV Box remote controls
>
> I am not particularly happy with drvdata not being actually used "the
> usual way", i.e. to store a pointer, but apart from being unusual, I don't
> see a re
DOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE,
> HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
>
> { 0, 0 }
> };
> --
> 2.5.0
>
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
y, as this depends on a patch queued in your tree, would you be okay
with taking the patch with my signoff?
Thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
ld->flags & HID_MAIN_ITEM_NULL_STATE) &&
> (field->logical_minimum < field->logical_maximum) &&
> (value < field->logical_minimum ||
> value > field->logical_maximum)) {
Your patch has been corrupted by your mailer badly. Please try to fix it
(some hi
the are not really worth it per se, but the ones in
aureal_report_fixup() and sensor_hub_*() are annoying enough to make the
code harder to read, so I am applying it as a whole.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input"
implementation of my "Ignore contacts in excess of declared
> contact count" patch which was pulled in as part of the 4.3 merge window.
Alright, I've applied this to for-4.3/upstream-fixes, but it's now very
late in the cycle, so I am not 100% sure this patch will make it
I would suggest future removal of device specific
> drivers.
> The userspace tools don't use these attributes for a year now.
> The first Kone is not fully HID-compliant and will still need a module.
Ok, I am queuing this in for-4.4/roccat-sysfs-deprecation, let's see how
this go
_2 case. The second case has been moved to the
>switch in wacom_setup_pad_input_capabilities where it belongs.
>
> * The second CINTIQ_COMPANION_2 case mentioned above no longer explicitly
>sets up the pad buttons since wacom_setup_numbered_buttons is now
>(70ee06c) in charge
if it should read the
> 11th bit.
>
> Signed-off-by: Jason Gerecke
Applied to for-4.4/wacom.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; + __set_bit(BTN_A, input_dev->keybit);
> + break;
> +
And here you break out of the same case again explicitly again.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
s as needed in mt_feature_mapping(). This prevents
> fetching reports which might cause problems with the device in question.
>
> Suggested-by: Benjamin Tissoires
> Signed-off-by: Mika Westerberg
> ---
> Added check for MT_CLS_WIN_8 so that the fix is only done for real Win8
>
s does it have?), I'd be in
favor of doing that.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Rodland
Sorry, the formatting is still damaged, please fix your client and resend
the patch.
For some common ones, there are some hints in
Documentation/email-clients.txt
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
t
g to look at every 'return -1' occurence in the kernel and
convert it to something else? That can keep you busy for quite some time:
$ git grep 'return -1' | wc -l
9167
The only cleanup I'd imagine at least remotely possible in this case would
be to
land
Andrew,
your patch has been corrupted by your mailer (line wrapped). Could you
please fix this up on your side and resend?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.ker
#x27;ve fixed up the formatting and applied to hid.git#for-4.3/upstream-fixes
(please note that this doesn't guarantee that this patch will not go to
4.3 still, because it alone is not going to be reason for pull request,
but might eventually piggy-back on something that'll be needed for 4.
v->clamed flags accordingly.
Could you please be more specific about the -EPERM mapping you are talking
about?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More m
> + int removed;
This could be made bool.
Also the patch subject doesn't really follow the usual format we're using
in hid.git.
Otherwise I like the code, thanks a lot for working on the driver. I have
fixed the nits above and it's now queued in hid.git#for-4.4/corsa
pplied to hid.git#for-4.4/upstream, thanks Dmitry.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
low too minor to justify cluttering of git blame.
>
> Ok, although Greg Kroah-Hartman inspires you in his video to submit patches
> to make the code checkpatch clean. https://www.youtube.com/watch?v=LLBrBBImJt4
HID is not a subsystem residing in drivers/staging playground thoug
blame compiler on getting it wrong here as well.
The generated assembly really needs to be inspected to see how does clang
manage to leak the IRQ state (probably some incorrect reordering, i.e. not
respecting the "memory" clobber while fiddling with flags).
[ ... snip a lot of stuff ... ]
390
For files which are already in tree I'd be taking such fixes only as a
side-change if refactoring the code anyway in a substantial way. Otherwise
I consider the ones below too minor to justify cluttering of git blame.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list:
On Mon, 28 Sep 2015, Mika Westerberg wrote:
> Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
> the device as "Touchpad".
>
> Signed-off-by: Mika Westerberg
Applied to hid.git#for-4.4/multitouch.
--
Jiri Kosina
SUSE Labs
--
To unsu
but it is left empty by the
> driver.
>
> Make it look better and fill in the physical device name.
>
> Signed-off-by: Mika Westerberg
Applied to hid.git#for-4.4/i2c-hid.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe
t;usbhid.h"
+#include
+
/*
* Version Information
*/
@@ -725,6 +727,9 @@ void usbhid_close(struct hid_device *hid)
mutex_lock(&hid_open_mut);
+ if(WARN_ON(irqs_disabled()))
+ print_irqtrace_events(current);
+
/* protecting hid->open to make sure we don't restart
* data acquistion due to a resumption we no longer
* care about
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
u are able to see how usbhid_close() can be called with IRQs
off, that would be a completely different story. But if that's not the
case, the warning is bogus, and gcc-compiled kernels are right about not
issuing it.
But without that, I so far fail to see how this is a correct thing to d
pend/resume asynchronously".
Is there any reason why not enable this from userspace via sysfs instead,
based on whitelist on known-to-be-well-behaved devices, from udev?
I am really careful when it comes to enabling features like this
(especially given the state of PM support on some low-
On Wed, 23 Sep 2015, Ping Cheng wrote:
> Not all Bamboo support both pen and touch. Make sure we deal with
> pen only and touch only devices properly.
>
> Signed-off-by: Ping Cheng
> Tested-By: Aaron Skomra
Both patches queued in hid.git#for-4.4/wacom.
Thanks,
--
Jiri K
On Wed, 23 Sep 2015, Ping Cheng wrote:
> Signed-off-by: Ping Cheng
> Tested-By: Aaron Skomra
Please insert a changelog here. At least explanation why these are not
just a simple a device ID additions, but actual code changes are
necessary, is needed.
Thanks.
--
Jiri Kosina
SUS
with
> printk. This leads to corruption on the console/in the logs.
>
> Ensure buf is initialized to an empty string.
>
> Signed-off-by: Richard Purdie
> [dvhart: Initialize string to "" rather than assign buf[0] = NULL;]
> Cc: Jiri Kosina
> Cc: linux-input@vger.k
On Thu, 17 Sep 2015, Daniel Martin wrote:
> Just to prettify the log message. Otherwise it would be .
>
> Signed-off-by: Daniel Martin
Applied to hid.git#for-4.4/upstream, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-inpu
On Tue, 15 Sep 2015, Donavan Lance wrote:
> Adds support for Microsoft Type Cover 3 with 0x07e2 product ID.
>
> Signed-off-by: Donavan Lance
Queued in hid.git#for-4.4/microsoft. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux
gt; - hid_debug_unregister(hdev);
> + if (hdev->debug)
> + hid_debug_unregister(hdev);
As we are sprinkling these checks around, and hid_debug_unregister() is a
slow path anyway, I think I'll just rearrange the code that
hid_debug_unregister() actually a
{
> + ret = -ENOMEM;
> + goto fail_backlight;
> + }
> + snprintf(name, name_sz, "%s" K90_BACKLIGHT_LED_SUFFIX,
> + dev_name(&dev->dev));
> + led = &drvdata->backlight;
> + led->cdev.name = name;
> + led
ug_init() and hid_debug_exit() only if hid_debug
> * add check for the hid_debug_root in the hid_debug_register()
>
> Signed-off-by: Alexander Kuleshov
Did you try to even compile-test your patch?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line &qu
be careful.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 3 Sep 2015, Maciej Zuk wrote:
> From: Maciej Zuk
>
> Fixed HID descriptor for DragonRise Joystick.
> Replaced default descriptor which doubles Z axis
> and causes mixing values of X and Z axes.
Applied to for-4.4/dragonrise.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe
e that from the
> host by using the feature 0x6010.
>
> The first patch might conflict with Simon's current work in progress, so
> that's why Simon is CC-ed to it.
Now in for-4.4/logitech. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "
ers
> > (hid-accel-3d,hid-gyro-3d,etc) loaded, and its possible to read their
> > values.
> >
> > Signed-off-by: Fernando D S Lima
> Reviewed-by: Srinivas Pandruvada
Applied to for-4.3/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 3 Sep 2015, Harald Brinkmann wrote:
> Hi all,
>
> this patch applies to Linux 4.2.0.
>
> It enables the Saitek HID quirk for the mode button
> of the Mad Catz R.A.T.5 gaming mouse.
>
> Signed-off-by: Harald Brinkmann
Applied to for-4.4/upstream. Thanks,
-
gt; input_dev *input_dev,
> return 0;
> }
>
> +void wacom_setup_numbered_buttons(struct input_dev *input_dev,
I made this static, and applied both patches. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input"
jamin Tissoires
Applied to for-4.3/upstream. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ange related to the rest of the patch?
It's wrong anyway, because hid_debug is independent of the debugfs HID
debugging facility. Please see for example the printk() a few lines above
in this very function, which is emited in case hid_debug is enabled.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
1 - 100 of 1112 matches
Mail list logo
