Re: [PATCH v2 4/4] leds: no longer use unnamed gpios

2015-01-22 Thread Olliver Schinagl
Hey Rojhalat, On 22-01-15 10:32, Rojhalat Ibrahim wrote: On Wednesday 21 January 2015 22:33:48 Olliver Schinagl wrote: From: Olliver Schinagl The gpio document says we should not use unnamed bindings for gpios. This patch uses the 'led-' prefix to the gpios and updates code and

Re: [PATCH v1 2/4] gpio: add parameter to allow the use named gpios

2015-01-21 Thread Olliver Schinagl
Hey Alexandre, On 01/19/2015 05:04 AM, Alexandre Courbot wrote: On Wed, Jan 7, 2015 at 6:08 PM, Olliver Schinagl wrote: From: Olliver Schinagl The gpio binding document says that new code should always use named gpios. Patch 40b73183 added support to parse a list of gpios from child nodes

[PATCH v2 3/4] leds: Let the binding document example for leds-gpio follow the gpio bindings

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl In the gpio bindings documents it is requested to use the marco's in include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led drivers don't seem to form an exception, so update the example in the document bindings. Signed-off-by: Olliver Schinagl

[PATCH v2 4/4] leds: no longer use unnamed gpios

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl The gpio document says we should not use unnamed bindings for gpios. This patch uses the 'led-' prefix to the gpios and updates code and documents. Because the devm_get_gpiod_from_child() falls back to using old-style unnamed gpios, we can update the code first,

[PATCH v2 2/4] gpio: add parameter to allow the use named gpios

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl The gpio binding document says that new code should always use named gpios. Patch 40b73183 added support to parse a list of gpios from child nodes, but does not make it possible to use named gpios. This patch adds the con_id property and implements it is done in gpiolib.c

[PATCH v2 0/4] Let leds use named gpios

2015-01-21 Thread Olliver Schinagl
s and if that fails, fall back to standard gpios for the users of devm_get_gpiod_from_child. Olliver Schinagl (4): gpio: use sizeof() instead of hardcoded values gpio: add parameter to allow the use named gpios leds: Let the binding document example for leds-gpio follow the gpio bin

[PATCH v2 1/4] gpio: use sizeof() instead of hardcoded values

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl gpiolib uses a fixed string for the suffixes and defines it at 32 bytes. Later in the code snprintf is used with this fixed value of 32. Using sizeof() is safer in case the size for the suffixes is ever changed. Signed-off-by: Olliver Schinagl --- drivers/gpio/gpiolib.c

Re: [PATCH v1 4/4] leds: no longer use unnamed gpios

2015-01-14 Thread Olliver Schinagl
On 14-01-15 13:45, Linus Walleij wrote: On Thu, Jan 8, 2015 at 11:12 PM, Dmitry Torokhov wrote: On Thu, Jan 08, 2015 at 08:40:20AM -0600, Rob Herring wrote: On Thu, Jan 8, 2015 at 2:45 AM, Olliver Schinagl wrote: --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -184,7

Re: [PATCH v1 4/4] leds: no longer use unnamed gpios

2015-01-08 Thread Olliver Schinagl
Hey Dmitry, On 08-01-15 00:55, Dmitry Torokhov wrote: On Wed, Jan 07, 2015 at 10:08:42AM +0100, Olliver Schinagl wrote: From: Olliver Schinagl The gpio document says we should not use unnamed bindings for gpios. This patch uses the 'led-' prefix to the gpios and updates code and

Re: [PATCH v1] input: make use of the input_set_capability helper

2015-01-07 Thread Olliver Schinagl
HEy Dmitry, On 07-01-15 09:26, Dmitry Torokhov wrote: On Wed, Jan 07, 2015 at 09:19:28AM +0100, Olliver Schinagl wrote: Hey Dmitry, On 07-01-15 08:57, Dmitry Torokhov wrote: Hi Olliver, On Wed, Jan 07, 2015 at 08:31:06AM +0100, Olliver Schinagl wrote: From: Olliver Schinagl Almost all of

[PATCH v1 1/4] gpio:gpiolib: use static const char const * for a suffixes array

2015-01-07 Thread Olliver Schinagl
From: Olliver Schinagl Checkpatch complains, and probably with good reason that we should use const char const * for the static constant array that never gets changed. Signed-off-by: Olliver Schinagl --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v1 3/4] leds: Let the binding document example for leds-gpio follow the gpio bindings

2015-01-07 Thread Olliver Schinagl
From: Olliver Schinagl In the gpio bindings documents it is requested to use the marco's in include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led drivers don't seem to form an exception, so update the example in the document bindings. Signed-off-by: Ollive

[PATCH v1 2/4] gpio: add parameter to allow the use named gpios

2015-01-07 Thread Olliver Schinagl
From: Olliver Schinagl The gpio binding document says that new code should always use named gpios. Patch 40b73183 added support to parse a list of gpios from child nodes, but does not make it possible to use named gpios. This patch adds the con_id property and implements it is done in gpiolib.c

[PATCH v1 4/4] leds: no longer use unnamed gpios

2015-01-07 Thread Olliver Schinagl
From: Olliver Schinagl The gpio document says we should not use unnamed bindings for gpios. This patch uses the 'led-' prefix to the gpios and updates code and documents. Because the devm_get_gpiod_from_child() falls back to using old-style unnamed gpios, we can update the code first,

[PATCH v1 0/4] Let leds use named gpios

2015-01-07 Thread Olliver Schinagl
From: Olliver Schinagl The gpio binding docs ask to use named-gpios wherever possible, however 40b73183 probably forgot that. This patch makes the new devm_get_gpiod_from_child use named gpios. Olliver Schinagl (4): gpio:gpiolib: use static const char const * for a suffixes array gpio

Re: [PATCH v1] input: make use of the input_set_capability helper

2015-01-07 Thread Olliver Schinagl
Hey Dmitry, On 07-01-15 08:57, Dmitry Torokhov wrote: Hi Olliver, On Wed, Jan 07, 2015 at 08:31:06AM +0100, Olliver Schinagl wrote: From: Olliver Schinagl Almost all of the speaker drivers under input manipulate the ev bits directly, which is not needed, as there is a helper available

[PATCH v1] input: make use of the input_set_capability helper

2015-01-06 Thread Olliver Schinagl
From: Olliver Schinagl Almost all of the speaker drivers under input manipulate the ev bits directly, which is not needed, as there is a helper available. This patch makes use of the helper for the speaker drivers. Signed-off-by: Olliver Schinagl --- drivers/input/misc/cm109.c | 4