Re: SATA hotplug from the user side ?

2007-01-12 Thread Tejun Heo
Soeren Sonnenburg wrote: It is true it detects a removal and newly plugged devices immediately... However it still prints warnings and errors that it could not synchronize SCSI cache for the disks. Then it prints regular 'rejects I/O to dead device' warning messages and on replugging the disks

Re: /sys/$DEVPATH/uevent vs uevent attributes

2007-01-12 Thread Michael Tokarev
Greg KH wrote: On Fri, Jan 12, 2007 at 10:32:10PM +0300, Michael Tokarev wrote: (No patch at this time, -- just asking about an.. idea ;) Let's see what such a patch looks like to see if it would be workable or not. Umm.. it's definitely workable, and even almost trivial. Just splitting

Re: 2.6.20-rc3-mm1 - git-block.patch causes hard lockups

2007-01-12 Thread Valdis . Kletnieks
On , [EMAIL PROTECTED] said: On Thu, 04 Jan 2007 22:02:00 PST, Andrew Morton said: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc3/2.6.20-rc3-mm1/ Still seeing this in -rc4-mm1.. With git-block.patch applied, my system locks up *hard* at system shutdown

Re: svc: unknown version (3) when CONFIG_NFSD_V4=y

2007-01-12 Thread Fengguang Wu
On Sat, Jan 13, 2007 at 06:43:07AM +1100, Neil Brown wrote: Ok, thanks. I must have missed something else wrong in the code.. Probably this 'break' in the wrong place... Could you try this patch instead please - or just move the 'break' to where it should be. Now it worked :)

Re: Linux v2.6.20-rc5

2007-01-12 Thread Nigel Cunningham
Hi. On Fri, 2007-01-12 at 14:26 -0800, Andrew Morton wrote: On Fri, 12 Jan 2007 14:27:48 -0500 (EST) Linus Torvalds [EMAIL PROTECTED] wrote: Ok, there it is, in all its shining glory. It still doesn't run Excel. Heretic! :) - To unsubscribe from this list: send the line

Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

2007-01-12 Thread Tino Keitel
On Fri, Jan 12, 2007 at 14:50:25 +, Pavel Machek wrote: Hi! It didn't. It looks like it is unusable, becuase it isn't reliable in 2.6.20-rc3. Is this issue still present in -rc4? I used 2.6.20-rc4 in single user mode, and applied 2 patches from netdev to get wake

[patch 0/7] fault vs truncate/invalidate race fix

2007-01-12 Thread Nick Piggin
The following set of patches fix the fault vs invalidate and fault vs truncate_range race for filemap_nopage mappings, plus those and fault vs truncate race for nonlinear mappings. Hasn't changed since I last submitted it, when it was rejected because it made one of the buffered write deadlocks

[patch 2/7] mm: simplify filemap_nopage

2007-01-12 Thread Nick Piggin
Identical block is duplicated twice: contrary to the comment, we have been re-reading the page *twice* in filemap_nopage rather than once. If any retry logic or anything is needed, it belongs in lower levels anyway. Only retry once. Linus agrees. Signed-off-by: Nick Piggin [EMAIL PROTECTED]

[patch 1/7] mm: debug check for the fault vs invalidate race

2007-01-12 Thread Nick Piggin
Add a bugcheck for Andrea's pagefault vs invalidate race. This is triggerable for both linear and nonlinear pages with a userspace test harness (using direct IO and truncate, respectively). Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index: linux-2.6/mm/filemap.c

[patch 3/7] mm: fix fault vs invalidate race for linear mappings

2007-01-12 Thread Nick Piggin
Fix the race between invalidate_inode_pages and do_no_page. Andrea Arcangeli identified a subtle race between invalidation of pages from pagecache with userspace mappings, and do_no_page. The issue is that invalidation has to shoot down all mappings to the page, before it can be discarded from

[patch 6/7] mm: merge nopfn into fault

2007-01-12 Thread Nick Piggin
Remove -nopfn and reimplement the only existing handler using -fault Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index: linux-2.6/drivers/char/mspec.c === --- linux-2.6.orig/drivers/char/mspec.c +++ linux-2.6/drivers/char/mspec.c

[patch 5/7] mm: add vm_insert_pfn

2007-01-12 Thread Nick Piggin
Add a vm_insert_pfn helper, so that -fault handlers can have nopfn functionality by installing their own pte and returning NULL. Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index: linux-2.6/include/linux/mm.h === ---

[patch 4/7] mm: merge populate and nopage into fault (fixes nonlinear)

2007-01-12 Thread Nick Piggin
Nonlinear mappings are (AFAIKS) simply a virtual memory concept that encodes the virtual address - file offset differently from linear mappings. I can't see why the filesystem/pagecache code should need to know anything about it, except for the fact that the -nopage handler didn't quite pass down

[patch 7/7] mm: remove legacy cruft

2007-01-12 Thread Nick Piggin
Remove legacy filemap_nopage and all of the .populate API cruft. This patch is optional and can be left out (eg. for a cleaner merge with -mm), and rebased after the previous patches go upstream. include/linux/mm.h |9 -- mm/filemap.c | 195

2.6.19.1 failing

2007-01-12 Thread Von Wolher
Hi, I just build a 2.6.19.1 vanilla kernel based on the previous config (make oldconfig) but for some reason it is not starting. Despite following the usual procedure with lilo like many times before it seems that lilo tries to boot it and jumps back to the menu screen. But selecting the old

Re: Linux v2.6.20-rc5

2007-01-12 Thread Jeff Chua
On 1/13/07, Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2007 14:27:48 -0500 (EST) Linus Torvalds [EMAIL PROTECTED] wrote: http://userweb.kernel.org/~akpm/2.6.20-rc5-mm-fixes The KVM and direct-io changes are significant, so if people are testing those things, please be sure to have

Re: Choosing a HyperThreading/SMP/MultiCore kernel ?

2007-01-12 Thread Valdis . Kletnieks
On Fri, 12 Jan 2007 10:03:49 EST, Lennart Sorensen said: I would expect any distribution should work on these (as long as the kernel they use isn't too old.). Of course if it is a Mac, you need a distribution that supports their firmware (which is of course not a PC bios). As long as you

Re: Linux v2.6.20-rc5

2007-01-12 Thread Jeff Chua
On 1/13/07, Jeff Chua [EMAIL PROTECTED] wrote: On 1/13/07, Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2007 14:27:48 -0500 (EST) Linus Torvalds [EMAIL PROTECTED] wrote: CC [M] drivers/kvm/vmx.o {standard input}: Assembler messages: {standard input}:3257: Error: bad register name

Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo

2007-01-12 Thread Tino Keitel
On Sat, Jan 13, 2007 at 04:05:28 +0100, Tino Keitel wrote: [...] I think I found the problem. In 2.6.18, I had a slightly different config. With 2.6.20-rc4, I had sucessful suspend/resume cycles without the USB DVB-T box attached. I tweaked the USB options a bit and activated some options

Re: 2.6.19.1 failing

2007-01-12 Thread Randy Dunlap
On Sat, 13 Jan 2007 03:58:19 +0100 Von Wolher wrote: Hi, I just build a 2.6.19.1 vanilla kernel based on the previous config (make oldconfig) but for some reason it is not starting. Despite following the usual procedure with lilo like many times before it seems that lilo tries to boot it

Re: High lock spin time for zone-lru_lock under extreme conditions

2007-01-12 Thread Nick Piggin
Ravikiran G Thirumalai wrote: Hi, We noticed high interrupt hold off times while running some memory intensive tests on a Sun x4600 8 socket 16 core x86_64 box. We noticed softlockups, [...] We did not use any lock debugging options and used plain old rdtsc to measure cycles. (We disable

Re: O_DIRECT question

2007-01-12 Thread Nick Piggin
Bill Davidsen wrote: The point is that if you want to be able to allocate at all, sometimes you will have to write dirty pages, garbage collect, and move or swap programs. The hardware is just too limited to do something less painful, and the user can't see memory to do things better. Linus

Re: tuning/tweaking VM settings for low memory (preventing OOM)

2007-01-12 Thread Nick Piggin
Kumar Gala wrote: I'm working on an embedded PPC setup with 64M of memory and no swap. I'm trying to figure out how best to tune the VM for an OOM situation I'm running into. I'm running a 2.6.16.35 kernel and have a bittorrent app that appears to be initializing a large file for it to

Re: Linux v2.6.20-rc5

2007-01-12 Thread Adrian Bunk
On Fri, Jan 12, 2007 at 02:26:45PM -0800, Andrew Morton wrote: On Fri, 12 Jan 2007 14:27:48 -0500 (EST) Linus Torvalds [EMAIL PROTECTED] wrote: Ok, there it is, in all its shining glory. It still doesn't run Excel. ... It should work with CrossOver. cu Adrian -- Is there

[PATCH] 2.6.15-rc5 - removes video device notify message (fwd)

2007-01-12 Thread Jeff Chua
Here's a line fix to ignore the video device notify message ... --- linux/drivers/acpi/video.c.org 2007-01-12 23:05:23 +0800 +++ linux/drivers/acpi/video.c 2007-01-12 23:05:29 +0800 @@ -1771,1 +1771,1 @@ - printk(video device notify\n); + //printk(video device notify\n);

Re: [PATCH 0/4] Linux Kernel Markers

2007-01-12 Thread Mathieu Desnoyers
Hi Richard, * Richard J Moore ([EMAIL PROTECTED]) wrote: Mathieu Desnoyers [EMAIL PROTECTED] wrote on 20/12/2006 23:52:16: Hi, You will find, in the following posts, the latest revision of the Linux Kernel Markers. Due to the need some tracing projects (LTTng, SystemTAP) has of

Re: Linux v2.6.20-rc5

2007-01-12 Thread Jeff Chua
From: Jeff Chua [EMAIL PROTECTED] CC [M] drivers/kvm/vmx.o {standard input}: Assembler messages: {standard input}:3257: Error: bad register name `%sil' make[2]: *** [drivers/kvm/vmx.o] Error 1 make[1]: *** [drivers/kvm] Error 2 make: *** [drivers] Error 2 I'm not using the kernel

reiserfs BUGs

2007-01-12 Thread Randy Dunlap
Running fsx-linux (akpm ext3-tools version) on reiserfs, 2.6.20-rc5 on x86_64. [ 4496.964604] [ cut here ] [ 4496.964614] Kernel BUG at 880b4499 [verbose debug info unavailable] [ 4496.964621] invalid opcode: [1] SMP [ 4496.964629] CPU 2 [ 4496.964635]

Re: [patch] sched: avoid div in rebalance_tick

2007-01-12 Thread Nick Piggin
On Fri, Jan 12, 2007 at 09:59:40AM +, Alan wrote: On Fri, 12 Jan 2007 07:02:13 +0100 Nick Piggin [EMAIL PROTECTED] wrote: Just noticed this while looking at a bug. Avoid an expensive integer divide 3 times per CPU per tick. Integer divide is cheap on some modern processors, and

Re: tuning/tweaking VM settings for low memory (preventing OOM)

2007-01-12 Thread Willy Tarreau
On Fri, Jan 12, 2007 at 03:58:08PM -0600, Kumar Gala wrote: I'm working on an embedded PPC setup with 64M of memory and no swap. I'm trying to figure out how best to tune the VM for an OOM situation I'm running into. I'm running a 2.6.16.35 kernel and have a bittorrent app that appears

Re: SATA hotplug from the user side ?

2007-01-12 Thread Soeren Sonnenburg
On Sat, 2007-01-13 at 10:55 +0900, Tejun Heo wrote: Soeren Sonnenburg wrote: It is true it detects a removal and newly plugged devices immediately... However it still prints warnings and errors that it could not synchronize SCSI cache for the disks. Then it prints regular 'rejects I/O to

2.6.20-rc4-mm1: status of sn9c102_pas202bca?

2007-01-12 Thread Adrian Bunk
On Thu, Jan 11, 2007 at 10:26:27PM -0800, Andrew Morton wrote: ... Changes since 2.6.20-rc3-mm1: ... git-dvb.patch ... git trees ... drivers/media/video/sn9c102/sn9c102_pas202bca.c is no longer used or built but still shipped. cu Adrian -- Is there not promise of rain? Ling Tan

Re: High lock spin time for zone-lru_lock under extreme conditions

2007-01-12 Thread Ravikiran G Thirumalai
On Sat, Jan 13, 2007 at 03:39:45PM +1100, Nick Piggin wrote: Ravikiran G Thirumalai wrote: Hi, We noticed high interrupt hold off times while running some memory intensive tests on a Sun x4600 8 socket 16 core x86_64 box. We noticed softlockups, [...] We did not use any lock debugging

Re: High lock spin time for zone-lru_lock under extreme conditions

2007-01-12 Thread Ravikiran G Thirumalai
On Fri, Jan 12, 2007 at 05:11:16PM -0800, Andrew Morton wrote: On Fri, 12 Jan 2007 17:00:39 -0800 Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: But is lru_lock an issue is another question. I doubt it, although there might be changes we can make in there to work around it.

Re: High lock spin time for zone-lru_lock under extreme conditions

2007-01-12 Thread Nick Piggin
Ravikiran G Thirumalai wrote: On Sat, Jan 13, 2007 at 03:39:45PM +1100, Nick Piggin wrote: What is the CS time? Critical Section :). This is the maximal time interval I measured from t2 above to the time point we release the spin lock. This is the hold time I guess. It would be

[patch]cleanup and error reporting for sound/core/init.c

2007-01-12 Thread Oliver Neukum
Hi, please accept this patch, which makes the control flow clear with indentation, adds some comments and improves error reporting. Regards Oliver Signed-off-by: Oliver Neukum [EMAIL PROTECTED] -- --- a/sound/core/init.c 2007-01-12 14:26:47.0 +0100 +++

Re: [patch]cleanup and error reporting for sound/core/init.c

2007-01-12 Thread Takashi Iwai
At Fri, 12 Jan 2007 14:49:57 +0100, Oliver Neukum wrote: + } else { + if (idx snd_ecards_limit) { + if (snd_cards_lock (1 idx)) + err = -EBUSY; /* invalid */ + } else if (idx SNDRV_CARDS) +

Re: - sys_mbind-use-cpuset-accessors-for-mems_allowed.patch removed from -mm tree

2007-01-12 Thread Paul Jackson
Andrew, regarding a patch by Andy: + nodemask_t allowed_nodes; err = get_nodes(nodes, nmask, maxnode); - nodes_and(nodes, nodes, current-mems_allowed); + allowed_nodes = cpuset_mems_allowed(current); Not that it matters now, as we're messing with other variations, but I

Re: [patch] Fix bttv and friends on 64bit machines with lots of memory.

2007-01-12 Thread Mauro Carvalho Chehab
Em Qui, 2007-01-11 às 00:41 +0100, hermann pitton escreveu: Am Mittwoch, den 10.01.2007, 09:58 +0100 schrieb Gerd Hoffmann: Hi, We have a DMA32 zone now, lets use it to make sure the card can reach the memory we have allocated for the video frame buffers. please apply,

Re: [patch] Fix bttv and friends on 64bit machines with lots of memory.

2007-01-12 Thread hermann pitton
Am Freitag, den 12.01.2007, 22:42 -0200 schrieb Mauro Carvalho Chehab: Em Qui, 2007-01-11 às 00:41 +0100, hermann pitton escreveu: Am Mittwoch, den 10.01.2007, 09:58 +0100 schrieb Gerd Hoffmann: Hi, We have a DMA32 zone now, lets use it to make sure the card can reach the memory

Re: [patch]cleanup and error reporting for sound/core/init.c

2007-01-12 Thread Oliver Neukum
Am Freitag, 12. Januar 2007 18:42 schrieb Takashi Iwai: At Fri, 12 Jan 2007 14:49:57 +0100, Oliver Neukum wrote: + } else { +if (idx snd_ecards_limit) { + if (snd_cards_lock (1 idx)) + err = -EBUSY; /* invalid */ +

kexec + USB storage in 2.6.19

2007-01-12 Thread Dan Aloni
Hello, After upgrading from 2.6.18.3 to 2.6.19.2 on an x86_64 machine I noticed that the EHCI USB host is unable to work properly after a kexec invocation. This makes it impossible to mount the rootfs in the configuration I'm using. According to the prints, the irq changes from 23 to 10.

Re: kexec + USB storage in 2.6.19

2007-01-12 Thread Eric W. Biederman
Dan Aloni [EMAIL PROTECTED] writes: Hello, After upgrading from 2.6.18.3 to 2.6.19.2 on an x86_64 machine I noticed that the EHCI USB host is unable to work properly after a kexec invocation. This makes it impossible to mount the rootfs in the configuration I'm using. According to the

Re: kexec + USB storage in 2.6.19

2007-01-12 Thread Dan Aloni
On Fri, Jan 12, 2007 at 07:05:09AM -0700, Eric W. Biederman wrote: Dan Aloni [EMAIL PROTECTED] writes: Hello, After upgrading from 2.6.18.3 to 2.6.19.2 on an x86_64 machine I noticed that the EHCI USB host is unable to work properly after a kexec invocation. This makes it impossible

Re: kexec + USB storage in 2.6.19

2007-01-12 Thread Dan Aloni
On Fri, Jan 12, 2007 at 07:05:09AM -0700, Eric W. Biederman wrote: Dan Aloni [EMAIL PROTECTED] writes: Hello, After upgrading from 2.6.18.3 to 2.6.19.2 on an x86_64 machine I noticed that the EHCI USB host is unable to work properly after a kexec invocation. This makes it impossible

Re: kexec + USB storage in 2.6.19

2007-01-12 Thread Eric W. Biederman
Dan Aloni [EMAIL PROTECTED] writes: I'm attaching the full logs. Thanks. [ 8656.272980] ACPI Error (tbxfroot-0512): Could not map memory at 040E for length 2 [20060707] Ok. This looks like the first sign of trouble. Normally I would suspect a memory map issue but your e820 memory map

Re: 2.6.20-rc3-mm1: umount reiser4 FS stuck in D state

2007-01-12 Thread Laurent Riffard
Le 06.01.2007 19:58, Vladimir V. Saveliev a écrit : Hello On Saturday 06 January 2007 13:58, Laurent Riffard wrote: Hello, got this with 2.6.20-rc3-mm1: === SysRq : Show Blocked State freesibling task PC

Re: [PATCH/RFC 2.6.21 2/5] ehca: ehca_uverbs.c: proper use of mmap

2007-01-12 Thread Christoph Raisch
Roland Dreier wrote on 11.01.2007 20:54:58: int ehca_mmap(struct ib_ucontext *context, struct vm_area_struct *vma) { Can you split this monster routine into individual functions for each type of mmap please? With two helpers to get and verify the cq/qp shared by the

Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
Hi Roland! spin_lock_irqsave(ehca_cq_idr_lock, flags); while (my_cq-nr_callbacks) yield(); Isn't that code outright buggy? Calling into the scheduler with a spinlock held and local interrupts disabled... Yes, absolutely -- if nr_callbacks

Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
Hi, + if (my_cq-ownpid != cur_pid) { + ehca_err(device, Invalid caller pid=%x ownpid=%x +cq_num=%x, +cur_pid, my_cq-ownpid, my_cq-cq_number); + return -EINVAL; + } (for

unionfs unusable on multiuser systems (was Re: [PATCH 01/24] Unionfs: Documentation)

2007-01-12 Thread Pavel Machek
Hi! That statement is meant to scare people away from modifying the lower fs :) I tortured unionfs quite a bit, and it can oops but it takes some effort. But isn't it then potential DOS? If you happen to union two filesystems and an untrusted user has write access to both original

Re: unionfs unusable on multiuser systems (was Re: [PATCH 01/24] Unionfs: Documentation)

2007-01-12 Thread Shaya Potter
Pavel Machek wrote: Hi! That statement is meant to scare people away from modifying the lower fs :) I tortured unionfs quite a bit, and it can oops but it takes some effort. But isn't it then potential DOS? If you happen to union two filesystems and an untrusted user has write access to

[patch 0/10] buffered write deadlock fix

2007-01-12 Thread Nick Piggin
The following set of patches attempt to fix the buffered write locking problems (and there are a couple of peripheral patches and cleanups there too). This does pass the write deadlock tests that otherwise fail. Has survived a few hours of fsx-linux on ext2 and 3. Patches against 2.6.20-rc4. I

[patch 1/10] fs: libfs buffered write leak fix

2007-01-12 Thread Nick Piggin
simple_prepare_write and nobh_prepare_write leak uninitialised kernel data. Fix the former, make a note of the latter. Several other filesystems seem to be iffy here, too. Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index: linux-2.6/fs/libfs.c

[patch 2/10] mm: revert generic_file_buffered_write(): handle zero length iovec segments

2007-01-12 Thread Nick Piggin
From: Andrew Morton [EMAIL PROTECTED] Revert 81b0c8713385ce1b1b9058e916edcf9561ad76d6. This was a bugfix against 6527c2bdf1f833cc18e8f42bd97973d583e4aa83, which we also revert. Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index:

[patch 3/10] mm: revert generic_file_buffered_write(): deadlock on vectored write

2007-01-12 Thread Nick Piggin
From: Andrew Morton [EMAIL PROTECTED] Revert 6527c2bdf1f833cc18e8f42bd97973d583e4aa83 This patch fixed the following bug: When prefaulting in the pages in generic_file_buffered_write(), we only faulted in the pages for the firts segment of the iovec. If the second of successive segment

[patch 7/10] mm: cleanup pagecache insertion operations

2007-01-12 Thread Nick Piggin
Quite a bit of code is used in maintaining these cached pages that are probably pretty unlikely to get used. It would require a narrow race where the page is inserted concurrently while this process is allocating a page in order to create the spare page. Then a multi-page write into an uncached

[patch 8/10] mm: generic_file_buffered_write cleanup more

2007-01-12 Thread Nick Piggin
No need to do the confusing switch of variables from copied into status. Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index: linux-2.6/mm/filemap.c === --- linux-2.6.orig/mm/filemap.c +++ linux-2.6/mm/filemap.c @@ -1898,28 +1898,22

[patch 5/10] mm: debug write deadlocks

2007-01-12 Thread Nick Piggin
Allow CONFIG_DEBUG_VM to switch off the prefaulting logic, to simulate the difficult race where the page may be unmapped before calling copy_from_user. Makes the race much easier to hit. This is useful for demonstration and testing purposes, but is removed in a subsequent patch. Signed-off-by:

[patch 9/10] mm: generic_file_buffered_write iovec cleanup

2007-01-12 Thread Nick Piggin
Hide some of the open-coded nr_segs tests into the iovec helpers. This is all to simplify generic_file_buffered_write, because that gets more complex in the next patch. Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index: linux-2.6/mm/filemap.h

[patch 10/10] mm: fix pagecache write deadlocks

2007-01-12 Thread Nick Piggin
Modify the core write() code so that it won't take a pagefault while holding a lock on the pagecache page. There are a number of different deadlocks possible if we try to do such a thing: 1. generic_buffered_write 2. lock_page 3.prepare_write 4. unlock_page+vmtruncate 5.

[patch 6/10] mm: be sure to trim blocks

2007-01-12 Thread Nick Piggin
If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then we may have failed the write operation despite prepare_write having instantiated blocks past i_size. Fix this, and consolidate the trimming into one place. Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index:

[patch 4/10] mm: generic_file_buffered_write cleanup

2007-01-12 Thread Nick Piggin
From: Andrew Morton [EMAIL PROTECTED] Clean up buffered write code. Rename some variables and fix some types. Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index: linux-2.6/mm/filemap.c

Re: kvm dyntick

2007-01-12 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: dyntick-enabled guest: - reduce the load on the host when the guest is idling (currently an idle guest consumes a few percent cpu) yeah. KVM under -rt already works with dynticks enabled on both the host and the guest. (but it's more optimal to

Re: [kvm-devel] [RFC] Stable kvm userspace interface

2007-01-12 Thread Pavel Machek
Hi! Can we please avoid adding a ton of new ioctls? ioctls inevitably require 64-bit compat code for certain architectures, whereas sysfs/procfs does not. For performance reasons, an ascii string based interface is not desireable here, some of these calls should be optimized to

Re: kvm dyntick

2007-01-12 Thread Avi Kivity
Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: dyntick-enabled guest: - reduce the load on the host when the guest is idling (currently an idle guest consumes a few percent cpu) yeah. KVM under -rt already works with dynticks enabled on both the host and the guest. (but

RE: [kvm-devel] kvm dyntick

2007-01-12 Thread Dor Laor
* Ingo Molnar [EMAIL PROTECTED] wrote: dyntick-enabled guest: - reduce the load on the host when the guest is idling (currently an idle guest consumes a few percent cpu) yeah. KVM under -rt already works with dynticks enabled on both the host and the guest. (but it's more optimal to

Re: [kvm-devel] kvm dyntick

2007-01-12 Thread Thomas Gleixner
On Fri, 2007-01-12 at 15:25 -0800, Dor Laor wrote: This is great news for PV guests. Never-the-less we still need to improve our full virtualized guest support. Full virtualized guests, which have their own dyntick support, are fine as long as we provide local apic emulation for them. If a

Re: [ckrm-tech] [PATCH 3/6] containers: Add generic multi-subsystem API to containers

2007-01-12 Thread Paul Menage
On 1/11/07, Balbir Singh [EMAIL PROTECTED] wrote: to 0. To walk the hierarchy, I have no root now since I do not have any task context. I was wondering if exporting the rootnode or providing a function to export the rootnode of the mounter hierarchy will make programming easier. Ah - I

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-12 Thread Paul Menage
On 1/11/07, Balbir Singh [EMAIL PROTECTED] wrote: I tried something similar, I added an activated field, which is set to true when the -create() callback is invoked. That did not help either, the machine still panic'ed. I think that marking it active when create() is called may be too soon.

Re: [ckrm-tech] [PATCH 3/6] containers: Add generic multi-subsystem API to containers

2007-01-12 Thread Balbir Singh
Paul Menage wrote: On 1/11/07, Balbir Singh [EMAIL PROTECTED] wrote: to 0. To walk the hierarchy, I have no root now since I do not have any task context. I was wondering if exporting the rootnode or providing a function to export the rootnode of the mounter hierarchy will make programming

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-12 Thread Balbir Singh
Paul Menage wrote: On 1/11/07, Balbir Singh [EMAIL PROTECTED] wrote: I tried something similar, I added an activated field, which is set to true when the -create() callback is invoked. That did not help either, the machine still panic'ed. I think that marking it active when create() is

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-12 Thread Paul Menage
On 1/12/07, Balbir Singh [EMAIL PROTECTED] wrote: I understand that the features are exported to userspace. But from the userspace POV only the mount options change - right? The mount options, plus the fact that you can mount different instances of containerfs with different resource

Re: [PATCH 0/6] containers: Generic Process Containers (V6)

2007-01-12 Thread Serge E. Hallyn
Quoting Paul Menage ([EMAIL PROTECTED]): Hi Serge, On 1/3/07, Serge E. Hallyn [EMAIL PROTECTED] wrote: From: Serge E. Hallyn [EMAIL PROTECTED] Subject: [RFC] [PATCH 1/1] container: define a namespace container subsystem Here's a stab at a namespace container subsystem based on Paul

Re: How git affects kernel.org performance

2007-01-12 Thread Nigel Cunningham
Hi. On Wed, 2007-01-10 at 22:07 +0800, Fengguang Wu wrote: Thanks, Nigel. But I'm very sorry that the calculation in the patch was wrong. Would you give this new patch a run? Sorry for my slowness. I just did time find /usr/src | wc -l again: Without patch: 35.137, 35.104, 35.351 seconds

[PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Eric Sandeen
I've been looking at a case where many threads are opening, unlinking, and hardlinking files on ext3 . At unmount time I see an oops, because the superblock's orphan list points to a freed inode. I did some tracing of the inodes, and it looks like this:

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Alex Tomas
interesting .. I thought VFS doesn't allow concurrent operations. if unlink goes first, then link should wait on the parent's i_mutex and then found no source name. thanks, Alex Eric Sandeen (ES) writes: ES ) ES I've been looking at a case where many threads are opening, unlinking, and ES

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Eric Sandeen
Alex Tomas wrote: interesting .. I thought VFS doesn't allow concurrent operations. if unlink goes first, then link should wait on the parent's i_mutex and then found no source name. thanks, Alex Well... I was wondering that myself, whether this race should even happen. But the bottom

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Alex Tomas
ah, it seems vfs_link() doesn't check whether source is still alive. for example, in mkdir case vfs_mkdir() calls may_create() and checks the parent is still there: if (IS_DEADDIR(dir)) return -ENOENT; VFS doesn't set S_DEAD on regular files, but we could check i_nlink.

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Dave Kleikamp
On Sat, 2007-01-13 at 00:02 +0300, Alex Tomas wrote: interesting .. I thought VFS doesn't allow concurrent operations. if unlink goes first, then link should wait on the parent's i_mutex and then found no source name. I don't think the VFS ever takes the source's parent's i_mutex. Unless

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Alex Tomas
Eric Sandeen (ES) writes: ES so I think it's possible that link can sneak in there find it after ES the mutex is dropped...? Is this ok? :) It's certainly -happening- ES anyway yes, but it shouldn't allow to re-link such inode back, IMHO. a filesystem may start some non-revertable

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Eric Sandeen
Alex Tomas wrote: Eric Sandeen (ES) writes: ES so I think it's possible that link can sneak in there find it after ES the mutex is dropped...? Is this ok? :) It's certainly -happening- ES anyway yes, but it shouldn't allow to re-link such inode back, IMHO. a filesystem may

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Alex Tomas
Eric Sandeen (ES) writes: ES I tend to agree, chatting w/ Al I think he does too. :) I'll test ES a patch that kicks out ext3_link() with -ENOENT at the top, and resubmit ES that if things go well. shouldn't VFS do that? thanks, Alex - To unsubscribe from this list: send the line

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Eric Sandeen
Alex Tomas wrote: Eric Sandeen (ES) writes: ES I tend to agree, chatting w/ Al I think he does too. :) I'll test ES a patch that kicks out ext3_link() with -ENOENT at the top, and resubmit ES that if things go well. shouldn't VFS do that? Al says no and I'm not arguing. :)

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Alex Tomas
Eric Sandeen (ES) writes: ES Al says no and I'm not arguing. :) ES Apparently this may be OK with some filesystems, and Al says he doesn't ES want to know about i_nlink in the vfs in any case. well, generic_drop_inode() uses i_nlink ... ES But I suppose there may be other filesystems

Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

2007-01-12 Thread Eric Sandeen
Eric Sandeen wrote: Alex Tomas wrote: yes, but it shouldn't allow to re-link such inode back, IMHO. a filesystem may start some non-revertable activity in its unlink method. thanks, Alex I tend to agree, chatting w/ Al I think he does too. :) I'll test a patch that kicks out

Re: [PATCH 2/5] fixing errors handling during pci_driver resume stage [ata]

2007-01-12 Thread Grant Grundler
On Tue, Jan 09, 2007 at 12:01:28PM +0300, Dmitriy Monakhov wrote: ata pci drivers have to return correct error code during resume stage in case of errors. ... @@ -6246,8 +6253,10 @@ int ata_pci_device_suspend(struct pci_de int ata_pci_device_resume(struct pci_dev *pdev) { struct

Re: [Suspend-devel] asus p5ld2 se, serial port gone after suspend and i8042 problems (solved, pnpacpi=off needed)

2007-01-12 Thread emisca
But using pnpacpi=no, I disable the acpi code.. the normal pnp code, what does on suspend? Does it simply do nothing? In the dmesg I don't see anything related to pnp device reinit. I tried suspend to ram on this motherboard. A strange thing happens.. the system goes to suspend and then suddenly

Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible

2007-01-12 Thread Alan
On Fri, 12 Jan 2007 05:28:07 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: use PIO/MMIO operations directly where possible This results in smaller/faster/simpler code and allows future optimizations. Also remove no longer needed ide[_mm]_{inl,outl}() and

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Alan
On Fri, 12 Jan 2007 05:28:00 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: add ide_use_fast_pio() helper * add ide_use_fast_pio() helper for use by host drivers * add DMA capability and autodma checks to ide_use_dma() - au1xxx-ide/it8213/it821x drivers didn't check

Re: [PATCH 0/19] new IDE quilt tree

2007-01-12 Thread Alan
Generally looks very good - couple of odd items I noticed I've send replies about. Good to have someone working on the old IDE code again. Alan - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Proposed changes for libata speed handling

2007-01-12 Thread Alan
I'm currently hacking on the speed handling code a bit I'd like to do the following unless anyone has any objections - Remove post_set_mode and make drivers wrap the guts of the existing set_mode() function. This allows a driver to wrap and see success/failure while removing a callback, and also

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2007 05:28:00 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: add ide_use_fast_pio() helper * add ide_use_fast_pio() helper for use by host drivers * add DMA capability and autodma checks to ide_use_dma() -

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Alan
if(strstr(id-model, Integrated Technology Express)) { /* In raid mode the ident block is slightly buggy We need to set the bits so that the IDE layer knows LBA28. LBA48 and DMA ar valid */

Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2007 05:28:07 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: use PIO/MMIO operations directly where possible This results in smaller/faster/simpler code and allows future optimizations. Also remove no longer

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: if(strstr(id-model, Integrated Technology Express)) { /* In raid mode the ident block is slightly buggy We need to set the bits so that the IDE layer knows LBA28.

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Alan
It seems that it821x_tune_chipset() is buggy since it sends SET FEATURES command even when in smart mode. Shouldn't there be don't tune flag in it812x_fixups() to tell it821x_tune_chipset() to not send SET FEATURES commands? It's itdev-smart but falls through to ide_config_drive_speed while

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: It seems that it821x_tune_chipset() is buggy since it sends SET FEATURES command even when in smart mode. Shouldn't there be don't tune flag in it812x_fixups() to tell it821x_tune_chipset() to not send SET FEATURES commands? It's itdev-smart but

Re: ahci_softreset prevents acpi_power_off

2007-01-12 Thread Tejun Heo
Hello, Faik Uygur wrote: We have a Sony PCG-6H1M laptop. It started failing to poweroff with our switch from 2.6.16 stable series kernels to 2.6.18 stable series. Rebooting works. While searching for the cause, I have found these reported bug reports in the kernel bugzilla which may be

Re: Proposed changes for libata speed handling

2007-01-12 Thread Tejun Heo
Alan wrote: I'm currently hacking on the speed handling code a bit I'd like to do the following unless anyone has any objections - Remove post_set_mode and make drivers wrap the guts of the existing set_mode() function. This allows a driver to wrap and see success/failure while removing a

<    1   2   3   4   5   6   >