Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Eric Dumazet
Pekka J Enberg a écrit : Thanks for the profile. I still wonder where exactly thouse super-hot call-sites are... In this case, it's a typical network server Each time a packet is sent to or received from network, network stack has to allocate/free a skb (kmem_cache_alloc()/kmem_cache_free()

Re: 2.6.21-rc4-mm1

2007-03-19 Thread Michal Piotrowski
Andrew Morton napisał(a): > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/ > Some new details about http://www.ussg.iu.edu/hypermail/linux/kernel/0703.2/1367.html I can reproduce it by running this on AutoTest for profiler in ('oprofile', ): try: p

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Pekka J Enberg
On 3/19/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > This is a super-hot path. At some point in time, I wrote: > > Super-hot exactly where? On Tue, 20 Mar 2007, Eric Dumazet wrote: > Don't be silly Pekka ... We have plenty oprofiles results if you dont trust > Andrew. Oh, don't get me wron

Re: [RFC][PATCH 0/6] per device dirty throttling

2007-03-19 Thread David Chinner
On Mon, Mar 19, 2007 at 04:57:37PM +0100, Peter Zijlstra wrote: > This patch-set implements per device dirty page throttling. Which should solve > the problem we currently have with one device hogging the dirty limit. > > Preliminary testing shows good results: I just ran some higher throughput n

Re: [2.6.21 patch] net/sunrpc/svcsock.c: fix a check

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 10:33:42 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > The return value of kernel_recvmsg() should be assigned to "err", not > compared with the random value of a never initialized "err" > (and the "< 0" check wrongly always returned false since == comparisons > never have a

Re: [PATCH] Complain about missing system calls.

2007-03-19 Thread David Woodhouse
On Mon, 2007-03-19 at 16:42 -0700, Andrew Morton wrote: > hm, did you try running this on x86_64? I don't have any. I only tested it on PowerPC and i386. Others then provided more exclusions for SPARC and maybe ARM, although I'm not sure you have the latter yet. It's not hard to add extra exclusio

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Eric Dumazet
Pekka Enberg a écrit : On 3/19/07, Andrew Morton <[EMAIL PROTECTED]> wrote: This is a super-hot path. Super-hot exactly where? Don't be silly Pekka ... We have plenty oprofiles results if you dont trust Andrew. CPU: AMD64 processors, speed 1992.52 MHz (estimated) Counted CPU_CLK_UNHALTED

Re: Kernel Oops in pl2303_shutdown()

2007-03-19 Thread Zilvinas Valinskas
Hello Adrian, reverting d9a7ecacac5f8274d2afce09aadcf37bdb42b93a does help. thanks ! On Mon, 2007-03-19 at 17:34 +0100, Adrian Bunk wrote: > On Mon, Mar 19, 2007 at 05:27:58PM +0200, Zilvinas Valinskas wrote: > > Hello, > > > > Before 2.6.21-rc4 (vanilla) serial was oopsing if I pull usb-seri

Re: Kernel 2.6.20 does not work anymore with SCSI or SATA on old Opteron / Xeon servers

2007-03-19 Thread Andrew Morton
On Sun, 18 Mar 2007 21:50:46 +0100 Stefan Priebe <[EMAIL PROTECTED]> wrote: > Hello! > > We've a very strange Problem with Kernel 2.6.20.x > > If i try to access a SCSI or SATA Disk (tested with Adaptec U320 > ASC-29320, ICP Vortex 9024, Promise TX300) the whole server hangs - no > output - no

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Michal Piotrowski
[EMAIL PROTECTED] napisał(a): > The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz > > It contains the following patches against 2.6.21-rc4: PM: Adding info for No Bus:vcsa7 BUG

Re: [PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-19 Thread Nicolas Boichat
Hello, Andrew Morton wrote: > On Mon, 19 Mar 2007 13:19:00 +0800 Nicolas Boichat <[EMAIL PROTECTED]> wrote: > > >> This driver provides support for the Apple System Management Controller, >> which >> provides an accelerometer (Apple Sudden Motion Sensor), light sensors, >> temperature sensors,

Re: [BUG] no boot with 2.6.21-rc3 and later

2007-03-19 Thread Jiri Kosina
On Mon, 19 Mar 2007, Bob Tracy wrote: > I applied all of the 2.6.21-rc2-rc3 incremental patch except for the > portion applicable to "drivers/ide" files. The problem seems to be > elsewhere: 2.6.21-rc3 minus the drivers/ide changes still hangs at the > same spot during the boot process. Any id

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Pekka Enberg
On 3/19/07, Andrew Morton <[EMAIL PROTECTED]> wrote: This is a super-hot path. Super-hot exactly where? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Plea

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Pekka Enberg
On 3/19/07, Andrew Morton <[EMAIL PROTECTED]> wrote: The BUG_ON (at least) should probably be moved into CONFIG_DEBUG_SLAB. No it shouldn't. Letting non-slab pages pass through causes nasty and hard to debug problems which is why we have the BUG_ONs in the first place: http://lkml.org/lkml/200

Re: [RFC][PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-19 Thread Nicolas Boichat
Hello, Bob Copeland wrote: > On 3/14/07, Nicolas Boichat <[EMAIL PROTECTED]> wrote: >> Hello, >> >> I developed, a while ago, a driver the Apple System Management >> Controller, which provides an accelerometer (Apple Sudden Motion >> Sensor), light sensors, temperature sensors, keyboard backlight

new warning in ata_sg_clean

2007-03-19 Thread Meelis Roos
In todays 2.6.21-rc4+git the following news warning has appeared on my ppc computer: CC [M] drivers/ata/libata-core.o drivers/ata/libata-core.c: In function 'ata_sg_clean': drivers/ata/libata-core.c:3558: warning: unused variable 'dir' -- Meelis Roos ([EMAIL PROTECTED]) - To unsubscribe from

Re: XFS internal error xfs_da_do_buf(2) at line 2087 of file fs/xfs/xfs_da_btree.c. Caller 0xc01b00bd

2007-03-19 Thread David Chinner
On Mon, Mar 19, 2007 at 11:32:27AM +0100, Marco Berizzi wrote: > Marco Berizzi wrote: > > David Chinner wrote: > > > >> Ok, so an ipsec change. And I see from the history below it > >> really has nothing to do with this problem. it seems the problem > >> has something to do with changes between 2.6

PNPACPI probes serial twice, messes up serial console

2007-03-19 Thread Keith Owens
Dell SC1425 x86_64 running in i386 mode (the problem also occurs in x86_64 mode). Kernel 2.6.21-rc4, gcc 4.1.0. Config extract at end. Booting with 'console=tty console=ttyS0,9600'. The serial console on ttyS0 (0x3f8, irq 4) is probed twice, once from serial8250_init() and again from serial_pnp

Re: [PATCH] vt: fix a potential race in the VT_WAITACTIVE handler

2007-03-19 Thread Andrew Morton
On Thu, 15 Mar 2007 15:10:23 +0100 Michal Januszewski <[EMAIL PROTECTED]> wrote: > On a multiprocessor machine the VT_WAITACTIVE ioctl call may return 0 > if fg_console has already been updated in redraw_screen(), but the > console switch itself hasn't been completed. Fix this by checking > fg_co

Re: [PATCH] Sanitize filesystem NLS handling

2007-03-19 Thread Alexander E. Patrakov
OGAWA Hirofumi wrote: "Alexander E. Patrakov" <[EMAIL PROTECTED]> writes: But, anyway, this is a separate issue that my patch doesn't attempt to correct. The conclusion so far is that we disagree, and that there are situations where using utf8 iocharset is the least of all evils, so the warni

Re: [BUG] 2.6.21-rc1,2,3 regressions on my system that I found so far

2007-03-19 Thread Thomas Gleixner
On Mon, 2007-03-19 at 21:27 -0700, Greg KH wrote: > On Sat, Mar 17, 2007 at 02:26:57PM +0100, Andi Kleen wrote: > > Arjan van de Ven <[EMAIL PROTECTED]> writes: > > > > > > well we can do the handshake to take ownership like we do much later in > > > boot, but that requires PCI to be there and ful

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Thomas Gleixner
On Mon, 2007-03-19 at 20:05 -0500, Matt Mackall wrote: > On Tue, Mar 20, 2007 at 01:42:46AM +0100, Thomas Gleixner wrote: > > On Mon, 2007-03-19 at 17:32 -0500, Matt Mackall wrote: > > > This is exactly the same problem as booting on a desktop PC. But > > > somehow LILO manages. My first Linux box

Re: [RFC][PATCH] split file and anonymous page queues #2

2007-03-19 Thread Nick Piggin
Rik van Riel wrote: Split the anonymous and file backed pages out onto their own pageout queues. This we do not unnecessarily churn through lots of anonymous pages when we do not want to swap them out anyway. This should (with additional tuning) be a great step forward in scalability, allowing

Re: RSDL v0.31

2007-03-19 Thread Willy Tarreau
On Mon, Mar 19, 2007 at 08:11:55PM -0700, Linus Torvalds wrote: > Quite frankly, I was *planning* on merging RSDL very early after 2.6.21, > but there is one thing that has turned me completely off the whole thing: > > - the people involved seem to be totally unwilling to even admit there >

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-19 Thread Nick Piggin
On Mon, Mar 19, 2007 at 09:44:28PM +0100, Blaisorblade wrote: > On Sunday 18 March 2007 03:50, Nick Piggin wrote: > > > > > > > > Yes, I believe that is the case, however I wonder if that is going to > > > > be a problem for you to distinguish between write faults for clean > > > > writable ptes, a

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: > For VMI, the default clobber was "cc", and you need a way to allow at > least that, because saving and restoring flags is too expensive on x86. According to lore (Andi, I think), asm() always clobbers cc. > I still don't think this was a good trade. The primary motivatio

Re: [BUG] 2.6.21-rc1,2,3 regressions on my system that I found so far

2007-03-19 Thread Eric St-Laurent
On Tue, 2007-20-03 at 01:04 -0400, Lee Revell wrote: > I think CONFIG_TRY_TO_DISABLE_SMI would be excellent for debugging, > not to mention people trying to spec out hardware for RT > applications... There is a SMI disabling module in RTAI, check the smi-module.c in this: https://www.rtai.org/RT

Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread Nick Piggin
Christoph Hellwig wrote: On Mon, Mar 19, 2007 at 09:11:31PM +1100, Nick Piggin wrote: I've got the patches in -mm now. I hope they will get merged when the the next window opens. I didn't submit the ->page_mkwrite conversion yet, because I didn't have any callers to look at. It is is slightly

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Nick Piggin
Nick Piggin wrote: Andrew Morton wrote: On Tue, 20 Mar 2007 13:47:53 +1100 Nick Piggin <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: Hang on a sec... I'll try fixing the thing before you next make a release. Too late. hot-fixes/ awaits thee. Awww... well thanks very much Micha

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Nick Piggin
Andrew Morton wrote: On Tue, 20 Mar 2007 13:47:53 +1100 Nick Piggin <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: Hang on a sec... I'll try fixing the thing before you next make a release. Too late. hot-fixes/ awaits thee. Awww... well thanks very much Michal for reporting the bug

Re: [patch 00/31] 2.6.20-stable review

2007-03-19 Thread Gene Heskett
On Monday 19 March 2007, Greg KH wrote: >This is the start of the stable review cycle for the 2.6.20.4 release. >There are 31 patches in this series, all will be posted as a response >to this one. If anyone has any issues with these being applied, please >let us know. If anyone is a maintainer of

Re: [PATCH] powerpc minor pagefault optimization with kprobes enabled

2007-03-19 Thread Anton Blanchard
> I've attached a patch below the optimizes this code path for powerpc, > but the scheme applies to all architectures aswell. It just rips out all > the callachin madness, and does as good as it gets in the pagefault > handler: NAK, patch on the way to get rid of all the debugger() crap by using

Re: [BUG] 2.6.21-rc1,2,3 regressions on my system that I found so far

2007-03-19 Thread Lee Revell
On 3/16/07, Thomas Gleixner <[EMAIL PROTECTED]> wrote: Yes, this is probably caused by SMM code trying to emulate a PS/2 keyboard from a (maybe connected or not) USB keyboard. Unfortunately we have no way to disable this BIOS misfeature in the early boot process. https://mail.rtai.org/pipermail

2.6.21-rc4-mm1

2007-03-19 Thread Andrew Morton
Temporarily at http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc4/2.6.21-rc4-mm1/ - Restored the RSDL CPU scheduler (a new version thereof) Boilerplate: - See the `hot-fixes' directory for any

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Andrew Morton
On Tue, 20 Mar 2007 13:47:53 +1100 Nick Piggin <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Mon, 19 Mar 2007 17:58:52 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > >>The kernel without Nick's patchset but with the assert runs OK too. Under > >>the principle of mm-has-been

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Paul Mackerras
Christoph Lameter writes: > +static inline void *quicklist_alloc(int nr, gfp_t flags, void (*ctor)(void > *)) > +{ ... > + p = (void *)__get_free_page(flags | __GFP_ZERO); This will cause problems on 64-bit powerpc, at least with 4k pages, since the pmd and pgd levels only use 1/4 of a pag

Re: [BUG] 2.6.21-rc1,2,3 regressions on my system that I found so far

2007-03-19 Thread Greg KH
On Sat, Mar 17, 2007 at 02:26:57PM +0100, Andi Kleen wrote: > Arjan van de Ven <[EMAIL PROTECTED]> writes: > > > > well we can do the handshake to take ownership like we do much later in > > boot, but that requires PCI to be there and fully discovered, which we > > don't have this early. > > That

Re: [PATCH] sysctl: vfs_cache_divisor

2007-03-19 Thread H. Peter Anvin
Randy Dunlap wrote: The we duplicate all the relevant /proc knobs: cat /proc/sys/vm/dirty_ratio 30 cat /proc/sys/vm/hires-dirty_ratio/ 30 Or we do something else ;) Sounds better. I wasn't very keen on the userspace interface that this exposed. Will look at those. Okay... may be I c

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Rusty Russell
On Mon, 2007-03-19 at 18:00 -0800, Zachary Amsden wrote: > Rusty Russell wrote: > > *This* was the reason that the current hand-coded calls only clobber % > > eax. It was a compromise between native (no clobbers) and others (might > > need a reg). > > I still don't think this was a good trade. ..

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > From: Linus Torvalds <[EMAIL PROTECTED]> > Date: Mon, 19 Mar 2007 20:18:14 -0700 (PDT) > >> > > Please don't subject us to another couple months of hair-pulling only >> > > to have Linus yank the thing out again, there are certainly more >> > > useful thi

Re: [stable] [patch 29/31] Input: i8042 - fix AUX IRQ delivery check

2007-03-19 Thread Greg KH
On Mon, Mar 19, 2007 at 05:48:55PM -0400, Dmitry Torokhov wrote: > On 3/19/07, Greg KH <[EMAIL PROTECTED]> wrote: > > -stable review patch. If anyone has any objections, please let us know. > > > > -- > > > > From: Dmitry Torokhov <[EMAIL PROTECTED]> > > > > Input: i8042 - fix AUX

Re: [patch 03/31] Fix user copy length in ipv6_sockglue.c

2007-03-19 Thread Greg KH
On Mon, Mar 19, 2007 at 03:01:25PM -0700, Chris Wright wrote: > * Greg KH ([EMAIL PROTECTED]) wrote: > > From: Chris Wright <[EMAIL PROTECTED]> > > > > [IPV6] fix ipv6_getsockopt_sticky copy_to_user leak > > > > User supplied len < 0 can cause leak of kernel memory. > > Use unsigned compare inste

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread David Miller
From: Linus Torvalds <[EMAIL PROTECTED]> Date: Mon, 19 Mar 2007 20:18:14 -0700 (PDT) > > > Please don't subject us to another couple months of hair-pulling only > > > to have Linus yank the thing out again, there are certainly more > > > useful things to spend time on :-) > > Good call. Dwarf2 un

Re: [PATCH 2.6.22 3/3] Add LED trigger to libata core

2007-03-19 Thread Tejun Heo
Tony Vroon wrote: The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/ Apple K2 driver. Used by the IDE LED trigger on G5 towers. Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox. Just two comments. 1. IMHO, ata_qc_issue_prot_ledtrigger() without 'wi

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Linus Torvalds
On Mon, 19 Mar 2007, Andi Kleen wrote: > > Initially we had some bugs that accounted for near all failures, but they > were all fixed in the latest version. No. The real bugs were that the people involved wouldn't even accept that unwinding information was inevitably buggy and/or incomplete.

Re: RSDL v0.31

2007-03-19 Thread Linus Torvalds
On Mon, 19 Mar 2007, Xavier Bestel wrote: > > >> Stock scheduler wins easily, no contest. > > > > > > What happens when you renice X ? > > > > Dunno -- not necessary with the stock scheduler. > > Could you try something like renice -10 $(pidof Xorg) ? Could you try something as simple and acc

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Nick Piggin
Andrew Morton wrote: On Mon, 19 Mar 2007 17:58:52 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: The kernel without Nick's patchset but with the assert runs OK too. Under the principle of mm-has-been-too-flakey-lately, I'll drop the patches: mm-debug-check-for-the-fault-vs-invalidate-race.pa

ignore this posting

2007-03-19 Thread David Miller
Just trying to generate an example bounce so Intel can fix their attachment email filters, ignore me. #!/bin/sh # # Usage: git suck path-to-tree # # Pull all patches relative to 'origin' from the tree specified # and apply them to the current directory tree, keeping all changelog # and authorship

RE: UDP packets scheduling

2007-03-19 Thread David Schwartz
> can anyone suggest me a proper way how to schedule UDP packets to > transmit at > some given rate? > > E.g., I have two boxes both having 10 GE interfaces. One box is able to > transmit at 9.9Gbps, the other one is able to receive only at > about 5.5Gbps. > Flow control must be turned off for so

Re: [6/6] 2.6.21-rc4: known regressions

2007-03-19 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 18 Mar 2007 19:49:38 +0100 > Subject: ipv6 crash > References : http://lkml.org/lkml/2007/3/10/2 > Submitter : Len Brown <[EMAIL PROTECTED]> > Status : unknown This is caused by some problem in the router round-robin code in net/ipv6/route

Re: SMP performance degradation with sysbench

2007-03-19 Thread Zhang, Yanmin
On Wed, 2007-03-14 at 16:33 -0700, Siddha, Suresh B wrote: > On Tue, Mar 13, 2007 at 05:08:59AM -0700, Nick Piggin wrote: > > I would agree that it points to MySQL scalability issues, however the > > fact that such large gains come from tcmalloc is still interesting. > > What glibc version are you

RE: MPT Fusion LSI22320 , Domain validation loops .

2007-03-19 Thread Moore, Eric
On Saturday, March 17, 2007 2:33 PM, James W. Laferriere wrote: > Hello All , I am have been having this problem since I > purchased the > controller and after changing out the disks I thought were > the problem . > I am still getting the continous : > > mptscsih: ioc1: attempting

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 17:58:52 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > The kernel without Nick's patchset but with the assert runs OK too. Under > the principle of mm-has-been-too-flakey-lately, I'll drop the patches: > > mm-debug-check-for-the-fault-vs-invalidate-race.patch > mm-simplify

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Zachary Amsden
Rusty Russell wrote: On Mon, 2007-03-19 at 11:38 -0700, Linus Torvalds wrote: On Mon, 19 Mar 2007, Eric W. Biederman wrote: True. You can use all of the call clobbered registers. Quite often, the biggest single win of inlining is not so much the code size (although if done righ

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 22:37:46 +0100 "Michal Piotrowski" <[EMAIL PROTECTED]> wrote: > On 19/03/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Mon, 19 Mar 2007 20:23:40 +0100 > > Michal Piotrowski <[EMAIL PROTECTED]> wrote: > > > > > [EMAIL PROTECTED] napisał(a): > > > > The mm snapshot broken-

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: > Jeremy Fitzhardinge wrote: >> If we then work out in each direction and see matched push/pops, >> then we know what registers can be trashed in the call. This also >> allows us to determine the callsite size, and therefore how much space >> we need for inlining. >> > >

Re: [BUG] no boot with 2.6.21-rc3 and later

2007-03-19 Thread Bob Tracy
Jiri wrote: > Looks like it's related to some change in drivers/ide. As there have been > only 13 patches in this area between rc2 and rc3, it should take only 3 or > 4 reboots to figure the offending patch using git-bisect - could you > please give it a try? I applied all of the 2.6.21-rc2-rc3

Re: [patch 1/13] signal/timer/event fds v7 - anonymous inode source ...

2007-03-19 Thread Davide Libenzi
On Tue, 20 Mar 2007, Thomas Gleixner wrote: > > + error = -ENFILE; > > + file = get_empty_filp(); > > + if (!file) > > + goto eexit_1; > > make this "return -ENFILE;" please Done > > + inode = aino_getinode(); > > + if (IS_ERR(inode)) { > > + error = PTR_ERR(inode

Re: [patch 6/13] signal/timer/event fds v7 - timerfd core ...

2007-03-19 Thread Davide Libenzi
On Tue, 20 Mar 2007, Eric Dumazet wrote: > Davide Libenzi a écrit : > > > +struct timerfd_ctx { > > + struct hrtimer tmr; > > + ktime_t tintv; > > + spinlock_t lock; > > + wait_queue_head_t wqh; > > + unsigned long ticks; > > +}; > > > +static struct kmem_cache *timerfd_ctx_cachep; >

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 18:03:54 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Mon, 19 Mar 2007, Andrew Morton wrote: > > > > See the patch. We are only touching 2 cachelines instead of 32. So even > > > without considering the page allocator overhead and the slab allocator > > > o

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: For example, say we wanted to put a general call for sti into entry.S, where its expected it won't touch any registers. In that case, we'd have a sequence like: push %eax push %ecx push %edx call paravirt_cli pop %edx pop %ecx pop %eax

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Tue, Mar 20, 2007 at 01:42:46AM +0100, Thomas Gleixner wrote: > On Mon, 2007-03-19 at 17:32 -0500, Matt Mackall wrote: > > > > If a static volume is simply a non-dynamic volume, then device mapper > > > > can do that too. And countless other things. Which is not an aside. > > > > UBI growing to

Re: BUG lapic: Can't boot on battery (2.6.21-rc{1,2,3,4})

2007-03-19 Thread Thomas Gleixner
On Mon, 2007-03-19 at 22:51 +0100, Stefan Prechtel wrote: > 2007/3/19, Thomas Gleixner <[EMAIL PROTECTED]>: > > On Mon, 2007-03-19 at 21:35 +0100, Stefan Prechtel wrote: > > >CPU0 CPU1 > > > 0: 28289 0 local-APIC-edge-fasteio timer > > > ... > > > LOC: 28237

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Christoph Lameter
On Mon, 19 Mar 2007, Andrew Morton wrote: > > + > > +#ifdef CONFIG_QUICKLIST > > + > > +#ifndef CONFIG_NR_QUICK > > +#define CONFIG_NR_QUICK 1 > > +#endif > > No, please don't define config items like this. Do it in Kconfig. They can be set up in the arch specific Kconfig. Ok. I moved the #ifn

Re: [RFC][PATCH] split file and anonymous page queues #2

2007-03-19 Thread Rik van Riel
Rik van Riel wrote: Split the anonymous and file backed pages out onto their own pageout queues. This we do not unnecessarily churn through lots of anonymous pages when we do not want to swap them out anyway. Please take this patch for a spin and let me know what goes well and what goes wrong

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Christoph Lameter
On Mon, 19 Mar 2007, Andrew Morton wrote: > > See the patch. We are only touching 2 cachelines instead of 32. So even > > without considering the page allocator overhead and the slab allocator > > overhead (which will make the situation even better) its superior. > > That's not proof, it is han

Re: chrdev_open lifetime question

2007-03-19 Thread Pete Zaitcev
On Wed, 7 Mar 2007 17:23:05 -0500, "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > It seems that if a process keeps a character device open then other > processes will also be able to get into filp->f_op->open(inode,filp) > in chrdev_open() even after a driver called cdev_del() as part of its > unw

Re: [patch 1/13] signal/timer/event fds v7 - anonymous inode source ...

2007-03-19 Thread Thomas Gleixner
Davide, On Mon, 2007-03-19 at 16:47 -0700, Davide Libenzi wrote: > This patch add an anonymous inode source, to be used for files that need > and inode only in order to create a file*. We do not care of having an > inode for each file, and we do not even care of having different names in > the

Re: Suspend to RAM doesn't work anymore in 2.6.21

2007-03-19 Thread Tobias Doerffel
On Monday 19 March 2007 22:43:20 you wrote: > Hi, > > On Monday, 19 March 2007 13:50, Tobias Doerffel wrote: > > Hi, > > > > Suspend to RAM used to work fine on my computer (Intel Core Duo, 1 GB > > RAM, Intel 82801G (ICH7-chipset) mainboard, NVIDIA-gfx-card, > > tg3-ethernet) up to 2.6.20.3. But n

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 17:44:28 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Mon, 19 Mar 2007, Andrew Morton wrote: > > > Please provide proof that quicklists are superior to simply going direct to > > the page allocator for these pages. > > See the patch. We are only touching 2 ca

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Randy Dunlap
On Mon, 19 Mar 2007 17:39:15 -0700 Andrew Morton wrote: > On Mon, 19 Mar 2007 17:27:11 -0700 > Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: > > > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3

[RFC][PATCH] split file and anonymous page queues #2

2007-03-19 Thread Rik van Riel
Split the anonymous and file backed pages out onto their own pageout queues. This we do not unnecessarily churn through lots of anonymous pages when we do not want to swap them out anyway. This should (with additional tuning) be a great step forward in scalability, allowing Linux to run well on

UDP packets scheduling

2007-03-19 Thread Lukas Hejtmanek
Hello, can anyone suggest me a proper way how to schedule UDP packets to transmit at some given rate? E.g., I have two boxes both having 10 GE interfaces. One box is able to transmit at 9.9Gbps, the other one is able to receive only at about 5.5Gbps. Flow control must be turned off for some other

Re: [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1)

2007-03-19 Thread Francois Romieu
Tasos Parisinos <[EMAIL PROTECTED]> : [...] RSA is slow. syscalls are fast. Which part of the kernel is supposed to benefit from this code ? -- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Christoph Lameter
On Mon, 19 Mar 2007, Andrew Morton wrote: > Please provide proof that quicklists are superior to simply going direct to > the page allocator for these pages. See the patch. We are only touching 2 cachelines instead of 32. So even without considering the page allocator overhead and the slab alloc

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 17:27:11 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2/ > > > > - This is the same as 2.6.21-rc3-mm1, except Con's CPU s

Re: [patch 6/13] signal/timer/event fds v7 - timerfd core ...

2007-03-19 Thread Eric Dumazet
Davide Libenzi a écrit : +struct timerfd_ctx { + struct hrtimer tmr; + ktime_t tintv; + spinlock_t lock; + wait_queue_head_t wqh; + unsigned long ticks; +}; +static struct kmem_cache *timerfd_ctx_cachep; + timerfd_ctx_cachep = kmem_cache_create("timerfd_

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Thomas Gleixner
On Mon, 2007-03-19 at 16:36 -0500, Matt Mackall wrote: > On Mon, Mar 19, 2007 at 11:06:33PM +0200, Artem Bityutskiy wrote: > > On Mon, 2007-03-19 at 14:54 -0500, Matt Mackall wrote: > > > The issue is 14000 lines of patch to make a parallel subsystem. > > > > Parallel system exists since very long

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Thomas Gleixner
On Mon, 2007-03-19 at 17:32 -0500, Matt Mackall wrote: > > > If a static volume is simply a non-dynamic volume, then device mapper > > > can do that too. And countless other things. Which is not an aside. > > > UBI growing to do all the things that device mapper does is exactly > > > the thing we s

Re: [PATCH 2/3] swsusp: Do not use page flags

2007-03-19 Thread Andrew Morton
On Mon, 12 Mar 2007 22:19:20 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > Make swsusp use memory bitmaps instead of page flags for marking 'nosave' and > free pages. This allows us to 'recycle' two page flags that can be used for > other > purposes. Also, the memory needed to store th

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Randy Dunlap
On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2/ > > - This is the same as 2.6.21-rc3-mm1, except Con's CPU scheduler changes > were dropped. > > This is for A/B comparison purposes, and becau

Re: [patch 2/13] signal/timer/event fds v7 - signalfd core ...

2007-03-19 Thread Davide Libenzi
On Tue, 20 Mar 2007, Oleg Nesterov wrote: > On 03/19, Davide Libenzi wrote: > > > > +static void signalfd_unlock(struct signalfd_ctx *ctx, > > + struct signalfd_lockctx *lk) > > +{ > > + unlock_task_sighand(lk->tsk, &lk->flags); > > +} > > Again, this is a matter of taste.

Re: [patch 2/13] signal/timer/event fds v7 - signalfd core ...

2007-03-19 Thread Oleg Nesterov
On 03/19, Davide Libenzi wrote: > > +static void signalfd_unlock(struct signalfd_ctx *ctx, > + struct signalfd_lockctx *lk) > +{ > + unlock_task_sighand(lk->tsk, &lk->flags); > +} Again, this is a matter of taste. But I can't understand why signalfd_unlock() needs "sign

Re: [patch 2/13] signal/timer/event fds v7 - signalfd core ...

2007-03-19 Thread Davide Libenzi
On Tue, 20 Mar 2007, Oleg Nesterov wrote: > On 03/19, Davide Libenzi wrote: > > > > +struct signalfd_lockctx { > > + struct task_struct *tsk; > > + struct sighand_struct *sighand; > > + unsigned long flags; > > +}; > > signalfd_lockctx is "private" to signalfd_lock/signalfd_unlock. But > l

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 15:37:16 -0800 (PST) Christoph Lameter <[EMAIL PROTECTED]> wrote: > ... > > --- /dev/null 1970-01-01 00:00:00.0 + > +++ linux-2.6.21-rc3-mm2/include/linux/quicklist.h2007-03-16 > 02:19:15.0 -0700 > @@ -0,0 +1,95 @@ > +#ifndef LINUX_QUICKLIST_H > +#defin

Re: [patch 2/13] signal/timer/event fds v7 - signalfd core ...

2007-03-19 Thread Oleg Nesterov
On 03/19, Davide Libenzi wrote: > > +struct signalfd_lockctx { > + struct task_struct *tsk; > + struct sighand_struct *sighand; > + unsigned long flags; > +}; signalfd_lockctx is "private" to signalfd_lock/signalfd_unlock. But lk->sighand is used only by signalfd_lock(). I'd suggest to

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 16:57:55 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Mon, 19 Mar 2007, Andrew Morton wrote: > > > Has it been proven that quicklists are superior to simply going direct to > > the > > page allocator for these pages? > > Yes. Sigh. Please provide proof tha

unify encoding of files in Documentation

2007-03-19 Thread Till Maas
Hiyas, at the moment, some file in Documentation are utf-8 encoded and some are latin1 encoded. Therefore I propose to change the default encoding to utf-8, because this is the encoding that may current linux distributions use. I can send a patch, if required. If you want to change the encoding

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-19 Thread Éric Piel
19.03.2007 22:28, Dmitry Torokhov wrote/a écrit: On 3/15/07, Éric Piel <[EMAIL PROTECTED]> wrote: Ok, so let me summarize: There are two kinds of keys on those laptops (for which we are not sure about the keycode that it should generate): * Laptop screen on/off * Display output selection (for

Re: [2.6 patch] x25_forward_call(): fix NULL dereferences

2007-03-19 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Mon, 19 Mar 2007 10:24:03 +0100 > This patch fixes two NULL dereferences spotted by the Coverity checker. > > For a better understanding, the "diff -uwp" output (that ignores the > indentation changes) is: I'll apply this, thanks Adrian. - To unsubscr

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Rusty Russell
On Mon, 2007-03-19 at 11:38 -0700, Linus Torvalds wrote: > > On Mon, 19 Mar 2007, Eric W. Biederman wrote: > > > > True. You can use all of the call clobbered registers. > > Quite often, the biggest single win of inlining is not so much the code > size (although if done right, that will be sma

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Christoph Lameter
On Mon, 19 Mar 2007, Andrew Morton wrote: > Has it been proven that quicklists are superior to simply going direct to the > page allocator for these pages? Yes. > Would it provide a superior solution if we were to a) stop zeroing out the > pte's when doing a fullmm==1 teardown and b) go direct

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Mon, 19 Mar 2007 16:53:29 -0700 > Would it provide a superior solution if we were to a) stop zeroing out the > pte's when doing a fullmm==1 teardown and b) go direct to the page allocator > for these pages? While you could avoid zero'ing them out, you

Re: [QUICKLIST 1/5] Quicklists for page table pages V3

2007-03-19 Thread Andrew Morton
On Mon, 19 Mar 2007 15:37:16 -0800 (PST) Christoph Lameter <[EMAIL PROTECTED]> wrote: > This patchset introduces an arch independent framework to handle lists > of recently used page table pages to replace the existing (ab)use of the > slab for that purpose. > > 1. Proven code from the IA64 arch.

[patch 4/13] signal/timer/event fds v7 - signalfd wire up x86_64 arch ...

2007-03-19 Thread Davide Libenzi
This patch wire the signalfd system call to the x86_64 architecture. Signed-off-by: Davide Libenzi - Davide Index: linux-2.6.21-rc3.quilt/include/asm-x86_64/unistd.h === --- linux-2.6.21-rc3.quilt.orig/include/asm-x86_64/unist

[patch 8/13] signal/timer/event fds v7 - timerfd wire up x86_64 arch ...

2007-03-19 Thread Davide Libenzi
This patch wire the timerfd system call to the x86_64 architecture. Signed-off-by: Davide Libenzi - Davide Index: linux-2.6.21-rc3.quilt/arch/x86_64/ia32/ia32entry.S === --- linux-2.6.21-rc3.quilt.orig/arch/x86_64/ia32/ia32ent

[patch 5/13] signal/timer/event fds v7 - signalfd compat code ...

2007-03-19 Thread Davide Libenzi
This patch implement the necessary compat code for the signalfd system call. Signed-off-by: Davide Libenzi - Davide Index: linux-2.6.21-rc3.quilt/fs/compat.c === --- linux-2.6.21-rc3.quilt.orig/fs/compat.c 2007-03-19 16:03:

[patch 10/13] signal/timer/event fds v7 - eventfd core ...

2007-03-19 Thread Davide Libenzi
This is a very simple and light file descriptor, that can be used as event wait/dispatch by userspace (both wait and dispatch) and by the kernel (dispatch only). It can be used instead of pipe(2) in all cases where those would simply be used to signal events. Their kernel overhead is much lower tha

[patch 11/13] signal/timer/event fds v7 - eventfd wire up i386 arch ...

2007-03-19 Thread Davide Libenzi
This patch wire the eventfd system call to the i386 architecture. Signed-off-by: Davide Libenzi - Davide Index: linux-2.6.21-rc3.quilt/arch/i386/kernel/syscall_table.S === --- linux-2.6.21-rc3.quilt.orig/arch/i386/kernel/syscal

[patch 12/13] signal/timer/event fds v7 - eventfd wire up x86_64 arch ...

2007-03-19 Thread Davide Libenzi
This patch wire the eventfd system call to the x86_64 architecture. Signed-off-by: Davide Libenzi - Davide Index: linux-2.6.21-rc3.quilt/arch/x86_64/ia32/ia32entry.S === --- linux-2.6.21-rc3.quilt.orig/arch/x86_64/ia32/ia32ent

  1   2   3   4   5   >