[PATCH] [qla2xxx] Remove duplicate pci_disable_device() call
On the path qla2x00_probe_one() - probe_failed - qla2x00_free_device(),
pci_disable_device() is executed twice, once in qla2x00_free_device()
and once in qla2x00_probe_one().
This patch removes the unnecessary call.
Signed-off-by:
On Mon, 2007-03-26 at 13:36 +0800, Shaohua Li wrote:
Hi,
On Sat, 2007-03-24 at 03:47 -0400, Adam Belay wrote:
This patch adds the 'menu' governor, as was described in my first email.
+/**
+ * menu_select - selects the next idle state to enter
+ * @dev: the CPU
+ */
+static int
On 3/27/07, Jiri Slaby [EMAIL PROTECTED] wrote:
johann deneux napsal(a):
On 3/27/07, Jiri Slaby [EMAIL PROTECTED] wrote:
Dmitry Torokhov napsal(a):
On Wednesday 21 March 2007 18:03, johann deneux wrote:
I have forgotten the details of ioctl: Wouldn't the
following work?
No, at least,
johann deneux napsal(a):
On 3/27/07, Jiri Slaby [EMAIL PROTECTED] wrote:
johann deneux napsal(a):
Are we
misunderstanding eachother maybe? By vector I mean a triplet of
numbers, when you say torques and forces vector, do you mean that
each effect is composed of a bunch of torques?
Ok,
Jiri Kosina schrieb:
On Sun, 18 Mar 2007, Thomas Meyer wrote:
Appletouch is bound to the device:
OK, so the quirk actually works fine ...
Yes, it works fine, but...
But the X server touchpad driver doesn't work anymore, that means i
can't emulte a right click by tapping
On 3/27/07, Jiri Slaby [EMAIL PROTECTED] wrote:
Ok, so how to deal with these devices? Does anybody have some idea? That's
what I was talking about somewhere in the beginning of this thread, the raw
values, because it seems too specific for letting kernel to cope with each
of these devices
On Tue, Mar 27, 2007 at 03:44:01PM -0700, Zach Brown wrote:
The user can generate console output if they cause do_mmap() to fail during
sys_io_setup(). This was seen in a regression test that does exactly that by
spinning calling mmap() until it gets -ENOMEM before calling io_setup().
We
On Mon, Mar 26, 2007 at 07:32:00PM -0400, Robert P. J. Day wrote:
the output from a short script i wrote, locating all CONFIG_
variables in makefiles that don't appear to exist in any Kconfig file
anywhere in the source tree.
first, from the drivers/ directory:
...
= ZS =
Williams, Mitch A [EMAIL PROTECTED] writes:
Doh! I was reading the code wrong. We only mask if we're still
handling a previous interrupt on the same vector. My bad.
However, I can't really see where mask() is used outside of that
instance. Which then leads us back to the question: do we
Hi Ingo,
At Tue, 27 Mar 2007 21:14:20 +0200,
Ingo Molnar wrote:
* Satoru Takeuchi [EMAIL PROTECTED] wrote:
Hi Ingo and all,
When I was executing massive interactive processes, I found that some
of them occupy CPU time and the others hardly run.
yeah.
I also attach the test
Herbert Poetzl wrote:
On Sat, Mar 24, 2007 at 12:19:06PM -0800, Andrew Morton wrote:
Or change the reclaim code so that a page which hasn't
been referenced from a process within its hardware
container is considered unreferenced (so it gets reclaimed).
that might easily lead to some
On Tue, Mar 27, 2007 at 07:17:49PM +0200, Cornelia Huck wrote:
On Tue, 27 Mar 2007 11:25:57 +0200,
Kay Sievers [EMAIL PROTECTED] wrote:
Checking the uevent return value, will not prevent any malfunction,
usually this kind of error handling just prevents bringing up a
whole subsystem, or
So I've been putting off this change for awhile since there's been so
much churn in the timekeeping code, but now looking at both -mm and -rt
it seems there is only a minimal amount of timekeeping changes pending,
so I wanted to send this out there for comments before pushing it to -mm
Linux _will_ write all modified data to permanent storage locations.
Since 2.6.17 it will do this regardless of msync(). Before 2.6.17 you
do need msync() to enable data to be written back.
But it will not start I/O immediately, which is not a requirement in
the standard, or at least it's
On Mar 27 2007 17:07, Paweł Sikora wrote:
The recent gcc (3.4/4.x) optimizer inlines functions across
sections which is definitely not we want, e.g. inlining
functions from .init.text section.
I think, the `__init' macro needs `noinline' attribute and all
An function from the .init section
On Tue, 2007-03-27 at 08:34 -0700, Randy Dunlap wrote:
On Tue, 27 Mar 2007 13:40:45 +0800 Wu, Bryan wrote:
On Mon, 2007-03-26 at 22:27 -0700, Randy Dunlap wrote:
On Tue, 27 Mar 2007 01:17:06 -0400 Mike Frysinger wrote:
On 3/27/07, Paul Mundt [EMAIL PROTECTED] wrote:
On Tue,
In that case, Bryan may like to know that git, mercurial (IIRC),
and quilt have patchbomb tools. Also GregKH has one somewhere (he
can tell you where). And Paul Jacksone has one at
http://www.speakeasy.org/~pj99/sgi/sendpatchset
Thanks a lot, I will try on my side. And one more
On Tuesday March 27, [EMAIL PROTECTED] wrote:
On Tue, Mar 27, 2007 at 11:40:48AM -0700, Phy Prabab wrote:
Hello,
I am currently running 2.6.21-rc5 and I am seeing quite a bit of this
message in my log files:
kernel: rpcsvc: received unknown control message:-2144992132/-1
This
On Tuesday 27 March 2007 18:16, Len Brown wrote:
On Tuesday 27 March 2007 17:34, Linus Torvalds wrote:
On Tue, 27 Mar 2007, Len Brown wrote:
I think the only fool-proof way to do this automatically is to
Why not just take the known-good CPUID signature?
Screw firmware or ACPI
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
drivers/char/Kconfig | 33 +
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 3429ece..d0c978f 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -386,6 +386,39 @@ config
Andi Kleen wrote:
init functions should only ever be called from other init functions.
So this should not happen. If it happens the annotations need to be fixed.
I've seen some versions of gcc inline weak functions too.
J
-
To unsubscribe from this list: send the line unsubscribe
On Mar 27, 2007, at 12:04 PM, Adam Belay wrote:
On Mon, 2007-03-26 at 13:36 +0800, Shaohua Li wrote:
Hi,
On Sat, 2007-03-24 at 03:47 -0400, Adam Belay wrote:
This patch adds the 'menu' governor, as was described in my first
email.
+/**
+ * menu_select - selects the next idle state to
On Mon, Mar 26, 2007 at 09:38:15AM +0900, Noriaki TAKAMIYA wrote:
Hi,
Sun, 25 Mar 2007 08:55:21 -0700
[Subject: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL]
[USB] fixed to skip NULL entry in struct serial usb_serial_port.]
Greg KH [EMAIL PROTECTED] wrote...
Yes,
On Tuesday 27 March 2007 20:05:24 Pete Zaitcev wrote:
On Tue, 27 Mar 2007 13:15:14 -0400 (EDT), Alan Stern [EMAIL PROTECTED]
wrote:
Suspend to disk still causes virtual replugging and I think that
controller is reset and will unplug/replug devices anyway
Resolving this problem is
Marcel Holtmann wrote:
please don't take the transport layers into account when designing the
HID bus. They have nothing to do with the upper layer. Especially the
upper layer shouldn't care at all if the actual HID reports are sent
over USB or Bluetooth.
I am sorry for I see this mail so
On Fri, Mar 23, 2007 at 07:13:21PM +, Alan Cox wrote:
For reference this is what I am currently using with 2.6.21-rc4-mm1 and
it is working for all my test cases so far: Its basically Kyle's patch
with a libata switch to turn it on/off and some minor fixups from
the original patch as
On Wed, Mar 28, 2007 at 01:08:52AM +0100, Matthew Garrett wrote:
ata3.01: ata_hpa_resize 1: sectors = 234441648, hpa_sectors = 0
^
Does this just indicate the lack of an hpa? If so, the
/* if no hpa, both should be equal */
comment
On Wed, Mar 28, 2007 at 01:16:10AM +0100, Matthew Garrett wrote:
comment seems to be wrong (or, alternatively, it's the
ata_read_native_max_address_ext call that's failing and returning
garbage? I'll look into that)
It's ata_read_native_max_address_ext failing, and it's fine if I use
ahci
[ This patch needs to get into 2.6.21, as it fixes a serious bug
introduced soon after 2.6.20 ]
Commit 62f96cb01e8de7a5daee472e540f726db2801499 introduced per-devices
queues and locks, which was fine as far as it went, but left in place
a global which controlled access to submitting requests to
Michael Ellerman [EMAIL PROTECTED] writes:
Although it might be nice to do a printk before BUG'ing, it's really not
necessary, and it complicates the code.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
Signed-off-by: Michael Ellerman [EMAIL PROTECTED]
---
drivers/pci/msi.c | 19
Michael Ellerman [EMAIL PROTECTED] writes:
Although it might be nice to do a printk before BUG'ing, it's really not
necessary, and it complicates the code.
The behaviour has changed slightly, in that before we set a flag if the irq
had an action, and continued freeing the other irqs. But as
Kay Sievers ([EMAIL PROTECTED]) said:
If you *do* try to use one of these names, the rename will succeed...
partway. The link in /sys/class/net is renamed, the directory is
not (as it obviously can't rename on top of whatever is already there.)
Various networking tools then break in assorted
Michael Ellerman [EMAIL PROTECTED] writes:
Although it might be nice to do a printk before BUG'ing, it's really not
necessary, and it complicates the code.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
Eric
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of
Eric W. Biederman wrote:
Sid Boyce [EMAIL PROTECTED] writes:
This is what I've got so far on the first boot, I shall have to check the
manpage for git-bisect again to see if there is anything else to be added,
nothing enlightening seen so far - further reboots to be done.
I'm a
Michael Ellerman [EMAIL PROTECTED] writes:
Although it might be nice to do a printk before BUG'ing, it's really not
necessary, and it complicates the code.
The behaviour has changed slightly, in that before we set a flag if the irq
had an action, and continued freeing the other irqs. But as
BIT macro cleanup,now in bitops.h
Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED]
---
arch/ppc/platforms/chestnut.c |1
drivers/edac/edac_mc.h |2 -
drivers/i2c/busses/i2c-pxa.c| 55 ++--
Thomas,
Is this failure specific to NO_HZ, and that is why the nolapic_timer fix is
i386 only?
I'm running 2.6.21-rc5 an nx6325 here in 64-bit mode and I don't see the
dramatic
boot failure described earlier in this thread.
However, I have observed that when running on battery,
the LOC falls
I am not sure where to post this, maybe you can direct me what to do, if
anything.
We have two computers running slackware for amd64 version 11.0.
Tonight we compiled mplayer on each of the systems.
On the first, everything compiled fine--it has a core 2 duo cpu and is
running a stock kernel
On Tuesday 27 March 2007 23:28, Len Brown wrote:
Thomas,
Is this failure specific to NO_HZ, and that is why the nolapic_timer fix is
i386 only?
I'm running 2.6.21-rc5 an nx6325 here in 64-bit mode and I don't see the
dramatic
boot failure described earlier in this thread.
However, I
On Wed, Mar 28, 2007 at 04:26:05AM +0100, Sid Boyce wrote:
Eric W. Biederman wrote:
Sid Boyce [EMAIL PROTECTED] writes:
This is what I've got so far on the first boot, I shall have to check the
manpage for git-bisect again to see if there is anything else to be added,
nothing
On Tue, Mar 27, 2007 at 11:17:43PM -0400, Bill Nottingham wrote:
Kay Sievers ([EMAIL PROTECTED]) said:
If you *do* try to use one of these names, the rename will succeed...
partway. The link in /sys/class/net is renamed, the directory is
not (as it obviously can't rename on top of whatever
Michael Ellerman [EMAIL PROTECTED] writes:
For the MSI-X case we do exactly the same logic in pci_disable_msix() and
msi_remove_pci_irq_vectors(), so consolidate them.
msi_remove_pci_irq_vectors() wasn't setting dev-first_msi_irq to 0, but
I think it should have been, so the consolidated
Michael Ellerman [EMAIL PROTECTED] writes:
When freeing MSIs and MSI-Xs, we BUG_ON() if the irq has not been
freed, ie. if it still has an action. We can consolidate all of these
BUG_ON()s into msi_free_irqs() as all the code paths lead there almost
immediately anyway.
Acked-by: Eric W.
Michael Ellerman [EMAIL PROTECTED] writes:
Move EXPORT_SYMBOL()s near their definition.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Michael Ellerman [EMAIL PROTECTED] writes:
We don't need a special cache just for msi descriptors. They're not
particularly large, under 100 bytes for sure, and don't seem to require any
special alignment etc. On most systems there will be relatively few MSIs,
and hence we waste most of a
On Wed, Mar 28, 2007 at 02:16:08AM +0100, Matthew Garrett wrote:
It's ata_read_native_max_address_ext failing, and it's fine if I use
ahci rather than ata_piix, so I'll just chalk this up to Apple's
firmware being broken (again) and putting the hardware into some sort of
I can't believe
Add IRQF_IRQPOLL for the timer interrupt on IA64.
Signed-off-by: Bernhard Walle [EMAIL PROTECTED]
---
arch/ia64/kernel/time.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.21-rc5-mm2/arch/ia64/kernel/time.c
Tue, 27 Mar 2007 15:51:39 -0700
[Subject: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL]
[USB] fixed to skip NULL entry in struct serial usb_serial_port.]
Greg KH [EMAIL PROTECTED] wrote...
I think so. But I wonder if usb_get_serial_port_data() should check
the
On Tuesday 27 March 2007 17:34, johann deneux wrote:
What about adding a member to ff_effect which would be the number of the
motor?
We can't change the layout of ff_effect too much though, so we have to
find unused bits and put them to work.
For instance, we could replace
__u16 type;
Michael Ellerman [EMAIL PROTECTED] writes:
pci_enable_msi() and pci_enable_msix() both search for the MSI/MSI-X
capability, we can fold this into pci_msi_supported() by passing the
type in.
Update the code to match the comment for pci_msi_supported(). That is
it returns 0 on success, and
On Tue, 2007-03-27 at 22:45 -0600, Eric W. Biederman wrote:
Michael Ellerman [EMAIL PROTECTED] writes:
pci_enable_msi() and pci_enable_msix() both search for the MSI/MSI-X
capability, we can fold this into pci_msi_supported() by passing the
type in.
Update the code to match the
Michael Ellerman [EMAIL PROTECTED] writes:
I don't think it's that confusing. I agree it was a bit weird that
previously it was explicitly checking for 0, so I fixed that.
The previous case was clearer. This isn't a please do some work
for me function, where we expect occasional failure and
On another thought if we want to keep the return code we should
probably rename it pci_msi_verify(). Or something like that
so it is clear we are not asking if it is supported a question
with a boolean answer. But merely verifying that it is supported.
At which point if the verification
On Tue, 2007-03-27 at 23:20 -0600, Eric W. Biederman wrote:
Michael Ellerman [EMAIL PROTECTED] writes:
I don't think it's that confusing. I agree it was a bit weird that
previously it was explicitly checking for 0, so I fixed that.
The previous case was clearer. This isn't a please do
Michael Ellerman [EMAIL PROTECTED] writes:
Add an arch_msi_supported(), which gives archs a chance to check the input
to pci_enable_msi/x. For MSI-X this routine might need the entry array, so
pass it in. For plain MSI, NULL is passed, the arch routine needs to cope
with that. Propagate the
On Tue, Mar 27, 2007 at 02:27:45PM -0400, Jeff Dike wrote:
These are all 2.6.22 material.
err, I meant 2.6.21...
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Michael Ellerman [EMAIL PROTECTED] writes:
Consolidate precondition checks into a single if statement.
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Michael Ellerman [EMAIL PROTECTED] writes:
When freeing an MSI-X in msi_free_irq(), the irq must have already been
free'd (otherwise we'd hit the BUG_ON), and in the process will have been
masked or otherwise disabled by the irq chip methods. So there's no
reason to mask again in the MSI
On Mon, 2007-03-26 at 15:12 +0300, Pekka J Enberg wrote:
From: Pekka Enberg [EMAIL PROTECTED]
There's just no sane way to revoke shared memory mappings for NOMMU so lets
disable the thing completely when CONFIG_MMU=n.
Cc: Bryan Wu [EMAIL PROTECTED]
Cc: David Howells [EMAIL PROTECTED]
There is a tiny probability that the return value from vtime(time_t *t) is
different than the value stored in *t
Using a temporary variable solves the problem and gives a faster code.
17: 48 85 fftest %rdi,%rdi
1a: 48 8b 05 00 00 00 00mov0(%rip),%rax#
Hi all,
The CELF Embedded Linux Conference is less than a month away!
The conference is coming up on April 17, 18, and 19 in San Jose, California.
If you haven't already done so, PLEASE visit the conference website -
http://www.celinux.org/elc2007/ - to check out the session list and
register
From: Pekka Enberg [EMAIL PROTECTED]
As NOMMU does not include fs/revoke.c, we need to provide a stub for
generic_file_revoke() so that filesystems using it compile.
Cc: Bryan Wu [EMAIL PROTECTED]
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
include/linux/fs.h |4
1 file changed,
Michael Ellerman [EMAIL PROTECTED] writes:
The msi descriptors are linked together with what looks a lot like
a linked list, but isn't a struct list_head list. Make it one.
The only complication is that previously we walked a list of irqs, and
got the descriptor for each with get_irq_msi().
Michael Ellerman [EMAIL PROTECTED] writes:
It's an arch detail whether MSI irqs need to be masked using the PCI
MSI registers.
Agreed. It isn't an arch detail that they need to be unmasked in
the pci configuration space.
I assume this patch is motivated just to make arch support easier
and
On Sat, Mar 24, 2007 at 06:29:59PM +0100, Ingo Molnar wrote:
* Nikita Danilov [EMAIL PROTECTED] wrote:
Indeed, this technique is very well known. E.g.,
http://citeseer.ist.psu.edu/anderson01sharedmemory.html has a whole
section (3. Local-spin Algorithms) on them, citing papers from
+++ linux-2.6/drivers/s390/char/sclp_confmgm.c
Can we get less cyptic name?
Would you like to see sclp_configuration_management.c?
+static void sclp_conf_receiver_fn(struct evbuf_header *evbuf)
+{
+ struct conf_mgm_data *cdata;
+
+ cdata = (struct conf_mgm_data *)(evbuf + 1);
On Sat, Mar 24, 2007 at 01:41:28PM -0800, Andrew Morton wrote:
On Fri, 23 Mar 2007 11:32:44 +0100 Nick Piggin [EMAIL PROTECTED] wrote:
I'm not as concerned about the contended performance of spinlocks
The contended case matters. Back in 2.5.something I screwed up the debug
version of
Hi,
If a Linux process opens and reads a file A, then it closes the file.
Will Linux keep the file A's data in cache for a while in case another
process opens and reads the same in a short time? I think that is what
I heard before.
But after I digged into the kernel code, I am confused.
When a
Jesse Huang wrote:
Dear all:
Would someone tell me the current status of IP1000A Linux Driver?
Would it be putted into Linux Kernel or not?
I forgot what the status of this was? Didn't it need some cleanups?
Maybe Francois has a better memory than me.
Jeff
-
To unsubscribe from
Jeff Garzik [EMAIL PROTECTED] :
Jesse Huang wrote:
Dear all:
Would someone tell me the current status of IP1000A Linux Driver?
Would it be putted into Linux Kernel or not?
I forgot what the status of this was? Didn't it need some cleanups?
More cleanups than what it already had would be
From: Jay Cliburn [EMAIL PROTECTED]
The original vendor driver contained a private ether_crc_le() function
that produced an inverted crc. When we changed to the kernel version of
ether_crc_le(), we neglected to undo the inversion. Let's do it now.
Discovered by and patch proffered by Jose
On Wed, 28 Mar 2007 01:00:24 +0200
Adrian Bunk [EMAIL PROTECTED] wrote:
Subject: atl1 net driver: problem with sockets
References : http://lkml.org/lkml/2007/3/21/248
Submitter : Jose Alberto Reguero [EMAIL PROTECTED]
Patch : http://marc.info/?l=linux-netdevm=117502041808665w=2
黃建興-Jesse wrote:
Dear Sirs,
I have got the status.
I appreciate your contribution to this driver.
And if anything I can help or any update, please let me know.
Someone needs to send me a signed-off patch.
Jeff
-
To unsubscribe from this list: send the line unsubscribe
Jay Cliburn wrote:
From: Jay Cliburn [EMAIL PROTECTED]
The original vendor driver contained a private ether_crc_le() function
that produced an inverted crc. When we changed to the kernel version of
ether_crc_le(), we neglected to undo the inversion. Let's do it now.
Discovered by and patch
Currently the size of the per-cpu region reserved to save crash
notes is set by the per-architecture value MAX_NOTE_BYTES. Which
in turn is currently set to 1024 on all supported architectures.
While testing ia64 I recently discovered that this value is
in fact too small. The particular setup I
On Wed, Mar 28, 2007 at 03:18:58PM +0900, Simon Horman wrote:
Currently the size of the per-cpu region reserved to save crash
notes is set by the per-architecture value MAX_NOTE_BYTES. Which
in turn is currently set to 1024 on all supported architectures.
While testing ia64 I recently
601 - 676 of 676 matches
Mail list logo
