Re: [PATCH -mm 0/5] LZO and swap write failure patches for -mm

2007-06-04 Thread Andrew Morton
On Tue, 5 Jun 2007 11:00:05 +0530 "Nitin Gupta" <[EMAIL PROTECTED]> wrote: > Andrew, Andrian, > > If you really have the opinion of not going for major cleanups, > optimizations outside of original LZO code (basically a fork), then > there is no point in me continuing this work. err, my LZO

Re: alpha modpost warnings

2007-06-04 Thread Sam Ravnborg
On Mon, Jun 04, 2007 at 01:11:07PM +0300, Meelis Roos wrote: > I am building current 2.6.22-rc3+git for my alpha (Eiger) and get these. > > MODPOST vmlinux > WARNING: "saved_config" [arch/alpha/kernel/built-in] is COMMON symbol > WARNING: arch/alpha/kernel/built-in.o(.text+0x7d2c): Section

Re: [PATCH -mm 0/5] LZO and swap write failure patches for -mm

2007-06-04 Thread Nitin Gupta
Andrew, Andrian, If you really have the opinion of not going for major cleanups, optimizations outside of original LZO code (basically a fork), then there is no point in me continuing this work. If you think otherwise, please let me know and I will post a newer version with improvements from

Re: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)

2007-06-04 Thread Pekka Enberg
Christoph Lameter wrote: SLUB: Return ZERO_SIZE_PTR for kmalloc(0) V3 Instead of returning the smallest available object return ZERO_SIZE_PTR. A ZERO_SIZE_PTR can be legitimately used as an object pointer as long as it is not deferenced. The dereference of ZERO_SIZE_PTR causes a distinctive

Re: default charset for linux-kernel code?

2007-06-04 Thread Sam Ravnborg
On Tue, Jun 05, 2007 at 01:11:15AM +0200, Adrian Bunk wrote: > On Mon, Jun 04, 2007 at 11:36:45PM +0200, Sam Ravnborg wrote: > > In private mail I have discussed with a person the default charset > > to use for source code and in particular Kconfig files in the kernel. > > I recall to have seen

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 23:18 -0500, Matt Mackall wrote: > On Tue, Jun 05, 2007 at 12:31:15PM +1000, Rusty Russell wrote: > > Does this solve it for you? > > Nope. Doesn't accept input and hogs the CPU with lots of system time. Dumb question: did you replace both the module and the launcher?

To swap or not to swap?

2007-06-04 Thread Mike Richards
Here's something that's been bugging me for a while now... I have several Linux servers that have been given enough RAM that they rarely ever use any swap space. For example, here's the typical output of uptime and free: [EMAIL PROTECTED] uptime; free 03:55:33 up 225 days, 17:34, 0 users,

Problem with /proc/diskstats on RHEL4

2007-06-04 Thread Marc Chiarini
Hi all, Wondering if folks can help me out. I have been doing some collection of statistics on my Redhat boxes and have noted that the read values in /proc/diskstats *very* rarely change. Things like # of read requests, reads merged, #bytes read, total time spent reading, are just basically

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Matt Mackall
On Tue, Jun 05, 2007 at 12:31:15PM +1000, Rusty Russell wrote: > Does this solve it for you? Nope. Doesn't accept input and hogs the CPU with lots of system time. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: 2.6.22-rc3 hibernate(?) disables SMART on ide

2007-06-04 Thread Mark Lord
David Greaves wrote: Mark Lord wrote: David Greaves wrote: I have 2 ide disks. If I enable SMART and hibernate/suspend2disk, SMART is disabled when I resume. Just a thought: This *may* be fixable at the drive, with "hdparm -K1". Thanks Mark, good idea. Just tried and it didn't help though

Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-04 Thread Andrew Morton
On Mon, 4 Jun 2007 21:00:18 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c > > index 544098d..9ec38e3 100644 > > --- a/drivers/usb/serial/io_ti.c > > +++ b/drivers/usb/serial/io_ti.c > > @@ -2351,7 +2351,7 @@ static int

Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-04 Thread Andrew Morton
On Mon, 04 Jun 2007 18:25:28 +0200 Yoann Padioleau <[EMAIL PROTECTED]> wrote: > > In a few files a function such as usb_submit_urb is taking GFP_KERNEL > as an argument whereas this function call is inside a > spin_lock_irqsave region of code. Documentation says that it must be > GFP_ATOMIC

Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-04 Thread Russell King
On Tue, Jun 05, 2007 at 01:52:38AM +0200, Martin Peschke wrote: > Andrew Morton wrote: > >On Sat, 2 Jun 2007 19:14:25 +0200 > >Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > >>statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch > >> > >>shows why

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Andreas Dilger
On Jun 04, 2007 19:03 -0700, Andrew Morton wrote: > What caused those inodes to be bad, anyway? Memory allocation failures? This can happen if e.g. NFS has a stale file handle - it will look up the inode by inum, but ext3_read_inode() will create a bad inode due to i_nlink = 0. Cheers, Andreas

Linux 2.6.22-rc4

2007-06-04 Thread Linus Torvalds
So -rc4 is out there now, hopefully shrinking the regression list further. The diffstat (for those that look at those kinds of things) tells the story: lots of small stuff to random files. I think the single biggest file change was the patch-checking script, along with some sparc64 fixes.

Re: Another missing RAM on x86_64

2007-06-04 Thread Robert Hancock
Reinaldo de Carvalho wrote: 1024MB dont detected on Notebook HP 2125 with kernel 2.6.21.3 BIOS-provided physical RAM map: BIOS-e820: - 0009dc00 (usable) BIOS-e820: 0009dc00 - 000a (reserved) BIOS-e820: 000d2000 - 0010

Re: [patch] CFS scheduler, -v14

2007-06-04 Thread Li Yu
lement the fairness as I want. I really confuse here. Would you like help me point out what's wrong in it? Any suggestion is welcome. Thanks in advanced. I think use wait_runtime is more clear. so I modify this script. #! /usr/bin/python # htucfs.py - Hard-To-Understand-CFS.py ;) # Wrote

Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes

2007-06-04 Thread Benjamin Herrenschmidt
On Mon, 2007-06-04 at 19:38 -0700, Davide Libenzi wrote: > > - I still think there's something wrong with dequeue_signal() being > > potentially called with a task different than current by signalfd, since > > __dequeue_signal() (among others) mucks around with current regardless. > > I'd love to

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Eric Sandeen
Vasily Averin wrote: After ext3 orphan list check has been added into ext3_destroy_inode() (please see my previous patch) the following situation has been detected: EXT3-fs warning (device sda6): ext3_unlink: Deleting nonexistent file (37901290), 0 Inode 0101a15b7840: orphan list check

Re: 2.6.22-rc: regression: no irda0 interface (2.6.21 was OK), smsc does not find chip

2007-06-04 Thread Andrey Borzenkov
On Tuesday 05 June 2007, Samuel Ortiz wrote: > (Adding Linus Walleij, who wrote part of the smsc driver, to Cc:) > > On Mon, Jun 04, 2007 at 06:33:56AM +0400, Andrey Borzenkov wrote: > > On Monday 04 June 2007, Samuel Ortiz wrote: > > > It seems that PnP tells us that the FIR port is at 0x2e8

Re: 2.6.22-rc: regression: no irda0 interface (2.6.21 was OK), smsc does not find chip

2007-06-04 Thread Andrey Borzenkov
On Monday 04 June 2007, Bjorn Helgaas wrote: > On Sunday 03 June 2007 02:16:05 am Andrey Borzenkov wrote: > > On Sunday 03 June 2007, Andrey Borzenkov wrote: > > > Under 2.6.22-rc I lost irda0 interface - smsc claims no device present. > > > Nothing was changed in setup except kernel version. > >

Re: [PATCH ext3/ext4] orphan list check on destroy_inode

2007-06-04 Thread Eric Sandeen
Vasily Averin wrote: Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue. Vasily, does your customer have this patch in place?

[PATCH] RAMFS NOMMU: missed POSIX UID/GID inode attribute checking

2007-06-04 Thread Bryan Wu
From: Bryan Wu <[EMAIL PROTECTED]> This bug was caught by LTP testcase fchmod06 on Blackfin platform. In the manpage of fchmod, "EPERM: The effective UID does not match the owner of the file, and the process is not privileged (Linux: it does not have the CAP_FOWNER capability)." But the ramfs

Re: lguest rebroken in 2.6.22-rc3-mm1

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 20:12 +0200, Andi Kleen wrote: > > > > > > Looks like this one got lost in rc3-mm1. > > > > Andi said that he fixed the zero-divide by other means? > > I determined it cannot happen in my source tree. When notsc > is passed TSC CPUID is cleared and sched-clock works. > > I

Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes

2007-06-04 Thread Davide Libenzi
On Tue, 5 Jun 2007, Benjamin Herrenschmidt wrote: > - I still think there's something wrong with dequeue_signal() being > potentially called with a task different than current by signalfd, since > __dequeue_signal() (among others) mucks around with current regardless. > I'd love to just make

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Matt Mackall
On Tue, Jun 05, 2007 at 10:18:54AM +1000, Rusty Russell wrote: > On Mon, 2007-06-04 at 12:37 -0500, Matt Mackall wrote: > > With 2.6.22-rc3-mm1, I've got a long-running video transcoding going > > on. In other windows, I'm compiling, reading email, etc. with no > > noticeable problems. > > > > If

Re: [patch] CFS scheduler, -v14

2007-06-04 Thread Li Yu
lement the fairness as I want. I really confuse here. Would you like help me point out what's wrong in it? Any suggestion is welcome. Thanks in advanced. #! /usr/bin/python # htucfs.py - Hard-To-Understand-CFS.py ;) # Wrote by Li Yu / 20070604 # # only support static load on UP.

Re: [RFC] Documentation/CodingStyle: Add rules for goto labels

2007-06-04 Thread H. Peter Anvin
Jeff Garzik wrote: >> >> So, it seems that we can reach an agreement. Any other comments or >> suggestions? >> Or can someone ack/merge this patch? > > Honestly, I think not reaching an agreement is a good thing. > > "style" is always ultimately in the eye of the beholder, and reasoned > people

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Rusty Russell
On Tue, 2007-06-05 at 10:19 +1000, Rusty Russell wrote: > On Mon, 2007-06-04 at 12:37 -0500, Matt Mackall wrote: > > With 2.6.22-rc3-mm1, I've got a long-running video transcoding going > > on. In other windows, I'm compiling, reading email, etc. with no > > noticeable problems. > > > > If I fire

[PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy

2007-06-04 Thread Masatake YAMATO
Hi, Patches appended to this mail fixes a bug explained below. There are two ways to fix the bug. PLEASE CHOOSE BETTER ONE. Look at wait_drive_not_busy in drivers/ide/ide-taskfile.c: static u8 wait_drive_not_busy(ide_drive_t *drive) { ide_hwif_t *hwif = HWIF(drive);

Another missing RAM on x86_64

2007-06-04 Thread Reinaldo de Carvalho
1024MB dont detected on Notebook HP 2125 with kernel 2.6.21.3 -- Reinaldo de Carvalho :~# uname -a Linux devil 2.6.21-amd64 #5 SMP Tue May 22 21:29:48 BRT 2007 x86_64 GNU/Linux :~# free -m total used free sharedbuffers cached Mem: 939

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Olof Johansson
On Tue, Jun 05, 2007 at 11:02:00AM +1000, Rusty Russell wrote: > On Mon, 2007-06-04 at 17:58 -0500, Olof Johansson wrote: > > > > Is this on hvc console? The hvc driver was recently modified to back off > > it's timing interval when there's no input, the max value is 2 seconds. > > > > See

Re: [RFC] Documentation/CodingStyle: Add rules for goto labels

2007-06-04 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 10:10:27AM +0800, WANG Cong wrote: > On Mon, Jun 04, 2007 at 01:57:51PM -0400, Jeff Garzik wrote: > >On Mon, Jun 04, 2007 at 10:43:51AM -0700, H. Peter Anvin wrote: > >> Jan Engelhardt wrote: > >> > On Jun 4 2007 10:27, H. Peter Anvin wrote: > >> >> Jeff Garzik wrote: > >>

Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes

2007-06-04 Thread Benjamin Herrenschmidt
> > > > - something calls recalc_sigpending_tsk() on thread A (for example, > >something try to sends it S2 which is blocked). There is no longer > >an active signal and thus TIF_SIGPENDING is cleared on thread A > > I agree. That's unquestionably a bug. We should *never* clear

Re: [RFC] Documentation/CodingStyle: Add rules for goto labels

2007-06-04 Thread WANG Cong
On Mon, Jun 04, 2007 at 01:57:51PM -0400, Jeff Garzik wrote: >On Mon, Jun 04, 2007 at 10:43:51AM -0700, H. Peter Anvin wrote: >> Jan Engelhardt wrote: >> > On Jun 4 2007 10:27, H. Peter Anvin wrote: >> >> Jeff Garzik wrote: >> >>> Seconded. All my code contains the goto label in the first column.

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Andrew Morton
On Mon, 04 Jun 2007 09:19:10 +0400 Vasily Averin <[EMAIL PROTECTED]> wrote: > After ext3 orphan list check has been added into ext3_destroy_inode() (please > see my previous patch) the following situation has been detected: > EXT3-fs warning (device sda6): ext3_unlink: Deleting nonexistent file

[PATCH] sundance: PHY address form 0, only for device ID 0x0200 (IP100A) (20070605)

2007-06-04 Thread Jesse Huang
From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: Search PHY address form 0, only for device ID 0x0200 (IP100A). Other device are from PHY address 1. Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> --- drivers/net/sundance.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-)

Re: [PATCH ext3/ext4] orphan list check on destroy_inode

2007-06-04 Thread Andrew Morton
On Mon, 04 Jun 2007 09:18:55 +0400 Vasily Averin <[EMAIL PROTECTED]> wrote: > Customers claims to ext3-related errors, investigation showed that ext3 > orphan list has been corrupted and have the reference to non-ext3 inode. The > following debug helps to understand the reasons of this issue. >

[PATCH] sundance: PHY address form 0, only for device ID 0x0200 (IP100A) (20070605)

2007-06-04 Thread Jesse Huang
From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: Search PHY address form 0, only for device ID 0x0200 (IP100A). Other device are from PHY address 1. Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> --- drivers/net/sundance.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-)

Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes

2007-06-04 Thread Linus Torvalds
On Tue, 5 Jun 2007, Benjamin Herrenschmidt wrote: > > - something calls recalc_sigpending_tsk() on thread A (for example, >something try to sends it S2 which is blocked). There is no longer >an active signal and thus TIF_SIGPENDING is cleared on thread A I agree. That's unquestionably

Re: Intel's response Linux/MTRR/8GB Memory Support / Why doesn't the kernel realize the BIOS has problems and re-map appropriately?

2007-06-04 Thread Eric W. Biederman
"Yinghai Lu" <[EMAIL PROTECTED]> writes: > On 6/4/07, Eric W. Biederman <[EMAIL PROTECTED]> wrote: >> >> Exactly, and given that this is a fairly easy thing to do, and that >> occasionally we see systems where this happens (even if their BIOS is >> later fixed). It is likely worth it for someone

Re: [RFC] Documentation/CodingStyle: Add rules for goto labels (-v2)

2007-06-04 Thread WANG Cong
On Mon, Jun 04, 2007 at 12:02:28PM -0700, Jeremy Fitzhardinge wrote: >Sam Ravnborg wrote: >> If local(__label__) really so widely used in the kernel that it deserves >> a place in coding-style? >> A quick grep did not say so. >> > >Probably not, and its use shouldn't be (even tacitly)

[PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes

2007-06-04 Thread Benjamin Herrenschmidt
The story starts with... We've been seeing some occasional reports of -ERESTARTSYS and friends being returned to userland from syscalls like accept(). After some digging, we beleive that the signal code is inherently racy vs. the way one task (or interrupt) can cause another task TIG_SIGPENDING

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Stephen Rothwell
On Tue, 05 Jun 2007 11:02:00 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > See b791072ba3c3b29bab1890963bde52eb944a8451 for the changes in question. > > Hmm, I thought that was only supposed to happen for "interruptless" > consoles? The comment certainly says it only applies to polled

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 17:58 -0500, Olof Johansson wrote: > On Mon, Jun 04, 2007 at 12:37:10PM -0500, Matt Mackall wrote: > > With 2.6.22-rc3-mm1, I've got a long-running video transcoding going > > on. In other windows, I'm compiling, reading email, etc. with no > > noticeable problems. > > > >

Re: Intel's response Linux/MTRR/8GB Memory Support / Why doesn't the kernel realize the BIOS has problems and re-map appropriately?

2007-06-04 Thread Yinghai Lu
On 6/4/07, Eric W. Biederman <[EMAIL PROTECTED]> wrote: Exactly, and given that this is a fairly easy thing to do, and that occasionally we see systems where this happens (even if their BIOS is later fixed). It is likely worth it for someone to write up the patch and that compare MTRRs with

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-04 Thread William Lee Irwin III
From: Alan Cox <[EMAIL PROTECTED]> Date: Mon, 4 Jun 2007 14:30:05 +0100 >> There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters for the >> Sparc platform I thought ? On Mon, Jun 04, 2007 at 02:22:43PM -0700, David Miller wrote: > The 32-bit sparc port has some but those PCMCIA controllers

Re: Intel's response Linux/MTRR/8GB Memory Support / Why doesn't the kernel realize the BIOS has problems and re-map appropriately?

2007-06-04 Thread Yinghai Lu
On 6/4/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > From their e-mail: > > Note before continuing: Debian* Linux Operating System is not an > officially, validated, tested Operating System for the Intel(R) Desktop > Board DG965WH > (see

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-04 Thread Jeff Garzik
On Mon, Jun 04, 2007 at 08:47:19AM +0100, Christoph Hellwig wrote: > The right fix is the depend on the new HAS_DMA (or whatever it's called) ACK... if the platform truly does not do DMA. > symbol. The proper long-term fix is to move calln to the dam mapping > functions from the core libata

Re: [RFC] Documentation/CodingStyle: Add rules for goto labels

2007-06-04 Thread Jeff Garzik
On Mon, Jun 04, 2007 at 10:43:51AM -0700, H. Peter Anvin wrote: > Jan Engelhardt wrote: > > On Jun 4 2007 10:27, H. Peter Anvin wrote: > >> Jeff Garzik wrote: > >>> Seconded. All my code contains the goto label in the first column. > >>> > >>> IMO any other goto label indentation is silly,

Re: DMI_MATCH patch in reboot.c for SFF Dell OptiPlex 745 - fixes hang on reboot

2007-06-04 Thread Robert Hancock
James Jarvis wrote: I trust this is the right list... The following patch enables reboot through BIOS on the Dell Optiplex 745 Small Form Factor base, on which reboot hangs. The larger form factor does not require this, hence the match on DMI_BOARD_NAME. --- arch/i386/kernel/reboot.c.orig

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-04 Thread Bartlomiej Zolnierkiewicz
Hello, On Sunday 03 June 2007, Sergei Shtylyov wrote: > Geller Sandor wrote: > Hello. > > > The log of a typical IDE reset is available here: > > > http://petra.hos.u-szeged.hu/~wildy/syslog.gz > > > This was the worst case: the IDE bus was resetted during the system > >

Re: [RFC 0/4] CONFIG_STABLE to switch off development checks

2007-06-04 Thread Robert Hancock
Dave Kleikamp wrote: I'm on Christoph's side here. I don't think it makes sense for any code to ask to allocate zero bytes of memory and expect valid memory to be returned. Would a compromise be to return a pointer to some known invalid region? This way the kmalloc(0) call would appear

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 12:37 -0500, Matt Mackall wrote: > With 2.6.22-rc3-mm1, I've got a long-running video transcoding going > on. In other windows, I'm compiling, reading email, etc. with no > noticeable problems. > > If I fire up lguest and leave it sitting at a shell prompt for a > couple

Re: 64-bit syscall ABI issue

2007-06-04 Thread H. Peter Anvin
David Miller wrote: > From: "Joseph S. Myers" <[EMAIL PROTECTED]> > Date: Mon, 4 Jun 2007 20:56:57 + (UTC) > > [ added linux-arch which is a great place to discuss these > kinds of issues. ] > >> What should the kernel syscall ABI be in such cases (any case where the >> syscall

Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects

2007-06-04 Thread Keshavamurthy, Anil S
On Mon, Jun 04, 2007 at 07:43:54PM -0400, Jeff Garzik wrote: > On Mon, Jun 04, 2007 at 04:06:49PM -0700, Keshavamurthy, Anil S wrote: > > On Mon, Jun 04, 2007 at 06:57:14PM -0400, Jeff Garzik wrote: > > > you should add logic to free resources here (or queue_work to free the > > > resources), if

Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

2007-06-04 Thread Martin Peschke
Andrew Morton wrote: On Sat, 2 Jun 2007 19:14:25 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch shows why __attribute__((weak)) is harmful because you don't see if a required non-weak implemtation is

Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects

2007-06-04 Thread Jeff Garzik
On Mon, Jun 04, 2007 at 04:06:49PM -0700, Keshavamurthy, Anil S wrote: > On Mon, Jun 04, 2007 at 06:57:14PM -0400, Jeff Garzik wrote: > > you should add logic to free resources here (or queue_work to free the > > resources), if the pool grows beyond a certain size. > Can be added as an add on,

Re: [PATCH] stop x86 ->sysdata abuse; introduce pci_sysdata

2007-06-04 Thread Keshavamurthy, Anil S
On Mon, Jun 04, 2007 at 05:05:51PM -0400, Jeff Garzik wrote: > > This patch introduces struct pci_sysdata to x86 and x86-64, and > converts the existing two users (NUMA, Calgary) to use it. > > This eliminates the conflict between NUMA and Calgary using the same > pointer for different uses, and

Re: [Intel-IOMMU 01/10] DMAR detection and parsing logic

2007-06-04 Thread Keshavamurthy, Anil S
On Mon, Jun 04, 2007 at 07:03:56PM -0400, Jeff Garzik wrote: > > Is there no way at all, other than ACPI, to find this stuff? This is as clean as possible without letting ACPI to parse this DMA remapping unit. The only thing we might be using is the acpi data struct. -Anil - To unsubscribe from

Re: [bug] very high non-preempt latency in context_struct_compute_av()

2007-06-04 Thread Paul Moore
On Monday 04 June 2007 5:39:00 pm Stephen Smalley wrote: > On Mon, 2007-06-04 at 17:11 -0400, Paul Moore wrote: > > I'm not an expert on the SELinux security server guts like the other > > people on the To/CC line of this thread, but here are my two cents on the > > issue above. > > > > From what

Re: 4Gb ram not showing up

2007-06-04 Thread Wakko Warner
Tom Moore wrote: > Thank you for the reply back. Your answer makes perfect sense to me, > and it is what I had suspected but was not sure about. The math seems > to indicate that 4Gb of ram plus 1Gb of PCI address space equals 5Gb of > memory space. So it does sound like I should have a

Re: default charset for linux-kernel code?

2007-06-04 Thread Adrian Bunk
On Mon, Jun 04, 2007 at 11:36:45PM +0200, Sam Ravnborg wrote: > In private mail I have discussed with a person the default charset > to use for source code and in particular Kconfig files in the kernel. > I recall to have seen some mails about UTF-8 but I would like to have > confirmed what is the

Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects

2007-06-04 Thread Keshavamurthy, Anil S
On Mon, Jun 04, 2007 at 06:57:14PM -0400, Jeff Garzik wrote: > On Mon, Jun 04, 2007 at 02:02:44PM -0700, [EMAIL PROTECTED] wrote: > > This patch provides a common interface for pre allocating and > > managing pool of objects. > > > > Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> >

Re: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)

2007-06-04 Thread Christoph Lameter
On Mon, 4 Jun 2007, Andrew Morton wrote: > > I'd say lets drop the DEVELKERNEL stuff and the warnings and go with > > ZERO_SIZE_PTR. The DEVELKERNEL patch has the danger that subtle changes > > occur at release time that we have not anticipated. > > OK. Here a version of the patch that drops

Re: [Intel-IOMMU 01/10] DMAR detection and parsing logic

2007-06-04 Thread Jeff Garzik
Is there no way at all, other than ACPI, to find this stuff? We would prefer to avoid hardware if the hardware enumeration is sane. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [Intel-IOMMU 01/10] DMAR detection and parsing logic

2007-06-04 Thread Keshavamurthy, Anil S
On Mon, Jun 04, 2007 at 06:54:21PM -0400, Jeff Garzik wrote: > On Mon, Jun 04, 2007 at 02:02:43PM -0700, [EMAIL PROTECTED] wrote: > > --- linux-2.6.22-rc3.orig/drivers/pci/Makefile 2007-06-04 > > 12:28:13.0 -0700 > > +++ linux-2.6.22-rc3/drivers/pci/Makefile 2007-06-04

Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects

2007-06-04 Thread Jeff Garzik
On Mon, Jun 04, 2007 at 02:02:44PM -0700, [EMAIL PROTECTED] wrote: > This patch provides a common interface for pre allocating and > managing pool of objects. > > Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> > --- > include/linux/respool.h | 43 +++ > lib/Makefile

Re: [Intel-IOMMU 01/10] DMAR detection and parsing logic

2007-06-04 Thread Jeff Garzik
On Mon, Jun 04, 2007 at 02:02:43PM -0700, [EMAIL PROTECTED] wrote: > --- linux-2.6.22-rc3.orig/drivers/pci/Makefile2007-06-04 > 12:28:13.0 -0700 > +++ linux-2.6.22-rc3/drivers/pci/Makefile 2007-06-04 12:33:15.0 > -0700 > @@ -20,6 +20,9 @@ > # Build the Hypertransport

Re: [bug] very high non-preempt latency in context_struct_compute_av()

2007-06-04 Thread James Morris
On Mon, 4 Jun 2007, Paul Moore wrote: > Okay, for some reason I thought someone had found a way to make > RCU "preemptable" through the real-time work, maybe I'm just confused > again :) It is preemptible in the RT kernel, but as Ingo points out, nothing should be even trying to do something

Re: [Q] Bio traversal trouble?

2007-06-04 Thread Rene Herman
On 06/04/2007 10:38 PM, Rene Herman wrote: On 06/04/2007 08:41 PM, Pekka Enberg wrote: [ Jens' email address updated to his oracle address ] We can see that we're reading 2048 bytes from port 0x300 and storing the data in memory location 0x8c1d2071 which causes the OOPS. What's surprising is

Re: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)

2007-06-04 Thread Andrew Morton
On Mon, 4 Jun 2007 15:39:08 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > > Btw, if I am again missing something totally obvious, could you please be so > > kind to send me a batch of the same pills that the smart people take. I am > > all > > out. > > Heheheh Mind boogling

Re: A kexec approach to hibernation

2007-06-04 Thread Pavel Machek
Hi! > > > To me, it seems a lot easier to get right than the current approaches. > > > > Well, you are certainly welcome to create the patch. "suspend3" name > > is still free, AFAICT. > > I could be sneaky and call it "hibernate". Probably nicer though to use the > name "kexec hibernate" to

Re: Interesting interaction between lguest and CFS

2007-06-04 Thread Olof Johansson
On Mon, Jun 04, 2007 at 12:37:10PM -0500, Matt Mackall wrote: > With 2.6.22-rc3-mm1, I've got a long-running video transcoding going > on. In other windows, I'm compiling, reading email, etc. with no > noticeable problems. > > If I fire up lguest and leave it sitting at a shell prompt for a >

Re: joydev.c and saitek cyborg evo force

2007-06-04 Thread Renato Golin
On 04/06/07, Jiri Kosina <[EMAIL PROTECTED]> wrote: sorry, don't fully understand - what do you mean by "got the messages but not the fix"? The range "detected" was 0 to 255 but both X and Y axis are reporting 4096. I think that the code in drivers/hid/hid-input.c: if ((device->quirks &

Re: Syslets, signals, and security

2007-06-04 Thread Alan Cox
> The problem is that you would need to reference count/lock them in every > syscall or ioctl or similar. Otherwise another thread > could change them in the middle of a syscall which wouldn't be > good. Doing this full reference counting would be probably somewhat > expensive with more locked

Re: A kexec approach to hibernation

2007-06-04 Thread Nigel Cunningham
Hi. On Mon, 2007-06-04 at 18:09 -0400, Jeremy Maitin-Shepard wrote: > I was hoping that everyone would like the idea so much that they would > rush to > implement it, so that I wouldn't have to try. (I haven't written much kernel > code before, and I have a number of other time-requiring

Re: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)

2007-06-04 Thread Christoph Lameter
On Mon, 4 Jun 2007, Pekka Enberg wrote: > Christoph Lameter wrote: > > That is another patchset. See > > http://marc.info/?l=linux-kernel=2=1=DEVELKERNEL=b > > Oh my, I am totally confused now. > > First you fix kmalloc(0) to be legal and safe. And then you want to > DEVEL_WARN_ON_ONCE when

RE: [-mm patch] the ASYNC_* options shouldn't be user visible

2007-06-04 Thread Williams, Dan J
> From: Adrian Bunk [mailto:[EMAIL PROTECTED] > > One caveat with this... md.o needs xor.o to be initialized first. > > Moving xor.o under lib/ means this assumption is broken since the > > top-level Makefile puts 'libs' after 'drivers'. > >... > > What about using a different initcall level? >

[Intel-IOMMU 09/10] Iommu Gfx workaround

2007-06-04 Thread anil . s . keshavamurthy
When we fix all the opensource gfx drivers to use the DMA api's, at that time we can yank this config options out. Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> --- Documentation/Intel-IOMMU.txt |5 + arch/x86_64/Kconfig | 11 +++ arch/x86_64/kernel/e820.c

[Intel-IOMMU 10/10] Iommu floppy workaround

2007-06-04 Thread anil . s . keshavamurthy
This config option (DMAR_FLPY_WA) sets up 1:1 mapping for the floppy device so that the floppy device which does not use DMA api's will continue to work. Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> --- arch/x86_64/Kconfig | 10 ++ drivers/pci/intel-iommu.c |

[Intel-IOMMU 07/10] Intel iommu cmdline option - forcedac

2007-06-04 Thread anil . s . keshavamurthy
Introduce intel_iommu=forcedac commandline option. This option is helpful to verify the pci device capability of handling physical dma'able address greater than 4G. Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt |7 +++

[Intel-IOMMU 08/10] DMAR fault handling support

2007-06-04 Thread anil . s . keshavamurthy
MSI interrupt handler registrations and fault handling support for Intel-IOMMU hadrware. Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> --- Documentation/Intel-IOMMU.txt | 17 +++ arch/x86_64/kernel/io_apic.c | 59 drivers/pci/intel-iommu.c | 194

[Intel-IOMMU 04/10] clflush_cache_range now takes size param

2007-06-04 Thread anil . s . keshavamurthy
Introduce the size param for clflush_cache_range(). Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> --- arch/x86_64/mm/pageattr.c |6 +++--- include/asm-x86_64/cacheflush.h |1 + 2 files changed, 4 insertions(+), 3 deletions(-) Index:

[Intel-IOMMU 05/10] IOVA allocation and management routines

2007-06-04 Thread anil . s . keshavamurthy
This code implements a generic IOVA allocation and management. As per Dave's suggestion we are now allocating IO virtual address from Higher DMA limit address rather than lower end address and this eliminated the need to preserve the IO virtual address for multiple devices sharing the

[Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects

2007-06-04 Thread anil . s . keshavamurthy
This patch provides a common interface for pre allocating and managing pool of objects. Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> --- include/linux/respool.h | 43 +++ lib/Makefile|1 lib/respool.c | 176

[Intel-IOMMU 03/10] PCI generic helper function

2007-06-04 Thread anil . s . keshavamurthy
When devices are under a p2p bridge, upstream transactions get replaced by the device id of the bridge as it owns the PCIE transaction. Hence its necessary to setup translations on behalf of the bridge as well. Due to this limitation all devices under a p2p share the same domain in a DMAR. We

Re: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)

2007-06-04 Thread Pekka Enberg
Christoph Lameter wrote: That is another patchset. See http://marc.info/?l=linux-kernel=2=1=DEVELKERNEL=b Oh my, I am totally confused now. First you fix kmalloc(0) to be legal and safe. And then you want to DEVEL_WARN_ON_ONCE when size is zero so people can fix their code? I don't get it.

[Intel-IOMMU 00/10] Intel IOMMU support

2007-06-04 Thread anil . s . keshavamurthy
Hi, We are pleased to announce the revised version of the Intel IOMMU driver. This driver incorporates several feedback received from Anid Kleen, David Miller and several others. Most notable changes from previous postings (apart from general code cleanup) are 1) Replaced linear linked

[Intel-IOMMU 01/10] DMAR detection and parsing logic

2007-06-04 Thread anil . s . keshavamurthy
This patch adds support for early detection and parsing of DMAR's reported to OS via ACPI tables. Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]> --- arch/x86_64/Kconfig | 11 + drivers/pci/Makefile |3 drivers/pci/dmar.c| 318

Re: [patch 2/9] Conditional Calls - Hash Table

2007-06-04 Thread Mathieu Desnoyers
* Andi Kleen ([EMAIL PROTECTED]) wrote: > On Fri, Jun 01, 2007 at 04:33:06PM -0400, Mathieu Desnoyers wrote: > > * Andi Kleen ([EMAIL PROTECTED]) wrote: > > > > Yes, but as you have probably understood, I want to have everything > > > > embedded at the cond_call() site rather than polluting the

RE: [PATCH] x86_64: remove check for CONSTANT_TSC from time.c

2007-06-04 Thread Nagendra, Bhavana
Yes, the attached patch works for me. Andi, is this patch acceptable? Regards, -- Bhavana Nagendra AMD, Inc -Original Message- From: Joerg Roedel [mailto:[EMAIL PROTECTED] Sent: Monday, June 04, 2007 4:42 PM To: Andi Kleen Cc: linux-kernel@vger.kernel.org; Deguara, Joachim;

Re: [patch 9/9] Scheduler profiling - Use conditional calls

2007-06-04 Thread Mathieu Desnoyers
* William Lee Irwin III ([EMAIL PROTECTED]) wrote: > On Wed, May 30, 2007 at 10:00:34AM -0400, Mathieu Desnoyers wrote: > >>> + if (prof_on) > >>> + BUG_ON(cond_call_arm("profile_on")); > > * William Lee Irwin III ([EMAIL PROTECTED]) wrote: > >> What's the point of this BUG_ON()? The

Re: [patch 9/9] Scheduler profiling - Use conditional calls

2007-06-04 Thread Mathieu Desnoyers
* Andi Kleen ([EMAIL PROTECTED]) wrote: > > I see your point, but there is a level of control on the branch I would > > lack by doing so: the ability to put the call in either the if or else > > branch. It is an optimization on i386. > > What does it optimize exactly? > Nicholas McGuire told me

Re: [PATCH -mm 0/5] LZO and swap write failure patches for -mm

2007-06-04 Thread Daniel Hazelton
On Monday 04 June 2007 16:45:55 Richard Purdie wrote: > On Mon, 2007-06-04 at 13:37 -0400, Daniel Hazelton wrote: > > Yes - most of that work, IIRC, is related to the alignment issues that > > Herr Oberhumer noted. As it stands, the alternative does work well for a > > large number of the

[-mm patch] drivers/mmc/core/core.{h,c}: cleanups

2007-06-04 Thread Adrian Bunk
On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote: >... > Changes since 2.6.22-rc2-mm1: >... > git-mmc.patch >... > git trees >... This patch contains the following cleanups: - make the following needlessly global functions static: - core.c: mmc_schedule_delayed_work() - core.c:

[2.6 patch] drivers/video/vt8623fb.c: make code static

2007-06-04 Thread Adrian Bunk
This patch makes needlessly global code static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/video/vt8623fb.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) --- linux-2.6.22-rc3-mm1/drivers/video/vt8623fb.c.old 2007-06-04

[RFC: 2.6 patch] drivers/video/pm3fb.c: possible cleanups

2007-06-04 Thread Adrian Bunk
This patch contains the following possible cleanups: - remove the empty pm3fb_setup() and corresponding code - pm3fb_init() can become static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/video/pm3fb.c | 31 +-- 1 file changed, 1 insertion(+), 30

[-mm patch] e1000: #if 0 two functions

2007-06-04 Thread Adrian Bunk
e1000_{read,write}_pci_cfg() are no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.h |2 -- drivers/net/e1000/e1000_main.c |4 2 files changed, 4 insertions(+), 2 deletions(-) --- linux-2.6.22-rc3-mm1/drivers/net/e1000/e1000_hw.h.old

Re: joydev.c and saitek cyborg evo force

2007-06-04 Thread Jiri Kosina
On Mon, 4 Jun 2007, Renato Golin wrote: > Patched and run, we're almost there... I put an additional printk on > usb/input/hid-core.c and hid/hid-input.c to assure I got the right copy, > got the messages but not the fix. Hi Renato, sorry, don't fully understand - what do you mean by "got the

  1   2   3   4   5   6   7   8   9   10   >