Re: [BUGFIX]{PATCH] flush icache on ia64 take2

2007-07-18 Thread KAMEZAWA Hiroyuki
On Fri, 6 Jul 2007 11:29:01 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > This is a patch for fixing icache flush race in ia64(Montecito) by > implementing > flush_icache_page() at el. > > Changelog: > - updated against 2.6.22-rc7 (previous one was against 2.6.21) > - removed hugetlbe's

Re: 2.6.22-git10 compile error

2007-07-18 Thread Cornelia Huck
On Thu, 19 Jul 2007 09:28:26 +0300, Plamen Petrov <[EMAIL PROTECTED]> wrote: > Hi, all! > > Just for the record - linux kernel version 2.6.22-git10 fails to build > with the following error: > > In file included from net/netfilter/xt_connlimit.c:27: > include/net/netfilter/nf_conntrack.h:99: err

Re: [PATCH 1/1] i386: Geode's TSC is not neccessary to mark tu unstable

2007-07-18 Thread Juergen Beisert
On Thursday 19 July 2007 03:02, Andrew Morton wrote: > On Sun, 15 Jul 2007 21:06:27 +0200 > > Juergen Beisert <[EMAIL PROTECTED]> wrote: > > Replace NSC/Cyrix specific chipset access macros by inlined functions. > > With the macros a line like this fails (and does nothing): > > setCx86(CX86_CCR

Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:

2007-07-18 Thread Jens Axboe
On Thu, Jul 19 2007, Giacomo Catenazzi wrote: > Linus Torvalds wrote: > > > > On Thu, 19 Jul 2007, Bartlomiej Zolnierkiewicz wrote: > >> Thanks for finding and fixing this. > >> > >> The latest patch (with additional cleanups) also looks good and should be > >> safe enough (unchanged behavior for

Re: [patch 0/3] PS3 Storage Drivers for 2.6.23, take 5

2007-07-18 Thread Alessandro Rubini
Hello. > I didn't hear anything from the misc device maintainer (for the FLASH ROM > Storage Driver). Actually, I am not acting as a maintainer. I'm not active enough nor up to date with all the structure of kernel maintainance. So please don't wait for me. Actually, I tried a pair of times to

Re: System hangs on running kernbench

2007-07-18 Thread Dhaval Giani
> (gdb) thread 6 > [Switching to thread 6 (process 6233)]#0 __do_softirq () > at kernel/softirq.c:231 > 231 if (pending & 1) { > (gdb) bt > #0 __do_softirq () at kernel/softirq.c:231 > #1 0xc012998b in do_softirq () at kernel/softirq.c:269 > #2 0xc0129a09 in irq_exit ()

Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:

2007-07-18 Thread Giacomo Catenazzi
Linus Torvalds wrote: > > On Thu, 19 Jul 2007, Bartlomiej Zolnierkiewicz wrote: >> Thanks for finding and fixing this. >> >> The latest patch (with additional cleanups) also looks good and should be >> safe enough (unchanged behavior for all non-pc requests) to merge it now. >> >> Acked-by: Bartlo

Re: [PATH 0/1] Kexec jump - v2 - the first step to kexec based hibernation

2007-07-18 Thread Huang, Ying
On Wed, 2007-07-18 at 18:04 -0700, Andrew Morton wrote: > I like the idea but I think I'll let people chat about it a bit more > before looking at merging the patches, OK? I think maybe we should wait for Rafael to separate the device hibernate (quiesce and state save) from device suspend. Without

2.6.22-git10 compile error

2007-07-18 Thread Plamen Petrov
Hi, all! Just for the record - linux kernel version 2.6.22-git10 fails to build with the following error: In file included from net/netfilter/xt_connlimit.c:27: include/net/netfilter/nf_conntrack.h:99: error: field `ct_general' has incomplete type include/net/netfilter/nf_conntrack.h: In funct

Re: System hangs on running kernbench

2007-07-18 Thread Dhaval Giani
On Wed, Jul 18, 2007 at 08:16:37PM +0530, Dhaval Giani wrote: > Hi Andrew, > > On Wed, Jul 18, 2007 at 03:11:42PM +0530, Dhaval Giani wrote: > > On Wed, Jul 18, 2007 at 01:07:00AM -0700, Andrew Morton wrote: > > > On Wed, 18 Jul 2007 13:26:48 +0530 Dhaval Giani <[EMAIL PROTECTED]> wrote: > > > >

Re: [PATCH] Check for compound pages in set_page_dirty()

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Hugh Dickins wrote: > On Wed, 18 Jul 2007, Jens Axboe wrote: > > > > Since I had my hands dirty already... > > Great, thanks. (There's also such a test in fs/nfs/direct.c, > but let's not trouble Trond until we've settled what to do here.) > > > > > --- > > > > [PATCH] Re

Re: [PATCH 33/33] IDE: sg chaining support

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Bartlomiej Zolnierkiewicz wrote: > On Monday 16 July 2007, Jens Axboe wrote: > > Cc: [EMAIL PROTECTED] > > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > > Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> (for both acks) Thanks for reviewing and acking! -- Jens Axbo

Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Linus Torvalds wrote: > > > On Thu, 19 Jul 2007, Bartlomiej Zolnierkiewicz wrote: > > > > Thanks for finding and fixing this. > > > > The latest patch (with additional cleanups) also looks good and should be > > safe enough (unchanged behavior for all non-pc requests) to me

Re: [2.6 patch] kernel/sched.c: remove 2 unused exports

2007-07-18 Thread Adrian Bunk
On Tue, Jul 17, 2007 at 09:22:33PM +0200, Ingo Molnar wrote: > > * Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch removes the following unused exports: > > - EXPORT_SYMBOL(cond_resched_softirq); > > - EXPORT_SYMBOL_GPL(__wake_up_sync); > > these are there for API completeness - their co

Re: [patch] Change softlockup trigger limit using a kernel parameter

2007-07-18 Thread Andrew Morton
On Wed, 18 Jul 2007 22:41:21 -0700 Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > On Wed, Jul 18, 2007 at 04:08:58PM -0700, Andrew Morton wrote: > > On Mon, 16 Jul 2007 15:26:50 -0700 > > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > > Kernel warns of softlockups if the softlocku

Re: [PATCH] posix-timer: fix deletion race

2007-07-18 Thread Thomas Gleixner
On Wed, 2007-07-18 at 16:43 -0700, Jeremy Katz wrote: > On Wed, 18 Jul 2007, Jeremy Katz wrote: > > > On Wed, 18 Jul 2007, Thomas Gleixner wrote: > > > >>> Also can you please enable CONFIG_PROVE_LOCKING, which might catch any > >>> locking problem, which might be related to this. > >> > >> Anoth

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-18 Thread Jarek Poplawski
On Wed, Jul 18, 2007 at 01:48:20PM +0200, Jarek Poplawski wrote: ... > I'd be very glad if it could be verified and/or tested. Jarek, This patch is verified crap! Regards, Jarek P. PS: Olaf, You've written earlier that one of the main reasons for poll_napi is to work when the kernel "doesn't e

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Adrian Bunk
On Wed, Jul 18, 2007 at 05:18:20PM -0400, Robert P. J. Day wrote: > On Wed, 18 Jul 2007, Adrian Bunk wrote: > > > On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote: > > > On Wed, 18 Jul 2007, Jeff Garzik wrote: > > > > > > > Randy Dunlap wrote: > > > > > On Wed, 18 Jul 2007 16:23:09

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-18 Thread Greg KH
On Wed, Jul 18, 2007 at 10:42:09PM -0400, James Morris wrote: > On Wed, 18 Jul 2007, Andrew Morton wrote: > > aww man, you passed over an opportunity to fix vast amounts of coding style > > cruftiness. > > GregKH-esque :-) Yeah, sorry, that was when I was young and foolish and liked to bang on th

Re: [patch] Change softlockup trigger limit using a kernel parameter

2007-07-18 Thread Ravikiran G Thirumalai
On Wed, Jul 18, 2007 at 04:08:58PM -0700, Andrew Morton wrote: > On Mon, 16 Jul 2007 15:26:50 -0700 > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > Kernel warns of softlockups if the softlockup thread is not able to run > > on a CPU for 10s. It is useful to lower the softlockup warning >

Re: [PATCH 1/5][TAKE8] manpage for fallocate

2007-07-18 Thread Mark Fasheh
On Thu, Jul 19, 2007 at 03:10:52PM +1000, David Chinner wrote: > % git-log 84e1e99f112dead8f9ba036c02d24a9f5ce7f544 |head -10 > commit 84e1e99f112dead8f9ba036c02d24a9f5ce7f544 > Author: David Chinner <[EMAIL PROTECTED]> > Date: Mon Jun 18 16:50:27 2007 +1000 > > [XFS] Prevent ENOSPC from abo

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Andrew Morton wrote: > On Mon, 16 Jul 2007 18:15:40 +0200 > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > > > Add a Disk Storage Driver for the PS3: > > Your patchset significantly hits powerpc, scsi and block. So who g

RE: [PATCH 3/5] HOWTO: add Chinese translation ofDocumentation/HOWTO

2007-07-18 Thread Li Yang-r58472
> -Original Message- > From: Greg KH [mailto:[EMAIL PROTECTED] > Sent: Thursday, July 19, 2007 1:01 PM > To: WANG Cong > Cc: Jesper Juhl; linux-kernel@vger.kernel.org; Li > Yang-r58472; TripleX Chung; Maggie Chen > Subject: Re: [PATCH 3/5] HOWTO: add Chinese translation > ofDocumentation

Re: Powerpc - Include pagemap.h in asm/powerpc/tlb.h

2007-07-18 Thread Andrew Morton
On Fri, 13 Jul 2007 21:20:33 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Powerpc - Include pagemap.h in asm/powerpc/tlb.h > > Fixes this powerpc build error in 2.6.22-rc6-mm1 for powerpc 64 : > > In file included from include2/asm/tlb.h:60, > from > /home/compudj/git/l

Re: [PATCH 2/5] Documentation: add Japanese translated stable_api_nonsense.txt

2007-07-18 Thread Greg KH
On Thu, Jul 19, 2007 at 12:10:36PM +0900, IKEDA Munehiro wrote: > Jesper Juhl wrote: > > On 19/07/07, Greg Kroah-Hartman <[EMAIL PROTECTED]> wrote: > >> From: Tsugikazu Shibata <[EMAIL PROTECTED]> > >> > >> Add the japanese translation of the Documentation/HOWTO file. > >> > > A few comments below

Re: [PATCH 3/5] HOWTO: add Chinese translation of Documentation/HOWTO

2007-07-18 Thread Greg KH
On Thu, Jul 19, 2007 at 01:12:54PM +0800, WANG Cong wrote: > > Since these docs are not in the mainline tree yet, I don't have a copy. They are there now. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Mor

Re: [PATCH] hugetlbfs read() support

2007-07-18 Thread Andrew Morton
On Fri, 13 Jul 2007 18:23:33 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > Here is the patch to support read() for hugetlbfs, needed to get > oprofile working on executables backed by largepages. > > If you plan to consider Christoph Lameter's pagecache cleanup patches, > I

Re: [PATCH 1/5][TAKE8] manpage for fallocate

2007-07-18 Thread David Chinner
On Wed, Jul 18, 2007 at 08:41:55PM -0700, Mark Fasheh wrote: > On Sat, Jul 14, 2007 at 12:16:25AM +0530, Amit K. Arora wrote: > > After a successful call, subsequent writes are guaranteed not to fail > > because > > of lack of disk space. > > If a write to an unwritten region requires a node sp

Re: [PATCH 3/5] HOWTO: add Chinese translation of Documentation/HOWTO

2007-07-18 Thread WANG Cong
On Thu, Jul 19, 2007 at 01:46:08AM +0200, Jesper Juhl wrote: >On 19/07/07, Greg Kroah-Hartman <[EMAIL PROTECTED]> wrote: >>From: Li Yang <[EMAIL PROTECTED]> >> >>This is a Chinese translated version of Documentation/HOWTO. Currently >>Chinese involvement in Linux kernel is very low, especially com

Re: [PATCH] Update 2.4 maintainer in document

2007-07-18 Thread Willy Tarreau
On Thu, Jul 19, 2007 at 12:58:22PM +0800, Li Yang-r58472 wrote: > > -Original Message- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On Behalf Of Willy Tarreau > > Sent: Thursday, July 19, 2007 12:46 PM > > To: Li Yang > > Cc: linux-kernel@vger.kernel.org > > Subject: Re: [PAT

Re: early_printk accessing __log_buf

2007-07-18 Thread Stephane Couture
Andrew Morton wrote: On Wed, 18 Jul 2007 19:39:46 -0400 Robin Getz <[EMAIL PROTECTED]> wrote: On Wed 18 Jul 2007 18:16, Andrew Morton pondered: I'd suggest that any interface into here should be via function calls, not via direct access to printk internals: think up some nice copy_me_some_of_t

Re: which signal is sent to freeze process?

2007-07-18 Thread Nigel Cunningham
Hi. On Thursday 19 July 2007 14:09:56 Agarwal, Lomesh wrote: > Can you point me to code where kernel captures process in signal > handling and code which runs after suspend to ram is finished? Sure. It's in kernel/signal.c (get_signal_to_deliver) for x86 and x86_64, and arch//kernel/signal.c fo

RE: [PATCH] Update 2.4 maintainer in document

2007-07-18 Thread Li Yang-r58472
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Willy Tarreau > Sent: Thursday, July 19, 2007 12:46 PM > To: Li Yang > Cc: linux-kernel@vger.kernel.org > Subject: Re: [PATCH] Update 2.4 maintainer in document > > On Mon, Jul 09, 2007 at 03:05:07AM

Re: System hangs on running kernbench

2007-07-18 Thread Dhaval Giani
Hi Chuck, On Wed, Jul 18, 2007 at 11:08:18AM -0400, Chuck Ebbert wrote: > On 07/18/2007 05:41 AM, Dhaval Giani wrote: > > On Wed, Jul 18, 2007 at 01:07:00AM -0700, Andrew Morton wrote: > >> On Wed, 18 Jul 2007 13:26:48 +0530 Dhaval Giani <[EMAIL PROTECTED]> wrote: > >> > Softlockup is broken in 2.

Re: [PATCH] Update 2.4 maintainer in document

2007-07-18 Thread Willy Tarreau
On Mon, Jul 09, 2007 at 03:05:07AM +0800, Li Yang wrote: > Update the maintainer of 2.4 kernel in Documentations/SubmittingPatches. Thanks, but you should have CCed me, because I missed you mail ;-) I'll merge it. Regards, Willy > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > Documentation

Re: Linux 2.4.35 tree abandoned/delayed?

2007-07-18 Thread Willy Tarreau
On Wed, Jul 18, 2007 at 04:03:09PM -0800, Tony Borras wrote: > On Tue, 17 Jul 2007 22:50:10 +0200 > Willy Tarreau <[EMAIL PROTECTED]> wrote: > > > Hi Tony, > > > > [ first, please always keep people in CC on LKML since it's > > very easy to > > miss a thread ] > > > > On Mon, Jul 16, 2007 at 1

RE: which signal is sent to freeze process?

2007-07-18 Thread Agarwal, Lomesh
Can you point me to code where kernel captures process in signal handling and code which runs after suspend to ram is finished? -Original Message- From: Nigel Cunningham [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 18, 2007 7:19 PM To: Agarwal, Lomesh Cc: linux-kernel@vger.kernel.org S

Re: early_printk accessing __log_buf

2007-07-18 Thread Robin Getz
On Wed 18 Jul 2007 20:26, Andrew Morton pondered: > Robin Getz wrote: > > [need to access _log_buf from external for early debugging code] > > > > Something simple like - early_copy_log_buff(void *dest, size_t n) > > > > copies n bytes from log_buf to memory area dest. Returns number of > > byte

Re: early_printk accessing __log_buf

2007-07-18 Thread Andrew Morton
On Wed, 18 Jul 2007 23:37:34 -0400 Robin Getz <[EMAIL PROTECTED]> wrote: > On Wed 18 Jul 2007 19:53, Mike Frysinger pondered: > > On 7/18/07, Robin Getz <[EMAIL PROTECTED]> wrote: > > > On Wed 18 Jul 2007 18:16, Andrew Morton pondered: > > > > I'd suggest that any interface into here should be via

Re: Containers: css_put() dilemma

2007-07-18 Thread Balbir Singh
On 7/19/07, Paul Menage <[EMAIL PROTECTED]> wrote: On 7/17/07, Balbir Singh <[EMAIL PROTECTED]> wrote: > > Thinking out loud again, can we add can_destroy() callbacks? > What would the exact semantics of such a callback be? Since for proper interaction with release agents we need the subsystem

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-18 Thread david
On Wed, 18 Jul 2007, James Morris wrote: On Wed, 18 Jul 2007, Andrew Morton wrote: The SECURITY_FRAMEWORK_VERSION macro has also been removed. I'd like to understand who is (or claims to be) adversely affected by this change, and what their complaints (if any) will be. Because I prefer my

Re: [PATCH 1/5][TAKE8] manpage for fallocate

2007-07-18 Thread Mark Fasheh
On Sat, Jul 14, 2007 at 12:16:25AM +0530, Amit K. Arora wrote: > After a successful call, subsequent writes are guaranteed not to fail because > of lack of disk space. If a write to an unwritten region requires a node split, that could result in the allocation of new meta data which obviously co

PCI Quirk / Hidden Bus Report

2007-07-18 Thread pat-lkml
I received: PCI: Bus #0b (-#0e) is hidden behind transparent bridge #0a (-#0a) (try 'pci=assign-busses') Please report the result to linux-kernel to fix this permanently in my dmesg in 2.6.22, and am reporting it. Context of message follows. Full dmesg output available on request. This is a Cl

Re: [PATH 0/1] Kexec jump - v2 - the first step to kexec based hibernation

2007-07-18 Thread david
On Thu, 19 Jul 2007, Nigel Cunningham wrote: Hi. On Thursday 19 July 2007 11:04:20 Andrew Morton wrote: On Sun, 15 Jul 2007 15:13:13 +0800 "Huang, Ying" <[EMAIL PROTECTED]> wrote: The changelog between v1 and v2 1. The kexec jump implementation is put into the kexec/kdump framework inst

Re: early_printk accessing __log_buf

2007-07-18 Thread Robin Getz
On Wed 18 Jul 2007 19:53, Mike Frysinger pondered: > On 7/18/07, Robin Getz <[EMAIL PROTECTED]> wrote: > > On Wed 18 Jul 2007 18:16, Andrew Morton pondered: > > > I'd suggest that any interface into here should be via function calls, > > > not via direct access to printk internals: think up some ni

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-18 Thread Andrew Morton
On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > More statfs() improvements for ext2. ext2 already maintains > percpu counters for free blocks and inodes. Derive free > block count and inode count by summing up percpu counters, > instead of counting up all the group

Re: [PATCH 2/5] Documentation: add Japanese translated stable_api_nonsense.txt

2007-07-18 Thread IKEDA Munehiro
Jesper Juhl wrote: On 19/07/07, Greg Kroah-Hartman <[EMAIL PROTECTED]> wrote: From: Tsugikazu Shibata <[EMAIL PROTECTED]> Add the japanese translation of the Documentation/HOWTO file. A few comments below. (snip) Thank Jesper for the comments. Below is a patch for Japanese stable_api_non

[PATCH] Clean up on_each_cpu: should not fail, should not have "retry" arg

2007-07-18 Thread Rusty Russell
Summary: on_each_cpu() should return void, since callers can't do anything useful with an error. It should not have the "retry" arg since it's of questionable utility and simply adds to Kernel Trivial Persuit. Only Alpha and PA-RISC use the "retry" arg to smp_call_function (it makes them return -

[PATCH] fix ext4/JBD2 build warnings

2007-07-18 Thread Mingming Cao
On Wed, 2007-07-18 at 17:37 -0400, Jeff Garzik wrote: > It seems jbd_debug() might need modification: > Looking at the current linus-git tree jbd_debug() define in include/linux/jbd2.h extern u8 journal_enable_debug; #define jbd_debug(n, f, a...) \

Re: [PATCH] X86_64: hpet tsc calibration fix broken smi detection logic

2007-07-18 Thread Andrew Morton
On Sat, 14 Jul 2007 10:41:39 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > The current SMI detection logic in read_hpet_tsc() makes sure, > that when a SMI happens between the read of the HPET counter and > the read of the TSC, this wrong value is used for TSC calibration. > > This is not th

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-18 Thread James Morris
On Wed, 18 Jul 2007, Andrew Morton wrote: > > The SECURITY_FRAMEWORK_VERSION macro has also been removed. > > I'd like to understand who is (or claims to be) adversely affected by this > change, and what their complaints (if any) will be. > > Because I prefer my flamewars pre- rather than post-m

Re: [git patches] two warning fixes

2007-07-18 Thread Jeff Garzik
Linus Torvalds wrote: So let's make a new rule: We absolutely NEVER add things like "must_check" unless not checking causes a real and obvious SECURITY ISSUE. And we absolutely *never* add crap like "deprecated", where the only point of the warning is to effectively hide *real* probl

Re: which signal is sent to freeze process?

2007-07-18 Thread Nigel Cunningham
Hi. On Thursday 19 July 2007 09:42:02 Agarwal, Lomesh wrote: > My understanding is that Linux kernel sends a signal to freeze processes > during suspend2ram operation. Which signal is used to achieve this? > The problem I am facing is that some of the system calls are failing > with EINTR errno du

Re: [PATH 0/1] Kexec jump - v2 - the first step to kexec based hibernation

2007-07-18 Thread Nigel Cunningham
Hi. On Thursday 19 July 2007 11:04:20 Andrew Morton wrote: > On Sun, 15 Jul 2007 15:13:13 +0800 > "Huang, Ying" <[EMAIL PROTECTED]> wrote: > > > > > The changelog between v1 and v2 > > > > 1. The kexec jump implementation is put into the kexec/kdump > >framework instead of software suspend

Re: [Resend][PATCH 1/9] ACPI: Implement the set_target() callback from pm_ops

2007-07-18 Thread Len Brown
Rafael, Please delete the instances of the string ACPI_STATE_S2 -- it doesn't exist in practice and we don't want to imply it exists by inventing it here. otherwise: Acked-by: Len Brown <[EMAIL PROTECTED]> thanks, -Len On Tuesday 17 July 2007 20:02, Andrew Morton wrote: > On Tue, 17 Jul 2007 22

Re: [git patches] two warning fixes

2007-07-18 Thread Benjamin Herrenschmidt
On Wed, 2007-07-18 at 18:50 -0700, Linus Torvalds wrote: > > Now, we can talk about making those sysfs core functions generate warnings > > themselves, and we can talk about generating new wrappers around them which > > generate warnings and which return void, then migrating code over to use > > th

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Rene Herman
On 07/19/2007 03:37 AM, Matt Mackall wrote: Here's a way to make forward progress on this whole thing: Turn on irqstacks when using 8k stacks WLI: are you submitting? Makes great sense regardless of anything and they've been tested silly with 4KSTACKS already... Detect when usage with 8k

Re: [git patches] two warning fixes

2007-07-18 Thread Linus Torvalds
On Wed, 18 Jul 2007, Andrew Morton wrote: > > The only reason why the sysfs creation would fail is a kernel bug, > so the consequence of your proposal is in fact unfixed kernel bugs. Well, the thing is, I suspect we have created way more bugs by having that stupid "you must check the return va

Re: [git patches] two warning fixes

2007-07-18 Thread Andrew Morton
On Thu, 19 Jul 2007 11:19:05 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > In general, I share paulus point of view here that forcing us to test > all those result code from sysfs file creation functions is just a major > PITA and adds bloat all over the kernel. There are many many cas

Re: [git patches] two warning fixes

2007-07-18 Thread Linus Torvalds
On Wed, 18 Jul 2007, Jeff Garzik wrote: > > Please pull from 'warnings' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git warnings > > to receive the following updates: Quite frankly, I think a *lot* better fix for warnings would be to remove those damn broken "must

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Matt Mackall
On Thu, Jul 19, 2007 at 03:33:58AM +0200, Andrea Arcangeli wrote: > On Thu, Jul 19, 2007 at 01:39:55AM +0100, Alan Cox wrote: > > > About 4k stacks I was generally against them, much better to fail in > > > fork than to risk corruption. The per-irq stack part is great feature > > > instead (too bad

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-18 Thread Andrew Morton
On Sat, 14 Jul 2007 12:37:01 -0400 (EDT) James Morris <[EMAIL PROTECTED]> wrote: > Convert LSM into a static interface, as the ability to unload a security > module is not required by in-tree users and potentially complicates the > overall security architecture. > > Needlessly exported LSM symbol

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Andrea Arcangeli
On Thu, Jul 19, 2007 at 01:39:55AM +0100, Alan Cox wrote: > > About 4k stacks I was generally against them, much better to fail in > > fork than to risk corruption. The per-irq stack part is great feature > > instead (too bad it wasn't enabled for the safer 8k stacks). > > 8K stacks without IRQ st

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Matt Mackall
On Thu, Jul 19, 2007 at 02:48:37AM +0200, Rene Herman wrote: > On 07/19/2007 02:41 AM, Matt Mackall wrote: > > >On Thu, Jul 19, 2007 at 02:15:39AM +0200, Andrea Arcangeli wrote: > > >>Using kmalloc(8k) instead of alloc_page() doesn't sound a too big deal > >>and that will solve the problem. > > >

Re: [PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64

2007-07-18 Thread H. Peter Anvin
Andi Kleen wrote: >> >> No processors that support KVM exist that also do not support CMPXCHG64, >> so no additional check is necessary. This setup allows for a single kernel >> that will boot on i486 and also support KVM if available. > > The CONFIG should only control the early CPUID checks, wh

Re: [git patches] two warning fixes

2007-07-18 Thread Benjamin Herrenschmidt
On Wed, 2007-07-18 at 20:05 -0400, Jeff Garzik wrote: > Andi Kleen wrote: > > On Thursday 19 July 2007 01:55:04 Jeff Garzik wrote: > >> Please pull from 'warnings' branch of > >> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git warnings > >> > >> to receive the following updates: >

Re: [PATCH] Include serial_reg.h with userspace headers

2007-07-18 Thread Andrew Morton
On Sun, 15 Jul 2007 00:02:39 -0300 Herton Ronaldo Krzesinski <[EMAIL PROTECTED]> wrote: > As reported by Gustavo de Nardin <[EMAIL PROTECTED]>, while trying to > compile xosview (http://xosview.sourceforge.net/) with upstream kernel > headers being used you get the following errors: > serialmete

Re: [PATH 0/1] Kexec jump - v2 - the first step to kexec based hibernation

2007-07-18 Thread Andrew Morton
On Sun, 15 Jul 2007 15:13:13 +0800 "Huang, Ying" <[EMAIL PROTECTED]> wrote: > > The changelog between v1 and v2 > > 1. The kexec jump implementation is put into the kexec/kdump >framework instead of software suspend framework. The device >and CPU state save/restore code of software suspe

Re: [PATCH 1/1] i386: Geode's TSC is not neccessary to mark tu unstable

2007-07-18 Thread Andrew Morton
On Sun, 15 Jul 2007 21:06:27 +0200 Juergen Beisert <[EMAIL PROTECTED]> wrote: > Replace NSC/Cyrix specific chipset access macros by inlined functions. > With the macros a line like this fails (and does nothing): > setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); > With inlined functions this l

Re: new ext4 build warnings

2007-07-18 Thread Mingming Cao
On Wed, 2007-07-18 at 17:37 -0400, Jeff Garzik wrote: > It seems jbd_debug() might need modification: > > fs/ext4/inode.c: In function ‘ext4_write_inode’: > fs/ext4/inode.c:2906: warning: comparison is always true due to limited > range of data type > > fs/jbd2/recovery.c: In function ‘jbd2_jour

Re: Someone ( bsg merge ? ) broke {sd,hd}parm on current git

2007-07-18 Thread Gabriel C
FUJITA Tomonori wrote: > From: Gabriel C <[EMAIL PROTECTED]> > Subject: Re: Someone ( bsg merge ? ) broke {sd,hd}parm on current git > Date: Tue, 17 Jul 2007 03:40:58 +0200 > > >> FUJITA Tomonori wrote: >> >>> From: Gabriel C <[EMAIL PROTECTED]> >>> Subject: Re: Someone ( bsg merge ? ) brok

Re: [RFC] Deferred interrupt handling.

2007-07-18 Thread Peter Chubb
The problem you're having is essentially the same as the user-level interrupt handler problem I've been dealing with for ages. The basic rule is: don't share interrupts between devices on the host and devices in the guest. But you *can* share interrupts between devices in a single guest. If you

Re: RFC: CONFIG_PAGE_SHIFT (aka software PAGE_SIZE)

2007-07-18 Thread Rene Herman
On 07/19/2007 01:50 AM, Andrea Arcangeli wrote: On Wed, Jul 18, 2007 at 06:34:20PM +0200, Rene Herman wrote: It says that highmem is not an issue due to no such thing as highmem even existing on the machines with support for larger hard pagesizes, but this wouldn't hold for soft pages. Sort

Re: [PATCH][ACPI] Fix acpi_ev_pci_config_region_setup() to avoid memory leak

2007-07-18 Thread Andrew Morton
On Thu, 19 Jul 2007 00:48:03 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > Hello, > > In drivers/acpi/events/evrgnini.c::acpi_ev_pci_config_region_setup() > there is a memory leak. > We may return at "if (!pci_device_node)" without freeing storage > previously allocated and assigned to 'pci_id

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Rene Herman
On 07/19/2007 02:41 AM, Matt Mackall wrote: On Thu, Jul 19, 2007 at 02:15:39AM +0200, Andrea Arcangeli wrote: Using kmalloc(8k) instead of alloc_page() doesn't sound a too big deal and that will solve the problem. How do you figure? If you're saying that soft pages helps our 8k stack alloc

Re: [PATCH][ACPI] Fix acpi_ev_pci_config_region_setup() to avoid memory leak

2007-07-18 Thread Len Brown
On Wednesday 18 July 2007 18:48, Jesper Juhl wrote: > drivers/acpi/events/evrgnini.c applied (after changing to ACPI_FREE()) thanks, -Len - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

Re: sysfs root link count broken in 2.6.22-git5

2007-07-18 Thread Kay Sievers
On 7/18/07, Jean Delvare <[EMAIL PROTECTED]> wrote: On Tue, 17 Jul 2007 20:38:28 -0700, Greg KH wrote: > On Tue, Jul 17, 2007 at 11:05:30PM +0200, Jean Delvare wrote: > > This breaks libsensors. libsensors uses libsysfs, and libsysfs is not > > very smart in that it will initialize successfully e

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Matt Mackall
On Thu, Jul 19, 2007 at 02:15:39AM +0200, Andrea Arcangeli wrote: > On Mon, Jul 16, 2007 at 06:27:55PM -0500, Matt Mackall wrote: > > So it's absolutely no help in fixing our order-1 allocation problem > > because we don't want to force large pages on people. > > Using kmalloc(8k) instead of alloc

Re: Linux 2.4.35 tree abandoned/delayed?

2007-07-18 Thread Tony Borras
On Thu, 19 Jul 2007 02:10:58 +0200 "Jesper Juhl" <[EMAIL PROTECTED]> wrote: > > file: patch-2.4.34.3.bz2 has the corruption at line 213: > > goto errout > > > > That is where that came from, when I patched my 2.4.34 to > > arrive at 2.4.34.5, before applying the 2.4.35.rc5 patch! > > > That soun

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Alan Cox
> About 4k stacks I was generally against them, much better to fail in > fork than to risk corruption. The per-irq stack part is great feature > instead (too bad it wasn't enabled for the safer 8k stacks). 8K stacks without IRQ stacks are not "safer" so I don't understand your comment ? - To unsub

Re: early_printk accessing __log_buf

2007-07-18 Thread Andrew Morton
On Wed, 18 Jul 2007 19:39:46 -0400 Robin Getz <[EMAIL PROTECTED]> wrote: > On Wed 18 Jul 2007 18:16, Andrew Morton pondered: > > > > I'd suggest that any interface into here should be via function calls, > > not via direct access to printk internals: think up some nice > > copy_me_some_of_the_log

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-18 Thread Andrew Morton
On Wed, 18 Jul 2007 19:05:55 -0400 "J. Bruce Fields" <[EMAIL PROTECTED]> wrote: > On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: > > On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote: > > > > > +static void exp_flags(struct seq_file *m, int flag, int fsid, > >

Re: Linux, tcpdump and vlan

2007-07-18 Thread Patrick McHardy
Ben Greear wrote: > Patrick McHardy wrote: > >> Its actually more a problem on the RX path. VLAN acceleration >> works (at least with some drivers) by enabling HW header striping >> and using the VLAN ID for an immediate lookup in the VLAN devices >> configured on that device. So if the VLAN is no

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Andrea Arcangeli
On Mon, Jul 16, 2007 at 06:27:55PM -0500, Matt Mackall wrote: > So it's absolutely no help in fixing our order-1 allocation problem > because we don't want to force large pages on people. Using kmalloc(8k) instead of alloc_page() doesn't sound a too big deal and that will solve the problem. The wh

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-18 Thread Neil Brown
On Wednesday July 18, [EMAIL PROTECTED] wrote: > On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: > > On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote: > > > > > +static void exp_flags(struct seq_file *m, int flag, int fsid, > > > + uid_t anonu, uid_t an

Re: Linux 2.4.35 tree abandoned/delayed?

2007-07-18 Thread Jesper Juhl
On 19/07/07, Tony Borras <[EMAIL PROTECTED]> wrote: On Tue, 17 Jul 2007 22:50:10 +0200 Willy Tarreau <[EMAIL PROTECTED]> wrote: > Hi Tony, > > [ first, please always keep people in CC on LKML since it's > very easy to > miss a thread ] > > On Mon, Jul 16, 2007 at 11:23:57PM -0800, Tony Borras

[git patch] ISDN code movement fix

2007-07-18 Thread Jeff Garzik
Please pull from 'isdn-fix' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git isdn-fix to receive the following updates: drivers/isdn/hisax/config.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) Florin Malita (1): ISDN HiSax: uninitialized return

[git patches] two warning fixes

2007-07-18 Thread Jeff Garzik
Please pull from 'warnings' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git warnings to receive the following updates: drivers/video/aty/radeon_base.c | 23 ++- include/asm-x86_64/tlbflush.h |6 +- 2 files changed, 23 insertions(+), 6 d

Re: [git patches] two warning fixes

2007-07-18 Thread Jeff Garzik
Andi Kleen wrote: On Thursday 19 July 2007 01:55:04 Jeff Garzik wrote: Please pull from 'warnings' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git warnings to receive the following updates: drivers/video/aty/radeon_base.c | 23 ++- include/asm-

Re: [PATCH 1/1] Driver for the Atmel on-chip SSC on AT32AP and AT91.

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 08:52:32 +0200 Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: > The Synchronous Serial Controller (SSC) on Atmel microprocessors are capable > of > tranceiving many frame based protocols, like I2S. Tested on the > AT32AP7000/ATSTK1000. > > This driver is used in the ALSA s

Re: Linux 2.4.35 tree abandoned/delayed?

2007-07-18 Thread Tony Borras
On Tue, 17 Jul 2007 22:50:10 +0200 Willy Tarreau <[EMAIL PROTECTED]> wrote: > Hi Tony, > > [ first, please always keep people in CC on LKML since it's > very easy to > miss a thread ] > > On Mon, Jul 16, 2007 at 11:23:57PM -0800, Tony Borras wrote: > > On Tue, 17 Jul 2007 07:20:06 +0200 > > Wi

Re: Linux, tcpdump and vlan

2007-07-18 Thread Ben Greear
Patrick McHardy wrote: Ben Greear wrote: Patrick McHardy wrote: Put another way, once you enable VLAN header stripping, you won't see the headers for *any* VLAN, not only for those you're actually running locally. This is also a problem for devices like macvlan, where it would be desir

[git patches] net driver updates

2007-07-18 Thread Jeff Garzik
Nothing highly notable. Wireless pull, and new blackfin eth driver (didn't get merged with rest of blackfin, since additional review was requested). Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the foll

Re: [git patches] two warning fixes

2007-07-18 Thread Andi Kleen
On Thursday 19 July 2007 01:55:04 Jeff Garzik wrote: > > Please pull from 'warnings' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git warnings > > to receive the following updates: > > drivers/video/aty/radeon_base.c | 23 ++- > include/asm-x86_

Re: [PATCH 2/3] i386: use x86_64's desc_def.h

2007-07-18 Thread Andi Kleen
On Thu, Jul 19, 2007 at 09:27:41AM +1000, Rusty Russell wrote: > On Wed, 2007-07-18 at 09:19 -0700, Zachary Amsden wrote: > > > +#define GET_CONTENTS(desc) (((desc)->raw32.b >> 10) & 3) > > > +#define GET_WRITABLE(desc) (((desc)->raw32.b >> 9) & 1) > > > > You got rid of the duplicate

Re: [patch 3/3] ps3: FLASH ROM Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:42 +0200 Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > Add a FLASH ROM Storage Driver for the PS3: > - Implemented as a misc character device driver > - Uses a fixed 256 KiB buffer allocated from boot memory as the h

Re: early_printk accessing __log_buf

2007-07-18 Thread Mike Frysinger
On 7/18/07, Robin Getz <[EMAIL PROTECTED]> wrote: On Wed 18 Jul 2007 18:16, Andrew Morton pondered: > I'd suggest that any interface into here should be via function calls, > not via direct access to printk internals: think up some nice > copy_me_some_of_the_log_buffer() interface. If so - I wou

Re: RFC: CONFIG_PAGE_SHIFT (aka software PAGE_SIZE)

2007-07-18 Thread Andrea Arcangeli
On Wed, Jul 18, 2007 at 06:34:20PM +0200, Rene Herman wrote: > It says that highmem is not an issue due to no such thing as highmem even > existing on the machines with support for larger hard pagesizes, but this > wouldn't hold for soft pages. Sort of went "damn" in an x86 context upon > readin

Re: [PATCH] posix-timer: fix deletion race

2007-07-18 Thread Jeremy Katz
On Wed, 18 Jul 2007, Jeremy Katz wrote: On Wed, 18 Jul 2007, Thomas Gleixner wrote: Also can you please enable CONFIG_PROVE_LOCKING, which might catch any locking problem, which might be related to this. Another test: Can you please disable CONFIG_SCHED_SMT to narrow it down further ? I'll

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:41 +0200 Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > Add a BD/DVD/CD-ROM Storage Driver for the PS3: > - Implemented as a SCSI device driver > - Uses software scatter-gather with a 64 KiB bounce buffer as the hyper

  1   2   3   4   5   6   >