[RFC] [PATCH] To vunmap correct address in text_poke()(kprobes)

2007-07-24 Thread Srinivasa Ds
When I was testing kprobes on x86_64 and I come across the below error message on latest 2.6.23-rc1 kernel. == Trying to vfree() bad address (c20002233199) WARNING: at mm/vmalloc.c:330 __vunmap() Call Trace: [] sys_gettimeofday+0x0/0x62 [] text_po

Re: make randconfig improvement

2007-07-24 Thread Sam Ravnborg
On Wed, Jul 25, 2007 at 06:42:38AM +, Dave Young wrote: > Hi, > IMHO, the randconfig option make no sense sometimes. For me, My > computer need some must-have config options, like SATA and USB > keyboard config options. I think many other people maybe have similar > problems. > > So, what abou

Re: [PATCH][RFC] getting rid of stupid loop in BUG()

2007-07-24 Thread Heiko Carstens
On Tue, Jul 24, 2007 at 11:29:14PM -0700, David Miller wrote: > From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> > Date: Tue, 24 Jul 2007 23:24:55 -0700 > > > H. Peter Anvin wrote: > > > How far back was __builtin_trap() supported? > > > > I think its relatively recent, but it might be within our su

Re: [ck] Re: -mm merge plans for 2.6.23

2007-07-24 Thread Mike Galbraith
On Wed, 2007-07-25 at 16:19 +1000, Matthew Hawkins wrote: > On 7/25/07, Nick Piggin <[EMAIL PROTECTED]> wrote: > > Not to say that neither fix some problems, but for such conceptually > > big changes, it should take a little more effort than a constructed test > > case and no consideration of the a

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-24 Thread Alan Curry
Benjamin Herrenschmidt writes the following: > >Doesn't it have something in "compatible" instead ? that would be the >way to go. > Assuming that would be represented as a file named "compatible" in the directory /proc/device-tree/*/*/[EMAIL PROTECTED] ... no, it doesn't have one of those. For th

Re: [patch] mm: reduce pagetable-freeing latencies

2007-07-24 Thread Peter Zijlstra
On Wed, 2007-07-25 at 07:29 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2007-07-24 at 14:13 +0200, Andi Kleen wrote: > > Benjamin Herrenschmidt <[EMAIL PROTECTED]> writes: > > > > > > What a truly putrid patch. I am suspecting that this was a quick > > > > get-you-out-of-trouble thing, which t

Re: -mm merge plans for 2.6.23

2007-07-24 Thread Eric St-Laurent
On Wed, 2007-25-07 at 15:37 +1000, Nick Piggin wrote: > OK, this is where I start to worry. Swap prefetch AFAIKS doesn't fix > the updatedb problem very well, because if updatedb has caused swapout > then it has filled memory, and swap prefetch doesn't run unless there > is free memory (not to men

Re: [RFC] fs/super.c: Why alloc_super use a static variable default_op?

2007-07-24 Thread Al Viro
On Wed, Jul 25, 2007 at 07:39:53AM +0100, Al Viro wrote: > For superblocks and inodes that is different - if we go looking for a method, > we *are* going to hit the method table anyway; it's not going to be NULL in > anything resembling a normal case. So having the pointer to table initialized "

make randconfig improvement

2007-07-24 Thread Dave Young
Hi, IMHO, the randconfig option make no sense sometimes. For me, My computer need some must-have config options, like SATA and USB keyboard config options. I think many other people maybe have similar problems. So, what about improve the randconfig? let's add some basic options , like oldconfig.

Re: [PATCH]gx-suspmod.c use boot_cpu_data instead of current_cpu_data

2007-07-24 Thread Andrew Morton
On Wed, 25 Jul 2007 14:19:05 + Dave Young <[EMAIL PROTECTED]> wrote: > Hi, > in preemptible kernel will report BUG: using smp_processor_id() in > preemptible, so use boot_cpu_data instead of current_cpu_data. > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> > > --- > arch/i386/kernel/cpu/

Re: [RFC] fs/super.c: Why alloc_super use a static variable default_op?

2007-07-24 Thread Al Viro
On Wed, Jul 25, 2007 at 01:21:19PM +0800, rae l wrote: > But there are also many other subsystems will do > fs/dcache.c: > void dput(struct dentry *dentry) > if (dentry->d_op && dentry->d_op->d_delete) { > Do you think it's worth optimizing it with a static d_op filled? > > we can add a st

Re: Is PIE randomization breaking klibc binaries?

2007-07-24 Thread Ulrich Kunitz
On 07-07-24 15:45 H. Peter Anvin wrote: > Chuck Ebbert wrote: > > > >Okay, I tested with Fedora on x86_64 and it worked there too. > >(Not that that proves much.) > > > >Did you capture any of the error messages, like the address > >of the segfault? > > > > FWIW, on x86-64, this should show up in

Re: [ck] Re: -mm merge plans for 2.6.23

2007-07-24 Thread Nick Piggin
Matthew Hawkins wrote: On 7/25/07, Nick Piggin <[EMAIL PROTECTED]> wrote: Not to say that neither fix some problems, but for such conceptually big changes, it should take a little more effort than a constructed test case and no consideration of the alternatives to get it merged. Swap Prefetc

Re: [PATCH][RFC] getting rid of stupid loop in BUG()

2007-07-24 Thread David Miller
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Date: Tue, 24 Jul 2007 23:24:55 -0700 > H. Peter Anvin wrote: > > How far back was __builtin_trap() supported? > > I think its relatively recent, but it might be within our supported > compiler window. I'm pretty sure it is. - To unsubscribe from thi

Re: [PATCH][RFC] getting rid of stupid loop in BUG()

2007-07-24 Thread Jeremy Fitzhardinge
H. Peter Anvin wrote: > INT 6 is #UD, so the __builtin_trap() replaces the ud2a as well as the loop. > __builtin_trap() emits an actual ud2a; the effect is an int 6, of course. > How far back was __builtin_trap() supported? I think its relatively recent, but it might be within our supported c

Re: -mm merge plans for 2.6.23

2007-07-24 Thread david
On Wed, 25 Jul 2007, Nick Piggin wrote: [EMAIL PROTECTED] wrote: On Wed, 25 Jul 2007, Nick Piggin wrote: > OK, this is where I start to worry. Swap prefetch AFAIKS doesn't fix > the updatedb problem very well, because if updatedb has caused swapout > then it has filled memory, and swap p

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-24 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 21:28 -0400, Alan Curry wrote: > As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse controller > on the PegasosPPC. This is because of a feature/bug in the OF device tree: > the "device_type" attribute is an empty string instead of "8042" as the > kernel expect

Re: [ck] Re: -mm merge plans for 2.6.23

2007-07-24 Thread Matthew Hawkins
On 7/25/07, Nick Piggin <[EMAIL PROTECTED]> wrote: Not to say that neither fix some problems, but for such conceptually big changes, it should take a little more effort than a constructed test case and no consideration of the alternatives to get it merged. Swap Prefetch has existed since Septem

Re: [ck] Re: -mm merge plans for 2.6.23

2007-07-24 Thread Nick Piggin
Matthew Hawkins wrote: On 7/25/07, Nick Piggin <[EMAIL PROTECTED]> wrote: I'm not saying that we can't try to tackle that problem, but first of all you have a really nice narrow problem where updatedb seems to be causing the kernel to completely do the wrong thing. So we start on that. updat

Re: [PATCH 0/3] readahead drop behind and size adjustment

2007-07-24 Thread Eric St-Laurent
On Wed, 2007-25-07 at 15:19 +1000, Nick Piggin wrote: > What *I* think is supposed to happen is that newly read in pages get > put on the inactive list, and unless they get accessed againbefore > being reclaimed, they are allowed to fall off the end of the list > without disturbing active data too

[PATCH]gx-suspmod.c use boot_cpu_data instead of current_cpu_data

2007-07-24 Thread Dave Young
Hi, in preemptible kernel will report BUG: using smp_processor_id() in preemptible, so use boot_cpu_data instead of current_cpu_data. Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/cpufreq/gx-suspmod.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -pu

Re: [ck] Re: -mm merge plans for 2.6.23

2007-07-24 Thread Matthew Hawkins
On 7/25/07, Nick Piggin <[EMAIL PROTECTED]> wrote: I'm not saying that we can't try to tackle that problem, but first of all you have a really nice narrow problem where updatedb seems to be causing the kernel to completely do the wrong thing. So we start on that. updatedb isn't the only problem

Re: -mm merge plans for 2.6.23

2007-07-24 Thread Nick Piggin
[EMAIL PROTECTED] wrote: On Wed, 25 Jul 2007, Nick Piggin wrote: OK, this is where I start to worry. Swap prefetch AFAIKS doesn't fix the updatedb problem very well, because if updatedb has caused swapout then it has filled memory, and swap prefetch doesn't run unless there is free memory (not

Re: -mm merge plans for 2.6.23

2007-07-24 Thread david
On Wed, 25 Jul 2007, Nick Piggin wrote: Eric St-Laurent wrote: On Wed, 2007-25-07 at 06:55 +0200, Rene Herman wrote: > It certainly doesn't run for me ever. Always kind of a "that's not the > point" comment but I just keep wondering whenever I see anyone complain > about updatedb why the _

Re: -mm merge plans for 2.6.23

2007-07-24 Thread david
On Wed, 25 Jul 2007, Rene Herman wrote: On 07/25/2007 07:12 AM, [EMAIL PROTECTED] wrote: On Wed, 25 Jul 2007, Rene Herman wrote: > It certainly doesn't run for me ever. Always kind of a "that's not the > point" comment but I just keep wondering whenever I see anyone complain > about up

Re: 2.6.23-rc1 regression: mm: fix fault vs invalidate race for linear mappings

2007-07-24 Thread Nick Piggin
Dave Airlie wrote: Is this with a binary-only module? We saw an issue with that in SLES9 where the module is returning a locked page from its nopage handler when it isn't really supposed to. It might be fixed in latest drivers, have you tried them? Doesn't sound like it he mentions radeon drm

Re: [PATCH] Print utsname on Oops on all architectures

2007-07-24 Thread Andrew Morton
On Thu, 5 Jul 2007 18:52:27 -0700 (PDT) Joshua Wise <[EMAIL PROTECTED]> wrote: > Background: > This patch is a follow-on to "Info dump on Oops or panic()" [1]. > > On some architectures, the kernel printed some information on the running > kernel, but not on all architectures. The information

Re: -mm merge plans for 2.6.23

2007-07-24 Thread Nick Piggin
Eric St-Laurent wrote: On Wed, 2007-25-07 at 06:55 +0200, Rene Herman wrote: It certainly doesn't run for me ever. Always kind of a "that's not the point" comment but I just keep wondering whenever I see anyone complain about updatedb why the _hell_ they are running it in the first place. If

Re: -mm merge plans for 2.6.23

2007-07-24 Thread Rene Herman
On 07/25/2007 07:12 AM, [EMAIL PROTECTED] wrote: On Wed, 25 Jul 2007, Rene Herman wrote: It certainly doesn't run for me ever. Always kind of a "that's not the point" comment but I just keep wondering whenever I see anyone complain about updatedb why the _hell_ they are running it in the fi

Re: -mm merge plans for 2.6.23

2007-07-24 Thread Eric St-Laurent
On Wed, 2007-25-07 at 06:55 +0200, Rene Herman wrote: > It certainly doesn't run for me ever. Always kind of a "that's not the > point" comment but I just keep wondering whenever I see anyone complain > about updatedb why the _hell_ they are running it in the first place. If > anyone who never

Re: [RFC] fs/super.c: Why alloc_super use a static variable default_op?

2007-07-24 Thread rae l
On 7/25/07, Al Viro <[EMAIL PROTECTED]> wrote: On Wed, Jul 25, 2007 at 12:29:17PM +0800, rae l wrote: > But is it valuable? Compared to a waste of sizeof(struct super_block) > bytes memory. It's less that struct super_block, actually. > When some code want to refer fs_type->s_op, it almost alwa

Re: [PATCH 0/3] readahead drop behind and size adjustment

2007-07-24 Thread Nick Piggin
Eric St-Laurent wrote: On Mon, 2007-23-07 at 19:00 +1000, Nick Piggin wrote: I don't like this kind of conditional information going from something like readahead into page reclaim. Unless it is for readahead _specific_ data such as "I got these all wrong, so you can reclaim them" (which this

Re: [PATCH] x86_64 tce section mismatch

2007-07-24 Thread Muli Ben-Yehuda
On Tue, Jul 24, 2007 at 02:17:02PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix section mismatch warnings: > these functions are called only from __init functions. > > WARNING: vmlinux.o(.text+0x1861c): Section mismatch: reference to > .init.text:free_bootmem (betw

Re: -mm merge plans for 2.6.23

2007-07-24 Thread david
On Wed, 25 Jul 2007, Rene Herman wrote: On 07/25/2007 06:06 AM, Nick Piggin wrote: Ray Lee wrote: > Anyway, my point is that I worry that tuning for an unusual and > infrequent workload (which updatedb certainly is), is the wrong way to > go. Well it runs every day or so for every d

Re: [PATCH][RFC] getting rid of stupid loop in BUG()

2007-07-24 Thread H. Peter Anvin
Keith Owens wrote: > Trent Piepho (on Tue, 24 Jul 2007 19:31:36 -0700 (PDT)) wrote: >> Adding __builtin_trap after the >> asm might be an ok fix. It will emit a spurious int 6, but that won't even >> be >> reached since the asm doesn't return, and it probably be less extra code than >> the loop.

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-24 Thread Manuel Lauss
On Tue, Jul 24, 2007 at 09:56:59PM +0200, Stefan Richter wrote: > Manuel Lauss wrote: > > Actually, copying data to the disk while playing/seeking through a moviefile > > which is also located on it is already enough. Forget the NFS thing... > > > > Afterwards the firewire_sbp2 module has to be rm

Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()

2007-07-24 Thread Mike Galbraith
On Tue, 2007-07-24 at 11:25 -0700, Linus Torvalds wrote: > > On Tue, 24 Jul 2007, Andrew Morton wrote: > > > > I guess this was the bug: > > Looks very likely to me. Mike, Alexey, does this fix things for you? I don't have very much runtime on it yet, but yes, it seems to have. -Mike

Re: [PATCH]: allow individual core dump methods to be unlimited when sending to a pipe

2007-07-24 Thread Andrew Morton
SuperH allmodconfig broke: fs/binfmt_flat.c:83: warning: initialization from incompatible pointer type fs/binfmt_flat.c:94: error: conflicting types for 'flat_core_dump' fs/binfmt_flat.c:78: error: previous declaration of 'flat_core_dump' was here fs/binfmt_flat.c:94: error: conflicting types for

Re: [PATCH] Fix corruption of memmap on IA64 SPARSEMEM when mem_section is not a power of 2

2007-07-24 Thread Andrew Morton
On Tue, 13 Mar 2007 10:42:02 + [EMAIL PROTECTED] (Mel Gorman) wrote: > There are problems in the use of SPARSEMEM and pageblock flags that causes > problems on ia64. > > The first part of the problem is that units are incorrect in > SECTION_BLOCKFLAGS_BITS computation. This results in a map_s

Re: -mm merge plans for 2.6.23

2007-07-24 Thread Nick Piggin
Rene Herman wrote: On 07/25/2007 06:06 AM, Nick Piggin wrote: Ray Lee wrote: Anyway, my point is that I worry that tuning for an unusual and infrequent workload (which updatedb certainly is), is the wrong way to go. Well it runs every day or so for every desktop Linux user, and it has s

Re: -mm merge plans for 2.6.23

2007-07-24 Thread Rene Herman
On 07/25/2007 06:06 AM, Nick Piggin wrote: Ray Lee wrote: Anyway, my point is that I worry that tuning for an unusual and infrequent workload (which updatedb certainly is), is the wrong way to go. Well it runs every day or so for every desktop Linux user, and it has similarities with other

Re: [PATCH 4/8] i386: bitops: Kill volatile-casting of memory addresses

2007-07-24 Thread Nick Piggin
Linus Torvalds wrote: On Tue, 24 Jul 2007, Benjamin Herrenschmidt wrote: Besides, as Nick pointed out, it prevents some valid optimizations. No it doesn't. Not the ones on the functions that just do an inline asm. The only valid optimization it might break is for "constant_test_bit()", w

[patch] oom: print points as unsigned long

2007-07-24 Thread David Rientjes
In badness(), the automatic variable 'points' is unsigned long. Print it as such. Signed-off-by: David Rientjes <[EMAIL PROTECTED]> --- mm/oom_kill.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@

Re: -mm merge plans for 2.6.23

2007-07-24 Thread david
On Tue, 24 Jul 2007, Ray Lee wrote: On 7/23/07, Nick Piggin <[EMAIL PROTECTED]> wrote: Ray Lee wrote: Looking at your past email, you have a 1GB desktop system and your overnight updatedb run is causing stuff to get swapped out such that swap prefetch makes it significantly better. This

Re: 2.6.23-rc1 regression: mm: fix fault vs invalidate race for linear mappings

2007-07-24 Thread Dave Airlie
Is this with a binary-only module? We saw an issue with that in SLES9 where the module is returning a locked page from its nopage handler when it isn't really supposed to. It might be fixed in latest drivers, have you tried them? Doesn't sound like it he mentions radeon drm module which is open

Re: [RFC] fs/super.c: Why alloc_super use a static variable default_op?

2007-07-24 Thread Al Viro
On Wed, Jul 25, 2007 at 12:29:17PM +0800, rae l wrote: > But is it valuable? Compared to a waste of sizeof(struct super_block) > bytes memory. It's less that struct super_block, actually. > When some code want to refer fs_type->s_op, it almost always want to > refer some function pointer in s_op

Re: [PATCH 0/3] readahead drop behind and size adjustment

2007-07-24 Thread Eric St-Laurent
On Mon, 2007-23-07 at 19:00 +1000, Nick Piggin wrote: > I don't like this kind of conditional information going from something > like readahead into page reclaim. Unless it is for readahead _specific_ > data such as "I got these all wrong, so you can reclaim them" (which > this isn't). > > But I

Re: [RFC] fs/super.c: Why alloc_super use a static variable default_op?

2007-07-24 Thread rae l
On 7/25/07, Al Viro <[EMAIL PROTECTED]> wrote: On Wed, Jul 25, 2007 at 11:48:35AM +0800, rae l wrote: > Why alloc_super use a static variable default_op? > the static struct super_operations default_op is just all zeros, and > just referenced as the initial value of a new allocated super_block, >

Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console

2007-07-24 Thread Yinghai Lu
On 7/24/07, Bjorn Helgaas <[EMAIL PROTECTED]> wrote: On Tuesday 24 July 2007 02:33:05 pm Yinghai Lu wrote: > I have a system that has the same problem, and it turns out that FW > missed PNP0501 is DSDT for uart. and add that it into DSDT works well. Is this FW that has been shipped? Can you giv

Re: [RFC] fs/super.c: Why alloc_super use a static variable default_op?

2007-07-24 Thread Al Viro
On Wed, Jul 25, 2007 at 11:48:35AM +0800, rae l wrote: > Why alloc_super use a static variable default_op? > the static struct super_operations default_op is just all zeros, and > just referenced as the initial value of a new allocated super_block, > what does it for? So that we would not have to

Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily

2007-07-24 Thread Nick Piggin
Benjamin Herrenschmidt wrote: On Tue, 2007-07-24 at 17:55 -0400, Trond Myklebust wrote: If you want to use bitops as spinlocks you should rather be using . That also does the right thing w.r.t. pre-emption and sparse locking annotations. Heh, I didn't know about those... A bit annoying that

Re: -mm merge plans for 2.6.23

2007-07-24 Thread Nick Piggin
Ray Lee wrote: On 7/23/07, Nick Piggin <[EMAIL PROTECTED]> wrote: Also a random day at the desktop, it is quite a broad scope and pretty well impossible to analyse. It is pretty broad, but that's also what swap prefetch is targetting. As for hard to analyze, I'm not sure I agree. One can bl

Re: [PATCH 1/3] readahead: drop behind

2007-07-24 Thread Eric St-Laurent
On Sat, 2007-21-07 at 23:00 +0200, Peter Zijlstra wrote: > Use the read-ahead code to provide hints to page reclaim. > > This patch has the potential to solve the streaming-IO trashes my > desktop problem. > > It tries to aggressively reclaim pages that were loaded in a strong > sequential patte

[RFC] fs/super.c: Why alloc_super use a static variable default_op?

2007-07-24 Thread rae l
Why alloc_super use a static variable default_op? the static struct super_operations default_op is just all zeros, and just referenced as the initial value of a new allocated super_block, what does it for? the filesystem dependent code such as ext2_fill_super would fill this field eventually, and

Re: 2.6.23-rc1 regression: mm: fix fault vs invalidate race for linear mappings

2007-07-24 Thread Nick Piggin
Bret Towe wrote: for a while in -git I've had an issue that on boot when gdm loads the screen stays black using ctrl-f1 doesn't return to a console and killing X doesn't help any ssh'ing into the box does work top only shows 100% io-wait dmesg shows nothing odd the work around I have is at the m

Re: RFC: CONFIG_PAGE_SHIFT (aka software PAGE_SIZE)

2007-07-24 Thread William Lee Irwin III
On Wed, Jul 18, 2007 at 06:32:22AM -0700, William Lee Irwin III wrote: >> Actually I'd worked on what was called MPSS (Multiple Page Size Support) >> before I ever started on pgcl. Some large portion of the pgcl proposal >> as I presented it internally was to reduce the order of large page >> alloc

Re: [PATCH][RFC] getting rid of stupid loop in BUG()

2007-07-24 Thread Keith Owens
Trent Piepho (on Tue, 24 Jul 2007 19:31:36 -0700 (PDT)) wrote: >Adding __builtin_trap after the >asm might be an ok fix. It will emit a spurious int 6, but that won't even be >reached since the asm doesn't return, and it probably be less extra code than >the loop. int 6 is a two byte instruction,

Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console

2007-07-24 Thread Bjorn Helgaas
On Tuesday 24 July 2007 02:33:05 pm Yinghai Lu wrote: > I have a system that has the same problem, and it turns out that FW > missed PNP0501 is DSDT for uart. and add that it into DSDT works well. Is this FW that has been shipped? Can you give any more details, like DMI info and a copy of the DSD

Re: [PATCH RFC] extent mapped page cache

2007-07-24 Thread Nick Piggin
On Tue, Jul 24, 2007 at 07:25:09PM -0400, Chris Mason wrote: > On Tue, 24 Jul 2007 23:25:43 +0200 > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > The tree is a critical part of the patch, but it is also the easiest to > rip out and replace. Basically the code stores a range by inserting > an obje

Re: [PATCH][RFC] getting rid of stupid loop in BUG()

2007-07-24 Thread Trent Piepho
On Tue, 24 Jul 2007, Al Viro wrote: > AFAICS, the patch below should do it for i386; instead of > using a dummy loop to tell gcc that this sucker never returns, > we do > static void __always_inline __noreturn __BUG(const char *file, int line); > containing the actual asm we want to insert an

Re: [PATCH] hwmon: Add missing __devexit tags in various drivers

2007-07-24 Thread Mark M. Hoffman
Hi Jean: * Jean Delvare <[EMAIL PROTECTED]> [2007-07-22 12:09:48 +0200]: > On Sun, 22 Jul 2007 00:30:56 +0200, Gabriel C wrote: > > I noticed this warnings on current git: > > > > drivers/hwmon/pc87360.c:1082: warning: 'pc87360_remove' defined but not used > > drivers/hwmon/sis5595.c:580: warning:

Re: [PATCH][07/37] Clean up duplicate includes in drivers/hwmon/

2007-07-24 Thread Mark M. Hoffman
Hi Jesper: * Jesper Juhl <[EMAIL PROTECTED]> [2007-07-21 17:02:01 +0200]: > Hi, > > This patch cleans up duplicate includes in > drivers/hwmon/ > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > --- > > diff --git a/drivers/hwmon/ams/ams-core.c b/drivers/hwmon/ams/ams-core.c > index

Re: v2.6.22.1-rt5

2007-07-24 Thread Gene Heskett
On Tuesday 24 July 2007, Ingo Molnar wrote: >* Gene Heskett <[EMAIL PROTECTED]> wrote: >> The above stanza still needs some tlc. I built a 2.6.22.1-rt6 (rt5 >> wouldn't build) using the same old config that a make oldconfig didn't >> fuss about, but the reboot never completed, see the attached, he

Re: [rtc-linux] Re: rtc-ds1307.c: array overrun

2007-07-24 Thread Alessandro Zummo
On Sun, 22 Jul 2007 18:17:17 -0700 David Brownell <[EMAIL PROTECTED]> wrote: > > On Sunday 22 July 2007, Adrian Bunk wrote: > > The Coverity checker spotted the following array overrun > > in drivers/rtc/rtc-ds1307.c: > > Typo -- thanks, fix is attached. > > CUT HERE > Fix a typo

Re: [rtc-linux] [PATCH] s3c2410: fixup after arch moves

2007-07-24 Thread Alessandro Zummo
On Tue, 24 Jul 2007 13:40:04 +0100 Ben Dooks <[EMAIL PROTECTED]> wrote: > > Fixup the changes from moving around the arch > support for s3c24xx based systems. > > Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Acked-by: Alessandro Zummo <[EMAIL PROTECTED]> -- Best regards, Alessandro Zum

Re: [PATCH] Fix arch/i386/kernel/nmi.c - 'unknown_nmi_panic_callback' declared 'static' but never defined warning

2007-07-24 Thread Andrew Morton
On Sun, 22 Jul 2007 21:20:38 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > I get this warning when CONFIG_SYSCTL is not set : > > ... > > arch/i386/kernel/nmi.c:52: warning: 'unknown_nmi_panic_callback' declared > 'static' but never defined > > ... > > Signed-off-by: Gabriel Craciunescu <[EMAI

Re: v2.6.22.1-rt5

2007-07-24 Thread Gene Heskett
On Tuesday 24 July 2007, Ingo Molnar wrote: >* Gene Heskett <[EMAIL PROTECTED]> wrote: >> The above stanza still needs some tlc. I built a 2.6.22.1-rt6 (rt5 >> wouldn't build) using the same old config that a make oldconfig didn't >> fuss about, but the reboot never completed, see the attached, he

Re: [ck] Re: -mm merge plans for 2.6.23

2007-07-24 Thread David Miller
From: "Matthew Hawkins" <[EMAIL PROTECTED]> Date: Wed, 25 Jul 2007 11:26:57 +1000 > On 7/24/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > The other consideration here is, as Nick points out, are the problems which > > people see this patch solving for them solveable in other, better ways? > > I

[PATCH] powerpc: Pegasos keyboard detection

2007-07-24 Thread Alan Curry
As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse controller on the PegasosPPC. This is because of a feature/bug in the OF device tree: the "device_type" attribute is an empty string instead of "8042" as the kernel expects. This patch (against 2.6.22.1) adds a secondary detection w

Re: v2.6.22.1-rt5

2007-07-24 Thread Gene Heskett
On Tuesday 24 July 2007, Ingo Molnar wrote: >* Gene Heskett <[EMAIL PROTECTED]> wrote: >> The above stanza still needs some tlc. I built a 2.6.22.1-rt6 (rt5 >> wouldn't build) using the same old config that a make oldconfig didn't >> fuss about, but the reboot never completed, see the attached, he

Re: [ck] Re: -mm merge plans for 2.6.23

2007-07-24 Thread Matthew Hawkins
On 7/24/07, Andrew Morton <[EMAIL PROTECTED]> wrote: The other consideration here is, as Nick points out, are the problems which people see this patch solving for them solveable in other, better ways? IOW, is this patch fixing up preexisting deficiencies post-facto? So let me get this straight

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andrew Morton
On Wed, 25 Jul 2007 11:09:21 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Also, I prefer the style where the ? and : operators have a space > after them but not before them, rather than a space either side. Could I point out that your likes and dislikes are immaterial? The whole point here

Re: Time Problems with 2.6.23-rc1-gf695baf2

2007-07-24 Thread Bartlomiej Zolnierkiewicz
On Wednesday 25 July 2007, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday 25 July 2007, Michal Piotrowski wrote: > > Hi, > > > > On 24/07/07, Eric Sesterhenn / Snakebyte <[EMAIL PROTECTED]> wrote: > > > hi, > > > > > > seems like the clock got screwed or something similar. During boot

Re: [PATCH] update checkpatch.pl to version 0.08

2007-07-24 Thread Adrian Bunk
On Tue, Jul 24, 2007 at 03:32:59PM -0500, jschopp wrote: >>> Yep I think the consensus is we need a >>> "--i-don't-agree-just-check-things-which-will-get-me-rejected-out-of-hand" >>> option of some sort which will restrict output to the real errors. >> No, the default should be to show only the rea

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Paul Mackerras
Andy Whitcroft writes: > Ok, this is something we need to decide on. Currently we only ask for > consistent spacing on all the mathematic operators. This is mostly as > we do see a large number of non-spaced uses in defines and the like. > > I am happy to expand these tests so they are always s

Re: Patches for REALLY TINY 386 kernels

2007-07-24 Thread Yinghai Lu
On 7/24/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Tue, Jul 24, 2007 at 01:50:35PM -0700, Yinghai Lu wrote: > On 7/24/07, Helge Hafting <[EMAIL PROTECTED]> wrote: >> Andi Kleen wrote: >> >> Some people are putting Linux kernels in the "BIOS" (i.e. ROM chip) >> when >> >> using LinuxBIOS (www.l

Re: [linux-pm] Power Management framework proposal

2007-07-24 Thread david
On Wed, 25 Jul 2007, Jerome Glisse wrote: On 7/24/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: On Tue, 24 Jul 2007, Jerome Glisse wrote: > On 7/23/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > On Mon, 23 Jul 2007, Igor Stoppa wrote: > > > again, HAL / OHM / Mobilin > > > >

Re: [patch 2.6.23-rc1] dma_free_coherent() needs irqs enabled (sigh)

2007-07-24 Thread David Brownell
On Tuesday 24 July 2007, Russell King wrote: > > > > > > I think you got the year wrong: > > > > > > 5edf71ae (Russell King      2005-11-25 15:52:51 + 364)       > > > WARN_ON(irqs_disabled()); > > > > > > which is due to this commit: > > > > > > [ARM] Do not call flush_tlb_kernel_range() w

Re: [PATCH 13/16] Switch to operating with pid_numbers instead of pids

2007-07-24 Thread sukadev
Pavel Emelianov [EMAIL PROTECTED] wrote: | Make alloc_pid() initialize pid_numbers and hash them | into the hashtable, not the struct pid itself. | | Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]> | | --- | | pid.c | 47 +-- | 1 files changed, 3

Re: crash with 2.6.22.1 crash:ll_rw_blk.c blk_remove_plug()

2007-07-24 Thread Satyam Sharma
On 7/23/07, Jens Axboe <[EMAIL PROTECTED]> wrote: On Sun, Jul 22 2007, Satyam Sharma wrote: > Hi Walter, > > Thanks for reporting this. > > On 7/22/07, walter harms <[EMAIL PROTECTED]> wrote: >> hello all, >> on my asus notebook tm620 there is a crash with 2.6.22 and 2.6.21 > > Did this happen wh

Re: 2.6.20->2.6.21 - networking dies after random time

2007-07-24 Thread Thomas Gleixner
On Tue, 2007-07-24 at 22:04 +0200, Ingo Molnar wrote: > Marcin, could you try the patch below too? [without having any other > patch applied.] It basically turns the critical section into an irqs-off > critical section and thus checks whether your problem is related to that > particular area of

Re: sysfs/udev broken in 2.6.23-rc1 [input, i2c, ...] (Was: sysfs/udev broken in latest git?)

2007-07-24 Thread Kay Sievers
On 7/24/07, Simon Arlott <[EMAIL PROTECTED]> wrote: On 24/07/07 17:34, Kay Sievers wrote: > On 7/24/07, Simon Arlott <[EMAIL PROTECTED]> wrote: >> On 24/07/07 13:54, Cornelia Huck wrote: >> > On Tue, 24 Jul 2007 11:20:02 +0200, >> > "Kay Sievers" <[EMAIL PROTECTED]> wrote: >> > >> >> It looks fin

Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK

2007-07-24 Thread Andrew Morton
On Tue, 24 Jul 2007 16:58:51 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Tue, 24 Jul 2007, Andrew Morton wrote: > > > __GFP_COMP I'm not so sure about. > > drivers/char/drm/drm_pci.c:drm_pci_alloc() (and other places like > > infiniband) > > pass it into dma_alloc_coherent()

Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK

2007-07-24 Thread Christoph Lameter
On Tue, 24 Jul 2007, Andrew Morton wrote: > __GFP_COMP I'm not so sure about. > drivers/char/drm/drm_pci.c:drm_pci_alloc() (and other places like infiniband) > pass it into dma_alloc_coherent() which some architectures implement via > slab. umm, > arch/arm/mm/consistent.c is one such. Should

Re: Regression in serial console on ia64 after 2.6.22

2007-07-24 Thread Yinghai Lu
IA64 Subject : Regression in serial console on ia64 after 2.6.22 References : http://marc.info/?l=linux-ia64&m=118483645914066&w=2 Last known good : ? Submitter : Horms <[EMAIL PROTECTED]> Caused-By : Yinghai Lu <[EMAIL PROTECTED]> commit 18a8bd949d6adb3

Re: Thinkpad ACPI

2007-07-24 Thread Steven
On Tue, 24 Jul 2007 17:19:17 -0500, YOSHIFUJI Hideaki / 吉藤英明 wrote: > Linux 2.6.23-rc1 fails to power off my ThinkPad T42. Git-bisect told me > that the following commit is to blame, and by reverting that commit, it > works appropriately. I have noted the same behavior on a Thinkpad 600X. On the

Re: Power Management framework proposal

2007-07-24 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 16:02 -0700, [EMAIL PROTECTED] wrote: > > what requirements are needed? (I'm sure that there are others, but > hopefully it's possible to avoid requirements like 'the clock speed > for > device A must be >X to allow device B to operate in mode Y') I had an idea a while ag

Re: [RFC] scheduler: improve SMP fairness in CFS

2007-07-24 Thread Chris Friesen
Chris Snook wrote: A fraction of *each* CPU, or a fraction of *total* CPU? Per-cpu granularity doesn't make anything more fair. Well, our current solution uses per-cpu weights, because our vendor couldn't get the load balancer working accurately enough. Having per-cpu weights and cpu affin

Re: 2.6.23-rc1 sky2 boot crash in sky2_mac_intr

2007-07-24 Thread Michal Piotrowski
Hi Florian, On 24/07/07, Florian Lohoff <[EMAIL PROTECTED]> wrote: On Tue, Jul 24, 2007 at 09:50:08AM +0100, Stephen Hemminger wrote: > The problem is related to power management. The PHY has a number of PCI configuration > registers for power control, and the function of these changes based on

Re: [PATCH RFC] extent mapped page cache

2007-07-24 Thread Chris Mason
On Tue, 24 Jul 2007 23:25:43 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Tue, 2007-07-24 at 16:13 -0400, Trond Myklebust wrote: > > On Tue, 2007-07-24 at 16:00 -0400, Chris Mason wrote: > > > On Tue, 10 Jul 2007 17:03:26 -0400 > > > Chris Mason <[EMAIL PROTECTED]> wrote: > > > > > > > Th

Re: [RFC] scheduler: improve SMP fairness in CFS

2007-07-24 Thread hui
On Tue, Jul 24, 2007 at 05:22:47PM -0400, Chris Snook wrote: > Bill Huey (hui) wrote: > Well, you need enough CPU time to meet your deadlines. You need > pre-allocated memory, or to be able to guarantee that you can allocate > memory fast enough to meet your deadlines. This principle extends to

Re: [linux-pm] Power Management framework proposal

2007-07-24 Thread Jerome Glisse
On 7/24/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: On Tue, 24 Jul 2007, Jerome Glisse wrote: > On 7/23/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> On Mon, 23 Jul 2007, Igor Stoppa wrote: >> > again, HAL / OHM / Mobilin >> >> I was trying to define the lower level interfaces that

Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK

2007-07-24 Thread Andrew Morton
On Tue, 24 Jul 2007 16:00:32 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Tue, 24 Jul 2007, Andrew Morton wrote: > > > I think I'll duck this for now. Otherwise I have a suspicion that I'll > > be the first person to run it and I'm too old for such excitement. > > I always had

Re: Is PIE randomization breaking klibc binaries?

2007-07-24 Thread Ulrich Kunitz
On 07-07-24 15:45 H. Peter Anvin wrote: > Chuck Ebbert wrote: > > > >Okay, I tested with Fedora on x86_64 and it worked there too. > >(Not that that proves much.) > > > >Did you capture any of the error messages, like the address > >of the segfault? > > > > FWIW, on x86-64, this should show up in

Re: [DRIVER SUBMISSION] DRBD wants to go mainline

2007-07-24 Thread Satyam Sharma
Hi Lars, On 7/24/07, Lars Ellenberg <[EMAIL PROTECTED]> wrote: On Mon, Jul 23, 2007 at 07:10:58PM +0530, Satyam Sharma wrote: > On 7/23/07, Lars Ellenberg <[EMAIL PROTECTED]> wrote: > >On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote: > >[...] > >> Don't use signals between kernel t

Re: [patch 2.6.23-rc1] dma_free_coherent() needs irqs enabled (sigh)

2007-07-24 Thread Russell King
On Tue, Jul 24, 2007 at 04:08:11PM -0700, David Brownell wrote: > On Tuesday 24 July 2007, Russell King wrote: > > On Tue, Jul 24, 2007 at 02:29:05PM -0700, David Brownell wrote: > > > On at least ARM (and I'm told MIPS too) dma_free_coherent() has a newish > > > call context requirement: unlike i

Re: [patch 2.6.23-rc1] dma_free_coherent() needs irqs enabled (sigh)

2007-07-24 Thread David Brownell
On Tuesday 24 July 2007, Russell King wrote: > On Tue, Jul 24, 2007 at 02:29:05PM -0700, David Brownell wrote: > > On at least ARM (and I'm told MIPS too) dma_free_coherent() has a newish > > call context requirement: unlike its dma_alloc_coherent() sibling, it > > may not be called with IRQs disa

Re: [PATCH] pata_hpt37x: Fix 2.6.22 clock PLL regression

2007-07-24 Thread Linus Torvalds
On Tue, 24 Jul 2007, Alan Cox wrote: > > Just one version of Linux ago > The PLL code broke - oh no! > But set the right mode > And fix up the code > Makes the PLL timing sync go Alan, I'm getting a bit worried about you. Linus - To unsubscribe fro

Re: Power Management framework proposal

2007-07-24 Thread david
On Wed, 25 Jul 2007, Benjamin Herrenschmidt wrote: On Tue, 2007-07-24 at 13:14 -0700, [EMAIL PROTECTED] wrote: I think we need a set of constraints that trickle down the power tree and limit what a given driver can do locally. what sort of contraints are you thinking of? A parent power st

Re: understanding firmware loader for speedtouch (kernel 2.6.21.5)

2007-07-24 Thread Duncan Sands
Hi Mikie, > Do you have any news regarding my case of slow transfers via > Speedtouch USB modem on linux ? I found my old speedtouch modem and tested here. I got 2.1 Mbaud bulk downspeed, and 3 Mbaud isoc downspeed. This last is half the speed my line supports, so something is wrong [*]. Unfor

  1   2   3   4   5   6   >